)]}'
{"neutron/tests/fullstack/test_ports_binding.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"f8ac6e3093b7d94b51e2513c1855bf841212eaf5","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def test_smartnic_port_binding_on_non_smartnic_agent(self):"},{"line_number":114,"context_line":"        \"\"\"Test scenario"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        1. Create SmartNIC port which will not be properly bound to host"},{"line_number":117,"context_line":"        2. Validate port\u0027s bound status to be bound failed"},{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":"        port_1 \u003d self.safe_client.create_port("},{"line_number":120,"context_line":"            self.tenant_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_b142fe0d","line":117,"range":{"start_line":116,"start_character":8,"end_line":117,"end_character":58},"updated":"2019-05-30 21:57:32.000000000","message":"I assume the binding fails because we don\u0027t set up the agent to handle smartnic\u0027s by stopping the agent and adding l2_agent_config[\u0027agent\u0027][\u0027baremetal_smartnic\u0027] \u003d \u0027True\u0027 to l2_agent_config and restarting?","commit_id":"f247ce01f82abd9b160e8d2592981624626b3fda"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"d2e2cf3352c6afa494726a20274643077d5a023e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def test_smartnic_port_binding_on_non_smartnic_agent(self):"},{"line_number":114,"context_line":"        \"\"\"Test scenario"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        1. Create SmartNIC port which will not be properly bound to host"},{"line_number":117,"context_line":"        2. Validate port\u0027s bound status to be bound failed"},{"line_number":118,"context_line":"        \"\"\""},{"line_number":119,"context_line":"        port_1 \u003d self.safe_client.create_port("},{"line_number":120,"context_line":"            self.tenant_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_89bc50bc","line":117,"range":{"start_line":116,"start_character":8,"end_line":117,"end_character":58},"in_reply_to":"bfb3d3c7_b142fe0d","updated":"2019-06-02 00:43:00.000000000","message":"exactly.\nBy default, Neutron OVS agent doesn\u0027t bind SmartNIC ports.","commit_id":"f247ce01f82abd9b160e8d2592981624626b3fda"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7ef33b4c8aff43c28ca6d24b3cf28b936bc3df04","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        def port_bound():"},{"line_number":53,"context_line":"            port \u003d self.safe_client.client.show_port(port_id)[\u0027port\u0027]"},{"line_number":54,"context_line":"            return ("},{"line_number":55,"context_line":"                    port[portbindings.VIF_TYPE] not in"},{"line_number":56,"context_line":"                    [portbindings.VIF_TYPE_UNBOUND,"},{"line_number":57,"context_line":"                     portbindings.VIF_TYPE_BINDING_FAILED])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_193e6929","line":55,"range":{"start_line":55,"start_character":20,"end_line":55,"end_character":54},"updated":"2019-06-03 07:54:48.000000000","message":"nitty nit: can it be maybe moved to line above?","commit_id":"f2fae7d4c37904703b00ec1041d689fde8eb36c5"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"1aeb17f8b19ff26b5847226632d5c5b59c5a03ac","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        def port_bound():"},{"line_number":53,"context_line":"            port \u003d self.safe_client.client.show_port(port_id)[\u0027port\u0027]"},{"line_number":54,"context_line":"            return ("},{"line_number":55,"context_line":"                    port[portbindings.VIF_TYPE] not in"},{"line_number":56,"context_line":"                    [portbindings.VIF_TYPE_UNBOUND,"},{"line_number":57,"context_line":"                     portbindings.VIF_TYPE_BINDING_FAILED])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_26aab870","line":55,"range":{"start_line":55,"start_character":20,"end_line":55,"end_character":54},"in_reply_to":"9fb8cfa7_193e6929","updated":"2019-06-10 14:35:11.000000000","message":"Done","commit_id":"f2fae7d4c37904703b00ec1041d689fde8eb36c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7ef33b4c8aff43c28ca6d24b3cf28b936bc3df04","unresolved":false,"context_lines":[{"line_number":101,"context_line":"               }"},{"line_number":102,"context_line":"               }"},{"line_number":103,"context_line":"        )"},{"line_number":104,"context_line":"        vm_1 \u003d self.useFixture("},{"line_number":105,"context_line":"            machine.FakeFullstackMachine("},{"line_number":106,"context_line":"                self.environment.hosts[0],"},{"line_number":107,"context_line":"                self.network[\u0027id\u0027],"},{"line_number":108,"context_line":"                self.tenant_id,"},{"line_number":109,"context_line":"                self.safe_client,"},{"line_number":110,"context_line":"                neutron_port\u003dport_1))"},{"line_number":111,"context_line":"        self._ensure_port_bound(vm_1.neutron_port[\u0027id\u0027])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_smartnic_port_binding_on_non_smartnic_agent(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_196c2935","line":110,"range":{"start_line":104,"start_character":8,"end_line":110,"end_character":37},"updated":"2019-06-03 07:54:48.000000000","message":"is creation of vm really necessary? I think that creating port with specific host where it should be bound would be enough, no?","commit_id":"f2fae7d4c37904703b00ec1041d689fde8eb36c5"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"1aeb17f8b19ff26b5847226632d5c5b59c5a03ac","unresolved":false,"context_lines":[{"line_number":101,"context_line":"               }"},{"line_number":102,"context_line":"               }"},{"line_number":103,"context_line":"        )"},{"line_number":104,"context_line":"        vm_1 \u003d self.useFixture("},{"line_number":105,"context_line":"            machine.FakeFullstackMachine("},{"line_number":106,"context_line":"                self.environment.hosts[0],"},{"line_number":107,"context_line":"                self.network[\u0027id\u0027],"},{"line_number":108,"context_line":"                self.tenant_id,"},{"line_number":109,"context_line":"                self.safe_client,"},{"line_number":110,"context_line":"                neutron_port\u003dport_1))"},{"line_number":111,"context_line":"        self._ensure_port_bound(vm_1.neutron_port[\u0027id\u0027])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_smartnic_port_binding_on_non_smartnic_agent(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_89a7eba7","line":110,"range":{"start_line":104,"start_character":8,"end_line":110,"end_character":37},"in_reply_to":"9fb8cfa7_196c2935","updated":"2019-06-10 14:35:11.000000000","message":"you are right, VM creation is not needed.","commit_id":"f2fae7d4c37904703b00ec1041d689fde8eb36c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7ef33b4c8aff43c28ca6d24b3cf28b936bc3df04","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        1. Create SmartNIC port which will not be properly bound to host"},{"line_number":117,"context_line":"        because OVS agent doesn\u0027t bind SmartNIC ports by default"},{"line_number":118,"context_line":"        2. Validate port\u0027s bound status to be bound failed"},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        port_1 \u003d self.safe_client.create_port("},{"line_number":121,"context_line":"            self.tenant_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_b97ddde8","line":118,"updated":"2019-06-03 07:54:48.000000000","message":"You can maybe merge those 2 scenarios into one. First do the part which is in this test and then change config, restart agent and try the part from the test above.\nThis will safe some resources as You will not need to spawn separate neutron-server and ovs-agent for 2 different tests.","commit_id":"f2fae7d4c37904703b00ec1041d689fde8eb36c5"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"1aeb17f8b19ff26b5847226632d5c5b59c5a03ac","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        1. Create SmartNIC port which will not be properly bound to host"},{"line_number":117,"context_line":"        because OVS agent doesn\u0027t bind SmartNIC ports by default"},{"line_number":118,"context_line":"        2. Validate port\u0027s bound status to be bound failed"},{"line_number":119,"context_line":"        \"\"\""},{"line_number":120,"context_line":"        port_1 \u003d self.safe_client.create_port("},{"line_number":121,"context_line":"            self.tenant_id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_69aab771","line":118,"in_reply_to":"9fb8cfa7_b97ddde8","updated":"2019-06-10 14:35:11.000000000","message":"Done","commit_id":"f2fae7d4c37904703b00ec1041d689fde8eb36c5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7ef33b4c8aff43c28ca6d24b3cf28b936bc3df04","unresolved":false,"context_lines":[{"line_number":132,"context_line":"               }"},{"line_number":133,"context_line":"               }"},{"line_number":134,"context_line":"        )"},{"line_number":135,"context_line":"        vm_1 \u003d self.useFixture("},{"line_number":136,"context_line":"            machine.FakeFullstackMachine("},{"line_number":137,"context_line":"                self.environment.hosts[0],"},{"line_number":138,"context_line":"                self.network[\u0027id\u0027],"},{"line_number":139,"context_line":"                self.tenant_id,"},{"line_number":140,"context_line":"                self.safe_client,"},{"line_number":141,"context_line":"                neutron_port\u003dport_1))"},{"line_number":142,"context_line":"        self._ensure_port_binding_failed(vm_1.neutron_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_798765d9","line":141,"range":{"start_line":135,"start_character":8,"end_line":141,"end_character":37},"updated":"2019-06-03 07:54:48.000000000","message":"is creation of vm really necessary? I think that creating port with specific host where it should be bound would be enough, no?","commit_id":"f2fae7d4c37904703b00ec1041d689fde8eb36c5"},{"author":{"_account_id":22948,"name":"Hamdy Khader","email":"hamdyk@mellanox.com","username":"hamdyk"},"change_message_id":"1aeb17f8b19ff26b5847226632d5c5b59c5a03ac","unresolved":false,"context_lines":[{"line_number":132,"context_line":"               }"},{"line_number":133,"context_line":"               }"},{"line_number":134,"context_line":"        )"},{"line_number":135,"context_line":"        vm_1 \u003d self.useFixture("},{"line_number":136,"context_line":"            machine.FakeFullstackMachine("},{"line_number":137,"context_line":"                self.environment.hosts[0],"},{"line_number":138,"context_line":"                self.network[\u0027id\u0027],"},{"line_number":139,"context_line":"                self.tenant_id,"},{"line_number":140,"context_line":"                self.safe_client,"},{"line_number":141,"context_line":"                neutron_port\u003dport_1))"},{"line_number":142,"context_line":"        self._ensure_port_binding_failed(vm_1.neutron_port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_49bfb3af","line":141,"range":{"start_line":135,"start_character":8,"end_line":141,"end_character":37},"in_reply_to":"9fb8cfa7_798765d9","updated":"2019-06-10 14:35:11.000000000","message":"no","commit_id":"f2fae7d4c37904703b00ec1041d689fde8eb36c5"}]}