)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4cf537827bf7332c595daeff4cbefc2da5cfe4c7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"},{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug/1831706). So, we must add some extra flows to solve it."},{"line_number":16,"context_line":"For example (These flows will be deleted in this patch.):"},{"line_number":17,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d288,dl_dst\u003dfa:16:3e:2d:d7:85 actions\u003dstrip_vlan,output:\"tap0500d7e2-87\""},{"line_number":18,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d203,dl_dst\u003dfa:16:3e:8f:88:bc actions\u003dstrip_vlan,output:\"tap2610c99a-52\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_c8c92b59","line":15,"range":{"start_line":15,"start_character":35,"end_line":15,"end_character":46},"updated":"2019-06-12 16:45:18.000000000","message":"If you want add flows to the commit message, add these extra flows too.","commit_id":"8b45d7752327e63b67aaa3315e03b5e20cd992c9"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"5e787c1b4f5cb09d12226b69ad98e89759a1adb1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"},{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug/1831706). So, we must add some extra flows to solve it."},{"line_number":16,"context_line":"For example (These flows will be deleted in this patch.):"},{"line_number":17,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d288,dl_dst\u003dfa:16:3e:2d:d7:85 actions\u003dstrip_vlan,output:\"tap0500d7e2-87\""},{"line_number":18,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d203,dl_dst\u003dfa:16:3e:8f:88:bc actions\u003dstrip_vlan,output:\"tap2610c99a-52\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_5cec1429","line":15,"range":{"start_line":15,"start_character":35,"end_line":15,"end_character":46},"in_reply_to":"9fb8cfa7_c8c92b59","updated":"2019-06-13 01:21:45.000000000","message":"No, I want not to add flows. Maybe I am not making myself clear here. I mean that the original process needs these extra flows to avoid `NORMAL` action.","commit_id":"8b45d7752327e63b67aaa3315e03b5e20cd992c9"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4cf537827bf7332c595daeff4cbefc2da5cfe4c7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug/1831706). So, we must add some extra flows to solve it."},{"line_number":16,"context_line":"For example (These flows will be deleted in this patch.):"},{"line_number":17,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d288,dl_dst\u003dfa:16:3e:2d:d7:85 actions\u003dstrip_vlan,output:\"tap0500d7e2-87\""},{"line_number":18,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d203,dl_dst\u003dfa:16:3e:8f:88:bc actions\u003dstrip_vlan,output:\"tap2610c99a-52\""},{"line_number":19,"context_line":"and (These flows will be improved in patch[1]):"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_c8a04b93","line":16,"range":{"start_line":16,"start_character":33,"end_line":16,"end_character":40},"updated":"2019-06-12 16:45:18.000000000","message":"replaced with what?","commit_id":"8b45d7752327e63b67aaa3315e03b5e20cd992c9"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"5e787c1b4f5cb09d12226b69ad98e89759a1adb1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug/1831706). So, we must add some extra flows to solve it."},{"line_number":16,"context_line":"For example (These flows will be deleted in this patch.):"},{"line_number":17,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d288,dl_dst\u003dfa:16:3e:2d:d7:85 actions\u003dstrip_vlan,output:\"tap0500d7e2-87\""},{"line_number":18,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d203,dl_dst\u003dfa:16:3e:8f:88:bc actions\u003dstrip_vlan,output:\"tap2610c99a-52\""},{"line_number":19,"context_line":"and (These flows will be improved in patch[1]):"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_5cd5f442","line":16,"range":{"start_line":16,"start_character":33,"end_line":16,"end_character":40},"in_reply_to":"9fb8cfa7_c8a04b93","updated":"2019-06-13 01:21:45.000000000","message":"These flows already exist, but I think they are redundant if we adopt these patch. I indeed want to delete these flows.","commit_id":"8b45d7752327e63b67aaa3315e03b5e20cd992c9"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4cf537827bf7332c595daeff4cbefc2da5cfe4c7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"This patch modifies both `dl_src` and `in_port` of these packets,"},{"line_number":24,"context_line":"and strip VLAN tag of these packets, by these processes these packets"},{"line_number":25,"context_line":"will fully similar with packets that from local qr-*, we can securely"},{"line_number":26,"context_line":"processed them wich `NORMAL` action. So that, we can simplify some flows"},{"line_number":27,"context_line":"and fix some bugs(bug/1831534)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[1] https://review.opendev.org/#/c/639009/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_135c54eb","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":27},"updated":"2019-06-12 16:45:18.000000000","message":"After some test, I noticed this normal (br-int table 60) will cause duplicate of all reply packets from dvr_no_external compute host VM to out side world, aka floating IP. Whether enable openflow security group does not relate to duplicate packages. \n\nHere are some ping packets captured in the compute node qrouter-namespace:\n23:54:14.847743 fa:16:3e:17:d3:d2 \u003e fa:16:3e:23:53:7c, ethertype IPv4 (0x0800), length 98: 192.168.200.5 \u003e 172.16.5.10: ICMP echo reply, id 17351, seq 3, length 64\n23:54:15.850649 fa:16:3e:da:85:f5 \u003e fa:16:3e:17:d3:d2, ethertype IPv4 (0x0800), length 98: 192.168.200.5 \u003e 172.16.5.10: ICMP echo reply, id 17351, seq 4, length 64\n23:54:15.850696 fa:16:3e:17:d3:d2 \u003e fa:16:3e:23:53:7c, ethertype IPv4 (0x0800), length 98: 192.168.200.5 \u003e 172.16.5.10: ICMP echo reply, id 17351, seq 4, length 64\n23:54:16.852045 fa:16:3e:da:85:f5 \u003e fa:16:3e:17:d3:d2, ethertype IPv4 (0x0800), length 98: 192.168.200.5 \u003e 172.16.5.10: ICMP echo reply, id 17351, seq 5, length 64\n23:54:16.852113 fa:16:3e:17:d3:d2 \u003e fa:16:3e:23:53:7c, ethertype IPv4 (0x0800), length 98: 192.168.200.5 \u003e 172.16.5.10: ICMP echo reply, id 17351, seq 5, length 64\n23:54:17.853214 fa:16:3e:da:85:f5 \u003e fa:16:3e:17:d3:d2, ethertype IPv4 (0x0800), length 98: 192.168.200.5 \u003e 172.16.5.10: ICMP echo reply, id 17351, seq 6, length 64\n23:54:17.853252 fa:16:3e:17:d3:d2 \u003e fa:16:3e:23:53:7c, ethertype IPv4 (0x0800), length 98: 192.168.200.5 \u003e 172.16.5.10: ICMP echo reply, id 17351, seq 6, length 64\n\n\nSome TCP reply packets (ssh):\n\n00:01:53.296894 fa:16:3e:da:85:f5 \u003e fa:16:3e:17:d3:d2, ethertype IPv4 (0x0800), length 118: 192.168.200.5.ssh \u003e 172.16.5.10.38088: Flags [P.], seq 1035:1087, ack 1858, win 4368, options [nop,nop,TS val 186880520 ecr 1462375419], length 52\n00:01:53.296938 fa:16:3e:17:d3:d2 \u003e fa:16:3e:23:53:7c, ethertype IPv4 (0x0800), length 118: 192.168.200.5.ssh \u003e 172.16.5.10.38088: Flags [P.], seq 1035:1087, ack 1858, win 4368, options [nop,nop,TS val 186880520 ecr 1462375419], length 52\n00:01:53.299107 fa:16:3e:da:85:f5 \u003e fa:16:3e:17:d3:d2, ethertype IPv4 (0x0800), length 134: 192.168.200.5.ssh \u003e 172.16.5.10.38088: Flags [P.], seq 1087:1155, ack 1926, win 4368, options [nop,nop,TS val 186880521 ecr 1462375422], length 68\n00:01:53.299148 fa:16:3e:17:d3:d2 \u003e fa:16:3e:23:53:7c, ethertype IPv4 (0x0800), length 134: 192.168.200.5.ssh \u003e 172.16.5.10.38088: Flags [P.], seq 1087:1155, ack 1926, win 4368, options [nop,nop,TS val 186880521 ecr 1462375422], length 68\n00:01:53.302245 fa:16:3e:da:85:f5 \u003e fa:16:3e:17:d3:d2, ethertype IPv4 (0x0800), length 134: 192.168.200.5.ssh \u003e 172.16.5.10.38088: Flags [P.], seq 1155:1223, ack 2298, win 5092, options [nop,nop,TS val 186880522 ecr 1462375424], length 68\n00:01:53.302286 fa:16:3e:17:d3:d2 \u003e fa:16:3e:23:53:7c, ethertype IPv4 (0x0800), length 134: 192.168.200.5.ssh \u003e 172.16.5.10.38088: Flags [P.], seq 1155:1223, ack 2298, win 5092, options [nop,nop,TS val 186880522 ecr 1462375424], length 68","commit_id":"8b45d7752327e63b67aaa3315e03b5e20cd992c9"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"4cf537827bf7332c595daeff4cbefc2da5cfe4c7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"This patch modifies both `dl_src` and `in_port` of these packets,"},{"line_number":24,"context_line":"and strip VLAN tag of these packets, by these processes these packets"},{"line_number":25,"context_line":"will fully similar with packets that from local qr-*, we can securely"},{"line_number":26,"context_line":"processed them wich `NORMAL` action. So that, we can simplify some flows"},{"line_number":27,"context_line":"and fix some bugs(bug/1831534)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[1] https://review.opendev.org/#/c/639009/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_736cb09b","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":19},"updated":"2019-06-12 16:45:18.000000000","message":"with? or which?","commit_id":"8b45d7752327e63b67aaa3315e03b5e20cd992c9"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"ba66398948a48bdb81e3cd25a7c4ee9f84c22c7e","unresolved":false,"context_lines":[{"line_number":23,"context_line":"This patch modifies both `dl_src` and `in_port` of these packets,"},{"line_number":24,"context_line":"and strip VLAN tag of these packets, by these processes these packets"},{"line_number":25,"context_line":"will fully similar with packets that from local qr-*, we can securely"},{"line_number":26,"context_line":"processed them wich `NORMAL` action. So that, we can simplify some flows"},{"line_number":27,"context_line":"and fix some bugs(bug/1831534)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[1] https://review.opendev.org/#/c/639009/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_f0515237","line":26,"range":{"start_line":26,"start_character":21,"end_line":26,"end_character":27},"in_reply_to":"9fb8cfa7_135c54eb","updated":"2019-06-14 08:35:31.000000000","message":"I can\u0027t reproduce the bug, the floating IP works very well in my environment, and I don\u0027t think there\u0027s anything wrong with you captured packets. But, The east/west traffic will produce duplicate reply packets occasionally, this is caused by some residual tap devices [1] (Restart network node(with dhcp-agent or l3-agent) can produce these residual tap devices). These residual tap devices will result in some residual flows:\n  \"table\u003d2, priority\u003d4,dl_vlan\u003d287,dl_dst\u003dfa:16:3e:f8:8e:51 actions\u003dmod_dl_src:fa:16:3e:71:9d:7b,load:0x5-\u003eNXM_OF_IN_PORT[],strip_vlan,resubmit(,60)\"\nThe flow will permit invalid packets(with dst mac fa:16:3e:f8:8e:51) through, these packets will be output to br-tun or br-vlan again, so the replicate reply packets produced.\n\nPlease confirm whether the sg-* port remains at other nodes and you can pull my last patch set to test.\n\nIf the issue still exists. Please provide more details.\n\n[1] http://paste.openstack.org/show/752914","commit_id":"8b45d7752327e63b67aaa3315e03b5e20cd992c9"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"5e787c1b4f5cb09d12226b69ad98e89759a1adb1","unresolved":false,"context_lines":[{"line_number":23,"context_line":"This patch modifies both `dl_src` and `in_port` of these packets,"},{"line_number":24,"context_line":"and strip VLAN tag of these packets, by these processes these packets"},{"line_number":25,"context_line":"will fully similar with packets that from local qr-*, we can securely"},{"line_number":26,"context_line":"processed them wich `NORMAL` action. So that, we can simplify some flows"},{"line_number":27,"context_line":"and fix some bugs(bug/1831534)."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"[1] https://review.opendev.org/#/c/639009/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9fb8cfa7_1ccbfca4","line":26,"range":{"start_line":26,"start_character":15,"end_line":26,"end_character":19},"in_reply_to":"9fb8cfa7_736cb09b","updated":"2019-06-13 01:21:45.000000000","message":"I want to use \u0027with\u0027. :_)","commit_id":"8b45d7752327e63b67aaa3315e03b5e20cd992c9"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"596320d861b8cee4668390f37a5bf0c09bf6f9bb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  table\u003d82, priority\u003d50,ct_state\u003d+est-rel+rpl,ct_zone\u003d644,ct_mark\u003d0,reg5\u003d0x2 actions\u003dstrip_vlan,output:2"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch modifies both `dl_src` and `in_port` of these packets,"},{"line_number":30,"context_line":"and strip VLAN tag of these packets, by these processes these packets"},{"line_number":31,"context_line":"will fully similar with packets that from local qr-*, we can securely"},{"line_number":32,"context_line":"processed them with `NORMAL` action. So that, we can simplify some flows"},{"line_number":33,"context_line":"and fix some bugs(bug/1831534)."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9fb8cfa7_cd57ab26","line":31,"range":{"start_line":30,"start_character":37,"end_line":31,"end_character":51},"updated":"2019-06-17 22:39:49.000000000","message":"Can you re-frame this sentence. It is confusing.","commit_id":"1de1d77845cf87d600beac708bdd9af6fa2600c5"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"8484683e350c5cf3df08ab5b226ecfe737df7135","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  table\u003d82, priority\u003d50,ct_state\u003d+est-rel+rpl,ct_zone\u003d644,ct_mark\u003d0,reg5\u003d0x2 actions\u003dstrip_vlan,output:2"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch modifies both `dl_src` and `in_port` of these packets,"},{"line_number":30,"context_line":"and strip VLAN tag of these packets, by these processes these packets"},{"line_number":31,"context_line":"will fully similar with packets that from local qr-*, we can securely"},{"line_number":32,"context_line":"processed them with `NORMAL` action. So that, we can simplify some flows"},{"line_number":33,"context_line":"and fix some bugs(bug/1831534)."},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9fb8cfa7_07d6f7f2","line":31,"range":{"start_line":30,"start_character":37,"end_line":31,"end_character":51},"in_reply_to":"9fb8cfa7_cd57ab26","updated":"2019-06-18 12:01:05.000000000","message":"I am so sorry for my poor English skill.","commit_id":"1de1d77845cf87d600beac708bdd9af6fa2600c5"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"596320d861b8cee4668390f37a5bf0c09bf6f9bb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"and strip VLAN tag of these packets, by these processes these packets"},{"line_number":31,"context_line":"will fully similar with packets that from local qr-*, we can securely"},{"line_number":32,"context_line":"processed them with `NORMAL` action. So that, we can simplify some flows"},{"line_number":33,"context_line":"and fix some bugs(bug/1831534)."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[1] https://review.opendev.org/#/c/639009/"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9fb8cfa7_ad34b7fc","line":33,"updated":"2019-06-17 22:39:49.000000000","message":"Also what would be advantage that we will be getting on these changes that you are proposing.","commit_id":"1de1d77845cf87d600beac708bdd9af6fa2600c5"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"8484683e350c5cf3df08ab5b226ecfe737df7135","unresolved":false,"context_lines":[{"line_number":30,"context_line":"and strip VLAN tag of these packets, by these processes these packets"},{"line_number":31,"context_line":"will fully similar with packets that from local qr-*, we can securely"},{"line_number":32,"context_line":"processed them with `NORMAL` action. So that, we can simplify some flows"},{"line_number":33,"context_line":"and fix some bugs(bug/1831534)."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"[1] https://review.opendev.org/#/c/639009/"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"9fb8cfa7_47ccef60","line":33,"in_reply_to":"9fb8cfa7_ad34b7fc","updated":"2019-06-18 12:01:05.000000000","message":"Done","commit_id":"1de1d77845cf87d600beac708bdd9af6fa2600c5"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3bb0abda1edd651b653cd8d3004592723c60422f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify `in_port` and `dl_vlan` fields of packets which from remote `qr-*` ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aim to make the packets which from remote `qr-*` ports"},{"line_number":10,"context_line":"can be processed by `NORMAL` action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_fd2c8b4b","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":15},"updated":"2019-06-18 17:58:04.000000000","message":"aims","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3bb0abda1edd651b653cd8d3004592723c60422f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify `in_port` and `dl_vlan` fields of packets which from remote `qr-*` ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aim to make the packets which from remote `qr-*` ports"},{"line_number":10,"context_line":"can be processed by `NORMAL` action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_9df46fd1","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":40},"updated":"2019-06-18 17:58:04.000000000","message":"packets flowing from or packets coming in from","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"bc3e1e283853fee88f6aed6ae3c6906e3c4177db","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Modify `in_port` and `dl_vlan` fields of packets which from remote `qr-*` ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch aim to make the packets which from remote `qr-*` ports"},{"line_number":10,"context_line":"can be processed by `NORMAL` action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_ef0da3e8","line":9,"range":{"start_line":9,"start_character":27,"end_line":9,"end_character":40},"in_reply_to":"9fb8cfa7_9df46fd1","updated":"2019-06-19 12:20:10.000000000","message":"Thank you very much for your painstaking review. I will work hard to improve my English skills.","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3bb0abda1edd651b653cd8d3004592723c60422f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch aim to make the packets which from remote `qr-*` ports"},{"line_number":10,"context_line":"can be processed by `NORMAL` action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"},{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug 1831706). So, in order to avoid `NORMAL` action we need below flows(I"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_dd12e709","line":12,"range":{"start_line":12,"start_character":56,"end_line":12,"end_character":65},"updated":"2019-06-18 17:58:04.000000000","message":"typo","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"bc3e1e283853fee88f6aed6ae3c6906e3c4177db","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch aim to make the packets which from remote `qr-*` ports"},{"line_number":10,"context_line":"can be processed by `NORMAL` action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"},{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug 1831706). So, in order to avoid `NORMAL` action we need below flows(I"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_0f13570f","line":12,"range":{"start_line":12,"start_character":56,"end_line":12,"end_character":65},"in_reply_to":"9fb8cfa7_dd12e709","updated":"2019-06-19 12:20:10.000000000","message":"Done","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3bb0abda1edd651b653cd8d3004592723c60422f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"can be processed by `NORMAL` action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"},{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug 1831706). So, in order to avoid `NORMAL` action we need below flows(I"},{"line_number":16,"context_line":"think we can simplify them)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_3d9d4366","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":43},"updated":"2019-06-18 17:58:04.000000000","message":"as a result of this.","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3bb0abda1edd651b653cd8d3004592723c60422f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch aim to make the packets which from remote `qr-*` ports"},{"line_number":10,"context_line":"can be processed by `NORMAL` action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"},{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug 1831706). So, in order to avoid `NORMAL` action we need below flows(I"},{"line_number":16,"context_line":"think we can simplify them)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_9de22f01","line":13,"range":{"start_line":12,"start_character":66,"end_line":13,"end_character":11},"updated":"2019-06-18 17:58:04.000000000","message":"which come from remote or which flows from remote","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"bc3e1e283853fee88f6aed6ae3c6906e3c4177db","unresolved":false,"context_lines":[{"line_number":10,"context_line":"can be processed by `NORMAL` action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"},{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug 1831706). So, in order to avoid `NORMAL` action we need below flows(I"},{"line_number":16,"context_line":"think we can simplify them)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_4fd70f25","line":13,"range":{"start_line":13,"start_character":23,"end_line":13,"end_character":43},"in_reply_to":"9fb8cfa7_3d9d4366","updated":"2019-06-19 12:20:10.000000000","message":"Done","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"bc3e1e283853fee88f6aed6ae3c6906e3c4177db","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch aim to make the packets which from remote `qr-*` ports"},{"line_number":10,"context_line":"can be processed by `NORMAL` action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"},{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug 1831706). So, in order to avoid `NORMAL` action we need below flows(I"},{"line_number":16,"context_line":"think we can simplify them)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_6f1a1318","line":13,"range":{"start_line":12,"start_character":66,"end_line":13,"end_character":11},"in_reply_to":"9fb8cfa7_9de22f01","updated":"2019-06-19 12:20:10.000000000","message":"Done","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3bb0abda1edd651b653cd8d3004592723c60422f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"},{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug 1831706). So, in order to avoid `NORMAL` action we need below flows(I"},{"line_number":16,"context_line":"think we can simplify them)."},{"line_number":17,"context_line":"For example:"},{"line_number":18,"context_line":"(These flows will be removed in this patch.):"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_7d5e5b46","line":15,"range":{"start_line":15,"start_character":52,"end_line":15,"end_character":71},"updated":"2019-06-18 17:58:04.000000000","message":"we need the flows below","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"bc3e1e283853fee88f6aed6ae3c6906e3c4177db","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Currently, the flow tables only modify `dl_src` field of patckets which"},{"line_number":13,"context_line":"from remote qr-* port, this way will result in these packets mustn\u0027t"},{"line_number":14,"context_line":"be processed by ovs flow `NORMAL` action(The reason is explained in"},{"line_number":15,"context_line":"bug 1831706). So, in order to avoid `NORMAL` action we need below flows(I"},{"line_number":16,"context_line":"think we can simplify them)."},{"line_number":17,"context_line":"For example:"},{"line_number":18,"context_line":"(These flows will be removed in this patch.):"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_0fe117ff","line":15,"range":{"start_line":15,"start_character":52,"end_line":15,"end_character":71},"in_reply_to":"9fb8cfa7_7d5e5b46","updated":"2019-06-19 12:20:10.000000000","message":"Done","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3bb0abda1edd651b653cd8d3004592723c60422f","unresolved":false,"context_lines":[{"line_number":16,"context_line":"think we can simplify them)."},{"line_number":17,"context_line":"For example:"},{"line_number":18,"context_line":"(These flows will be removed in this patch.):"},{"line_number":19,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d288,dl_dst\u003dfa:16:3e:2d:d7:85 actions\u003dstrip_vlan,output:\"tap0500d7e2-87\""},{"line_number":20,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d203,dl_dst\u003dfa:16:3e:8f:88:bc actions\u003dstrip_vlan,output:\"tap2610c99a-52\""},{"line_number":21,"context_line":"and (These flows will be improved in patch[1]):"},{"line_number":22,"context_line":"  table\u003d81, priority\u003d100,arp,reg5\u003d0x1 actions\u003dstrip_vlan,output:1"},{"line_number":23,"context_line":"  table\u003d81, priority\u003d100,arp,reg5\u003d0x2 actions\u003dstrip_vlan,output:2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_5d035710","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":102},"updated":"2019-06-18 17:58:04.000000000","message":"So does it mean the packets will be dropped in without stripping the vlan that are intended for the VMs.","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"bc3e1e283853fee88f6aed6ae3c6906e3c4177db","unresolved":false,"context_lines":[{"line_number":16,"context_line":"think we can simplify them)."},{"line_number":17,"context_line":"For example:"},{"line_number":18,"context_line":"(These flows will be removed in this patch.):"},{"line_number":19,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d288,dl_dst\u003dfa:16:3e:2d:d7:85 actions\u003dstrip_vlan,output:\"tap0500d7e2-87\""},{"line_number":20,"context_line":"  table\u003d60, priority\u003d4,dl_vlan\u003d203,dl_dst\u003dfa:16:3e:8f:88:bc actions\u003dstrip_vlan,output:\"tap2610c99a-52\""},{"line_number":21,"context_line":"and (These flows will be improved in patch[1]):"},{"line_number":22,"context_line":"  table\u003d81, priority\u003d100,arp,reg5\u003d0x1 actions\u003dstrip_vlan,output:1"},{"line_number":23,"context_line":"  table\u003d81, priority\u003d100,arp,reg5\u003d0x2 actions\u003dstrip_vlan,output:2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_af96cb93","line":20,"range":{"start_line":19,"start_character":0,"end_line":20,"end_character":102},"in_reply_to":"9fb8cfa7_5d035710","updated":"2019-06-19 12:20:10.000000000","message":"The flows are introduced by DVR code. It works happily if we do not use openvswitch firewall driver. But, it will result in bug 1831534 if we use openvswitch firewall driver. Since the request packet coming from remote qr-* port never go into conntrack table, so the reply packets will be treat as invalid.","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3bb0abda1edd651b653cd8d3004592723c60422f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  table\u003d82, priority\u003d50,ct_state\u003d+est-rel+rpl,ct_zone\u003d644,ct_mark\u003d0,reg5\u003d0x1 actions\u003dstrip_vlan,output:1"},{"line_number":27,"context_line":"  table\u003d82, priority\u003d50,ct_state\u003d+est-rel+rpl,ct_zone\u003d644,ct_mark\u003d0,reg5\u003d0x2 actions\u003dstrip_vlan,output:2"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch modifies both `dl_src` and `in_port` of these packets, and"},{"line_number":30,"context_line":"strip VLAN tag of these packets. Through these modifications, we can"},{"line_number":31,"context_line":"make the packets coming from the remote qr-* port and the packets coming"},{"line_number":32,"context_line":"from local qr-* port fully similar. This will make we can process them"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_381b1174","line":29,"range":{"start_line":29,"start_character":48,"end_line":29,"end_character":64},"updated":"2019-06-18 17:58:04.000000000","message":"When you say these packets, does it point to the above packets such as the \u0027arp\u0027, \u0027icmp6\u0027 and connection state packets.","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"bc3e1e283853fee88f6aed6ae3c6906e3c4177db","unresolved":false,"context_lines":[{"line_number":26,"context_line":"  table\u003d82, priority\u003d50,ct_state\u003d+est-rel+rpl,ct_zone\u003d644,ct_mark\u003d0,reg5\u003d0x1 actions\u003dstrip_vlan,output:1"},{"line_number":27,"context_line":"  table\u003d82, priority\u003d50,ct_state\u003d+est-rel+rpl,ct_zone\u003d644,ct_mark\u003d0,reg5\u003d0x2 actions\u003dstrip_vlan,output:2"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch modifies both `dl_src` and `in_port` of these packets, and"},{"line_number":30,"context_line":"strip VLAN tag of these packets. Through these modifications, we can"},{"line_number":31,"context_line":"make the packets coming from the remote qr-* port and the packets coming"},{"line_number":32,"context_line":"from local qr-* port fully similar. This will make we can process them"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_afc48b93","line":29,"range":{"start_line":29,"start_character":48,"end_line":29,"end_character":64},"in_reply_to":"9fb8cfa7_381b1174","updated":"2019-06-19 12:20:10.000000000","message":"Sorry, I did not say it clearly. It still refers to these packets coming for remote qr-* port.","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3bb0abda1edd651b653cd8d3004592723c60422f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"This patch modifies both `dl_src` and `in_port` of these packets, and"},{"line_number":30,"context_line":"strip VLAN tag of these packets. Through these modifications, we can"},{"line_number":31,"context_line":"make the packets coming from the remote qr-* port and the packets coming"},{"line_number":32,"context_line":"from local qr-* port fully similar. This will make we can process them"},{"line_number":33,"context_line":"with `NORMAL` action securely."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Other more things, this patch fixed the bug 1831534 and resolved the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_b820619d","line":32,"range":{"start_line":32,"start_character":36,"end_line":32,"end_character":65},"updated":"2019-06-18 17:58:04.000000000","message":"This change will make sure that we can process","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"3bb0abda1edd651b653cd8d3004592723c60422f","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from local qr-* port fully similar. This will make we can process them"},{"line_number":33,"context_line":"with `NORMAL` action securely."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Other more things, this patch fixed the bug 1831534 and resolved the"},{"line_number":36,"context_line":"breaking issue of DVR east/west traffic in patch[1]. Further on, I want"},{"line_number":37,"context_line":"to simplify some flows about openvswitch firewall driver[2], the patch[2]"},{"line_number":38,"context_line":"depends on patch[1]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_983c7dc0","line":36,"range":{"start_line":35,"start_character":56,"end_line":36,"end_character":51},"updated":"2019-06-18 17:58:04.000000000","message":"It seems that this patch https://review.opendev.org/#/c/639009/ hasn\u0027t merged yet.","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"bc3e1e283853fee88f6aed6ae3c6906e3c4177db","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from local qr-* port fully similar. This will make we can process them"},{"line_number":33,"context_line":"with `NORMAL` action securely."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Other more things, this patch fixed the bug 1831534 and resolved the"},{"line_number":36,"context_line":"breaking issue of DVR east/west traffic in patch[1]. Further on, I want"},{"line_number":37,"context_line":"to simplify some flows about openvswitch firewall driver[2], the patch[2]"},{"line_number":38,"context_line":"depends on patch[1]"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":13,"id":"9fb8cfa7_4fedcf23","line":36,"range":{"start_line":35,"start_character":56,"end_line":36,"end_character":51},"in_reply_to":"9fb8cfa7_983c7dc0","updated":"2019-06-19 12:20:10.000000000","message":"Yes, Because of it break DVR east/west traffic. This patch will fix it.","commit_id":"eaf62e90dbfb30cccd97809b95facfb7feea23c3"}],"neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_int.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0c517b1b0f6752ea0bc5a08b460c167f0fb5fcd2","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        actions \u003d ["},{"line_number":117,"context_line":"            ofpp.OFPActionSetField(eth_src\u003dgateway_mac),"},{"line_number":118,"context_line":"        ]"},{"line_number":119,"context_line":"        if network_type \u003d\u003d p_const.TYPE_VLAN:"},{"line_number":120,"context_line":"            actions.append("},{"line_number":121,"context_line":"                ofpp.OFPActionSetField(vlan_vid\u003dlocal_vlan))"},{"line_number":122,"context_line":"        instructions \u003d ["}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_51033b43","line":119,"range":{"start_line":119,"start_character":44,"end_line":119,"end_character":45},"updated":"2019-06-04 14:10:20.000000000","message":"`and local_vlan` ?","commit_id":"0d2d30c6786eb1fa6666e838bb148c03ec213f35"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e8eb415cd42a4108c7bcadd9d3d300e3980e7cf1","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                      dl_vlan\u003dvlan_tag, dl_dst\u003ddst_mac,"},{"line_number":146,"context_line":"                      actions\u003d\u0027mod_dl_src:{:s},\u0027"},{"line_number":147,"context_line":"                              \u0027load:{:d}-\u003eNXM_OF_IN_PORT[],\u0027"},{"line_number":148,"context_line":"                              \u0027strip_vlan,\u0027"},{"line_number":149,"context_line":"                              \u0027resubmit(,{:d})\u0027.format("},{"line_number":150,"context_line":"                                  gateway_mac, dqr_ofport,"},{"line_number":151,"context_line":"                                  constants.TRANSIENT_TABLE))"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fb8cfa7_78b0e4dd","line":148,"range":{"start_line":148,"start_character":31,"end_line":148,"end_character":41},"updated":"2019-06-14 13:23:18.000000000","message":"IMO, this is a security problem. You\u0027ll have a non VLAN tagged packet inside the bridge, sent to a table and not to a port. With this action you are deisolating this traffic.\n\nOnly NORMAL action (which strips the VLAN if needed) or forced output to ports (along with manual VLAN strip action) should remove the VLAN isolation inside the int-br.","commit_id":"128d44354bd4ca2f9e5efc976f3d6cfa455d5936"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"56994c4e3f53854ddb4ff145805ca028550cd458","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                      dl_vlan\u003dvlan_tag, dl_dst\u003ddst_mac,"},{"line_number":146,"context_line":"                      actions\u003d\u0027mod_dl_src:{:s},\u0027"},{"line_number":147,"context_line":"                              \u0027load:{:d}-\u003eNXM_OF_IN_PORT[],\u0027"},{"line_number":148,"context_line":"                              \u0027strip_vlan,\u0027"},{"line_number":149,"context_line":"                              \u0027resubmit(,{:d})\u0027.format("},{"line_number":150,"context_line":"                                  gateway_mac, dqr_ofport,"},{"line_number":151,"context_line":"                                  constants.TRANSIENT_TABLE))"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fb8cfa7_363913f1","line":148,"range":{"start_line":148,"start_character":31,"end_line":148,"end_character":41},"in_reply_to":"9fb8cfa7_78b0e4dd","updated":"2019-06-15 04:47:14.000000000","message":"No, I don\u0027t think I am de-isolating this traffic. The isolation of traffic is implemented by \u0027reg6\u0027 in subsequent flow tables. And, the local qr-* port is an access port(the packet that includes an 802.1Q header it will be treated as invalid), so that we must strip the VLAN tag in order to fully simulate local qr-* port.","commit_id":"128d44354bd4ca2f9e5efc976f3d6cfa455d5936"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0c517b1b0f6752ea0bc5a08b460c167f0fb5fcd2","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                gateway_mac\u003dsubnet_info[\u0027gateway_mac\u0027],"},{"line_number":407,"context_line":"                dst_mac\u003dcomp_ovsport.get_mac(),"},{"line_number":408,"context_line":"                dst_port\u003dcomp_ovsport.get_ofport(),"},{"line_number":409,"context_line":"                local_vlan\u003dlvm.vlan)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        if lvm.network_type \u003d\u003d n_const.TYPE_VLAN:"},{"line_number":412,"context_line":"            # TODO(vivek) remove the IPv6 related flows once SNAT is not"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_9113f366","line":409,"range":{"start_line":409,"start_character":27,"end_line":409,"end_character":35},"updated":"2019-06-04 14:10:20.000000000","message":"local_vlan\u003dlvm.vlan if n_const.TYPE_VLAN else None","commit_id":"0d2d30c6786eb1fa6666e838bb148c03ec213f35"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"ec22d4c24b04d6a556f91a71ccfd269ccbaf363b","unresolved":false,"context_lines":[{"line_number":406,"context_line":"                gateway_mac\u003dsubnet_info[\u0027gateway_mac\u0027],"},{"line_number":407,"context_line":"                dst_mac\u003dcomp_ovsport.get_mac(),"},{"line_number":408,"context_line":"                dst_port\u003dcomp_ovsport.get_ofport(),"},{"line_number":409,"context_line":"                local_vlan\u003dlvm.vlan)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        if lvm.network_type \u003d\u003d n_const.TYPE_VLAN:"},{"line_number":412,"context_line":"            # TODO(vivek) remove the IPv6 related flows once SNAT is not"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_574a4155","line":409,"range":{"start_line":409,"start_character":27,"end_line":409,"end_character":35},"in_reply_to":"9fb8cfa7_9113f366","updated":"2019-06-05 01:08:38.000000000","message":"Here are some BUGs still. I am thinking about how to refect it.","commit_id":"0d2d30c6786eb1fa6666e838bb148c03ec213f35"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0c517b1b0f6752ea0bc5a08b460c167f0fb5fcd2","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                gateway_mac\u003dsubnet_info[\u0027gateway_mac\u0027],"},{"line_number":480,"context_line":"                dst_mac\u003dovsport.get_mac(),"},{"line_number":481,"context_line":"                dst_port\u003dovsport.get_ofport(),"},{"line_number":482,"context_line":"                local_vlan\u003dlvm.vlan)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"    def _bind_centralized_snat_port_on_dvr_subnet(self, port, lvm,"},{"line_number":485,"context_line":"                                                  fixed_ips, device_owner):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_510d7b3c","line":482,"range":{"start_line":482,"start_character":27,"end_line":482,"end_character":35},"updated":"2019-06-04 14:10:20.000000000","message":"ditto","commit_id":"0d2d30c6786eb1fa6666e838bb148c03ec213f35"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0c517b1b0f6752ea0bc5a08b460c167f0fb5fcd2","unresolved":false,"context_lines":[{"line_number":539,"context_line":"            gateway_mac\u003dsubnet_info[\u0027gateway_mac\u0027],"},{"line_number":540,"context_line":"            dst_mac\u003dovsport.get_mac(),"},{"line_number":541,"context_line":"            dst_port\u003dovsport.get_ofport(),"},{"line_number":542,"context_line":"            local_vlan\u003dlvm.vlan)"},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"    def bind_port_to_dvr(self, port, local_vlan_map,"},{"line_number":545,"context_line":"                         fixed_ips, device_owner):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_1107031f","line":542,"range":{"start_line":542,"start_character":23,"end_line":542,"end_character":31},"updated":"2019-06-04 14:10:20.000000000","message":"ditto","commit_id":"0d2d30c6786eb1fa6666e838bb148c03ec213f35"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0eecb519f8122dbec47339129cb5415529b1b22d","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                vlan_tag\u003dvlan_to_use,"},{"line_number":434,"context_line":"                gateway_mac\u003dsubnet_info[\u0027gateway_mac\u0027],"},{"line_number":435,"context_line":"                dst_mac\u003dcomp_ovsport.get_mac(),"},{"line_number":436,"context_line":"                dst_port\u003dcomp_ovsport.get_ofport())"},{"line_number":437,"context_line":"        # Add the following flow rule only when ARP RESPONDER is"},{"line_number":438,"context_line":"        # enabled"},{"line_number":439,"context_line":"        if self.arp_responder_enabled:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fb8cfa7_d04d24c4","line":436,"range":{"start_line":436,"start_character":16,"end_line":436,"end_character":51},"updated":"2019-06-14 23:53:05.000000000","message":"Jun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent [None req-afffbf1e-1da7-4b03-bcbe-1bde223edb04 None None] Error while processing VIF ports: TypeError: install_dvr_to_local_gateway_port() got an unexpected keyword argument \u0027dst_port\u0027\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent Traceback (most recent call last):\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py\", line 2398, in rpc_loop\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     port_info, provisioning_needed)\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/usr/lib/python2.7/site-packages/osprofiler/profiler.py\", line 160, in wrapper\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     result \u003d f(*args, **kwargs)\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py\", line 1931, in process_network_ports\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     devices_added_updated, provisioning_needed))\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/usr/lib/python2.7/site-packages/osprofiler/profiler.py\", line 160, in wrapper\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     result \u003d f(*args, **kwargs)\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py\", line 1813, in treat_devices_added_or_updated\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     provisioning_needed)\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/usr/lib/python2.7/site-packages/osprofiler/profiler.py\", line 160, in wrapper\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     result \u003d f(*args, **kwargs)\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py\", line 1690, in treat_vif_port\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     fixed_ips, device_owner, provisioning_needed)\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/usr/lib/python2.7/site-packages/osprofiler/profiler.py\", line 160, in wrapper\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     result \u003d f(*args, **kwargs)\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py\", line 998, in port_bound\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     device_owner)\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/usr/lib/python2.7/site-packages/osprofiler/profiler.py\", line 160, in wrapper\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     result \u003d f(*args, **kwargs)\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py\", line 601, in bind_port_to_dvr\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     device_owner)\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent   File \"/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py\", line 436, in _bind_distributed_router_interface_port\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent     dst_port\u003dcomp_ovsport.get_ofport())\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent TypeError: install_dvr_to_local_gateway_port() got an unexpected keyword argument \u0027dst_port\u0027\nJun 15 00:42:18 network2 neutron-openvswitch-agent[25163]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent","commit_id":"128d44354bd4ca2f9e5efc976f3d6cfa455d5936"},{"author":{"_account_id":28329,"name":"yangjianfeng","display_name":"JeffYang","email":"yjf1970231893@gmail.com","username":"yangjianfeng"},"change_message_id":"56994c4e3f53854ddb4ff145805ca028550cd458","unresolved":false,"context_lines":[{"line_number":433,"context_line":"                vlan_tag\u003dvlan_to_use,"},{"line_number":434,"context_line":"                gateway_mac\u003dsubnet_info[\u0027gateway_mac\u0027],"},{"line_number":435,"context_line":"                dst_mac\u003dcomp_ovsport.get_mac(),"},{"line_number":436,"context_line":"                dst_port\u003dcomp_ovsport.get_ofport())"},{"line_number":437,"context_line":"        # Add the following flow rule only when ARP RESPONDER is"},{"line_number":438,"context_line":"        # enabled"},{"line_number":439,"context_line":"        if self.arp_responder_enabled:"}],"source_content_type":"text/x-python","patch_set":9,"id":"9fb8cfa7_36b6f38b","line":436,"range":{"start_line":436,"start_character":16,"end_line":436,"end_character":51},"in_reply_to":"9fb8cfa7_d04d24c4","updated":"2019-06-15 04:47:14.000000000","message":"Thanks, This is a mistake I made in resolving conflicts when I rebase master branch in patch set 8.","commit_id":"128d44354bd4ca2f9e5efc976f3d6cfa455d5936"}]}