)]}'
{"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":29071,"name":"norman shen","email":"yshxxsjt715@gmail.com","username":"ushen"},"change_message_id":"36384ee5f2a1d4f744bbc38e9529578e54cf91f4","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            connected_router_ids \u003d set(router_ids)"},{"line_number":141,"context_line":"            for router_id in router_ids:"},{"line_number":142,"context_line":"                connected_router_ids.update("},{"line_number":143,"context_line":"                    self._get_other_dvr_router_ids_connected_router("},{"line_number":144,"context_line":"                        context, router_id))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            LOG.debug(\u0027DVR: Handle new service port, host %(host)s, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_fa9b9f6f","line":143,"range":{"start_line":143,"start_character":25,"end_line":143,"end_character":67},"updated":"2019-06-12 04:15:41.000000000","message":"Please correct me \nif I am wrong but from this https://github.com/openstack/neutron/blob/c6426b3fecd4443b6c06aeedbb07c54946eda5e0/neutron/db/l3_dvrscheduler_db.py#L445, I think connected routers will be returned during syncing so is it really necessary to send connected routers to the agent?","commit_id":"52529bc949acff9a3454abd44925342468064b78"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"a1ce0d184d3b51287af44fca25fc78f92f887b29","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            connected_router_ids \u003d set(router_ids)"},{"line_number":141,"context_line":"            for router_id in router_ids:"},{"line_number":142,"context_line":"                connected_router_ids.update("},{"line_number":143,"context_line":"                    self._get_other_dvr_router_ids_connected_router("},{"line_number":144,"context_line":"                        context, router_id))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            LOG.debug(\u0027DVR: Handle new service port, host %(host)s, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_f53cbb31","line":143,"range":{"start_line":143,"start_character":25,"end_line":143,"end_character":67},"in_reply_to":"9fb8cfa7_adf71c59","updated":"2019-06-17 17:26:43.000000000","message":"Looks good to me.","commit_id":"52529bc949acff9a3454abd44925342468064b78"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2e30ad356d7a6381132df7ae6f18d1d21f79e6c0","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            connected_router_ids \u003d set(router_ids)"},{"line_number":141,"context_line":"            for router_id in router_ids:"},{"line_number":142,"context_line":"                connected_router_ids.update("},{"line_number":143,"context_line":"                    self._get_other_dvr_router_ids_connected_router("},{"line_number":144,"context_line":"                        context, router_id))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"            LOG.debug(\u0027DVR: Handle new service port, host %(host)s, \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_adf71c59","line":143,"range":{"start_line":143,"start_character":25,"end_line":143,"end_character":67},"in_reply_to":"9fb8cfa7_fa9b9f6f","updated":"2019-06-13 07:27:35.000000000","message":"after receiving routers_updated_on_host l3 agent will not do resync, it will just request specified routers from server and update them.","commit_id":"52529bc949acff9a3454abd44925342468064b78"}]}