)]}'
{"neutron/tests/unit/linuxbridge/test_lb_db.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"fd1ac734b43f10ebcf31e085de33aa67400f90f2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012-2014 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_79ec4b2a","line":1,"updated":"2014-05-22 12:48:08.000000000","message":"Please do not modify this line.  Your submitted work is on behalf Suse and not the OpenStack Foundation.","commit_id":"fc62bc3721a7807031f0b1e8cfb8971671e5af23"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"c83af20f201d254db4a71b67ca4e9df5548736eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2012-2014 OpenStack Foundation."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_0ad8437e","line":1,"in_reply_to":"7adec928_79ec4b2a","updated":"2014-05-22 13:56:38.000000000","message":"Done","commit_id":"fc62bc3721a7807031f0b1e8cfb8971671e5af23"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"fd1ac734b43f10ebcf31e085de33aa67400f90f2","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_sync_network_states_no_vlan_ranges(self):"},{"line_number":49,"context_line":"        lb_db.sync_network_states({})"},{"line_number":50,"context_line":"        self.assertEqual([], self.session.query(lb_models.NetworkState).all())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_sync_network_states(self):"},{"line_number":53,"context_line":"        self.assertIsNone(lb_db.get_network_state(PHYS_NET,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_7950cb0a","line":50,"updated":"2014-05-22 12:48:08.000000000","message":"self.assertFalse(self.session.query(lb_models.NetworkState).all())","commit_id":"fc62bc3721a7807031f0b1e8cfb8971671e5af23"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"c83af20f201d254db4a71b67ca4e9df5548736eb","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_sync_network_states_no_vlan_ranges(self):"},{"line_number":49,"context_line":"        lb_db.sync_network_states({})"},{"line_number":50,"context_line":"        self.assertEqual([], self.session.query(lb_models.NetworkState).all())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_sync_network_states(self):"},{"line_number":53,"context_line":"        self.assertIsNone(lb_db.get_network_state(PHYS_NET,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7adec928_eadcf776","line":50,"in_reply_to":"7adec928_7950cb0a","updated":"2014-05-22 13:56:38.000000000","message":"Done","commit_id":"fc62bc3721a7807031f0b1e8cfb8971671e5af23"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"eb8c1649b72f0b44676a2f4a0b3c17294bd3a534","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_sync_network_states_no_vlan_ranges(self):"},{"line_number":49,"context_line":"        lb_db.sync_network_states({})"},{"line_number":50,"context_line":"        self.assertFalse(self.session.query(lb_models.NetworkState).all())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_sync_network_states(self):"},{"line_number":53,"context_line":"        self.assertIsNone(lb_db.get_network_state(PHYS_NET,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7adec928_61d63729","line":50,"updated":"2014-05-23 04:47:31.000000000","message":"I can\u0027t say this test isn\u0027t useful.  However, it is very minimally useful.  Could the test ensure that the lines of code in the loop are actually being called?  Maybe check that session.delete gets called?","commit_id":"f3bd04f797148baacb8f067f0bf4f85705787b4a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"11aad03e9c841aa44e28be448b8b0e1017377cdd","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_sync_network_states_no_vlan_ranges(self):"},{"line_number":49,"context_line":"        lb_db.sync_network_states({})"},{"line_number":50,"context_line":"        self.assertFalse(self.session.query(lb_models.NetworkState).all())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_sync_network_states(self):"},{"line_number":53,"context_line":"        self.assertIsNone(lb_db.get_network_state(PHYS_NET,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_a95b7df4","line":50,"updated":"2014-06-04 09:31:38.000000000","message":"Thanks for clarifying.  I think it would be good to add the test were NetworkStates exist and then we call with the empty dict.","commit_id":"f3bd04f797148baacb8f067f0bf4f85705787b4a"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"47d5bbf9d2417ad6b061ed1f78abc73041c7c1fc","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_sync_network_states_no_vlan_ranges(self):"},{"line_number":49,"context_line":"        lb_db.sync_network_states({})"},{"line_number":50,"context_line":"        self.assertFalse(self.session.query(lb_models.NetworkState).all())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_sync_network_states(self):"},{"line_number":53,"context_line":"        self.assertIsNone(lb_db.get_network_state(PHYS_NET,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ae8d1ca_afb92c30","line":50,"in_reply_to":"3ae8d1ca_0c895126","updated":"2014-05-28 11:04:45.000000000","message":"This test is useful because it used to fail without the commit which fixed the bug. It\u0027s a regression test as said in the commit message.","commit_id":"f3bd04f797148baacb8f067f0bf4f85705787b4a"},{"author":{"_account_id":2340,"name":"Ionut Artarisi","email":"iartarisi@suse.cz","username":"mapleoin"},"change_message_id":"cdd39a591b5bf2028923689c0a8a6788c0c29c97","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_sync_network_states_no_vlan_ranges(self):"},{"line_number":49,"context_line":"        lb_db.sync_network_states({})"},{"line_number":50,"context_line":"        self.assertFalse(self.session.query(lb_models.NetworkState).all())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_sync_network_states(self):"},{"line_number":53,"context_line":"        self.assertIsNone(lb_db.get_network_state(PHYS_NET,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ae8d1ca_b22fcfa0","line":50,"in_reply_to":"3ae8d1ca_afb92c30","updated":"2014-05-28 12:03:49.000000000","message":"I feel like I should expand more on this. I think that testing that specific lines of code are called would tie the tests to the implementation and make the code harder to modify. The fact that the called method contains a session.delete call is an artifact of looping twice over the same data set, it\u0027s not inherent to syncing network states.\n\nThere was a bug which would make this test fail. I think this is motivation enough for adding this test.","commit_id":"f3bd04f797148baacb8f067f0bf4f85705787b4a"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"4788cd5a7fa93301fc7e86ac3b0b4d3b5ef1bf5a","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_sync_network_states_no_vlan_ranges(self):"},{"line_number":49,"context_line":"        lb_db.sync_network_states({})"},{"line_number":50,"context_line":"        self.assertFalse(self.session.query(lb_models.NetworkState).all())"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_sync_network_states(self):"},{"line_number":53,"context_line":"        self.assertIsNone(lb_db.get_network_state(PHYS_NET,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ae8d1ca_0c895126","line":50,"in_reply_to":"7adec928_61d63729","updated":"2014-05-28 09:17:58.000000000","message":"+1","commit_id":"f3bd04f797148baacb8f067f0bf4f85705787b4a"}]}