)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c69d60df2200a65a7077dfe23a809e2daa7e4de4","unresolved":false,"context_lines":[{"line_number":630,"context_line":"    def delete_route(self, cidr, device\u003dNone, via\u003dNone, table\u003dNone, scope\u003dNone,"},{"line_number":631,"context_line":"                     **kwargs):"},{"line_number":632,"context_line":"        table \u003d table or self._table"},{"line_number":633,"context_line":"        return delete_ip_route(self._parent.namespace, cidr, device\u003ddevice,"},{"line_number":634,"context_line":"                               via\u003dvia, table\u003dtable, scope\u003dscope, **kwargs)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_6e57e727","line":633,"updated":"2019-06-27 18:45:04.000000000","message":"Does this need to return anything?  At least delete_gateway() and flush() don\u0027t care.","commit_id":"b69073d5fe1fabc5e9d619db366ef55ad4586e7f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"faa2f09c63080cb870617ef1eaf709a0a2773c05","unresolved":false,"context_lines":[{"line_number":630,"context_line":"    def delete_route(self, cidr, device\u003dNone, via\u003dNone, table\u003dNone, scope\u003dNone,"},{"line_number":631,"context_line":"                     **kwargs):"},{"line_number":632,"context_line":"        table \u003d table or self._table"},{"line_number":633,"context_line":"        return delete_ip_route(self._parent.namespace, cidr, device\u003ddevice,"},{"line_number":634,"context_line":"                               via\u003dvia, table\u003dtable, scope\u003dscope, **kwargs)"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_843bfbe7","line":633,"in_reply_to":"9fb8cfa7_6e57e727","updated":"2019-07-01 10:37:39.000000000","message":"You are right. There is no need to return anything here.","commit_id":"b69073d5fe1fabc5e9d619db366ef55ad4586e7f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"8be900abd244e4f2babda03ea05a40d78047ed9d","unresolved":false,"context_lines":[{"line_number":619,"context_line":"    def flush(self, ip_version, table\u003dNone, **kwargs):"},{"line_number":620,"context_line":"        for route in self.list_routes(ip_version, table\u003dtable):"},{"line_number":621,"context_line":"            self.delete_route(route[\u0027cidr\u0027], device\u003droute[\u0027device\u0027],"},{"line_number":622,"context_line":"                              via\u003droute[\u0027via\u0027], table\u003dtable, **kwargs)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":"    def add_route(self, cidr, via\u003dNone, table\u003dNone, metric\u003dNone, scope\u003dNone,"},{"line_number":625,"context_line":"                  **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_9d61e93c","line":622,"updated":"2019-07-04 13:59:16.000000000","message":"isn\u0027t this slower than it was before as You are now deleting routes one by one instead of flush all at once?","commit_id":"429c77c574f471bdbb4dd91debef7a72c920b1e0"}],"neutron/privileged/agent/linux/ip_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c69d60df2200a65a7077dfe23a809e2daa7e4de4","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        with get_iproute(namespace) as ip:"},{"line_number":699,"context_line":"            kwargs.update(_make_pyroute2_route_args("},{"line_number":700,"context_line":"                namespace, ip_version, cidr, device, via, table, metric,"},{"line_number":701,"context_line":"                scope, \u0027static\u0027))"},{"line_number":702,"context_line":"            ip.route(\u0027replace\u0027, **kwargs)"},{"line_number":703,"context_line":"    except OSError as e:"},{"line_number":704,"context_line":"        if e.errno \u003d\u003d errno.ENOENT:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_ee38b7ee","line":701,"updated":"2019-06-27 18:45:04.000000000","message":"I think this could be outside the try right?","commit_id":"b69073d5fe1fabc5e9d619db366ef55ad4586e7f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"faa2f09c63080cb870617ef1eaf709a0a2773c05","unresolved":false,"context_lines":[{"line_number":698,"context_line":"        with get_iproute(namespace) as ip:"},{"line_number":699,"context_line":"            kwargs.update(_make_pyroute2_route_args("},{"line_number":700,"context_line":"                namespace, ip_version, cidr, device, via, table, metric,"},{"line_number":701,"context_line":"                scope, \u0027static\u0027))"},{"line_number":702,"context_line":"            ip.route(\u0027replace\u0027, **kwargs)"},{"line_number":703,"context_line":"    except OSError as e:"},{"line_number":704,"context_line":"        if e.errno \u003d\u003d errno.ENOENT:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_e404371a","line":701,"in_reply_to":"9fb8cfa7_ee38b7ee","updated":"2019-07-01 10:37:39.000000000","message":"Yes, we are not capturing any related error but I\u0027ll move it outside the try context.","commit_id":"b69073d5fe1fabc5e9d619db366ef55ad4586e7f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c69d60df2200a65a7077dfe23a809e2daa7e4de4","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        with get_iproute(namespace) as ip:"},{"line_number":718,"context_line":"            kwargs.update(_make_pyroute2_route_args("},{"line_number":719,"context_line":"                namespace, ip_version, None, device, None, table, None, None,"},{"line_number":720,"context_line":"                None))"},{"line_number":721,"context_line":"            return make_serializable(ip.route(\u0027show\u0027, **kwargs))"},{"line_number":722,"context_line":"    except OSError as e:"},{"line_number":723,"context_line":"        if e.errno \u003d\u003d errno.ENOENT:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_0e3c2bdf","line":720,"updated":"2019-06-27 18:45:04.000000000","message":"Same","commit_id":"b69073d5fe1fabc5e9d619db366ef55ad4586e7f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"faa2f09c63080cb870617ef1eaf709a0a2773c05","unresolved":false,"context_lines":[{"line_number":717,"context_line":"        with get_iproute(namespace) as ip:"},{"line_number":718,"context_line":"            kwargs.update(_make_pyroute2_route_args("},{"line_number":719,"context_line":"                namespace, ip_version, None, device, None, table, None, None,"},{"line_number":720,"context_line":"                None))"},{"line_number":721,"context_line":"            return make_serializable(ip.route(\u0027show\u0027, **kwargs))"},{"line_number":722,"context_line":"    except OSError as e:"},{"line_number":723,"context_line":"        if e.errno \u003d\u003d errno.ENOENT:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_8709bd2b","line":720,"in_reply_to":"9fb8cfa7_0e3c2bdf","updated":"2019-07-01 10:37:39.000000000","message":"Done","commit_id":"b69073d5fe1fabc5e9d619db366ef55ad4586e7f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c69d60df2200a65a7077dfe23a809e2daa7e4de4","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        with get_iproute(namespace) as ip:"},{"line_number":738,"context_line":"            kwargs.update(_make_pyroute2_route_args("},{"line_number":739,"context_line":"                namespace, ip_version, cidr, device, via, table, None, scope,"},{"line_number":740,"context_line":"                None))"},{"line_number":741,"context_line":"            ip.route(\u0027del\u0027, **kwargs)"},{"line_number":742,"context_line":"    except OSError as e:"},{"line_number":743,"context_line":"        if e.errno \u003d\u003d errno.ENOENT:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_ce2133b6","line":740,"updated":"2019-06-27 18:45:04.000000000","message":"Same","commit_id":"b69073d5fe1fabc5e9d619db366ef55ad4586e7f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"faa2f09c63080cb870617ef1eaf709a0a2773c05","unresolved":false,"context_lines":[{"line_number":737,"context_line":"        with get_iproute(namespace) as ip:"},{"line_number":738,"context_line":"            kwargs.update(_make_pyroute2_route_args("},{"line_number":739,"context_line":"                namespace, ip_version, cidr, device, via, table, None, scope,"},{"line_number":740,"context_line":"                None))"},{"line_number":741,"context_line":"            ip.route(\u0027del\u0027, **kwargs)"},{"line_number":742,"context_line":"    except OSError as e:"},{"line_number":743,"context_line":"        if e.errno \u003d\u003d errno.ENOENT:"}],"source_content_type":"text/x-python","patch_set":6,"id":"9fb8cfa7_27149143","line":740,"in_reply_to":"9fb8cfa7_ce2133b6","updated":"2019-07-01 10:37:39.000000000","message":"Done","commit_id":"b69073d5fe1fabc5e9d619db366ef55ad4586e7f"}]}