)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"07b90773d7e66be1bdffdd675fc169f5d56f5ad6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send notifications about DVR routers to L3 agents"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The get_l3_agents_hosting_routers function doesn\u0027t return l3 agents for"},{"line_number":10,"context_line":"DVR routers. get_hosts_to_notify properly returns hosts for both DVR and"},{"line_number":11,"context_line":"non-DVR routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1807157"},{"line_number":14,"context_line":"Change-Id: I68ac816b08acabbba5fcaa24d3f53b50712061bb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_07011b07","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":16},"updated":"2019-11-07 14:21:49.000000000","message":"So what\u0027s the different? get_hosts_to_notify will return the dvr local router host? If so, I may say sometimes it does not make sense. For instance, if you allow dvr local router to be hosted to some nodes due to some services port, for instance scheduled DHCP node. Is it necessary to notify that host?","commit_id":"9a75b66943768ffc8fd609b5a0169bb0e5069203"},{"author":{"_account_id":28655,"name":"Alexandru Sorodoc","email":"alex@privacysystems.eu","username":"bno1"},"change_message_id":"8a9592cd855460be525f6226a449b449518e69a0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send notifications about DVR routers to L3 agents"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The get_l3_agents_hosting_routers function doesn\u0027t return l3 agents for"},{"line_number":10,"context_line":"DVR routers. get_hosts_to_notify properly returns hosts for both DVR and"},{"line_number":11,"context_line":"non-DVR routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1807157"},{"line_number":14,"context_line":"Change-Id: I68ac816b08acabbba5fcaa24d3f53b50712061bb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_8ebf51a9","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":16},"in_reply_to":"3fa7e38b_07011b07","updated":"2019-11-09 12:44:41.000000000","message":"This sounds like the same problem you described on https://review.opendev.org/666964. If it\u0027s the same problem then let\u0027s continue the discussion on that change.","commit_id":"9a75b66943768ffc8fd609b5a0169bb0e5069203"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f753448a131271862ceb4ba7f5d35af585d6477a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send notifications about DVR routers to L3 agents"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The get_l3_agents_hosting_routers function doesn\u0027t return l3 agents for"},{"line_number":10,"context_line":"DVR routers. get_hosts_to_notify properly returns hosts for both DVR and"},{"line_number":11,"context_line":"non-DVR routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Bug: #1807157"},{"line_number":14,"context_line":"Change-Id: I68ac816b08acabbba5fcaa24d3f53b50712061bb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3fa7e38b_d7cdd530","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":16},"in_reply_to":"3fa7e38b_8ebf51a9","updated":"2019-11-11 11:51:39.000000000","message":"Sure","commit_id":"9a75b66943768ffc8fd609b5a0169bb0e5069203"}],"neutron/api/rpc/agentnotifiers/metering_rpc_agent_api.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dac66c89360865d61b236f25aaee025c409d3c64","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _agent_notification(self, context, method, routers):"},{"line_number":38,"context_line":"        \"\"\"Notify l3 metering agents hosted by l3 agent hosts.\"\"\""},{"line_number":39,"context_line":"        adminContext \u003d context if context.is_admin else context.elevated()"},{"line_number":40,"context_line":"        plugin \u003d directory.get_plugin(plugin_constants.L3)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        l3_routers \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_3d001e34","side":"PARENT","line":39,"updated":"2019-07-01 13:18:48.000000000","message":"Why are you removing the admin ctx here? \"get_l3_agents_hosting_routers\" is calling \"get_admin_state_up_filter\" too. You\u0027ll miss some registers here.","commit_id":"b7b399f16e351a708e9e387dfcb32b2845a6d37b"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dac66c89360865d61b236f25aaee025c409d3c64","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        l3_routers \u003d {}"},{"line_number":42,"context_line":"        for router in routers:"},{"line_number":43,"context_line":"            for host in plugin.get_hosts_to_notify(context, router[\u0027id\u0027]):"},{"line_number":44,"context_line":"                LOG.debug(\u0027Notify metering agent at %(topic)s.%(host)s \u0027"},{"line_number":45,"context_line":"                          \u0027the message %(method)s\u0027,"},{"line_number":46,"context_line":"                          {\u0027topic\u0027: self.topic,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_1ddc3ae2","line":43,"range":{"start_line":43,"start_character":31,"end_line":43,"end_character":50},"updated":"2019-07-01 13:18:48.000000000","message":"\"get_hosts_to_notify\" is calling \"get_l3_agents_hosting_routers\", but you claim the last function does not return the L3 agents for DVR routers [1].\n\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/l3_agentschedulers_db.py#L507","commit_id":"159103d8517dfa1f8fefe188a030bb1e4e5ea29f"}]}