)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ab44528bd1271964b62af8f71ab738dcc21ddfaa","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2019-06-23 00:31:55 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Count traffic on the SNAT namespace"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I700f19753436c90337ff941550a990e7c5da2685"},{"line_number":10,"context_line":"Partial-Bug: #1807157"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9fb8cfa7_bd32cea5","line":8,"updated":"2019-07-01 12:54:44.000000000","message":"I would:\n\n1) Add more description here in the commit message.\n2) Add a release note. We are modifying some counters available for the user. IMO, we should inform about this.\n3) Add testing, please.","commit_id":"2347b4a29402d60ed7e5172fef0b09de786cbffe"}],"neutron/services/metering/drivers/iptables/iptables_driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ab44528bd1271964b62af8f71ab738dcc21ddfaa","unresolved":false,"context_lines":[{"line_number":402,"context_line":"                continue"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"            for label_id in rm.metering_labels:"},{"line_number":405,"context_line":"                chain_acc \u003d None"},{"line_number":406,"context_line":"                snat_chain_acc \u003d None"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_1dfafabb","line":405,"updated":"2019-07-01 12:54:44.000000000","message":"Instead of using two variables, you can update only one:\n\nchain_acc \u003d {}\n\nif rm.snat_iptables_manager:\n chain_acc.update(rm.snat_iptables_manager.\n                  get_traffic_counters(\n                     chain, wrap\u003dFalse, zero\u003dTrue))\n\n# Same in L414-416","commit_id":"2347b4a29402d60ed7e5172fef0b09de786cbffe"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"35e0d42ec7491fb90a3d940f2ecf8468ae04c672","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                                                            label_id,"},{"line_number":442,"context_line":"                                                            wrap\u003dFalse)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"                    if rm.iptables_manager:"},{"line_number":445,"context_line":"                        chain_acc \u003d rm.iptables_manager.get_traffic_counters("},{"line_number":446,"context_line":"                            chain, wrap\u003dFalse, zero\u003dTrue)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"                    if rm.snat_iptables_manager:"},{"line_number":449,"context_line":"                        snat_chain_acc \u003d \\"},{"line_number":450,"context_line":"                            rm.snat_iptables_manager.get_traffic_counters("},{"line_number":451,"context_line":"                                chain, wrap\u003dFalse, zero\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_67e6cfb3","line":448,"range":{"start_line":444,"start_character":20,"end_line":448,"end_character":48},"updated":"2019-11-07 14:05:56.000000000","message":"1. Is this for the metring of centralized floating IPs of dvr router? 2. How about check the agent mode and then just call \u0027get_traffic_counters\u0027 once?\n3. Is there any chance that the metering data for same IP will be counted twice?","commit_id":"a96c66073d16f3975e1a032cfb394ca8fbccb48a"},{"author":{"_account_id":30609,"name":"Stanislav Dmitriev","email":"sdmitriev1@gmail.com","username":"sdmitriev"},"change_message_id":"1b427db3376375a654f7c8b8019a7fc3b17c8baa","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                                                            label_id,"},{"line_number":442,"context_line":"                                                            wrap\u003dFalse)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"                    if rm.iptables_manager:"},{"line_number":445,"context_line":"                        chain_acc \u003d rm.iptables_manager.get_traffic_counters("},{"line_number":446,"context_line":"                            chain, wrap\u003dFalse, zero\u003dTrue)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"                    if rm.snat_iptables_manager:"},{"line_number":449,"context_line":"                        snat_chain_acc \u003d \\"},{"line_number":450,"context_line":"                            rm.snat_iptables_manager.get_traffic_counters("},{"line_number":451,"context_line":"                                chain, wrap\u003dFalse, zero\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_2e742f36","line":448,"range":{"start_line":444,"start_character":20,"end_line":448,"end_character":48},"in_reply_to":"3fa7e38b_67e6cfb3","updated":"2019-11-07 18:14:41.000000000","message":"1. This is for summarizing traffic counters from iptables_manager and snat_iptables_manager of a dvr\n2. The point is get counters from both of managers if they exist, because some traffic can flow through snat, some traffic can flow through local qrouter and we need to count all of it\n3. I don\u0027t think so","commit_id":"a96c66073d16f3975e1a032cfb394ca8fbccb48a"},{"author":{"_account_id":28655,"name":"Alexandru Sorodoc","email":"alex@privacysystems.eu","username":"bno1"},"change_message_id":"667d8b31083330edbb1a0ebaaae026e9e100a945","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                                                            label_id,"},{"line_number":442,"context_line":"                                                            wrap\u003dFalse)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"                    if rm.iptables_manager:"},{"line_number":445,"context_line":"                        chain_acc \u003d rm.iptables_manager.get_traffic_counters("},{"line_number":446,"context_line":"                            chain, wrap\u003dFalse, zero\u003dTrue)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"                    if rm.snat_iptables_manager:"},{"line_number":449,"context_line":"                        snat_chain_acc \u003d \\"},{"line_number":450,"context_line":"                            rm.snat_iptables_manager.get_traffic_counters("},{"line_number":451,"context_line":"                                chain, wrap\u003dFalse, zero\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_6ed775f0","line":448,"range":{"start_line":444,"start_character":20,"end_line":448,"end_character":48},"in_reply_to":"3fa7e38b_67e6cfb3","updated":"2019-11-09 13:20:38.000000000","message":"1. Yes\n2. I think that is possible. I would have to update the database code to include agent_mode when querying L3 agents on a host. Is it possible for a host to run multiple L3 agents? If yes then how does that work?\n3. Since metering is done using iptables rules a packet would have to go through multiple interfaces that are metered (rpf-/qg- interfaces depending on the l3 agent mode) to be counted more than once. Afaik those interfaces are used to route external traffic so I don\u0027t think it\u0027s possible to count the same packet twice.","commit_id":"a96c66073d16f3975e1a032cfb394ca8fbccb48a"}]}