)]}'
{"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"279e10f8146f584a2989d06a0d8809511ae38d8f","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # NOTE(ralonsoh): we should not rely on the current execution order of"},{"line_number":121,"context_line":"        # the port extending functions. Although here we have"},{"line_number":122,"context_line":"        # port_res[VNIC_TYPE], we should retrieve this value from the port DB"},{"line_number":123,"context_line":"        # object instead."},{"line_number":124,"context_line":"        vnic_trait \u003d pl_utils.vnic_type_trait("},{"line_number":125,"context_line":"            port_res[portbindings.VNIC_TYPE])"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_b24d393c","line":123,"range":{"start_line":122,"start_character":31,"end_line":123,"end_character":25},"updated":"2019-06-28 08:29:37.000000000","message":"Question: that would mean db queries, or am I wrong?","commit_id":"7345c55797a8f63bbe838344dbdc44af716c6739"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"acf6773c559609ef79dd0e49d79bfde5f57e2cb7","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # NOTE(ralonsoh): we should not rely on the current execution order of"},{"line_number":121,"context_line":"        # the port extending functions. Although here we have"},{"line_number":122,"context_line":"        # port_res[VNIC_TYPE], we should retrieve this value from the port DB"},{"line_number":123,"context_line":"        # object instead."},{"line_number":124,"context_line":"        vnic_trait \u003d pl_utils.vnic_type_trait("},{"line_number":125,"context_line":"            port_res[portbindings.VNIC_TYPE])"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_94f6e08e","line":123,"range":{"start_line":122,"start_character":31,"end_line":123,"end_character":25},"in_reply_to":"9fb8cfa7_910a7223","updated":"2019-07-01 08:44:18.000000000","message":"ok, thanks","commit_id":"7345c55797a8f63bbe838344dbdc44af716c6739"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1a0d16df23ee7213d13aa3e996398474d26a119c","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        # NOTE(ralonsoh): we should not rely on the current execution order of"},{"line_number":121,"context_line":"        # the port extending functions. Although here we have"},{"line_number":122,"context_line":"        # port_res[VNIC_TYPE], we should retrieve this value from the port DB"},{"line_number":123,"context_line":"        # object instead."},{"line_number":124,"context_line":"        vnic_trait \u003d pl_utils.vnic_type_trait("},{"line_number":125,"context_line":"            port_res[portbindings.VNIC_TYPE])"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_910a7223","line":123,"range":{"start_line":122,"start_character":31,"end_line":123,"end_character":25},"in_reply_to":"9fb8cfa7_b24d393c","updated":"2019-06-28 10:45:52.000000000","message":"The value of \"port_res[portbindings.VNIC_TYPE]\" is written in an extended function (same as this one). The problem is we can\u0027t control the execution order of those functions and that means we cannot expect here this value. We should therefore execute a code similar to \"ML2Plugin._ml2_extend_port_dict_binding\" to retrieve this value.\n\nWe should not rely on obj_res content in any extended function, by default. Everything should be retrieved from the current DB/OVO object.","commit_id":"7345c55797a8f63bbe838344dbdc44af716c6739"}]}