)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5ffc69ce391cec01422ebb3c199bd9d55108c21e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-05 10:39:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use Pyroute2 \"add_tc_filter_policy\" function in l3_tc_lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I17f886a6b37da989afb0671758481544d64a8e3b"},{"line_number":10,"context_line":"Related-Bug: #1492714"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_7cecf328","line":7,"range":{"start_line":7,"start_character":48,"end_line":7,"end_character":57},"updated":"2019-07-09 16:03:29.000000000","message":"I found some differences after this change:\n1. the tc filter \"linklayer ethernet\" and \"linklayer unspec\"\n2. the rate value is a bit different \"1Mbit\" and \"1024Kbit\"\n\nMy env:\n$ uname -r\n3.10.0-957.10.1.el7.x86_64\n$ which ip\n/usr/sbin/ip\n$ rpm -qf /usr/sbin/ip\niproute-4.11.0-14.el7.x86_64\n\nBefore:\n[yulong@network2 ~]$ sudo ip netns exec snat-1abc2c44-e385-41cd-b554-c811d2fe2547 tc qdisc show\nqdisc noqueue 0: dev lo root refcnt 2 \nqdisc noqueue 0: dev ha-9274d8ae-a5 root refcnt 2 \nqdisc noqueue 0: dev sg-c37717e5-de root refcnt 2 \nqdisc htb 1: dev qg-a2c257de-29 root refcnt 2 r2q 10 default 0 direct_packets_stat 0 direct_qlen 1000\nqdisc ingress ffff: dev qg-a2c257de-29 parent ffff:fff1 ---------------- \n[yulong@network2 ~]$ sudo ip netns exec snat-1abc2c44-e385-41cd-b554-c811d2fe2547 tc -s -d -p filter show dev qg-a2c257de-29 parent 1:\nfilter protocol ip pref 1 u32 \nfilter protocol ip pref 1 u32 fh 800: ht divisor 1 \nfilter protocol ip pref 1 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid :1 not_in_hw  (rule hit 0 success 0)\n  match IP src 172.16.13.52/32 (success 0 ) \n police 0x2 rate 1Mbit burst 125Kb mtu 64Kb action drop overhead 0b linklayer ethernet \n\tref 1 bind 1 installed 169 sec used 169 sec\n\n Sent 0 bytes 0 pkts (dropped 0, overlimits 0) \n[yulong@network2 ~]$ sudo ip netns exec snat-1abc2c44-e385-41cd-b554-c811d2fe2547 tc -s -d -p filter show dev qg-a2c257de-29 parent ffff:\nfilter protocol ip pref 1 u32 \nfilter protocol ip pref 1 u32 fh 800: ht divisor 1 \nfilter protocol ip pref 1 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid :1 not_in_hw  (rule hit 4 success 0)\n  match IP dst 172.16.13.52/32 (success 0 ) \n police 0x1 rate 1Mbit burst 125Kb mtu 64Kb action drop overhead 0b linklayer ethernet \n\tref 1 bind 1 installed 174 sec used 174 sec\n\n Sent 0 bytes 0 pkts (dropped 0, overlimits 0)\n\n\n\n\nAfter:\n[yulong@network2 ~]$ sudo ip netns exec snat-1abc2c44-e385-41cd-b554-c811d2fe2547 tc qdisc show\nqdisc noqueue 0: dev lo root refcnt 2 \nqdisc noqueue 0: dev ha-9274d8ae-a5 root refcnt 2 \nqdisc noqueue 0: dev sg-c37717e5-de root refcnt 2 \nqdisc htb 1: dev qg-a2c257de-29 root refcnt 2 r2q 10 default 0 direct_packets_stat 10 direct_qlen 1000\nqdisc ingress ffff: dev qg-a2c257de-29 parent ffff:fff1 ----------------\n[yulong@network2 ~]$ sudo ip netns exec snat-1abc2c44-e385-41cd-b554-c811d2fe2547 tc -s -d -p filter show dev qg-a2c257de-29 parent 1:\nfilter protocol ip pref 1 u32 \nfilter protocol ip pref 1 u32 fh 800: ht divisor 1 \nfilter protocol ip pref 1 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid :1 not_in_hw  (rule hit 0 success 0)\n  match IP src 172.16.13.52/32 (success 0 ) \n police 0x2 rate 1024Kbit burst 125Kb mtu 64Kb action drop overhead 0b linklayer unspec \n\tref 1 bind 1 installed 28 sec used 28 sec\n\n Sent 0 bytes 0 pkts (dropped 0, overlimits 0)\n[yulong@network2 ~]$ sudo ip netns exec snat-1abc2c44-e385-41cd-b554-c811d2fe2547 tc -s -d -p filter show dev qg-a2c257de-29 parent ffff:\nfilter protocol ip pref 1 u32 \nfilter protocol ip pref 1 u32 fh 800: ht divisor 1 \nfilter protocol ip pref 1 u32 fh 800::800 order 2048 key ht 800 bkt 0 flowid :1 not_in_hw  (rule hit 0 success 0)\n  match IP dst 172.16.13.52/32 (success 0 ) \n police 0x1 rate 1024Kbit burst 125Kb mtu 64Kb action drop overhead 0b linklayer unspec \n\tref 1 bind 1 installed 33 sec used 33 sec\n\n Sent 0 bytes 0 pkts (dropped 0, overlimits 0)","commit_id":"8c4b1d6e1f135286f522a996827a5fa5eccea6d4"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4357e523636ac6328fa4819c105f901b6d82c25c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rodolfo Alonso Hernandez \u003cralonsoh@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-05 10:39:53 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use Pyroute2 \"add_tc_filter_policy\" function in l3_tc_lib"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I17f886a6b37da989afb0671758481544d64a8e3b"},{"line_number":10,"context_line":"Related-Bug: #1492714"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_8fc70b46","line":7,"range":{"start_line":7,"start_character":48,"end_line":7,"end_character":57},"in_reply_to":"7faddb67_7cecf328","updated":"2019-07-11 10:55:13.000000000","message":"a) Rate value: so far, those values are the same. I don\u0027t know the criteria followed by the CLI to print the value using kbit or Mbit\n\nb) Linklayer: currently is not possible to define the linklayer in the TC filter using pyroute2. This new parameter [0][1][2] was introduced, the goal was to align the ATM cells by passing linklayer\u003dATM to the filter. If linklayer is ethernet (or not specified), no alignment is done. The behavior in both cases is going to be the same.\n\n[0]https://github.com/sivasankariit/iproute2/commit/292f29b42c3444375b5ae7086484c99da7129d94\n[1]https://www.cnblogs.com/zengkefu/p/5635100.html\n[2]http://man7.org/linux/man-pages/man8/tc-police.8.html","commit_id":"8c4b1d6e1f135286f522a996827a5fa5eccea6d4"}],"etc/neutron/rootwrap.d/l3.filters":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5ffc69ce391cec01422ebb3c199bd9d55108c21e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"l3_tc_show_qdisc: RegExpFilter, tc, root, tc, qdisc, show, dev, .+"},{"line_number":35,"context_line":"l3_tc_show_filters: RegExpFilter, tc, root, tc, -p, -s, -d, filter, show, dev, .+, parent, .+, prio, 1"},{"line_number":36,"context_line":"l3_tc_delete_filters: RegExpFilter, tc, root, tc, filter, del, dev, .+, parent, .+, prio, 1, handle, .+, u32"},{"line_number":37,"context_line":"l3_tc_add_filter_ingress: RegExpFilter, tc, root, tc, filter, add, dev, .+, parent, .+, protocol, ip, prio, 1, u32, match, ip, dst, .+, police, rate, .+, burst, .+, mtu, 64kb, drop, flowid, :1"},{"line_number":38,"context_line":"l3_tc_add_filter_egress:  RegExpFilter, tc, root, tc, filter, add, dev, .+, parent, .+, protocol, ip, prio, 1, u32, match, ip, src, .+, police, rate, .+, burst, .+, mtu, 64kb, drop, flowid, :1"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# For ip monitor"},{"line_number":41,"context_line":"kill_ip_monitor: KillFilter, root, ip, -9"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9fb8cfa7_d8679024","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":192},"updated":"2019-07-09 16:03:29.000000000","message":"These two lines","commit_id":"82cec3d4ab55e7f43c17d844e426cdf476ad3bac"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"687acafa573d9f2c3e8142adf1e79d4e544f9625","unresolved":false,"context_lines":[{"line_number":34,"context_line":"l3_tc_show_qdisc: RegExpFilter, tc, root, tc, qdisc, show, dev, .+"},{"line_number":35,"context_line":"l3_tc_show_filters: RegExpFilter, tc, root, tc, -p, -s, -d, filter, show, dev, .+, parent, .+, prio, 1"},{"line_number":36,"context_line":"l3_tc_delete_filters: RegExpFilter, tc, root, tc, filter, del, dev, .+, parent, .+, prio, 1, handle, .+, u32"},{"line_number":37,"context_line":"l3_tc_add_filter_ingress: RegExpFilter, tc, root, tc, filter, add, dev, .+, parent, .+, protocol, ip, prio, 1, u32, match, ip, dst, .+, police, rate, .+, burst, .+, mtu, 64kb, drop, flowid, :1"},{"line_number":38,"context_line":"l3_tc_add_filter_egress:  RegExpFilter, tc, root, tc, filter, add, dev, .+, parent, .+, protocol, ip, prio, 1, u32, match, ip, src, .+, police, rate, .+, burst, .+, mtu, 64kb, drop, flowid, :1"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# For ip monitor"},{"line_number":41,"context_line":"kill_ip_monitor: KillFilter, root, ip, -9"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7faddb67_afe767e4","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":192},"in_reply_to":"7faddb67_143572f7","updated":"2019-07-11 10:56:24.000000000","message":"Those lines are removed in the latest patch","commit_id":"82cec3d4ab55e7f43c17d844e426cdf476ad3bac"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4357e523636ac6328fa4819c105f901b6d82c25c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"l3_tc_show_qdisc: RegExpFilter, tc, root, tc, qdisc, show, dev, .+"},{"line_number":35,"context_line":"l3_tc_show_filters: RegExpFilter, tc, root, tc, -p, -s, -d, filter, show, dev, .+, parent, .+, prio, 1"},{"line_number":36,"context_line":"l3_tc_delete_filters: RegExpFilter, tc, root, tc, filter, del, dev, .+, parent, .+, prio, 1, handle, .+, u32"},{"line_number":37,"context_line":"l3_tc_add_filter_ingress: RegExpFilter, tc, root, tc, filter, add, dev, .+, parent, .+, protocol, ip, prio, 1, u32, match, ip, dst, .+, police, rate, .+, burst, .+, mtu, 64kb, drop, flowid, :1"},{"line_number":38,"context_line":"l3_tc_add_filter_egress:  RegExpFilter, tc, root, tc, filter, add, dev, .+, parent, .+, protocol, ip, prio, 1, u32, match, ip, src, .+, police, rate, .+, burst, .+, mtu, 64kb, drop, flowid, :1"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# For ip monitor"},{"line_number":41,"context_line":"kill_ip_monitor: KillFilter, root, ip, -9"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7faddb67_143572f7","line":38,"range":{"start_line":37,"start_character":0,"end_line":38,"end_character":192},"in_reply_to":"9fb8cfa7_d8679024","updated":"2019-07-11 10:55:13.000000000","message":"Done","commit_id":"82cec3d4ab55e7f43c17d844e426cdf476ad3bac"}]}
