)]}'
{"neutron/tests/common/agents/l3_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"6e2015790aaaff6aaa88692246d2ecd1915a6043","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def main(manager\u003d\u0027neutron.tests.common.agents.l3_agent.L3NATAgentForTest\u0027):"},{"line_number":109,"context_line":"    register_opts(cfg.CONF)"},{"line_number":110,"context_line":"    cfg.CONF.set_override(\u0027use_helper_for_ns_read\u0027, False, group\u003d\u0027AGENT\u0027)"},{"line_number":111,"context_line":"    l3_agent.main(manager\u003dmanager)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_215c2e24","line":110,"updated":"2019-07-08 08:27:28.000000000","message":"instead of overriding this here I would rather add it to the neutron/tests/fullstack/resources/config.py file to be configured for given agent as needed.\nIn the future we can even make it parametrised if we will need to test something with using this helper.\n\nAnd the same comment is for all other agents changed in this patch :)","commit_id":"0eec931df662edc27b2d63d524f4ea6fe5a639bc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"dc8aed1298e5d21c8d56eb5a346b603f9838a56c","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"def main(manager\u003d\u0027neutron.tests.common.agents.l3_agent.L3NATAgentForTest\u0027):"},{"line_number":109,"context_line":"    register_opts(cfg.CONF)"},{"line_number":110,"context_line":"    cfg.CONF.set_override(\u0027use_helper_for_ns_read\u0027, False, group\u003d\u0027AGENT\u0027)"},{"line_number":111,"context_line":"    l3_agent.main(manager\u003dmanager)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_676d5697","line":110,"in_reply_to":"7faddb67_215c2e24","updated":"2019-07-08 11:10:59.000000000","message":"Done","commit_id":"0eec931df662edc27b2d63d524f4ea6fe5a639bc"}],"neutron/tests/fullstack/resources/config.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"c374fa3ccef01f158290f86fdda8ba2adb7ef82c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            base_filename, config_fixtures.ConfigDict(), temp_dir)"},{"line_number":55,"context_line":"        self.env_desc \u003d env_desc"},{"line_number":56,"context_line":"        self.host_desc \u003d host_desc"},{"line_number":57,"context_line":"        self.config.update({\u0027AGENT\u0027: {\u0027use_helper_for_ns_read\u0027: \u0027False\u0027}})"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _generate_namespace_suffix(self):"},{"line_number":60,"context_line":"        return utils.get_rand_name(prefix\u003d\u0027test\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_eb72107b","line":57,"range":{"start_line":57,"start_character":39,"end_line":57,"end_character":61},"updated":"2019-07-13 16:39:51.000000000","message":"This config is for agent, so it is better to put it in the agent config subclass (i.e. OVSConfigFixture, LinuxBridgeConfigFixture, etc.).","commit_id":"d7d1a91a5961a61c95cce316e8c7b1e5b7de92ca"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e717de66de9bdddd5f41037bb70706e318460701","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            base_filename, config_fixtures.ConfigDict(), temp_dir)"},{"line_number":55,"context_line":"        self.env_desc \u003d env_desc"},{"line_number":56,"context_line":"        self.host_desc \u003d host_desc"},{"line_number":57,"context_line":"        self.config.update({\u0027AGENT\u0027: {\u0027use_helper_for_ns_read\u0027: \u0027False\u0027}})"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _generate_namespace_suffix(self):"},{"line_number":60,"context_line":"        return utils.get_rand_name(prefix\u003d\u0027test\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_ee1533e6","line":57,"range":{"start_line":57,"start_character":39,"end_line":57,"end_character":61},"in_reply_to":"7faddb67_2302843e","updated":"2019-07-15 13:35:23.000000000","message":"I don\u0027t see why we should repeat this config option for each agent but I\u0027ll submit a patch for this.","commit_id":"d7d1a91a5961a61c95cce316e8c7b1e5b7de92ca"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"91e801c1a5289dc9a2ae427a38d479644d8204b9","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            base_filename, config_fixtures.ConfigDict(), temp_dir)"},{"line_number":55,"context_line":"        self.env_desc \u003d env_desc"},{"line_number":56,"context_line":"        self.host_desc \u003d host_desc"},{"line_number":57,"context_line":"        self.config.update({\u0027AGENT\u0027: {\u0027use_helper_for_ns_read\u0027: \u0027False\u0027}})"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _generate_namespace_suffix(self):"},{"line_number":60,"context_line":"        return utils.get_rand_name(prefix\u003d\u0027test\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_2302843e","line":57,"range":{"start_line":57,"start_character":39,"end_line":57,"end_character":61},"in_reply_to":"7faddb67_8315789e","updated":"2019-07-15 13:01:16.000000000","message":"I agree with Hongbin here. Maybe it would be better if You would move this setting to specific agent\u0027s configs fixtures?","commit_id":"d7d1a91a5961a61c95cce316e8c7b1e5b7de92ca"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cfeb735701d7a07f328b7270623021e126f3aa09","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            base_filename, config_fixtures.ConfigDict(), temp_dir)"},{"line_number":55,"context_line":"        self.env_desc \u003d env_desc"},{"line_number":56,"context_line":"        self.host_desc \u003d host_desc"},{"line_number":57,"context_line":"        self.config.update({\u0027AGENT\u0027: {\u0027use_helper_for_ns_read\u0027: \u0027False\u0027}})"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _generate_namespace_suffix(self):"},{"line_number":60,"context_line":"        return utils.get_rand_name(prefix\u003d\u0027test\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_8315789e","line":57,"range":{"start_line":57,"start_character":39,"end_line":57,"end_character":61},"in_reply_to":"7faddb67_eb72107b","updated":"2019-07-15 12:52:41.000000000","message":"This variable will be used (and updated) in all agents by inheriting from ConfigFixture. For example, in a DHCP agent, this variable is set to False (PS4 last recheck):\nhttp://logs.openstack.org/99/669199/4/check/neutron-fullstack/6366df6/controller/logs/dsvm-fullstack-logs/PortShutDownTest.test_port_shut_down_Linux-bridge-agent_/neutron-linuxbridge-agent--2019-07-13--10-23-34-849441_log.txt.gz#_2019-07-13_10_23_39_723","commit_id":"d7d1a91a5961a61c95cce316e8c7b1e5b7de92ca"}]}