)]}'
{"neutron/plugins/nicira/dbexts/qos_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8ab8c66034690398e0d3cc4b2a7662addf75e655","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2013 VMware, Inc.  All rights reserved."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BcMs%3D","line":3,"updated":"2014-01-26 13:00:12.000000000","message":"I\u0027m not sure these changes are needed.\nOn the other hand, it\u0027s not something I would care about.","commit_id":"3d338bd5e4d6291c62c4aa2d06ac2484acb31640"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"b41ba65dfbb0b2072566beed0bdab17f0a3f4a8d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import sqlalchemy as sa"},{"line_number":19,"context_line":"from sqlalchemy import orm"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2FkAI%3D","line":16,"updated":"2014-02-12 10:28:27.000000000","message":"is there a reason why you remove Aaron\u0027s name?","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"36a1c060563bcf54e50427eea685eae899f2afe9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import sqlalchemy as sa"},{"line_number":19,"context_line":"from sqlalchemy import orm"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2FiMw%3D","line":16,"in_reply_to":"AAAAUX%2F%2FkAI%3D","updated":"2014-02-12 14:56:23.000000000","message":"I am removing all authors from files when I find them...it\u0027s hard to track them and keep them up to date. Aaron was obviously not the only one contributing to this file, and so the other folks for other files. Nothing personal :)","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"}],"neutron/plugins/nicira/nsxlib/queue.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aeee297644782cd8be3cfdcced55f7e3cacd953f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2014 VMware, Inc."},{"line_number":4,"context_line":"# All Rights Reserved"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FN1k%3D","line":1,"updated":"2014-01-16 09:32:11.000000000","message":"do you want to leave this out? there is a general move away form the \"vim: ...\" in the headers","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6b02c6e9bfdfbcdec20eb2b4264d44bf9d4cb35a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2014 VMware, Inc."},{"line_number":4,"context_line":"# All Rights Reserved"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FK1Q%3D","line":1,"in_reply_to":"AAAAUH%2F%2FN1k%3D","updated":"2014-01-16 19:23:26.000000000","message":"could do.","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aeee297644782cd8be3cfdcced55f7e3cacd953f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    queue_obj[\u0027tags\u0027] \u003d utils.get_tags()"},{"line_number":43,"context_line":"    # NOTE(armando-migliaccio): remember that"},{"line_number":44,"context_line":"    # dscp must be omitted for trusted queues"},{"line_number":45,"context_line":"    if \u0027dscp\u0027 in queue_data:"},{"line_number":46,"context_line":"        queue_obj[\u0027dscp\u0027] \u003d queue_data[\u0027dscp\u0027]"},{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        return do_request(HTTP_POST,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FN0g%3D","line":45,"updated":"2014-01-16 09:32:11.000000000","message":"any reason not to use queue_data.get(dscp\u0027)?","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6b02c6e9bfdfbcdec20eb2b4264d44bf9d4cb35a","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    queue_obj[\u0027tags\u0027] \u003d utils.get_tags()"},{"line_number":43,"context_line":"    # NOTE(armando-migliaccio): remember that"},{"line_number":44,"context_line":"    # dscp must be omitted for trusted queues"},{"line_number":45,"context_line":"    if \u0027dscp\u0027 in queue_data:"},{"line_number":46,"context_line":"        queue_obj[\u0027dscp\u0027] \u003d queue_data[\u0027dscp\u0027]"},{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        return do_request(HTTP_POST,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FK2A%3D","line":45,"in_reply_to":"AAAAUH%2F%2FN0g%3D","updated":"2014-01-16 19:23:26.000000000","message":"in case dscp is missing, we cannot add it to the queue_obj","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aeee297644782cd8be3cfdcced55f7e3cacd953f","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        return do_request(HTTP_POST,"},{"line_number":49,"context_line":"                          _build_uri_path(LQUEUE_RESOURCE),"},{"line_number":50,"context_line":"                          json.dumps(queue_obj),"},{"line_number":51,"context_line":"                          cluster\u003dcluster)[\u0027uuid\u0027]"},{"line_number":52,"context_line":"    except NvpApiClient.NvpApiException:"},{"line_number":53,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FN0Q%3D","line":50,"updated":"2014-01-16 09:32:11.000000000","message":"any reason not to use the common openstack json module","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6b02c6e9bfdfbcdec20eb2b4264d44bf9d4cb35a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    try:"},{"line_number":48,"context_line":"        return do_request(HTTP_POST,"},{"line_number":49,"context_line":"                          _build_uri_path(LQUEUE_RESOURCE),"},{"line_number":50,"context_line":"                          json.dumps(queue_obj),"},{"line_number":51,"context_line":"                          cluster\u003dcluster)[\u0027uuid\u0027]"},{"line_number":52,"context_line":"    except NvpApiClient.NvpApiException:"},{"line_number":53,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FK18%3D","line":50,"in_reply_to":"AAAAUH%2F%2FN0Q%3D","updated":"2014-01-16 19:23:26.000000000","message":"not sure, this is just refactoring.","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aeee297644782cd8be3cfdcced55f7e3cacd953f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                          cluster\u003dcluster)[\u0027uuid\u0027]"},{"line_number":52,"context_line":"    except NvpApiClient.NvpApiException:"},{"line_number":53,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":54,"context_line":"        LOG.exception(_(\"Failed to create logical queue\"))"},{"line_number":55,"context_line":"        raise exception.NeutronException()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FN0Y%3D","line":54,"updated":"2014-01-16 09:32:11.000000000","message":"same comment as below","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6b02c6e9bfdfbcdec20eb2b4264d44bf9d4cb35a","unresolved":false,"context_lines":[{"line_number":51,"context_line":"                          cluster\u003dcluster)[\u0027uuid\u0027]"},{"line_number":52,"context_line":"    except NvpApiClient.NvpApiException:"},{"line_number":53,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":54,"context_line":"        LOG.exception(_(\"Failed to create logical queue\"))"},{"line_number":55,"context_line":"        raise exception.NeutronException()"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FK1o%3D","line":54,"in_reply_to":"AAAAUH%2F%2FN0Y%3D","updated":"2014-01-16 19:23:26.000000000","message":"which one?","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aeee297644782cd8be3cfdcced55f7e3cacd953f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                   resource_id\u003dqueue_id),"},{"line_number":63,"context_line":"                   cluster\u003dcluster)"},{"line_number":64,"context_line":"    except Exception:"},{"line_number":65,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":66,"context_line":"        LOG.exception(_(\"Failed to delete logical queue\"))"},{"line_number":67,"context_line":"        raise exception.NeutronException()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FN1U%3D","line":65,"updated":"2014-01-16 09:32:11.000000000","message":"i think that the comment can be removed no?","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6b02c6e9bfdfbcdec20eb2b4264d44bf9d4cb35a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                                   resource_id\u003dqueue_id),"},{"line_number":63,"context_line":"                   cluster\u003dcluster)"},{"line_number":64,"context_line":"    except Exception:"},{"line_number":65,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":66,"context_line":"        LOG.exception(_(\"Failed to delete logical queue\"))"},{"line_number":67,"context_line":"        raise exception.NeutronException()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FK1c%3D","line":65,"in_reply_to":"AAAAUH%2F%2FN1U%3D","updated":"2014-01-16 19:23:26.000000000","message":"I think this still applies, even though Quantum \u003d\u003d Neutron","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"aeee297644782cd8be3cfdcced55f7e3cacd953f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    except Exception:"},{"line_number":65,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":66,"context_line":"        LOG.exception(_(\"Failed to delete logical queue\"))"},{"line_number":67,"context_line":"        raise exception.NeutronException()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FN04%3D","line":67,"updated":"2014-01-16 09:32:11.000000000","message":"my understanding that when exceptions are logged there may be a problem with eventlet so we should use\nWe are now logging exceptions so we need to use save_and_reraise.","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6b02c6e9bfdfbcdec20eb2b4264d44bf9d4cb35a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    except Exception:"},{"line_number":65,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":66,"context_line":"        LOG.exception(_(\"Failed to delete logical queue\"))"},{"line_number":67,"context_line":"        raise exception.NeutronException()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FK0Q%3D","line":67,"in_reply_to":"AAAAUH%2F%2FN04%3D","updated":"2014-01-16 19:23:26.000000000","message":"we are not doing anything here that can cause another stacktrace, though? That said, this piece of code should really be cleaned up but in the context of this patch I am limiting myself to renaming and basic refactoring.","commit_id":"82549cafc881ea51487eefd131b089b337a7d31d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8ab8c66034690398e0d3cc4b2a7662addf75e655","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from neutron.plugins.nicira.nvplib import do_request"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"HTTP_POST \u003d \"POST\""},{"line_number":28,"context_line":"HTTP_DELETE \u003d \"DELETE\""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"LQUEUE_RESOURCE \u003d \"lqueue\""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BcMY%3D","line":28,"updated":"2014-01-26 13:00:12.000000000","message":"In another patch I have introduced the module neutron.plugins.nicira.common.constants for this stuff.\nWould it make sense to add it to the first patch of the renaming series, or would you prefer to refactor at the end?","commit_id":"3d338bd5e4d6291c62c4aa2d06ac2484acb31640"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8ab8c66034690398e0d3cc4b2a7662addf75e655","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    }"},{"line_number":42,"context_line":"    queue_obj[\u0027tags\u0027] \u003d utils.get_tags()"},{"line_number":43,"context_line":"    # NOTE(armando-migliaccio): remember that"},{"line_number":44,"context_line":"    # dscp must be omitted for trusted queues"},{"line_number":45,"context_line":"    if \u0027dscp\u0027 in queue_data:"},{"line_number":46,"context_line":"        queue_obj[\u0027dscp\u0027] \u003d queue_data[\u0027dscp\u0027]"},{"line_number":47,"context_line":"    try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BcMU%3D","line":44,"updated":"2014-01-26 13:00:12.000000000","message":"If this is a note which is important for the caller, this should be in a docstring for the function, so that when we\u0027ll have developer docs this will appear there.\n\nBut again - not important","commit_id":"3d338bd5e4d6291c62c4aa2d06ac2484acb31640"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"7a9fa00aa1189ebf714362237d74578d791dff9d","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":21,"context_line":"from neutron.common import exceptions as exception"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F9aXg%3D","line":18,"updated":"2014-02-07 03:44:44.000000000","message":"We should use the version from jsonutils for consistency. \n\nfrom neutron.openstack.common import jsonutils as json","commit_id":"f18d8e9784f01019f860afd4c07e498cc39ac7f9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"41385856c8fa8817843deff73ed28c2a42173211","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":21,"context_line":"from neutron.common import exceptions as exception"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUX%2F%2Fyn0%3D","line":18,"in_reply_to":"AAAAUH%2F9aXg%3D","updated":"2014-02-10 19:44:28.000000000","message":"Done","commit_id":"f18d8e9784f01019f860afd4c07e498cc39ac7f9"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"b41ba65dfbb0b2072566beed0bdab17f0a3f4a8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 VMware, Inc."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2Fj%2Fk%3D","line":1,"updated":"2014-02-12 10:28:27.000000000","message":"I think you are missing the standar here:\n# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4\n#\n# Co...","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"36a1c060563bcf54e50427eea685eae899f2afe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 VMware, Inc."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2FiMU%3D","line":1,"in_reply_to":"AAAAUX%2F%2Fj%2Fk%3D","updated":"2014-02-12 14:56:23.000000000","message":"There\u0027s an effort about removing all of them.","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c372139417b289a5faf1b8e89ed211d4c98cd491","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                          _build_uri_path(LQUEUE_RESOURCE),"},{"line_number":54,"context_line":"                          jsonutils.dumps(queue_obj),"},{"line_number":55,"context_line":"                          cluster\u003dcluster)[\u0027uuid\u0027]"},{"line_number":56,"context_line":"    except NvpApiClient.NvpApiException:"},{"line_number":57,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":58,"context_line":"        LOG.exception(_(\"Failed to create logical queue\"))"},{"line_number":59,"context_line":"        raise exception.NeutronException()"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2FkOk%3D","line":56,"updated":"2014-02-12 10:00:55.000000000","message":"should save_and_reraise_exception be used here?","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"516adbca68669a6829fc1bc06f416def65706698","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                          _build_uri_path(LQUEUE_RESOURCE),"},{"line_number":54,"context_line":"                          jsonutils.dumps(queue_obj),"},{"line_number":55,"context_line":"                          cluster\u003dcluster)[\u0027uuid\u0027]"},{"line_number":56,"context_line":"    except NvpApiClient.NvpApiException:"},{"line_number":57,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":58,"context_line":"        LOG.exception(_(\"Failed to create logical queue\"))"},{"line_number":59,"context_line":"        raise exception.NeutronException()"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2FhfA%3D","line":56,"in_reply_to":"AAAAUX%2F%2FkOk%3D","updated":"2014-02-12 16:04:15.000000000","message":"Done","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"b41ba65dfbb0b2072566beed0bdab17f0a3f4a8d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                          jsonutils.dumps(queue_obj),"},{"line_number":55,"context_line":"                          cluster\u003dcluster)[\u0027uuid\u0027]"},{"line_number":56,"context_line":"    except NvpApiClient.NvpApiException:"},{"line_number":57,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":58,"context_line":"        LOG.exception(_(\"Failed to create logical queue\"))"},{"line_number":59,"context_line":"        raise exception.NeutronException()"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2Fj%2FY%3D","line":57,"updated":"2014-02-12 10:28:27.000000000","message":"QuantumException, what is Quantum?  :-)","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"516adbca68669a6829fc1bc06f416def65706698","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                          jsonutils.dumps(queue_obj),"},{"line_number":55,"context_line":"                          cluster\u003dcluster)[\u0027uuid\u0027]"},{"line_number":56,"context_line":"    except NvpApiClient.NvpApiException:"},{"line_number":57,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":58,"context_line":"        LOG.exception(_(\"Failed to create logical queue\"))"},{"line_number":59,"context_line":"        raise exception.NeutronException()"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2Fhe8%3D","line":57,"in_reply_to":"AAAAUX%2F%2Fj%2FY%3D","updated":"2014-02-12 16:04:15.000000000","message":"Done","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c372139417b289a5faf1b8e89ed211d4c98cd491","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                   _build_uri_path(LQUEUE_RESOURCE,"},{"line_number":66,"context_line":"                                   resource_id\u003dqueue_id),"},{"line_number":67,"context_line":"                   cluster\u003dcluster)"},{"line_number":68,"context_line":"    except Exception:"},{"line_number":69,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":70,"context_line":"        LOG.exception(_(\"Failed to delete logical queue\"))"},{"line_number":71,"context_line":"        raise exception.NeutronException()"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2FkOY%3D","line":68,"updated":"2014-02-12 10:00:55.000000000","message":"ditto","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"516adbca68669a6829fc1bc06f416def65706698","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                   _build_uri_path(LQUEUE_RESOURCE,"},{"line_number":66,"context_line":"                                   resource_id\u003dqueue_id),"},{"line_number":67,"context_line":"                   cluster\u003dcluster)"},{"line_number":68,"context_line":"    except Exception:"},{"line_number":69,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":70,"context_line":"        LOG.exception(_(\"Failed to delete logical queue\"))"},{"line_number":71,"context_line":"        raise exception.NeutronException()"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2Fhe0%3D","line":68,"in_reply_to":"AAAAUX%2F%2FkOY%3D","updated":"2014-02-12 16:04:15.000000000","message":"Done","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"b41ba65dfbb0b2072566beed0bdab17f0a3f4a8d","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                   resource_id\u003dqueue_id),"},{"line_number":67,"context_line":"                   cluster\u003dcluster)"},{"line_number":68,"context_line":"    except Exception:"},{"line_number":69,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":70,"context_line":"        LOG.exception(_(\"Failed to delete logical queue\"))"},{"line_number":71,"context_line":"        raise exception.NeutronException()"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2Fj%2FA%3D","line":69,"updated":"2014-02-12 10:28:27.000000000","message":"Quantum???","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"516adbca68669a6829fc1bc06f416def65706698","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                                   resource_id\u003dqueue_id),"},{"line_number":67,"context_line":"                   cluster\u003dcluster)"},{"line_number":68,"context_line":"    except Exception:"},{"line_number":69,"context_line":"        # FIXME(salv-orlando): This should not raise QauntumException"},{"line_number":70,"context_line":"        LOG.exception(_(\"Failed to delete logical queue\"))"},{"line_number":71,"context_line":"        raise exception.NeutronException()"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2Fhew%3D","line":69,"in_reply_to":"AAAAUX%2F%2Fj%2FA%3D","updated":"2014-02-12 16:04:15.000000000","message":"Done","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"}],"neutron/tests/unit/nicira/nsxlib/test_queue.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"8ab8c66034690398e0d3cc4b2a7662addf75e655","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.common import exceptions"},{"line_number":20,"context_line":"from neutron.plugins.nicira.nsxlib import queue as queuelib"},{"line_number":21,"context_line":"from neutron.plugins.nicira import NvpApiClient"},{"line_number":22,"context_line":"from neutron.tests.unit.nicira.test_nvplib import NvplibTestCase"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class TestLogicalQueueLib(NvplibTestCase):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAUH%2F%2BcMM%3D","line":22,"updated":"2014-01-26 13:00:12.000000000","message":"I think this blueprint would be a good place for becoming independent from the fake api client, so that we can move towards its removal.\n\nWhat is your opinion?","commit_id":"3d338bd5e4d6291c62c4aa2d06ac2484acb31640"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"b41ba65dfbb0b2072566beed0bdab17f0a3f4a8d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 VMware, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2Fj%2Bk%3D","line":1,"updated":"2014-02-12 10:28:27.000000000","message":"same comment that before!","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"36a1c060563bcf54e50427eea685eae899f2afe9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 VMware, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUX%2F%2FiMM%3D","line":1,"in_reply_to":"AAAAUX%2F%2Fj%2Bk%3D","updated":"2014-02-12 14:56:23.000000000","message":"ditto","commit_id":"85122a33892bcc653c7c0e0ee6b97ad97e221847"}]}