)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22165,"name":"caoyuan","email":"cao.yingjunz@gmail.com","username":"caoyuan"},"change_message_id":"176c26c51ee23ad8d2b0d3b0f6039e4ad611c3a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanghongyu \u003chongyu.yang@vip.163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-09 06:09:20 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Limit ports according to status for configure_dhcp_for_network() and reload_allocations()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The neutron dhcp agent will make ports status reactive after network/subnet/port update."},{"line_number":10,"context_line":"In wrong situation _dhcp_ready_ports_loop will rpc call dhcp_ready_on_ports and notify _port_provisioned"},{"line_number":11,"context_line":"to make port active no mater port status was active or down."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Here limit port whick is active for configure_dhcp_for_network() and reload_allocations()."},{"line_number":14,"context_line":"In this case port which status is down wont be put in dhcp_ready_ports and __dhcp_ready_ports_loop"},{"line_number":15,"context_line":"wont be trigled."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I20eb96728dae3ff5f8ace8a7a91fe92f6beef7b0"},{"line_number":18,"context_line":"Closes-Bug: #1834979"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_83062386","line":15,"range":{"start_line":7,"start_character":0,"end_line":15,"end_character":16},"updated":"2019-07-10 02:19:07.000000000","message":"Please follow proper formatting for commit messages\nTitle of commit \u003c less then 50 characters \u003cCR\u003e \nDescription of commit (wrapped at 71 characters) may be mulltiline\nCloses-Bug: #X or TrivialFix or Implements:","commit_id":"d7b8adeb6fe8f01ff35456ebac94904a016422a9"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3a9be90d06f24b73729a91f512f3ebeea2581e63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanghongyu \u003chongyu.yang@vip.163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-10 16:23:49 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Limit ports according to status for configure_dhcp_for_network() and reload_allocations()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The neutron dhcp agent will make ports status reactive after network/subnet/port update."},{"line_number":10,"context_line":"In wrong situation _dhcp_ready_ports_loop will rpc call dhcp_ready_on_ports and notify _port_provisioned"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_d3f79e8a","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":31},"updated":"2019-07-17 10:11:14.000000000","message":"This minimal sentence is enough for commit message title, IMO.","commit_id":"153f9fcfdab191d682a09448cb03913c6697dd79"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"3a9be90d06f24b73729a91f512f3ebeea2581e63","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Limit ports according to status for configure_dhcp_for_network() and reload_allocations()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The neutron dhcp agent will make ports status reactive after network/subnet/port update."},{"line_number":10,"context_line":"In wrong situation _dhcp_ready_ports_loop will rpc call dhcp_ready_on_ports and notify _port_provisioned"},{"line_number":11,"context_line":"to make port active no mater port status was active or down."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Here limit port whick is active for configure_dhcp_for_network() and reload_allocations()."},{"line_number":14,"context_line":"In this case port which status is down wont be put in dhcp_ready_ports and __dhcp_ready_ports_loop"},{"line_number":15,"context_line":"wont be trigled."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I20eb96728dae3ff5f8ace8a7a91fe92f6beef7b0"},{"line_number":18,"context_line":"Closes-Bug: #1834979"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_332e32fb","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":16},"updated":"2019-07-17 10:11:14.000000000","message":"Commit message body should not exceed 79 character width.\nHere are some examples:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"153f9fcfdab191d682a09448cb03913c6697dd79"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a224524c74bc69cdfa7b39bcac662940679148ac","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanghongyu \u003chongyu.yang@vip.163.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-07-22 02:20:34 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Limit ports according to status for configure_dhcp_for_network()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The neutron dhcp agent will make ports status reactive after"},{"line_number":10,"context_line":"network/subnet/port update.In wrong situation _dhcp_ready_ports_loop"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_213775e6","line":7,"range":{"start_line":7,"start_character":36,"end_line":7,"end_character":62},"updated":"2019-07-22 14:42:37.000000000","message":"nit: IMO, we should do not refer to the real function name for a commit message. A brief abstract of one function can be good.","commit_id":"f9a28ce8dde400eda3861b07e5d3781eb658f17a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"a224524c74bc69cdfa7b39bcac662940679148ac","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Limit ports according to status for configure_dhcp_for_network()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The neutron dhcp agent will make ports status reactive after"},{"line_number":10,"context_line":"network/subnet/port update.In wrong situation _dhcp_ready_ports_loop"},{"line_number":11,"context_line":"will rpc call dhcp_ready_on_ports and notify _port_provisioned to make port"},{"line_number":12,"context_line":"active no mater port status was active or down."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_e65df348","line":10,"range":{"start_line":10,"start_character":26,"end_line":10,"end_character":27},"updated":"2019-07-22 14:42:37.000000000","message":"Nit: missing white space","commit_id":"f9a28ce8dde400eda3861b07e5d3781eb658f17a"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"55ff26d6ebbd6bcbed209d5440a42d1c03e27519","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Here limit port whick is active for configure_dhcp_for_network()."},{"line_number":15,"context_line":"In this case port which status is down wont be put in dhcp_ready_ports"},{"line_number":16,"context_line":"and __dhcp_ready_ports_loop wont be trigled."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I20eb96728dae3ff5f8ace8a7a91fe92f6beef7b0"},{"line_number":19,"context_line":"Closes-Bug: #1834979"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7faddb67_7d442d1c","line":16,"updated":"2019-07-22 20:57:11.000000000","message":"nit: triggered","commit_id":"f9a28ce8dde400eda3861b07e5d3781eb658f17a"},{"author":{"_account_id":30103,"name":"xiaosa","email":"xiaosa@awcloud.com","username":"xiaosa"},"change_message_id":"6eef9d386b6b5847313e76af98d77a1bbfb0f4bd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"will rpc call dhcp_ready_on_ports and notify _port_provisioned to make port"},{"line_number":12,"context_line":"active no mater port status was active or down."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Here limit port whick is active for configure_dhcp_for_network()."},{"line_number":15,"context_line":"In this case port which status is down wont be put in dhcp_ready_ports"},{"line_number":16,"context_line":"and __dhcp_ready_ports_loop wont be triggered."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"7faddb67_ce19e522","line":14,"range":{"start_line":14,"start_character":16,"end_line":14,"end_character":21},"updated":"2019-07-23 02:25:22.000000000","message":"nit: which","commit_id":"e3449d58a6944b16b20bd8fdee5a353a493dd5dd"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"6403d998cd891384ea422f61ad5fe3a4fece093d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Limit ports according to status while update network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The neutron dhcp agent will make ports status reactive after"},{"line_number":10,"context_line":"network/subnet/port update. In wrong situation _dhcp_ready_ports_loop"},{"line_number":11,"context_line":"will rpc call dhcp_ready_on_ports and notify _port_provisioned to make port"},{"line_number":12,"context_line":"active no mater port status was active or down."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"1f493fa4_05b456f1","line":9,"range":{"start_line":9,"start_character":46,"end_line":9,"end_character":54},"updated":"2020-04-27 08:54:16.000000000","message":"back to ACTIVE","commit_id":"098d7b122aef3e1c689d0b161bbf1f88239dfacf"}],"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"952d1cee8afd1dbb6fe57a650b77f4dab55ff0ee","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                    # configuration on port which is DOWN. Otherwise it"},{"line_number":344,"context_line":"                    # will make DOWN port reactive incorrectly."},{"line_number":345,"context_line":"                    self.dhcp_ready_ports |\u003d {p.id for p in network.ports"},{"line_number":346,"context_line":"                         if p.status \u003d\u003d constants.PORT_STATUS_ACTIVE}"},{"line_number":347,"context_line":"                break"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"        self._resize_process_pool()"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_4d4fe691","line":346,"updated":"2019-07-29 08:26:59.000000000","message":"what about ports which has status BUILD? Shouldn\u0027t those be included here too?","commit_id":"098d7b122aef3e1c689d0b161bbf1f88239dfacf"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"222a381729ec44f985ab11f9b4d2af5336c9875c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                            mac_address\u003d\u0027aa:bb:cc:dd:ee:99\u0027,"},{"line_number":130,"context_line":"                            network_id\u003dFAKE_NETWORK_UUID,"},{"line_number":131,"context_line":"                            revision_number\u003d77,"},{"line_number":132,"context_line":"                            status\u003dconst.PORT_STATUS_ACTIVE,"},{"line_number":133,"context_line":"                            fixed_ips\u003d[fake_fixed_ip2]))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"fake_ipv6_port \u003d dhcp.DictModel(dict(id\u003d\u002712345678-1234-aaaa-123456789000\u0027,"}],"source_content_type":"text/x-python","patch_set":11,"id":"7faddb67_ceb4f738","line":132,"updated":"2019-07-31 21:43:24.000000000","message":"PERHAPS set this to BUILD status and make sure that it is handled appropriately.","commit_id":"098d7b122aef3e1c689d0b161bbf1f88239dfacf"}]}