)]}'
{"neutron/agent/linux/openvswitch_firewall/firewall.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1fd7a94ebd53150319ea720086eb380fbe880fc8","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        for port_id in port_ids:"},{"line_number":668,"context_line":"            self._initialize_egress_no_port_security(port_id)"},{"line_number":669,"context_line":"            # yield to let other greenthreads proceed"},{"line_number":670,"context_line":"            eventlet.sleep(0)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def remove_trusted_ports(self, port_ids):"},{"line_number":673,"context_line":"        for port_id in port_ids:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_12cb5b72","line":670,"range":{"start_line":670,"start_character":27,"end_line":670,"end_character":28},"updated":"2019-07-10 09:19:19.000000000","message":"nit: by default sleep(seconds\u003d0), so this 0 is not necessary.\nBut I agree that makes reading easier.","commit_id":"6278c9ae9f1941397bdc55632f8e4ca58a25834a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b308bc72885688b47bfaebfd418e96b83827d5df","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    def remove_trusted_ports(self, port_ids):"},{"line_number":673,"context_line":"        for port_id in port_ids:"},{"line_number":674,"context_line":"            try:"},{"line_number":675,"context_line":"                self._remove_egress_no_port_security(port_id)"},{"line_number":676,"context_line":"            except exceptions.OVSFWPortNotHandled as e:"},{"line_number":677,"context_line":"                LOG.debug(e)"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ef86cadb","line":675,"updated":"2019-07-10 19:24:34.000000000","message":"Should there be a sleep here as well?","commit_id":"6278c9ae9f1941397bdc55632f8e4ca58a25834a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e5026c0687569d75f9868da4761da1a3ba3842c5","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    def remove_trusted_ports(self, port_ids):"},{"line_number":673,"context_line":"        for port_id in port_ids:"},{"line_number":674,"context_line":"            try:"},{"line_number":675,"context_line":"                self._remove_egress_no_port_security(port_id)"},{"line_number":676,"context_line":"            except exceptions.OVSFWPortNotHandled as e:"},{"line_number":677,"context_line":"                LOG.debug(e)"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d544b41d","line":675,"in_reply_to":"7faddb67_a690f44f","updated":"2019-07-11 12:54:45.000000000","message":"There\u0027s probably some contrived way, like creating a network with 1000 subnets, then removing it from a dhcp agent.  I just wanted to make sure you weren\u0027t back in a month fixing it :)","commit_id":"6278c9ae9f1941397bdc55632f8e4ca58a25834a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"19f4662753db855f6aab9276a218f0c908d5d212","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    def remove_trusted_ports(self, port_ids):"},{"line_number":673,"context_line":"        for port_id in port_ids:"},{"line_number":674,"context_line":"            try:"},{"line_number":675,"context_line":"                self._remove_egress_no_port_security(port_id)"},{"line_number":676,"context_line":"            except exceptions.OVSFWPortNotHandled as e:"},{"line_number":677,"context_line":"                LOG.debug(e)"},{"line_number":678,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a690f44f","line":675,"in_reply_to":"7faddb67_ef86cadb","updated":"2019-07-11 07:10:52.000000000","message":"Not sure when can massive trusted ports removal take place.. Also seems there is no calls to OVS inside loop, only deferred flows apply.","commit_id":"6278c9ae9f1941397bdc55632f8e4ca58a25834a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"543c9cc32c42bf392fb8ff8fd255d9558cbb100d","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        for port_id in port_ids:"},{"line_number":668,"context_line":"            self._initialize_egress_no_port_security(port_id)"},{"line_number":669,"context_line":"            # yield to let other greenthreads proceed"},{"line_number":670,"context_line":"            eventlet.sleep(0)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def remove_trusted_ports(self, port_ids):"},{"line_number":673,"context_line":"        for port_id in port_ids:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_dd436c12","line":670,"updated":"2019-07-12 09:19:21.000000000","message":"what about iptables fw driver https://github.com/openstack/neutron/blob/15c5eef58df62acf595b4986f47d2d9801fc2f94/neutron/agent/linux/iptables_firewall.py#L119 ? Wouldn\u0027t be same change useful there too?","commit_id":"da539da3780188f01e18ef106dde9ca180324c2a"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7b3530e64ba2c5b7ddb9a79f3eacb3a41d9177f2","unresolved":false,"context_lines":[{"line_number":667,"context_line":"        for port_id in port_ids:"},{"line_number":668,"context_line":"            self._initialize_egress_no_port_security(port_id)"},{"line_number":669,"context_line":"            # yield to let other greenthreads proceed"},{"line_number":670,"context_line":"            eventlet.sleep(0)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def remove_trusted_ports(self, port_ids):"},{"line_number":673,"context_line":"        for port_id in port_ids:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_7de838e1","line":670,"in_reply_to":"7faddb67_dd436c12","updated":"2019-07-12 09:28:30.000000000","message":"Not sure, need to test","commit_id":"da539da3780188f01e18ef106dde9ca180324c2a"}]}