)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ddf6b84f0dc40c98c7e6c812a76779dddcb173a0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch includes a fix for the \"configure_for_func_testing.sh\" script."},{"line_number":10,"context_line":"When the guidelines are followed from the following link:"},{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment.html"},{"line_number":12,"context_line":"the test script displays the following error:"},{"line_number":13,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 (using password: YES)."},{"line_number":14,"context_line":"The fix for this is to include the saved password in order to access the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_06b9d678","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":76},"updated":"2019-07-10 15:46:10.000000000","message":"Could you please check with latest doc:\nhttps://docs.openstack.org/neutron/latest/contributor/testing/testing.html#id4\n\nPerhaps the description on ocata has issue","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"67c5e2f2490b8c619ceceb76083f2fba4f989952","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch includes a fix for the \"configure_for_func_testing.sh\" script."},{"line_number":10,"context_line":"When the guidelines are followed from the following link:"},{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment.html"},{"line_number":12,"context_line":"the test script displays the following error:"},{"line_number":13,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 (using password: YES)."},{"line_number":14,"context_line":"The fix for this is to include the saved password in order to access the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_31e427e1","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":76},"in_reply_to":"7faddb67_06b9d678","updated":"2019-07-12 14:13:48.000000000","message":"I checked the latest release and the steps outlined in the doc are the same ( they\u0027re correct.)\nThe parts which I followed from the page were the git clone devstack line and the relevant configure functional tests script located in /opt/stack/neutron/tools in and run in  /home/ubuntu/devstack.","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d8ea82e87dc6d2b24bdf88eddf6b9a19971becaa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch includes a fix for the \"configure_for_func_testing.sh\" script."},{"line_number":10,"context_line":"When the guidelines are followed from the following link:"},{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment.html"},{"line_number":12,"context_line":"the test script displays the following error:"},{"line_number":13,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 (using password: YES)."},{"line_number":14,"context_line":"The fix for this is to include the saved password in order to access the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_35016106","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":76},"in_reply_to":"7faddb67_31e427e1","updated":"2019-07-15 04:56:11.000000000","message":"ok, thanks for checking.","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"efdb23626f5e339d78050d951085e5bd54d85732","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch includes a fix for the \"configure_for_func_testing.sh\" script."},{"line_number":10,"context_line":"When the guidelines are followed from the following link:"},{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment.html"},{"line_number":12,"context_line":"the test script displays the following error:"},{"line_number":13,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 (using password: YES)."},{"line_number":14,"context_line":"The fix for this is to include the saved password in order to access the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_4f8001c0","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":76},"in_reply_to":"7faddb67_35016106","updated":"2019-07-15 15:45:09.000000000","message":"no worries!","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e1492ba6463fee7936d65a9e6664a4356cb92d2a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"When the guidelines are followed from the following link:"},{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment.html"},{"line_number":12,"context_line":"the test script displays the following error:"},{"line_number":13,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 (using password: YES)."},{"line_number":14,"context_line":"The fix for this is to include the saved password in order to access the"},{"line_number":15,"context_line":"MySQL database."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_32b8d774","line":13,"updated":"2019-07-10 09:40:40.000000000","message":"Max line length in commit messages: 72\n\nhttps://pep8.org/#maximum-line-length","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"67c5e2f2490b8c619ceceb76083f2fba4f989952","unresolved":false,"context_lines":[{"line_number":10,"context_line":"When the guidelines are followed from the following link:"},{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment.html"},{"line_number":12,"context_line":"the test script displays the following error:"},{"line_number":13,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 (using password: YES)."},{"line_number":14,"context_line":"The fix for this is to include the saved password in order to access the"},{"line_number":15,"context_line":"MySQL database."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_b1cfb754","line":13,"in_reply_to":"7faddb67_32b8d774","updated":"2019-07-12 14:13:48.000000000","message":"Done","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e1492ba6463fee7936d65a9e6664a4356cb92d2a","unresolved":false,"context_lines":[{"line_number":13,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 (using password: YES)."},{"line_number":14,"context_line":"The fix for this is to include the saved password in order to access the"},{"line_number":15,"context_line":"MySQL database."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I6ab5cb3ef1583258cebec9f8f5966eda250a6367"},{"line_number":18,"context_line":"Signed-off-by: Sara Nierodzik \u003csara.nierodzik@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_1284bbb0","line":16,"updated":"2019-07-10 09:40:40.000000000","message":"We need the bug link:\nCloses-Bug: #1836028","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"67c5e2f2490b8c619ceceb76083f2fba4f989952","unresolved":false,"context_lines":[{"line_number":13,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 (using password: YES)."},{"line_number":14,"context_line":"The fix for this is to include the saved password in order to access the"},{"line_number":15,"context_line":"MySQL database."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I6ab5cb3ef1583258cebec9f8f5966eda250a6367"},{"line_number":18,"context_line":"Signed-off-by: Sara Nierodzik \u003csara.nierodzik@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_51d8c31c","line":16,"in_reply_to":"7faddb67_1284bbb0","updated":"2019-07-12 14:13:48.000000000","message":"Added it in.","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e1492ba6463fee7936d65a9e6664a4356cb92d2a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"MySQL database."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I6ab5cb3ef1583258cebec9f8f5966eda250a6367"},{"line_number":18,"context_line":"Signed-off-by: Sara Nierodzik \u003csara.nierodzik@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_52a2334d","line":18,"updated":"2019-07-10 09:40:40.000000000","message":"nit: in OpenStack, we don\u0027t use this tag signed-off-by","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"67c5e2f2490b8c619ceceb76083f2fba4f989952","unresolved":false,"context_lines":[{"line_number":15,"context_line":"MySQL database."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I6ab5cb3ef1583258cebec9f8f5966eda250a6367"},{"line_number":18,"context_line":"Signed-off-by: Sara Nierodzik \u003csara.nierodzik@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_11080b90","line":18,"in_reply_to":"7faddb67_52a2334d","updated":"2019-07-12 14:13:48.000000000","message":"Sorry I didn\u0027t realize - makes sense since you can see the commit author and the commiter.","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"548b95aef00724920b66fbabfcb03b2647989ac6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch includes a fix for \"configure_for_func_testing.sh\" script."},{"line_number":10,"context_line":"When the guidelines are followed from the following link:"},{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment"},{"line_number":12,"context_line":".html"},{"line_number":13,"context_line":"the test script displays the following error:"},{"line_number":14,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 "},{"line_number":15,"context_line":"(using password: YES)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_84fd94b2","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":5},"updated":"2019-07-12 17:02:15.000000000","message":"I\u0027d use the current documentation link:\nhttps://docs.openstack.org/neutron/latest/contributor/testing/testing.html","commit_id":"77b25fbe79e2b609277ce4a547ee34e73556bd12"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"efdb23626f5e339d78050d951085e5bd54d85732","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch includes a fix for \"configure_for_func_testing.sh\" script."},{"line_number":10,"context_line":"When the guidelines are followed from the following link:"},{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment"},{"line_number":12,"context_line":".html"},{"line_number":13,"context_line":"the test script displays the following error:"},{"line_number":14,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 "},{"line_number":15,"context_line":"(using password: YES)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_0f40c9a4","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":5},"in_reply_to":"7faddb67_55065d1f","updated":"2019-07-15 15:45:09.000000000","message":"Done","commit_id":"77b25fbe79e2b609277ce4a547ee34e73556bd12"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d8ea82e87dc6d2b24bdf88eddf6b9a19971becaa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch includes a fix for \"configure_for_func_testing.sh\" script."},{"line_number":10,"context_line":"When the guidelines are followed from the following link:"},{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment"},{"line_number":12,"context_line":".html"},{"line_number":13,"context_line":"the test script displays the following error:"},{"line_number":14,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 "},{"line_number":15,"context_line":"(using password: YES)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_55065d1f","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":5},"in_reply_to":"7faddb67_84fd94b2","updated":"2019-07-15 04:56:11.000000000","message":"+1","commit_id":"77b25fbe79e2b609277ce4a547ee34e73556bd12"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"efdb23626f5e339d78050d951085e5bd54d85732","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch includes a fix for \"configure_for_func_testing.sh\" script."},{"line_number":10,"context_line":"When the guidelines are followed from the following link:"},{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment"},{"line_number":12,"context_line":".html"},{"line_number":13,"context_line":"the test script displays the following error:"},{"line_number":14,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 "},{"line_number":15,"context_line":"(using password: YES)."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_4f324160","line":12,"range":{"start_line":11,"start_character":0,"end_line":12,"end_character":5},"in_reply_to":"7faddb67_84fd94b2","updated":"2019-07-15 15:45:09.000000000","message":"Done","commit_id":"77b25fbe79e2b609277ce4a547ee34e73556bd12"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d8ea82e87dc6d2b24bdf88eddf6b9a19971becaa","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment"},{"line_number":12,"context_line":".html"},{"line_number":13,"context_line":"the test script displays the following error:"},{"line_number":14,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 "},{"line_number":15,"context_line":"(using password: YES)."},{"line_number":16,"context_line":"The fix for this is to include the saved password in order to access the"},{"line_number":17,"context_line":"MySQL database."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_f506691c","line":14,"range":{"start_line":14,"start_character":61,"end_line":14,"end_character":62},"updated":"2019-07-15 04:56:11.000000000","message":"nit: extra whitespace","commit_id":"77b25fbe79e2b609277ce4a547ee34e73556bd12"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"efdb23626f5e339d78050d951085e5bd54d85732","unresolved":false,"context_lines":[{"line_number":11,"context_line":"https://docs.openstack.org/neutron/ocata/devref/development.environment"},{"line_number":12,"context_line":".html"},{"line_number":13,"context_line":"the test script displays the following error:"},{"line_number":14,"context_line":"ERROR 1045 (28000): Access denied for user \u0027root\u0027@\u0027localhost\u0027 "},{"line_number":15,"context_line":"(using password: YES)."},{"line_number":16,"context_line":"The fix for this is to include the saved password in order to access the"},{"line_number":17,"context_line":"MySQL database."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_ef420dab","line":14,"range":{"start_line":14,"start_character":61,"end_line":14,"end_character":62},"in_reply_to":"7faddb67_f506691c","updated":"2019-07-15 15:45:09.000000000","message":"Done","commit_id":"77b25fbe79e2b609277ce4a547ee34e73556bd12"}],"tools/configure_for_func_testing.sh":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e1492ba6463fee7936d65a9e6664a4356cb92d2a","unresolved":false,"context_lines":[{"line_number":164,"context_line":"GRANT ALL PRIVILEGES ON *.* TO \u0027openstack_citest\u0027;"},{"line_number":165,"context_line":"FLUSH PRIVILEGES;"},{"line_number":166,"context_line":"EOF"},{"line_number":167,"context_line":"    /usr/bin/mysql -u root -p${MYSQL_PASSWORD:-stackdb} \u003c $tmp_dir/mysql.sql"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [[ \"$install_pg\" \u003d\u003d \"True\" ]]; then"},{"line_number":170,"context_line":"        cat \u003c\u003c EOF \u003e $tmp_dir/postgresql.sql"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7faddb67_329f7704","line":167,"range":{"start_line":167,"start_character":27,"end_line":167,"end_character":55},"updated":"2019-07-10 09:40:40.000000000","message":"The variable value has been written in L138, you don\u0027t need to define a default value. This could be:\n  -p $MYSQL_PASSWORD","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"67c5e2f2490b8c619ceceb76083f2fba4f989952","unresolved":false,"context_lines":[{"line_number":164,"context_line":"GRANT ALL PRIVILEGES ON *.* TO \u0027openstack_citest\u0027;"},{"line_number":165,"context_line":"FLUSH PRIVILEGES;"},{"line_number":166,"context_line":"EOF"},{"line_number":167,"context_line":"    /usr/bin/mysql -u root -p${MYSQL_PASSWORD:-stackdb} \u003c $tmp_dir/mysql.sql"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [[ \"$install_pg\" \u003d\u003d \"True\" ]]; then"},{"line_number":170,"context_line":"        cat \u003c\u003c EOF \u003e $tmp_dir/postgresql.sql"}],"source_content_type":"text/x-sh","patch_set":1,"id":"7faddb67_f15e8f74","line":167,"range":{"start_line":167,"start_character":27,"end_line":167,"end_character":55},"in_reply_to":"7faddb67_329f7704","updated":"2019-07-12 14:13:48.000000000","message":"Changed it to the variable instead. (The no empty space between the -p and the $ is needed to prevent the script from prompting the user to type in a password.)","commit_id":"1956be1b1fd094dfee2031f2267a024554b7128c"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"548b95aef00724920b66fbabfcb03b2647989ac6","unresolved":false,"context_lines":[{"line_number":164,"context_line":"GRANT ALL PRIVILEGES ON *.* TO \u0027openstack_citest\u0027;"},{"line_number":165,"context_line":"FLUSH PRIVILEGES;"},{"line_number":166,"context_line":"EOF"},{"line_number":167,"context_line":"    /usr/bin/mysql -u root -p$MYSQL_PASSWORD \u003c $tmp_dir/mysql.sql"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [[ \"$install_pg\" \u003d\u003d \"True\" ]]; then"},{"line_number":170,"context_line":"        cat \u003c\u003c EOF \u003e $tmp_dir/postgresql.sql"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_44da3c4c","line":167,"range":{"start_line":167,"start_character":29,"end_line":167,"end_character":44},"updated":"2019-07-12 17:02:15.000000000","message":"This should be quoted, for the few original people that will override the default value and use special characters (like space) in it","commit_id":"77b25fbe79e2b609277ce4a547ee34e73556bd12"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"efdb23626f5e339d78050d951085e5bd54d85732","unresolved":false,"context_lines":[{"line_number":164,"context_line":"GRANT ALL PRIVILEGES ON *.* TO \u0027openstack_citest\u0027;"},{"line_number":165,"context_line":"FLUSH PRIVILEGES;"},{"line_number":166,"context_line":"EOF"},{"line_number":167,"context_line":"    /usr/bin/mysql -u root -p$MYSQL_PASSWORD \u003c $tmp_dir/mysql.sql"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [[ \"$install_pg\" \u003d\u003d \"True\" ]]; then"},{"line_number":170,"context_line":"        cat \u003c\u003c EOF \u003e $tmp_dir/postgresql.sql"}],"source_content_type":"text/x-sh","patch_set":2,"id":"7faddb67_8f7a79ee","line":167,"range":{"start_line":167,"start_character":29,"end_line":167,"end_character":44},"in_reply_to":"7faddb67_44da3c4c","updated":"2019-07-15 15:45:09.000000000","message":"Hopefully that\u0027s fixed now.","commit_id":"77b25fbe79e2b609277ce4a547ee34e73556bd12"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3eccb3a00ede0c22b4a7359a7cd063b6b6336f44","unresolved":false,"context_lines":[{"line_number":164,"context_line":"GRANT ALL PRIVILEGES ON *.* TO \u0027openstack_citest\u0027;"},{"line_number":165,"context_line":"FLUSH PRIVILEGES;"},{"line_number":166,"context_line":"EOF"},{"line_number":167,"context_line":"    /usr/bin/mysql -u root -p\"$MYSQL_PASSWORD\" \u003c $tmp_dir/mysql.sql"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [[ \"$install_pg\" \u003d\u003d \"True\" ]]; then"},{"line_number":170,"context_line":"        cat \u003c\u003c EOF \u003e $tmp_dir/postgresql.sql"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_71cfd855","line":167,"updated":"2019-07-16 08:43:01.000000000","message":"what if there is no MYSQL_PASSWORD defined? It will then end up with something like\n\n    /usr/bin/mysql -u root -p\"\" \u003c $tmp_dir/mysql.sql\n\nwhich will not work properly if access is available without password.","commit_id":"adb6c1be32e2d01dbb919191275c6277f0905300"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5bad98c707da58ae6c85f96d3bb9d8866e41c778","unresolved":false,"context_lines":[{"line_number":164,"context_line":"GRANT ALL PRIVILEGES ON *.* TO \u0027openstack_citest\u0027;"},{"line_number":165,"context_line":"FLUSH PRIVILEGES;"},{"line_number":166,"context_line":"EOF"},{"line_number":167,"context_line":"    /usr/bin/mysql -u root -p\"$MYSQL_PASSWORD\" \u003c $tmp_dir/mysql.sql"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [[ \"$install_pg\" \u003d\u003d \"True\" ]]; then"},{"line_number":170,"context_line":"        cat \u003c\u003c EOF \u003e $tmp_dir/postgresql.sql"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_bc1be77e","line":167,"in_reply_to":"7faddb67_3ca4d7a5","updated":"2019-07-16 10:14:51.000000000","message":"ok, it looks that indeed L138 prevents to have empty string here so it should be ok","commit_id":"adb6c1be32e2d01dbb919191275c6277f0905300"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"fda2db1047402da9eb28338724985f582395a0a0","unresolved":false,"context_lines":[{"line_number":164,"context_line":"GRANT ALL PRIVILEGES ON *.* TO \u0027openstack_citest\u0027;"},{"line_number":165,"context_line":"FLUSH PRIVILEGES;"},{"line_number":166,"context_line":"EOF"},{"line_number":167,"context_line":"    /usr/bin/mysql -u root -p\"$MYSQL_PASSWORD\" \u003c $tmp_dir/mysql.sql"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [[ \"$install_pg\" \u003d\u003d \"True\" ]]; then"},{"line_number":170,"context_line":"        cat \u003c\u003c EOF \u003e $tmp_dir/postgresql.sql"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_fc8e3f77","line":167,"in_reply_to":"7faddb67_71cfd855","updated":"2019-07-16 09:20:33.000000000","message":"From my understanding the bug might be due to the MYSQL version 5.7. (but I may be wrong) In that version a random root password is generated as opposed to having no password like in the previous versions. \nThe MYSQL_PASSWORD is defined in this script on line 138 which overwrites the randomly generated one.\n\nTo answer your question - the \"access being available without password\" issue wouldn\u0027t occur in the version I\u0027m using (5.7) but I\u0027m not sure about the other ones.\n\nThis is the article I found when researching the issue: https://medium.com/@benmorel/remove-the-mysql-root-password-ba3fcbe29870","commit_id":"adb6c1be32e2d01dbb919191275c6277f0905300"},{"author":{"_account_id":29554,"name":"Sara Nierodzik","email":"sara.nierodzik@intel.com","username":"snierodz"},"change_message_id":"cabf20a225fedd1ff28f7afc29dbc779f3bc829f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"GRANT ALL PRIVILEGES ON *.* TO \u0027openstack_citest\u0027;"},{"line_number":165,"context_line":"FLUSH PRIVILEGES;"},{"line_number":166,"context_line":"EOF"},{"line_number":167,"context_line":"    /usr/bin/mysql -u root -p\"$MYSQL_PASSWORD\" \u003c $tmp_dir/mysql.sql"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    if [[ \"$install_pg\" \u003d\u003d \"True\" ]]; then"},{"line_number":170,"context_line":"        cat \u003c\u003c EOF \u003e $tmp_dir/postgresql.sql"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7faddb67_3ca4d7a5","line":167,"in_reply_to":"7faddb67_fc8e3f77","updated":"2019-07-16 09:41:23.000000000","message":"*(The specific MYSQL version on my environment is version 5.7.26)","commit_id":"adb6c1be32e2d01dbb919191275c6277f0905300"}]}