)]}'
{"neutron/db/l3_dvr_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a42d05071f57d987db1c8c4a843df3e8582d26a","unresolved":true,"context_lines":[{"line_number":418,"context_line":"    @registry.receives(resources.NETWORK, [events.AFTER_DELETE])"},{"line_number":419,"context_line":"    def delete_fip_namespaces_for_ext_net(self, rtype, event, trigger,"},{"line_number":420,"context_line":"                                          payload\u003dNone):"},{"line_number":421,"context_line":"        if payload.states[0].get(extnet_apidef.EXTERNAL):"},{"line_number":422,"context_line":"            # Send the information to all the L3 Agent hosts"},{"line_number":423,"context_line":"            # to clean up the fip namespace as it is no longer required."},{"line_number":424,"context_line":"            self.l3plugin.l3_rpc_notifier.delete_fipnamespace_for_ext_net("}],"source_content_type":"text/x-python","patch_set":7,"id":"519cb4dc_39153e13","line":421,"range":{"start_line":421,"start_character":8,"end_line":421,"end_character":56},"updated":"2021-05-04 09:20:18.000000000","message":"nit: may add \u0027network \u003d payload.states[0]\u0027 above for readability","commit_id":"e707321330e16dfe2f6bd107f8325a361d3b1d44"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"7d9292020f140bd8d613da18bd79f9a64566d738","unresolved":true,"context_lines":[{"line_number":418,"context_line":"    @registry.receives(resources.NETWORK, [events.AFTER_DELETE])"},{"line_number":419,"context_line":"    def delete_fip_namespaces_for_ext_net(self, rtype, event, trigger,"},{"line_number":420,"context_line":"                                          payload\u003dNone):"},{"line_number":421,"context_line":"        if payload.states[0].get(extnet_apidef.EXTERNAL):"},{"line_number":422,"context_line":"            # Send the information to all the L3 Agent hosts"},{"line_number":423,"context_line":"            # to clean up the fip namespace as it is no longer required."},{"line_number":424,"context_line":"            self.l3plugin.l3_rpc_notifier.delete_fipnamespace_for_ext_net("}],"source_content_type":"text/x-python","patch_set":7,"id":"592add60_4d1f4dcc","line":421,"range":{"start_line":421,"start_character":8,"end_line":421,"end_character":56},"in_reply_to":"519cb4dc_39153e13","updated":"2021-05-04 12:12:23.000000000","message":"Done.","commit_id":"e707321330e16dfe2f6bd107f8325a361d3b1d44"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8ba667dce580b658021fa3779777b2cf1a280315","unresolved":true,"context_lines":[{"line_number":418,"context_line":"    @registry.receives(resources.NETWORK, [events.AFTER_DELETE])"},{"line_number":419,"context_line":"    def delete_fip_namespaces_for_ext_net(self, rtype, event, trigger,"},{"line_number":420,"context_line":"                                          payload\u003dNone):"},{"line_number":421,"context_line":"        network \u003d payload.states[0]"},{"line_number":422,"context_line":"        if network.get(extnet_apidef.EXTERNAL):"},{"line_number":423,"context_line":"            # Send the information to all the L3 Agent hosts"},{"line_number":424,"context_line":"            # to clean up the fip namespace as it is no longer required."}],"source_content_type":"text/x-python","patch_set":11,"id":"e8709804_92b49ac2","line":421,"range":{"start_line":421,"start_character":26,"end_line":421,"end_character":35},"updated":"2021-05-06 13:36:40.000000000","message":"payload.latest_state looks nicer","commit_id":"558690f0fa155ab0b2eaa1cfb3615d77a8cf607a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"87b2acbb9d1eaaa1f2c8aa6fcfc68d2acd28c883","unresolved":true,"context_lines":[{"line_number":418,"context_line":"    @registry.receives(resources.NETWORK, [events.AFTER_DELETE])"},{"line_number":419,"context_line":"    def delete_fip_namespaces_for_ext_net(self, rtype, event, trigger,"},{"line_number":420,"context_line":"                                          payload\u003dNone):"},{"line_number":421,"context_line":"        network \u003d payload.states[0]"},{"line_number":422,"context_line":"        if network.get(extnet_apidef.EXTERNAL):"},{"line_number":423,"context_line":"            # Send the information to all the L3 Agent hosts"},{"line_number":424,"context_line":"            # to clean up the fip namespace as it is no longer required."}],"source_content_type":"text/x-python","patch_set":11,"id":"38271c9c_fc56e3ea","line":421,"range":{"start_line":421,"start_character":26,"end_line":421,"end_character":35},"in_reply_to":"e8709804_92b49ac2","updated":"2021-05-06 14:06:47.000000000","message":"Done.","commit_id":"558690f0fa155ab0b2eaa1cfb3615d77a8cf607a"}],"neutron/db/securitygroups_db.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2a42d05071f57d987db1c8c4a843df3e8582d26a","unresolved":true,"context_lines":[{"line_number":904,"context_line":"            self, resource, event, trigger, payload\u003dNone):"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        # TODO(boden): refactor into single callback method"},{"line_number":907,"context_line":"        tenant_id \u003d payload.latest_state[\u0027tenant_id\u0027]"},{"line_number":908,"context_line":"        if tenant_id:"},{"line_number":909,"context_line":"            self._ensure_default_security_group(payload.context, tenant_id)"},{"line_number":910,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"79dd39f5_27dee373","line":907,"range":{"start_line":907,"start_character":8,"end_line":907,"end_character":53},"updated":"2021-05-04 09:20:18.000000000","message":"please change to project_id","commit_id":"e707321330e16dfe2f6bd107f8325a361d3b1d44"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"7d9292020f140bd8d613da18bd79f9a64566d738","unresolved":true,"context_lines":[{"line_number":904,"context_line":"            self, resource, event, trigger, payload\u003dNone):"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        # TODO(boden): refactor into single callback method"},{"line_number":907,"context_line":"        tenant_id \u003d payload.latest_state[\u0027tenant_id\u0027]"},{"line_number":908,"context_line":"        if tenant_id:"},{"line_number":909,"context_line":"            self._ensure_default_security_group(payload.context, tenant_id)"},{"line_number":910,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"cd50568f_3cebe5d7","line":907,"range":{"start_line":907,"start_character":8,"end_line":907,"end_character":53},"in_reply_to":"79dd39f5_27dee373","updated":"2021-05-04 12:12:23.000000000","message":"Done.","commit_id":"e707321330e16dfe2f6bd107f8325a361d3b1d44"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8ba667dce580b658021fa3779777b2cf1a280315","unresolved":true,"context_lines":[{"line_number":904,"context_line":"            self, resource, event, trigger, payload\u003dNone):"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        # TODO(boden): refactor into single callback method"},{"line_number":907,"context_line":"        project_id \u003d payload.latest_state[\u0027tenant_id\u0027]"},{"line_number":908,"context_line":"        if project_id:"},{"line_number":909,"context_line":"            self._ensure_default_security_group(payload.context, project_id)"},{"line_number":910,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"524dc276_a21b5ea4","line":907,"range":{"start_line":907,"start_character":43,"end_line":907,"end_character":52},"updated":"2021-05-06 13:36:40.000000000","message":"project_id","commit_id":"558690f0fa155ab0b2eaa1cfb3615d77a8cf607a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"87b2acbb9d1eaaa1f2c8aa6fcfc68d2acd28c883","unresolved":true,"context_lines":[{"line_number":904,"context_line":"            self, resource, event, trigger, payload\u003dNone):"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        # TODO(boden): refactor into single callback method"},{"line_number":907,"context_line":"        project_id \u003d payload.latest_state[\u0027tenant_id\u0027]"},{"line_number":908,"context_line":"        if project_id:"},{"line_number":909,"context_line":"            self._ensure_default_security_group(payload.context, project_id)"},{"line_number":910,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"791d8620_dce8379c","line":907,"range":{"start_line":907,"start_character":43,"end_line":907,"end_character":52},"in_reply_to":"524dc276_a21b5ea4","updated":"2021-05-06 14:06:47.000000000","message":"Done.","commit_id":"558690f0fa155ab0b2eaa1cfb3615d77a8cf607a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"858c465ecf5e6687c5e50fd36deebd760d6a18d9","unresolved":true,"context_lines":[{"line_number":904,"context_line":"            self, resource, event, trigger, payload\u003dNone):"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        # TODO(boden): refactor into single callback method"},{"line_number":907,"context_line":"        project_id \u003d payload.latest_state[\u0027tenant_id\u0027]"},{"line_number":908,"context_line":"        if project_id:"},{"line_number":909,"context_line":"            self._ensure_default_security_group(payload.context, project_id)"},{"line_number":910,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"dad5e488_88d4450a","line":907,"range":{"start_line":907,"start_character":43,"end_line":907,"end_character":52},"updated":"2021-05-12 07:40:54.000000000","message":"nit: it\u0027s still tenant_id, see:\nhttps://review.opendev.org/c/openstack/neutron/+/670611/11/neutron/db/securitygroups_db.py#907","commit_id":"4aa5de254d077246e86e6a633bfc4ddfebfa6673"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a066279ba439ede11bfa79ef9b06e4de3d523713","unresolved":false,"context_lines":[{"line_number":904,"context_line":"            self, resource, event, trigger, payload\u003dNone):"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        # TODO(boden): refactor into single callback method"},{"line_number":907,"context_line":"        project_id \u003d payload.latest_state[\u0027tenant_id\u0027]"},{"line_number":908,"context_line":"        if project_id:"},{"line_number":909,"context_line":"            self._ensure_default_security_group(payload.context, project_id)"},{"line_number":910,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"c94e0af1_5b297d00","line":907,"range":{"start_line":907,"start_character":43,"end_line":907,"end_character":52},"in_reply_to":"49fecd71_6c961f25","updated":"2021-05-14 11:43:35.000000000","message":"Ack","commit_id":"4aa5de254d077246e86e6a633bfc4ddfebfa6673"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"66f0983eed2ade39073551bd99b45f85c9b277cb","unresolved":true,"context_lines":[{"line_number":904,"context_line":"            self, resource, event, trigger, payload\u003dNone):"},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        # TODO(boden): refactor into single callback method"},{"line_number":907,"context_line":"        project_id \u003d payload.latest_state[\u0027tenant_id\u0027]"},{"line_number":908,"context_line":"        if project_id:"},{"line_number":909,"context_line":"            self._ensure_default_security_group(payload.context, project_id)"},{"line_number":910,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"49fecd71_6c961f25","line":907,"range":{"start_line":907,"start_character":43,"end_line":907,"end_character":52},"in_reply_to":"dad5e488_88d4450a","updated":"2021-05-13 16:29:02.000000000","message":"On patchset 12 I have changed to \u0027project_id\u0027 but there failed a lot of tests, because tests use \u0027tenant_id\u0027 in test data.","commit_id":"4aa5de254d077246e86e6a633bfc4ddfebfa6673"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8ba667dce580b658021fa3779777b2cf1a280315","unresolved":true,"context_lines":[{"line_number":1239,"context_line":"        context \u003d payload.context"},{"line_number":1240,"context_line":"        network_id \u003d payload.resource_id"},{"line_number":1241,"context_line":"        if payload.states:"},{"line_number":1242,"context_line":"            network \u003d payload.states[0]"},{"line_number":1243,"context_line":"        else:"},{"line_number":1244,"context_line":"            network \u003d self.get_network(context, network_id)"},{"line_number":1245,"context_line":"        mech_context \u003d driver_context.NetworkContext(self,"}],"source_content_type":"text/x-python","patch_set":11,"id":"6939c909_ae43ce62","line":1242,"range":{"start_line":1242,"start_character":30,"end_line":1242,"end_character":39},"updated":"2021-05-06 13:36:40.000000000","message":"consider: \n\n network \u003d payload.latest_state if payload.states else \n           self.get_network(context, network_id)","commit_id":"558690f0fa155ab0b2eaa1cfb3615d77a8cf607a"},{"author":{"_account_id":32667,"name":"Mamatisa Nurmatov","email":"nurmatov.mamatisa@huawei.com","username":"isabek"},"change_message_id":"87b2acbb9d1eaaa1f2c8aa6fcfc68d2acd28c883","unresolved":true,"context_lines":[{"line_number":1239,"context_line":"        context \u003d payload.context"},{"line_number":1240,"context_line":"        network_id \u003d payload.resource_id"},{"line_number":1241,"context_line":"        if payload.states:"},{"line_number":1242,"context_line":"            network \u003d payload.states[0]"},{"line_number":1243,"context_line":"        else:"},{"line_number":1244,"context_line":"            network \u003d self.get_network(context, network_id)"},{"line_number":1245,"context_line":"        mech_context \u003d driver_context.NetworkContext(self,"}],"source_content_type":"text/x-python","patch_set":11,"id":"abd2e8dd_9bcd427b","line":1242,"range":{"start_line":1242,"start_character":30,"end_line":1242,"end_character":39},"in_reply_to":"6939c909_ae43ce62","updated":"2021-05-06 14:06:47.000000000","message":"Done.","commit_id":"558690f0fa155ab0b2eaa1cfb3615d77a8cf607a"}]}