)]}'
{"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"8802b832485c2d48003bcce8541ec091d585ef4e","unresolved":false,"context_lines":[{"line_number":780,"context_line":"        return cctxt.call(self.context, \u0027dhcp_ready_on_ports\u0027,"},{"line_number":781,"context_line":"                          port_ids\u003dport_ids)"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    def get_networks(self, **kwargs):"},{"line_number":784,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.7\u0027)"},{"line_number":785,"context_line":"        nets \u003d cctxt.call(self.context, \u0027get_networks\u0027, **kwargs)"},{"line_number":786,"context_line":"        return [dhcp.NetModel(net) for net in nets]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_021ad06d","line":783,"updated":"2019-07-16 11:19:05.000000000","message":"add a note that explains who currently uses it (networking-mlnx interface drivers)","commit_id":"d22d24a2801eba6bfcd4e05ca43272832ee2a40e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"28a83b6eb2c58c7ab2dccb297c140098401d498b","unresolved":false,"context_lines":[{"line_number":782,"context_line":"        return cctxt.call(self.context, \u0027dhcp_ready_on_ports\u0027,"},{"line_number":783,"context_line":"                          port_ids\u003dport_ids)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"    def get_networks(self, filters\u003dNone, fields\u003dNone,"},{"line_number":786,"context_line":"                     sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":787,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":788,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.7\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_7592124e","line":785,"updated":"2019-07-22 08:13:52.000000000","message":"am I understanding correct that this will always get list of all networks? Shouldn\u0027t You maybe limit it somehow?","commit_id":"3889cddf0521a98ff1a64efcd7cae6e286a2560a"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"6d7bd31aac66377fdd27cd336d74347ac3a57d41","unresolved":false,"context_lines":[{"line_number":782,"context_line":"        return cctxt.call(self.context, \u0027dhcp_ready_on_ports\u0027,"},{"line_number":783,"context_line":"                          port_ids\u003dport_ids)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"    def get_networks(self, filters\u003dNone, fields\u003dNone,"},{"line_number":786,"context_line":"                     sorts\u003dNone, limit\u003dNone, marker\u003dNone,"},{"line_number":787,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":788,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.7\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_fb459316","line":785,"in_reply_to":"7faddb67_7592124e","updated":"2019-07-22 10:19:18.000000000","message":"depends on how you call it.\n\nfilter can be used to limit the request to a certain network/s.\n\nand fields can be used to limit the response to the attributes we want.\n\nthe ability to fetch all networks is something desirable IMO as its possible to implement a caching mechanism where the first call will get all networks and subsequent calls will only get a single network in case there was a \"miss\"\n\nI can make filters,fields to be non-optional that way it will force the caller to specify them.","commit_id":"3889cddf0521a98ff1a64efcd7cae6e286a2560a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"28a83b6eb2c58c7ab2dccb297c140098401d498b","unresolved":false,"context_lines":[{"line_number":787,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":788,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.7\u0027)"},{"line_number":789,"context_line":"        nets \u003d cctxt.call(self.context, \u0027get_networks\u0027, filters\u003dfilters,"},{"line_number":790,"context_line":"                          fields\u003dfields, sorts\u003dsorts, limit\u003dlimit,"},{"line_number":791,"context_line":"                          marker\u003dmarker, page_reverse\u003dpage_reverse)"},{"line_number":792,"context_line":"        return [dhcp.NetModel(net) for net in nets]"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_b572ca48","line":791,"range":{"start_line":790,"start_character":26,"end_line":791,"end_character":66},"updated":"2019-07-22 08:13:52.000000000","message":"do we need to pass through rpc all those parameters? I think those are more REST API parameters.","commit_id":"3889cddf0521a98ff1a64efcd7cae6e286a2560a"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"6d7bd31aac66377fdd27cd336d74347ac3a57d41","unresolved":false,"context_lines":[{"line_number":787,"context_line":"                     page_reverse\u003dFalse):"},{"line_number":788,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.7\u0027)"},{"line_number":789,"context_line":"        nets \u003d cctxt.call(self.context, \u0027get_networks\u0027, filters\u003dfilters,"},{"line_number":790,"context_line":"                          fields\u003dfields, sorts\u003dsorts, limit\u003dlimit,"},{"line_number":791,"context_line":"                          marker\u003dmarker, page_reverse\u003dpage_reverse)"},{"line_number":792,"context_line":"        return [dhcp.NetModel(net) for net in nets]"},{"line_number":793,"context_line":""},{"line_number":794,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_bbeb9bda","line":791,"range":{"start_line":790,"start_character":26,"end_line":791,"end_character":66},"in_reply_to":"7faddb67_b572ca48","updated":"2019-07-22 10:19:18.000000000","message":"indeed, i think we should only care about filters and fields.\n\nInitially i just exposed the same API as neutron.neutron_plugin_base_v2.NeutronPluginBaseV2.get_networks()","commit_id":"3889cddf0521a98ff1a64efcd7cae6e286a2560a"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"8802b832485c2d48003bcce8541ec091d585ef4e","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.11\u0027)"},{"line_number":194,"context_line":"        return cctxt.call(context, \u0027get_host_ha_router_count\u0027, host\u003dself.host)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def get_networks(self, context, **kwargs):"},{"line_number":197,"context_line":"        \"\"\"Get networks.\"\"\""},{"line_number":198,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.12\u0027)"},{"line_number":199,"context_line":"        return cctxt.call(context, \u0027get_networks\u0027, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_c229188a","line":196,"updated":"2019-07-16 11:19:05.000000000","message":"add a note that explains who currently uses it (networking-mlnx interface drivers)","commit_id":"d22d24a2801eba6bfcd4e05ca43272832ee2a40e"}]}