)]}'
{"neutron/objects/network_segment_range.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"85bbe653b9f614ded46562b1cea1755c7c867911","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return db_utils.resource_fields(_dict, fields)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _check_shared_project_id(self, action):"},{"line_number":82,"context_line":"        if self.shared is False and not self.project_id:"},{"line_number":83,"context_line":"            raise n_exc.ObjectActionError("},{"line_number":84,"context_line":"                action\u003daction,"},{"line_number":85,"context_line":"                reason\u003d\u0027if NetworkSegmentRange is not shared, it must have a \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_2dcf6e2a","line":82,"range":{"start_line":82,"start_character":8,"end_line":82,"end_character":56},"updated":"2019-07-22 12:08:34.000000000","message":"nit: if not self.shared and not self.project_id:....\nJust if you plan to upload a new patch","commit_id":"7875400f9507ff89c38133b9c37c4471a595afe6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1dfb646420b011282553fb30c1c0dd32efef9d83","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return db_utils.resource_fields(_dict, fields)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _check_shared_project_id(self, action):"},{"line_number":82,"context_line":"        if self.shared is False and not self.project_id:"},{"line_number":83,"context_line":"            raise n_exc.ObjectActionError("},{"line_number":84,"context_line":"                action\u003daction,"},{"line_number":85,"context_line":"                reason\u003d\u0027if NetworkSegmentRange is not shared, it must have a \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_56ca92a0","line":82,"updated":"2019-07-19 13:44:22.000000000","message":"what in case if this is \"None\"?","commit_id":"7875400f9507ff89c38133b9c37c4471a595afe6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0e4185cf514a0f9456f8339d9a1c1022d1a903dc","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return db_utils.resource_fields(_dict, fields)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _check_shared_project_id(self, action):"},{"line_number":82,"context_line":"        if self.shared is False and not self.project_id:"},{"line_number":83,"context_line":"            raise n_exc.ObjectActionError("},{"line_number":84,"context_line":"                action\u003daction,"},{"line_number":85,"context_line":"                reason\u003d\u0027if NetworkSegmentRange is not shared, it must have a \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_bfd8791d","line":82,"in_reply_to":"7faddb67_56ca92a0","updated":"2019-07-19 16:19:24.000000000","message":"\"shared\" is an object field and the value is enforced by the definition:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/objects/network_segment_range.py#L57\n\nIt\u0027s a boolean and is not nullable.","commit_id":"7875400f9507ff89c38133b9c37c4471a595afe6"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ac167804c2737c7af358a1dcae55489138eb4f59","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return db_utils.resource_fields(_dict, fields)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _check_shared_project_id(self, action):"},{"line_number":82,"context_line":"        if self.shared is False and not self.project_id:"},{"line_number":83,"context_line":"            raise n_exc.ObjectActionError("},{"line_number":84,"context_line":"                action\u003daction,"},{"line_number":85,"context_line":"                reason\u003d\u0027if NetworkSegmentRange is not shared, it must have a \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_06b05add","line":82,"in_reply_to":"7faddb67_bfd8791d","updated":"2019-07-21 10:11:32.000000000","message":"right, I don\u0027t know how I missed that :)","commit_id":"7875400f9507ff89c38133b9c37c4471a595afe6"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"85bbe653b9f614ded46562b1cea1755c7c867911","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _check_shared_project_id(self, action):"},{"line_number":82,"context_line":"        if self.shared is False and not self.project_id:"},{"line_number":83,"context_line":"            raise n_exc.ObjectActionError("},{"line_number":84,"context_line":"                action\u003daction,"},{"line_number":85,"context_line":"                reason\u003d\u0027if NetworkSegmentRange is not shared, it must have a \u0027"},{"line_number":86,"context_line":"                       \u0027project_id\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def create(self):"},{"line_number":89,"context_line":"        self._check_shared_project_id(\u0027create\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_cda6da54","line":86,"range":{"start_line":83,"start_character":12,"end_line":86,"end_character":36},"updated":"2019-07-22 12:08:34.000000000","message":"More a question: How will this solve the failing testcase problem, as the NetworkSegmentRange object creation/update will fail, or am I missing something?","commit_id":"7875400f9507ff89c38133b9c37c4471a595afe6"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"68248a7701e8520299e291aa6872a6f6d64f214e","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _check_shared_project_id(self, action):"},{"line_number":82,"context_line":"        if self.shared is False and not self.project_id:"},{"line_number":83,"context_line":"            raise n_exc.ObjectActionError("},{"line_number":84,"context_line":"                action\u003daction,"},{"line_number":85,"context_line":"                reason\u003d\u0027if NetworkSegmentRange is not shared, it must have a \u0027"},{"line_number":86,"context_line":"                       \u0027project_id\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def create(self):"},{"line_number":89,"context_line":"        self._check_shared_project_id(\u0027create\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_813509ab","line":86,"range":{"start_line":83,"start_character":12,"end_line":86,"end_character":36},"in_reply_to":"7faddb67_cda6da54","updated":"2019-07-22 14:52:22.000000000","message":"+1","commit_id":"7875400f9507ff89c38133b9c37c4471a595afe6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c9d5eade25ae9357f428eedffc63628000d4bb8d","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _check_shared_project_id(self, action):"},{"line_number":82,"context_line":"        if self.shared is False and not self.project_id:"},{"line_number":83,"context_line":"            raise n_exc.ObjectActionError("},{"line_number":84,"context_line":"                action\u003daction,"},{"line_number":85,"context_line":"                reason\u003d\u0027if NetworkSegmentRange is not shared, it must have a \u0027"},{"line_number":86,"context_line":"                       \u0027project_id\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def create(self):"},{"line_number":89,"context_line":"        self._check_shared_project_id(\u0027create\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_0328da83","line":86,"range":{"start_line":83,"start_character":12,"end_line":86,"end_character":36},"in_reply_to":"7faddb67_cda6da54","updated":"2019-07-29 13:11:03.000000000","message":"It is not, but this will give us information about this possible problem.","commit_id":"7875400f9507ff89c38133b9c37c4471a595afe6"}]}