)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8363d868d209feca42e7b88bd5cdf50d71ac69a4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Using noop driver to disable security group is confusing."},{"line_number":10,"context_line":"In this commit, we introduce enable_security_group in server side."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-bug: #1112912"},{"line_number":13,"context_line":"Change-Id: Ice44a4e2a519c64e613eeb24372de46726473339"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAUH%2F%2FIcE%3D","line":12,"updated":"2014-01-17 05:36:06.000000000","message":"I can\u0027t understand why this change is related to bug 1112912 (get_firewall_required).","commit_id":"2313e738c8c990087a6069ba273f75507d66a539"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"dc741efaa8f0b1aa937cecfde03dbda5c7bc8dac","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using noop driver to disable security group is confusing."},{"line_number":10,"context_line":"In this commit, we introduce enable_security_group in server side."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements bp: security-group-config-cleanup"},{"line_number":13,"context_line":"Change-Id: Ice44a4e2a519c64e613eeb24372de46726473339"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAU3%2F%2F%2FIg%3D","line":11,"updated":"2014-02-23 01:42:38.000000000","message":"Please add DocImpact to the commit message.","commit_id":"3635d41e5ed0456d259cb1fab65b435a646b8608"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cd224bd96dd3ce0166c78fa297841284049db54c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using noop driver to disable security group is confusing."},{"line_number":10,"context_line":"In this commit, we introduce enable_security_group in server side."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements bp: security-group-config-cleanup"},{"line_number":13,"context_line":"Change-Id: Ice44a4e2a519c64e613eeb24372de46726473339"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAU3%2F%2F49E%3D","line":11,"in_reply_to":"AAAAU3%2F%2F%2FIg%3D","updated":"2014-02-24 10:04:18.000000000","message":"UpgradeImpact is also needed? I am not sure if this flag works but I was suggested previously.","commit_id":"3635d41e5ed0456d259cb1fab65b435a646b8608"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"0e90033de7af15f3d69083131b5a86c87883b331","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using noop driver to disable security group is confusing."},{"line_number":10,"context_line":"In this commit, we introduce enable_security_group in server side."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements bp: security-group-config-cleanup"},{"line_number":13,"context_line":"Change-Id: Ice44a4e2a519c64e613eeb24372de46726473339"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAAU3%2F%2Fygw%3D","line":11,"in_reply_to":"AAAAU3%2F%2F49E%3D","updated":"2014-02-24 19:26:30.000000000","message":"I\u0027ll add both","commit_id":"3635d41e5ed0456d259cb1fab65b435a646b8608"}],"etc/neutron.conf":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8801f386f50bd791f83a6402f8cf7fa19612699f","unresolved":false,"context_lines":[{"line_number":181,"context_line":"# rpc_zmq_bind_address \u003d *"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# Security Group"},{"line_number":184,"context_line":"# If you wan\u0027t to use nova side security group implemenation,"},{"line_number":185,"context_line":"# you should disable neutron side by setting"},{"line_number":186,"context_line":"# enable_security_group to False"},{"line_number":187,"context_line":"# enable_security_group \u003d True"}],"source_content_type":"text/plain","patch_set":3,"id":"AAAAUH%2F%2FBw8%3D","line":184,"updated":"2014-01-18 14:02:23.000000000","message":"wan\u0027t -\u003e want","commit_id":"b0634fd2d8feb45bfed85ccfdb89361e068fc098"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5349d6cf9006964abdc9bfc87cde3db60dde787d","unresolved":false,"context_lines":[{"line_number":181,"context_line":"# rpc_zmq_bind_address \u003d *"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"# Security Group"},{"line_number":184,"context_line":"# If you wan\u0027t to use nova side security group implemenation,"},{"line_number":185,"context_line":"# you should disable neutron side by setting"},{"line_number":186,"context_line":"# enable_security_group to False"},{"line_number":187,"context_line":"# enable_security_group \u003d True"}],"source_content_type":"text/plain","patch_set":3,"id":"AAAAUH%2F%2BVfc%3D","line":184,"in_reply_to":"AAAAUH%2F%2FBw8%3D","updated":"2014-01-27 22:30:06.000000000","message":"Done","commit_id":"b0634fd2d8feb45bfed85ccfdb89361e068fc098"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8801f386f50bd791f83a6402f8cf7fa19612699f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"# Security Group"},{"line_number":184,"context_line":"# If you wan\u0027t to use nova side security group implemenation,"},{"line_number":185,"context_line":"# you should disable neutron side by setting"},{"line_number":186,"context_line":"# enable_security_group to False"},{"line_number":187,"context_line":"# enable_security_group \u003d True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Notification System Options \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/plain","patch_set":3,"id":"AAAAUH%2F%2FBw4%3D","line":186,"updated":"2014-01-18 14:02:23.000000000","message":"Is that the default (that it is using nova security group)?","commit_id":"b0634fd2d8feb45bfed85ccfdb89361e068fc098"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5349d6cf9006964abdc9bfc87cde3db60dde787d","unresolved":false,"context_lines":[{"line_number":183,"context_line":"# Security Group"},{"line_number":184,"context_line":"# If you wan\u0027t to use nova side security group implemenation,"},{"line_number":185,"context_line":"# you should disable neutron side by setting"},{"line_number":186,"context_line":"# enable_security_group to False"},{"line_number":187,"context_line":"# enable_security_group \u003d True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Notification System Options \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/plain","patch_set":3,"id":"AAAAUH%2F%2BVfY%3D","line":186,"in_reply_to":"AAAAUH%2F%2FBw4%3D","updated":"2014-01-27 22:30:06.000000000","message":"default is neutron security group is enabled","commit_id":"b0634fd2d8feb45bfed85ccfdb89361e068fc098"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"713f58a9f47fdf92005564548812b79147acbea8","unresolved":false,"context_lines":[{"line_number":185,"context_line":"# you should disable neutron side by setting"},{"line_number":186,"context_line":"# enable_security_group to False"},{"line_number":187,"context_line":"# enable_security_group \u003d True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Notification System Options \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"# Notifications can be sent when network/subnet/port are create, updated or deleted."}],"source_content_type":"text/plain","patch_set":4,"id":"AAAAUH%2F%2BS0U%3D","line":188,"updated":"2014-01-28 10:16:12.000000000","message":"I think this parameter should be moved in a [securitygroup] group, regarding the register_opts in the neutron/agent/securitygroups_rpc.py file","commit_id":"c645454c0141388c67a6e5fab8c62b2f1b121a9b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"1e7de33ee93b0d47015424b41a9ac07237dfdf53","unresolved":false,"context_lines":[{"line_number":185,"context_line":"# you should disable neutron side by setting"},{"line_number":186,"context_line":"# enable_security_group to False"},{"line_number":187,"context_line":"# enable_security_group \u003d True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d Notification System Options \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"# Notifications can be sent when network/subnet/port are create, updated or deleted."}],"source_content_type":"text/plain","patch_set":4,"id":"AAAAUH%2F%2BPbk%3D","line":188,"in_reply_to":"AAAAUH%2F%2BS0U%3D","updated":"2014-01-28 19:15:44.000000000","message":"you are right, I\u0027ll move","commit_id":"c645454c0141388c67a6e5fab8c62b2f1b121a9b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d273053863ee5da698289d24ec5cea749916b07e","unresolved":false,"context_lines":[{"line_number":396,"context_line":"#service_provider \u003d LOADBALANCER:Radware:neutron.services.loadbalancer.drivers.radware.driver.LoadBalancerDriver:default"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"[securitygroup]"},{"line_number":399,"context_line":"# Security Group"},{"line_number":400,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":401,"context_line":"# you should disable neutron side by setting"},{"line_number":402,"context_line":"# enable_security_group to False"}],"source_content_type":"text/plain","patch_set":5,"id":"AAAAUX%2F%2FXxE%3D","line":399,"updated":"2014-02-13 17:05:16.000000000","message":"This line looks unnecessary.","commit_id":"11424644e76bf9da0d0ca5ed333a2b5218627d44"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"00d69c486d500de1ed3389ec16f6e0edf950d63e","unresolved":false,"context_lines":[{"line_number":396,"context_line":"#service_provider \u003d LOADBALANCER:Radware:neutron.services.loadbalancer.drivers.radware.driver.LoadBalancerDriver:default"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"[securitygroup]"},{"line_number":399,"context_line":"# Security Group"},{"line_number":400,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":401,"context_line":"# you should disable neutron side by setting"},{"line_number":402,"context_line":"# enable_security_group to False"}],"source_content_type":"text/plain","patch_set":5,"id":"AAAAUX%2F%2BpzY%3D","line":399,"in_reply_to":"AAAAUX%2F%2FXxE%3D","updated":"2014-02-22 16:47:17.000000000","message":"Done","commit_id":"11424644e76bf9da0d0ca5ed333a2b5218627d44"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"3d62e31cd13d90b8a2f0cd5be6ccf681f09dedc0","unresolved":false,"context_lines":[{"line_number":422,"context_line":"[securitygroup]"},{"line_number":423,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":424,"context_line":"# you should disable neutron side by setting"},{"line_number":425,"context_line":"# enable_security_group to False"},{"line_number":426,"context_line":"# enable_security_group \u003d True"}],"source_content_type":"text/plain","patch_set":10,"id":"AAAAU3%2F%2Fl98%3D","line":425,"updated":"2014-02-25 18:58:35.000000000","message":"Nit: This reads a bit funny. Maybe put a blank line in between the comment around setting \"enable_security_group\" to false and the default example which is True?","commit_id":"328a8ebc10f6e186848c9ec23987ba62890048fe"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"e8edd5f0bec4974e9baf6baabade80d54f1404f5","unresolved":false,"context_lines":[{"line_number":422,"context_line":"[securitygroup]"},{"line_number":423,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":424,"context_line":"# you should disable neutron side by setting"},{"line_number":425,"context_line":"# enable_security_group to False"},{"line_number":426,"context_line":"# enable_security_group \u003d True"}],"source_content_type":"text/plain","patch_set":10,"id":"AAAAU3%2F%2FjdU%3D","line":425,"in_reply_to":"AAAAU3%2F%2Fl98%3D","updated":"2014-02-25 23:49:46.000000000","message":"sure","commit_id":"328a8ebc10f6e186848c9ec23987ba62890048fe"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b0caa3c2e40fad432ff4545df59ff0eea6a7c9b0","unresolved":false,"context_lines":[{"line_number":420,"context_line":"#service_provider\u003dLOADBALANCER:NetScaler:neutron.services.loadbalancer.drivers.netscaler.netscaler_driver.NetScalerPluginDriver"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"[securitygroup]"},{"line_number":423,"context_line":"# enable_security_group \u003d True"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":426,"context_line":"# uncomment this line."}],"source_content_type":"text/plain","patch_set":19,"id":"AAAAVn%2F%2F1JQ%3D","line":423,"updated":"2014-03-03 22:05:26.000000000","message":"This should only go in plugins config file\u0027s that would want something like this. Having it here assumes that this disables the security_group extension for all plugins which isn\u0027t true.","commit_id":"2b696088170b13c2aa70670af2a075666185cf74"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"2664eb68ba8244b8d14dfc12a943f715792f3488","unresolved":false,"context_lines":[{"line_number":420,"context_line":"#service_provider\u003dLOADBALANCER:NetScaler:neutron.services.loadbalancer.drivers.netscaler.netscaler_driver.NetScalerPluginDriver"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"[securitygroup]"},{"line_number":423,"context_line":"# enable_security_group \u003d True"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":426,"context_line":"# uncomment this line."}],"source_content_type":"text/plain","patch_set":19,"id":"AAAAVn%2F%2FToU%3D","line":423,"in_reply_to":"AAAAVn%2F%2F1JQ%3D","updated":"2014-03-06 22:51:04.000000000","message":"Done","commit_id":"2b696088170b13c2aa70670af2a075666185cf74"}],"etc/neutron/plugins/brocade/brocade.ini":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1755256c2327a59ae32cef8c839505d2815a9ff2","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":35,"context_line":"# uncomment this line."},{"line_number":36,"context_line":"# enable_security_group \u003d False"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2F21w%3D","line":36,"updated":"2014-03-13 10:49:31.000000000","message":"there is no change in the code of brocade plugin. Does this option work? If not, i would suggest to remove it.","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b7fd5bc9f5d331281e2bcab225ec32f945a8a244","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":35,"context_line":"# uncomment this line."},{"line_number":36,"context_line":"# enable_security_group \u003d False"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2FzMQ%3D","line":36,"in_reply_to":"AAAAWH%2F%2F21w%3D","updated":"2014-03-13 18:28:25.000000000","message":"Done","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1755256c2327a59ae32cef8c839505d2815a9ff2","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2F208%3D","line":44,"updated":"2014-03-13 10:49:31.000000000","message":"Unnecessary blank lines..","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b7fd5bc9f5d331281e2bcab225ec32f945a8a244","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2FzMI%3D","line":44,"in_reply_to":"AAAAWH%2F%2F208%3D","updated":"2014-03-13 18:28:25.000000000","message":"Done","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"}],"etc/neutron/plugins/cisco/cisco_plugins.ini":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1755256c2327a59ae32cef8c839505d2815a9ff2","unresolved":false,"context_lines":[{"line_number":139,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":140,"context_line":"# uncomment this line."},{"line_number":141,"context_line":"# enable_security_group \u003d False"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2F20o%3D","line":142,"updated":"2014-03-13 10:49:31.000000000","message":"Same as a comment on brocade plugin.","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b7fd5bc9f5d331281e2bcab225ec32f945a8a244","unresolved":false,"context_lines":[{"line_number":139,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":140,"context_line":"# uncomment this line."},{"line_number":141,"context_line":"# enable_security_group \u003d False"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2FzME%3D","line":142,"in_reply_to":"AAAAWH%2F%2F20o%3D","updated":"2014-03-13 18:28:25.000000000","message":"Done","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"}],"etc/neutron/plugins/linuxbridge/linuxbridge_conf.ini":[{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"df12c3b4ed132c5da5f2b34c5a1fea2d767415b6","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":77,"context_line":"# It should be false when you use nova security group."},{"line_number":78,"context_line":"enable_security_gruop \u003d True"}],"source_content_type":"text/x-properties","patch_set":27,"id":"AAAAWH%2F%2Fv8w%3D","line":78,"updated":"2014-03-14 02:22:01.000000000","message":"enable_security_gruop should be enable_security_group","commit_id":"51b6ab26f007ee6dfd433a9e82a23d94a4cd68ca"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"df009d96333524b614e48da5bcf67410d0cdea52","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":77,"context_line":"# It should be false when you use nova security group."},{"line_number":78,"context_line":"enable_security_group \u003d True"}],"source_content_type":"text/x-properties","patch_set":29,"id":"AAAAWH%2F%2FR2M%3D","line":78,"updated":"2014-03-18 22:27:15.000000000","message":"According to our convention, an option with the default value should be commented out.","commit_id":"e2f6598148b8920313896250c93dd51c47887816"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"2742cf565f3712fa1f5516e02fc8b6da0fe7f35a","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":77,"context_line":"# It should be false when you use nova security group."},{"line_number":78,"context_line":"enable_security_group \u003d True"}],"source_content_type":"text/x-properties","patch_set":29,"id":"AAAAWH%2F%2FPtY%3D","line":78,"in_reply_to":"AAAAWH%2F%2FP6Q%3D","updated":"2014-03-19 06:07:13.000000000","message":"I got it.\nI just followed this comment.\n\nhttps://review.openstack.org/#/c/67281/25/etc/neutron/plugins/ml2/ml2_conf.ini","commit_id":"e2f6598148b8920313896250c93dd51c47887816"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"24b26912039b3329f163706304e182344aa9beff","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":77,"context_line":"# It should be false when you use nova security group."},{"line_number":78,"context_line":"enable_security_group \u003d True"}],"source_content_type":"text/x-properties","patch_set":29,"id":"AAAAWH%2F%2FPrU%3D","line":78,"in_reply_to":"AAAAWH%2F%2FPtY%3D","updated":"2014-03-19 06:13:39.000000000","message":"Woops.... sorry for confusion. I just wanted to suggest removing \"enable_security_group \u003d False\".","commit_id":"e2f6598148b8920313896250c93dd51c47887816"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"a82ef729222052ee98600ffd9a96c8329c86d825","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":77,"context_line":"# It should be false when you use nova security group."},{"line_number":78,"context_line":"enable_security_group \u003d True"}],"source_content_type":"text/x-properties","patch_set":29,"id":"AAAAWH%2F%2FP6Q%3D","line":78,"in_reply_to":"AAAAWH%2F%2FR2M%3D","updated":"2014-03-19 05:59:47.000000000","message":"Good comment. It\u0027s actually relevant to all etc/... files in the patch.","commit_id":"e2f6598148b8920313896250c93dd51c47887816"}],"etc/neutron/plugins/ml2/ml2_conf.ini":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"0bccc77339f16021cab505f4f43d7649ad59d87c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# Example: vxlan_group \u003d 239.1.1.1"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[securitygroup]"},{"line_number":60,"context_line":"# enable_security_group \u003d True"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":63,"context_line":"# uncomment this line."}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2F4Jo%3D","line":60,"updated":"2014-03-13 07:42:58.000000000","message":"I think setting enable_security_group\u003dTrue here and also setting it to False in line 64 may confuses user about the default value. It\u0027s hard to tell the default value from config file itself. Can we just use one value in the config file as default value?","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b7fd5bc9f5d331281e2bcab225ec32f945a8a244","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# Example: vxlan_group \u003d 239.1.1.1"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[securitygroup]"},{"line_number":60,"context_line":"# enable_security_group \u003d True"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":63,"context_line":"# uncomment this line."}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2FzLM%3D","line":60,"in_reply_to":"AAAAWH%2F%2F26E%3D","updated":"2014-03-13 18:28:25.000000000","message":"Done","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1755256c2327a59ae32cef8c839505d2815a9ff2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# Example: vxlan_group \u003d 239.1.1.1"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[securitygroup]"},{"line_number":60,"context_line":"# enable_security_group \u003d True"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":63,"context_line":"# uncomment this line."}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2F26E%3D","line":60,"in_reply_to":"AAAAWH%2F%2F4F4%3D","updated":"2014-03-13 10:49:31.000000000","message":"Please consider the following. It is copied from the option definition in securitygroup_rpc.py. I think it address the comment.\n\n  [security_group]\n  # Controls if neutron security group is enabled or not.\n  # It should be false when you use nova security group.\n  enable_security_gruop \u003d True","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"fb5432c7c5ef26bd9a6a357b69f5cc93dd48891b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# Example: vxlan_group \u003d 239.1.1.1"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[securitygroup]"},{"line_number":60,"context_line":"# enable_security_group \u003d True"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":63,"context_line":"# uncomment this line."}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2F4F4%3D","line":60,"in_reply_to":"AAAAWH%2F%2F4Jo%3D","updated":"2014-03-13 07:55:44.000000000","message":"This is not default value but a configuration example.\nso I think it is good think to show how to use parameters.","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"df12c3b4ed132c5da5f2b34c5a1fea2d767415b6","unresolved":false,"context_lines":[{"line_number":59,"context_line":"[security_group]"},{"line_number":60,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":61,"context_line":"# It should be false when you use nova security group."},{"line_number":62,"context_line":"enable_security_gruop \u003d True"}],"source_content_type":"text/x-properties","patch_set":27,"id":"AAAAWH%2F%2Fv88%3D","line":62,"updated":"2014-03-14 02:22:01.000000000","message":"enable_security_gruop should be enable_security_group.","commit_id":"51b6ab26f007ee6dfd433a9e82a23d94a4cd68ca"}],"etc/neutron/plugins/mlnx/mlnx_conf.ini":[{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"df12c3b4ed132c5da5f2b34c5a1fea2d767415b6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"[securitygroup]"},{"line_number":77,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":78,"context_line":"# It should be false when you use nova security group."},{"line_number":79,"context_line":"enable_security_gruop \u003d True"}],"source_content_type":"text/x-properties","patch_set":27,"id":"AAAAWH%2F%2Fv9c%3D","line":79,"updated":"2014-03-14 02:22:01.000000000","message":"It should be enable_security_group.","commit_id":"51b6ab26f007ee6dfd433a9e82a23d94a4cd68ca"}],"etc/neutron/plugins/nec/nec.ini":[{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"df12c3b4ed132c5da5f2b34c5a1fea2d767415b6","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":20,"context_line":"# It should be false when you use nova security group."},{"line_number":21,"context_line":"enable_security_gruop \u003d True"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"[ofc]"},{"line_number":24,"context_line":"# Specify OpenFlow Controller Host, Port and Driver to connect."}],"source_content_type":"text/x-properties","patch_set":27,"id":"AAAAWH%2F%2Fv8Y%3D","line":21,"updated":"2014-03-14 02:22:01.000000000","message":"dito","commit_id":"51b6ab26f007ee6dfd433a9e82a23d94a4cd68ca"}],"etc/neutron/plugins/nicira/nvp.ini":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1755256c2327a59ae32cef8c839505d2815a9ff2","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":207,"context_line":"# uncomment this line."},{"line_number":208,"context_line":"# enable_security_group \u003d False"}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2F25Y%3D","line":208,"updated":"2014-03-13 10:49:31.000000000","message":"Unnecessary per discussion at patch set 22.","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b7fd5bc9f5d331281e2bcab225ec32f945a8a244","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":207,"context_line":"# uncomment this line."},{"line_number":208,"context_line":"# enable_security_group \u003d False"}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2FzLw%3D","line":208,"in_reply_to":"AAAAWH%2F%2F25Y%3D","updated":"2014-03-13 18:28:25.000000000","message":"my bad.. sorry commit mistake","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"}],"etc/neutron/plugins/openvswitch/ovs_neutron_plugin.ini":[{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"df12c3b4ed132c5da5f2b34c5a1fea2d767415b6","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":137,"context_line":"# It should be false when you use nova security group."},{"line_number":138,"context_line":"enable_security_gruop \u003d True"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"#-----------------------------------------------------------------------------"},{"line_number":141,"context_line":"# Sample Configurations."}],"source_content_type":"text/x-properties","patch_set":27,"id":"AAAAWH%2F%2Fv8M%3D","line":138,"updated":"2014-03-14 02:22:01.000000000","message":"dito","commit_id":"51b6ab26f007ee6dfd433a9e82a23d94a4cd68ca"}],"etc/neutron/plugins/ryu/ryu.ini":[{"author":{"_account_id":9560,"name":"Lee Li","email":"lilinguo8212@gmail.com","username":"llg8212"},"change_message_id":"df12c3b4ed132c5da5f2b34c5a1fea2d767415b6","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":39,"context_line":"# It should be false when you use nova security group."},{"line_number":40,"context_line":"enable_security_gruop \u003d True"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[agent]"},{"line_number":43,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":27,"id":"AAAAWH%2F%2Fv8A%3D","line":40,"updated":"2014-03-14 02:22:01.000000000","message":"dito","commit_id":"51b6ab26f007ee6dfd433a9e82a23d94a4cd68ca"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"d779f3f2067c993e0fd60f062ed07e86c5b5517e","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":39,"context_line":"# It should be false when you use nova security group."},{"line_number":40,"context_line":"# enable_security_group \u003d True"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[agent]"},{"line_number":43,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":33,"id":"AAAAWH%2F%2B7bU%3D","line":40,"updated":"2014-03-21 16:06:18.000000000","message":"Shouldn\u0027t this config be added to some of the other plugins\u0027 config files too? For example, I don\u0027t see it for the bigswitch plugin\u0027s restproxy.ini config file.","commit_id":"f87e7d964c19cc2be33226df66f0c823af993d49"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"78bf06f32209a94126a1aa4c59daa51699fd49cc","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Controls if neutron security group is enabled or not."},{"line_number":39,"context_line":"# It should be false when you use nova security group."},{"line_number":40,"context_line":"# enable_security_group \u003d True"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"[agent]"},{"line_number":43,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":33,"id":"AAAAWH%2F%2B7VU%3D","line":40,"in_reply_to":"AAAAWH%2F%2B7bU%3D","updated":"2014-03-21 16:22:21.000000000","message":"Yes. Since this adds configuration based logic to the Big Switch plugin, the [securitygroup] section should be added to the default restproxy.ini as well.","commit_id":"f87e7d964c19cc2be33226df66f0c823af993d49"}],"etc/neutron/plugins/vmware/nsx.ini":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"90941d613f3717d6eb786cca262b7ec35a0a49a3","unresolved":false,"context_lines":[{"line_number":195,"context_line":"# but it MUST match with the configuration used by the Metadata server"},{"line_number":196,"context_line":"# metadata_shared_secret \u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"[securitygroup]"},{"line_number":199,"context_line":"# enable_security_group \u003d True"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# If you want to use nova side security group implemenation,"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAAVn%2F%2FJoA%3D","line":198,"updated":"2014-03-08 03:30:45.000000000","message":"copying this all over the place does sound a waste. Wouldn\u0027t it be better to move it to neutron.conf?","commit_id":"8f61729ad1475529ae7ec71b823403aff0976308"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"13bf0e03c5fffb41f5fd0baf6ca8bc5c7db10b03","unresolved":false,"context_lines":[{"line_number":195,"context_line":"# but it MUST match with the configuration used by the Metadata server"},{"line_number":196,"context_line":"# metadata_shared_secret \u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"[securitygroup]"},{"line_number":199,"context_line":"# enable_security_group \u003d True"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# If you want to use nova side security group implemenation,"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAAVn%2F%2B1s8%3D","line":198,"in_reply_to":"AAAAVn%2F%2B20s%3D","updated":"2014-03-11 20:15:15.000000000","message":"that sounds about right :)","commit_id":"8f61729ad1475529ae7ec71b823403aff0976308"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b959fd554bb7fa935e4f10dabc6cc9bf49e8d99e","unresolved":false,"context_lines":[{"line_number":195,"context_line":"# but it MUST match with the configuration used by the Metadata server"},{"line_number":196,"context_line":"# metadata_shared_secret \u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"[securitygroup]"},{"line_number":199,"context_line":"# enable_security_group \u003d True"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# If you want to use nova side security group implemenation,"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAAVn%2F%2B20s%3D","line":198,"in_reply_to":"AAAAVn%2F%2B80E%3D","updated":"2014-03-11 17:45:18.000000000","message":"So what I should do is remove this from nsx.conf and nicira.conf?","commit_id":"8f61729ad1475529ae7ec71b823403aff0976308"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"dfcdfb38e87f9f249e7f7e70eb6c47b5e7f57325","unresolved":false,"context_lines":[{"line_number":195,"context_line":"# but it MUST match with the configuration used by the Metadata server"},{"line_number":196,"context_line":"# metadata_shared_secret \u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"[securitygroup]"},{"line_number":199,"context_line":"# enable_security_group \u003d True"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# If you want to use nova side security group implemenation,"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAAVn%2F%2B80E%3D","line":198,"in_reply_to":"AAAAVn%2F%2FHWE%3D","updated":"2014-03-11 03:50:53.000000000","message":"right, this won\u0027t disable security groups for the nsx plugin. Also, ports and other resources will still have the default security group. I don\u0027t think we want this.","commit_id":"8f61729ad1475529ae7ec71b823403aff0976308"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4d5133c1904528cb3b51fefdcd93cb99fce74ea3","unresolved":false,"context_lines":[{"line_number":195,"context_line":"# but it MUST match with the configuration used by the Metadata server"},{"line_number":196,"context_line":"# metadata_shared_secret \u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"[securitygroup]"},{"line_number":199,"context_line":"# enable_security_group \u003d True"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# If you want to use nova side security group implemenation,"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAAVn%2F%2FHWE%3D","line":198,"in_reply_to":"AAAAVn%2F%2FIS4%3D","updated":"2014-03-09 08:58:26.000000000","message":"I remember the background of Aaron\u0027s comment.\n\nenable_security_group option is defined in agent/secrutiy_group_rpc.py and it means this option is defined only in plugins with agent-based security group implementation.\n\nI checked this patch and this option is only available for bigswitch, linuxbridge, ml2, ovs, mlnx, nec, ryu plugins. It is not enabled at least vmware nsx plugin and perhaps it applies to cisco and brocade plugins.\n\nIf we use the current implementation, it should be placed in plugin.ini. Otherwise, this option needs to be defined in other places and common on all plugins.","commit_id":"8f61729ad1475529ae7ec71b823403aff0976308"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d7a66ede8ba5bc833eec000cefdf9091cc9ee161","unresolved":false,"context_lines":[{"line_number":195,"context_line":"# but it MUST match with the configuration used by the Metadata server"},{"line_number":196,"context_line":"# metadata_shared_secret \u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"[securitygroup]"},{"line_number":199,"context_line":"# enable_security_group \u003d True"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# If you want to use nova side security group implemenation,"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAAVn%2F%2FIS4%3D","line":198,"in_reply_to":"AAAAVn%2F%2FIXE%3D","updated":"2014-03-08 16:38:57.000000000","message":"Oh! Let me bring Aaron\u0027s comment here:\n[\nThis should only go in plugins config file\u0027s that would want something like this. Having it here assumes that this disables the security_group extension for all plugins which isn\u0027t true.\n]\n\nCopying the config option into each ini file does not buy us anything though, it\u0027s just duplication, is that right? It\u0027s not like we can run multiple plugins at the same time.\n\nIf I understood what Aaron is saying, maybe he wanted to imply that some plugins may not implement the security group extension, in which case having a global config may be confusing. However, if I understand the patch correctly if a plugin does not implement the extension the config value is ineffective regardless the value.","commit_id":"8f61729ad1475529ae7ec71b823403aff0976308"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"33d52c6f9913c4c77c7e0c267e3e09b2c14ffdba","unresolved":false,"context_lines":[{"line_number":195,"context_line":"# but it MUST match with the configuration used by the Metadata server"},{"line_number":196,"context_line":"# metadata_shared_secret \u003d"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"[securitygroup]"},{"line_number":199,"context_line":"# enable_security_group \u003d True"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# If you want to use nova side security group implemenation,"}],"source_content_type":"text/x-properties","patch_set":22,"id":"AAAAVn%2F%2FIXE%3D","line":198,"in_reply_to":"AAAAVn%2F%2FJoA%3D","updated":"2014-03-08 15:56:36.000000000","message":"It was suggested by Aaron in patch set 19. IMO neutron.conf sounds reasonable because it is not specific to some plugin.","commit_id":"8f61729ad1475529ae7ec71b823403aff0976308"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1755256c2327a59ae32cef8c839505d2815a9ff2","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":202,"context_line":"# uncomment this line."},{"line_number":203,"context_line":"# enable_security_group \u003d False"}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2F25M%3D","line":203,"updated":"2014-03-13 10:49:31.000000000","message":"Unnecessary per discussion at patch set 22.","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b7fd5bc9f5d331281e2bcab225ec32f945a8a244","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"# If you want to use nova side security group implemenation,"},{"line_number":202,"context_line":"# uncomment this line."},{"line_number":203,"context_line":"# enable_security_group \u003d False"}],"source_content_type":"text/x-properties","patch_set":25,"id":"AAAAWH%2F%2FzJc%3D","line":203,"in_reply_to":"AAAAWH%2F%2F25M%3D","updated":"2014-03-13 18:28:25.000000000","message":"Done","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"}],"neutron/agent/securitygroups_rpc.py":[{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"7a00f9c252493b61e3e649feb7477f5227b2899b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"},{"line_number":35,"context_line":"        default\u003dTrue,"},{"line_number":36,"context_line":"        help\u003d_(\u0027Enable security group if True\u0027))"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FKkY%3D","line":36,"updated":"2014-01-16 20:06:32.000000000","message":"I think this could use a better help text since it is already self-documenting.","commit_id":"6804610111b10c925dbcd08074c15e4cebef8598"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"039db6e42ee98fe3793782bc3637367ffba3564f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"},{"line_number":35,"context_line":"        default\u003dTrue,"},{"line_number":36,"context_line":"        help\u003d_(\u0027Enable security group if True\u0027))"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FJ4k%3D","line":36,"in_reply_to":"AAAAUH%2F%2FKkY%3D","updated":"2014-01-16 22:17:37.000000000","message":"Done","commit_id":"6804610111b10c925dbcd08074c15e4cebef8598"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d273053863ee5da698289d24ec5cea749916b07e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"},{"line_number":35,"context_line":"        default\u003dTrue,"},{"line_number":36,"context_line":"        help\u003d_(\u0027Should be false when you use nova security group\u0027))"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FXwA%3D","line":36,"updated":"2014-02-13 17:05:16.000000000","message":"While the option name is self-descriptive, I still think it is better the help text should describe it.\n\n   Controls if neutron security group is enabled or not.\n   It should be false if you use nova security group.","commit_id":"11424644e76bf9da0d0ca5ed333a2b5218627d44"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"00d69c486d500de1ed3389ec16f6e0edf950d63e","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"},{"line_number":35,"context_line":"        default\u003dTrue,"},{"line_number":36,"context_line":"        help\u003d_(\u0027Should be false when you use nova security group\u0027))"},{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BpuU%3D","line":36,"in_reply_to":"AAAAUX%2F%2FXwA%3D","updated":"2014-02-22 16:47:17.000000000","message":"Done","commit_id":"11424644e76bf9da0d0ca5ed333a2b5218627d44"},{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"f18906d95b9f4339e3da7f1472b2620bca6f0756","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    supported_extension_aliases):"},{"line_number":47,"context_line":"    if not is_firewall_enabled():"},{"line_number":48,"context_line":"        LOG.debug(_(\u0027Disabled security-group extension.\u0027))"},{"line_number":49,"context_line":"        supported_extension_aliases.remove(\u0027security-group\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class SecurityGroupServerRpcApiMixin(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FRZs%3D","line":49,"updated":"2014-02-14 10:38:36.000000000","message":"If the \u0027enable_security_group\u0027 is False, the security group is handled by Nova. So the extension \u0027allowed-address-pairs\u0027 will not work and we should removed it if it\u0027s supported by the plugin.","commit_id":"11424644e76bf9da0d0ca5ed333a2b5218627d44"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"00d69c486d500de1ed3389ec16f6e0edf950d63e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    supported_extension_aliases):"},{"line_number":47,"context_line":"    if not is_firewall_enabled():"},{"line_number":48,"context_line":"        LOG.debug(_(\u0027Disabled security-group extension.\u0027))"},{"line_number":49,"context_line":"        supported_extension_aliases.remove(\u0027security-group\u0027)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class SecurityGroupServerRpcApiMixin(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BpuQ%3D","line":49,"in_reply_to":"AAAAUX%2F%2FRZs%3D","updated":"2014-02-22 16:47:17.000000000","message":"Done","commit_id":"11424644e76bf9da0d0ca5ed333a2b5218627d44"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c4d993e7a7781916bd47ec2b528cc4da1c12d96c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"},{"line_number":35,"context_line":"        default\u003dTrue,"},{"line_number":36,"context_line":"        help\u003d_("},{"line_number":37,"context_line":"            \u0027Controls if neutron security group is enabled or not.\u0027"},{"line_number":38,"context_line":"            \u0027It should be false when you use nova security group\u0027))"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAU3%2F%2FuWI%3D","line":37,"updated":"2014-02-25 03:31:20.000000000","message":"space at end of string.","commit_id":"d10ff4ee6835b4af09d7145e548ae467cb3d42ad"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"42f243d891b48bf273c3c81512c632ee754a84cf","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"security_group_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt("},{"line_number":30,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":31,"context_line":"        default\u003d\u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Driver for Security Groups Firewall\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt("}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAU3%2F%2Fjuk%3D","line":30,"updated":"2014-02-25 23:14:44.000000000","message":"I guess this was never documented in neutron.conf, or  I am a bit confused: can these two options co-exist?","commit_id":"328a8ebc10f6e186848c9ec23987ba62890048fe"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"e8edd5f0bec4974e9baf6baabade80d54f1404f5","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"security_group_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt("},{"line_number":30,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":31,"context_line":"        default\u003d\u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Driver for Security Groups Firewall\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt("}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAU3%2F%2Fjdw%3D","line":30,"in_reply_to":"AAAAU3%2F%2Fjuk%3D","updated":"2014-02-25 23:49:46.000000000","message":"It is documented in the plugin.conf\nFor example\nhttps://github.com/openstack/neutron/blob/master/etc/neutron/plugins/linuxbridge/linuxbridge_conf.ini#L71\n\nThis option will be needed when we support OpenFlow based security group implementation.","commit_id":"328a8ebc10f6e186848c9ec23987ba62890048fe"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"46803e52ca7d2d512b5c697b9ee5e092b8210905","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def is_firewall_enabled():"},{"line_number":44,"context_line":"    return (cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":45,"context_line":"            #This is backward compatibility check for Havana"},{"line_number":46,"context_line":"            cfg.CONF.SECURITYGROUP.firewall_driver !\u003d"},{"line_number":47,"context_line":"            \u0027neutron.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVX%2F%2FsV8%3D","line":45,"updated":"2014-03-01 00:30:10.000000000","message":"Hmmm... Seems like we should warn when sec is enabled and default few driver is noop.","commit_id":"10920b1abb73f49d168a9866a169185b1dd3406b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"e0c7a5a6349408e910781428ce1e5e6c35e24963","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def is_firewall_enabled():"},{"line_number":44,"context_line":"    return (cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":45,"context_line":"            #This is backward compatibility check for Havana"},{"line_number":46,"context_line":"            cfg.CONF.SECURITYGROUP.firewall_driver !\u003d"},{"line_number":47,"context_line":"            \u0027neutron.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVn%2F%2F2q0%3D","line":45,"in_reply_to":"AAAAVX%2F%2Fri0%3D","updated":"2014-03-03 19:38:24.000000000","message":"I prefer (a) too.\nI wanna also ask Mark\u0027s input","commit_id":"10920b1abb73f49d168a9866a169185b1dd3406b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5cadd2b68d2e2e0b80d5f93f8bdad7785985d621","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def is_firewall_enabled():"},{"line_number":44,"context_line":"    return (cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":45,"context_line":"            #This is backward compatibility check for Havana"},{"line_number":46,"context_line":"            cfg.CONF.SECURITYGROUP.firewall_driver !\u003d"},{"line_number":47,"context_line":"            \u0027neutron.agent.firewall.NoopFirewallDriver\u0027)"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVX%2F%2Fri0%3D","line":45,"in_reply_to":"AAAAVX%2F%2FsV8%3D","updated":"2014-03-01 06:09:40.000000000","message":"The original problem is that it is confusing security group is disabled if noop driver is used. Thus this behavior does not solve the problem.\n\nI think there are the following other options.\n- (a) Honor enable_security_group only. Log warning if enable_security_group is True and noop_driver is used. (the behavior is incompatible with havana) (perhaps same as mark suggested above)\n- (b) Change enable_security_group to force_enable_security_group. is_firewall_enabled() will be: return (force_enable_security_group or firewall_driver !\u003d noop_driver)\n\nPersonally I prefer option (a) because it address the original problem (confusing behavior that sg ext is disabled based on firewall_driver) and the case we discussed seems not so important for most operators, though it is incompatible with havana release.\n\nThought?","commit_id":"10920b1abb73f49d168a9866a169185b1dd3406b"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"46803e52ca7d2d512b5c697b9ee5e092b8210905","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def _ensure_extension_not_exist(extension, aliases):"},{"line_number":51,"context_line":"    if extension in aliases:"},{"line_number":52,"context_line":"        aliases.remove(extension)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVX%2F%2FsVc%3D","line":51,"updated":"2014-03-01 00:30:10.000000000","message":"How about _disable_extension as the method name","commit_id":"10920b1abb73f49d168a9866a169185b1dd3406b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"e0c7a5a6349408e910781428ce1e5e6c35e24963","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def _ensure_extension_not_exist(extension, aliases):"},{"line_number":51,"context_line":"    if extension in aliases:"},{"line_number":52,"context_line":"        aliases.remove(extension)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVn%2F%2F2qw%3D","line":51,"in_reply_to":"AAAAVX%2F%2FsVc%3D","updated":"2014-03-03 19:38:24.000000000","message":"Done","commit_id":"10920b1abb73f49d168a9866a169185b1dd3406b"},{"author":{"_account_id":55,"name":"Édouard Thuleau","email":"ethuleau@juniper.net","username":"ethuleau"},"change_message_id":"a85236d7325cfedc85268d7490bbea24c248840e","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def disable_security_group_extension_by_config(aliases):"},{"line_number":56,"context_line":"    if not is_firewall_enabled():"},{"line_number":57,"context_line":"        LOG.debug(_(\u0027Disabled security-group extension.\u0027))"},{"line_number":58,"context_line":"        _ensure_extension_not_exist(\u0027security-group\u0027, aliases)"},{"line_number":59,"context_line":"        _ensure_extension_not_exist(\u0027allowed-address-pairs\u0027, aliases)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVn%2F%2F844%3D","line":57,"updated":"2014-03-03 08:17:49.000000000","message":"nit: update debug log to prevent allowed-address-pairs also disabled.","commit_id":"10920b1abb73f49d168a9866a169185b1dd3406b"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"e0c7a5a6349408e910781428ce1e5e6c35e24963","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def disable_security_group_extension_by_config(aliases):"},{"line_number":56,"context_line":"    if not is_firewall_enabled():"},{"line_number":57,"context_line":"        LOG.debug(_(\u0027Disabled security-group extension.\u0027))"},{"line_number":58,"context_line":"        _ensure_extension_not_exist(\u0027security-group\u0027, aliases)"},{"line_number":59,"context_line":"        _ensure_extension_not_exist(\u0027allowed-address-pairs\u0027, aliases)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVn%2F%2F2qs%3D","line":57,"in_reply_to":"AAAAVn%2F%2F5Eg%3D","updated":"2014-03-03 19:38:24.000000000","message":"Done","commit_id":"10920b1abb73f49d168a9866a169185b1dd3406b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0d6f5075061b796d8627c17bbde3883202c79a29","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def disable_security_group_extension_by_config(aliases):"},{"line_number":56,"context_line":"    if not is_firewall_enabled():"},{"line_number":57,"context_line":"        LOG.debug(_(\u0027Disabled security-group extension.\u0027))"},{"line_number":58,"context_line":"        _ensure_extension_not_exist(\u0027security-group\u0027, aliases)"},{"line_number":59,"context_line":"        _ensure_extension_not_exist(\u0027allowed-address-pairs\u0027, aliases)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAVn%2F%2F5Eg%3D","line":57,"in_reply_to":"AAAAVn%2F%2F844%3D","updated":"2014-03-03 15:54:51.000000000","message":"Please raise the log level to INFO.","commit_id":"10920b1abb73f49d168a9866a169185b1dd3406b"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"428700bc99e330933ba47b3ee756988198bf3960","unresolved":false,"context_lines":[{"line_number":28,"context_line":"security_group_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt("},{"line_number":30,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":31,"context_line":"        default\u003d\u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Driver for Security Groups Firewall\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVn%2F%2FpYk%3D","line":31,"updated":"2014-03-04 21:37:57.000000000","message":"as you are adding a further option, and defaulting it to True, does it still make sense to default to NoOp?\n\nAlso, does the combination\nenable_security_group\u003dTrue\nfirewall_driver\u003dneutron.agent.firewall.NoopFirewallDriver\n\nmake sense? I think it might be ok default firewall driver to None now, and raise an error at startup because if enable_security_group\u003dTrue then you must have a firewall driver.\n\nalternatively, you can use the iptables driver as default or if you really want to be clever allow each plugin to select a driver when firewall_driver\u003dNone","commit_id":"2b696088170b13c2aa70670af2a075666185cf74"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"2664eb68ba8244b8d14dfc12a943f715792f3488","unresolved":false,"context_lines":[{"line_number":28,"context_line":"security_group_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt("},{"line_number":30,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":31,"context_line":"        default\u003d\u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Driver for Security Groups Firewall\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVn%2F%2FTlE%3D","line":31,"in_reply_to":"AAAAVn%2F%2FpYk%3D","updated":"2014-03-06 22:51:04.000000000","message":"Thanks.\nI\u0027ll choose firewall_driver\u003dNone.","commit_id":"2b696088170b13c2aa70670af2a075666185cf74"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"428700bc99e330933ba47b3ee756988198bf3960","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        LOG.info(_(\u0027Disabled security-group extension.\u0027))"},{"line_number":58,"context_line":"        _disable_extension(\u0027security-group\u0027, aliases)"},{"line_number":59,"context_line":"        LOG.info(_(\u0027Disabled allowed-address-pairs extension.\u0027))"},{"line_number":60,"context_line":"        _disable_extension(\u0027allowed-address-pairs\u0027, aliases)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class SecurityGroupServerRpcApiMixin(object):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVn%2F%2FpX8%3D","line":60,"updated":"2014-03-04 21:37:57.000000000","message":"is this change related to this patch?","commit_id":"2b696088170b13c2aa70670af2a075666185cf74"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"2664eb68ba8244b8d14dfc12a943f715792f3488","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        LOG.info(_(\u0027Disabled security-group extension.\u0027))"},{"line_number":58,"context_line":"        _disable_extension(\u0027security-group\u0027, aliases)"},{"line_number":59,"context_line":"        LOG.info(_(\u0027Disabled allowed-address-pairs extension.\u0027))"},{"line_number":60,"context_line":"        _disable_extension(\u0027allowed-address-pairs\u0027, aliases)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class SecurityGroupServerRpcApiMixin(object):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAVn%2F%2FTks%3D","line":60,"in_reply_to":"AAAAVn%2F%2FpX8%3D","updated":"2014-03-06 22:51:04.000000000","message":"if security group disabled, this should be also disabled. I\u0027ll mention this in commit message","commit_id":"2b696088170b13c2aa70670af2a075666185cf74"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"fefb7931fd420ce0c557bbdbe0197efac20fe7b9","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            #This is backward compatibility check for Havana"},{"line_number":46,"context_line":"            cfg.CONF.SECURITYGROUP.firewall_driver !\u003d"},{"line_number":47,"context_line":"            \u0027neutron.agent.firewall.NoopFirewallDriver\u0027):"},{"line_number":48,"context_line":"        LOG.warn(\"NoopDriver is used even if security group is enabled.\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    return cfg.CONF.SECURITYGROUP.enable_security_group"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAWH%2F%2F4cs%3D","line":48,"updated":"2014-03-13 06:50:36.000000000","message":"This warning looks a little bit misleading. Did you mean the case:\nif (cfg.CONF.SECURITYGROUP.enable_security_group and cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d         \u0027neutron.agent.firewall.NoopFirewallDriver\u0027)\nIt may be a good case for unit test.","commit_id":"c5371a27b04c68d576a14ce3cc26eb78e25de237"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"5f7e6b3b90eb7a415161d818850d3102fbe1b923","unresolved":false,"context_lines":[{"line_number":45,"context_line":"            #This is backward compatibility check for Havana"},{"line_number":46,"context_line":"            cfg.CONF.SECURITYGROUP.firewall_driver !\u003d"},{"line_number":47,"context_line":"            \u0027neutron.agent.firewall.NoopFirewallDriver\u0027):"},{"line_number":48,"context_line":"        LOG.warn(\"NoopDriver is used even if security group is enabled.\")"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    return cfg.CONF.SECURITYGROUP.enable_security_group"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAWH%2F%2F4YM%3D","line":48,"in_reply_to":"AAAAWH%2F%2F4cs%3D","updated":"2014-03-13 06:56:37.000000000","message":"My bad, you are right..","commit_id":"c5371a27b04c68d576a14ce3cc26eb78e25de237"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"0bccc77339f16021cab505f4f43d7649ad59d87c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def _is_valid_driver_combination():"},{"line_number":45,"context_line":"    return ((cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":46,"context_line":"             cfg.CONF.SECURITYGROUP.firewall_driver !\u003d"},{"line_number":47,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027) or"},{"line_number":48,"context_line":"            (not cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":49,"context_line":"             cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d"},{"line_number":50,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027))"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAWH%2F%2F4KM%3D","line":47,"updated":"2014-03-13 07:42:58.000000000","message":"What about enable_security_group\u003dTrue and firewall_driver\u003dNone? I think this combination is not valid but the current code doesn\u0027t prevent this.","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"fb5432c7c5ef26bd9a6a357b69f5cc93dd48891b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def _is_valid_driver_combination():"},{"line_number":45,"context_line":"    return ((cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":46,"context_line":"             cfg.CONF.SECURITYGROUP.firewall_driver !\u003d"},{"line_number":47,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027) or"},{"line_number":48,"context_line":"            (not cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":49,"context_line":"             cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d"},{"line_number":50,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027))"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAWH%2F%2F4GA%3D","line":47,"in_reply_to":"AAAAWH%2F%2F4KM%3D","updated":"2014-03-13 07:55:44.000000000","message":"We won\u0027t set this parameter in future release, so\nfirewall_driver\u003dNone is valid on server side.\nWe won\u0027t set enable_security_group in agent side.","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"576ead6eb5f179eab6379dc942cc2586d08e82df","unresolved":false,"context_lines":[{"line_number":28,"context_line":"security_group_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt("},{"line_number":30,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":31,"context_line":"        default\u003dNone,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Driver for Security Groups Firewall\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAWH%2F%2FI8k%3D","line":31,"updated":"2014-03-19 23:55:58.000000000","message":"is this change to None intentional, this is the one that breaks to UT\u0027s, I guess","commit_id":"4eea1d0e310db99273398be1d77c57fcd8197f78"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"f53c2b29ed02b6c7d3c8f24b8bd5ead874123f20","unresolved":false,"context_lines":[{"line_number":28,"context_line":"security_group_opts \u003d ["},{"line_number":29,"context_line":"    cfg.StrOpt("},{"line_number":30,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":31,"context_line":"        default\u003dNone,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Driver for Security Groups Firewall\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAWH%2F%2FHRc%3D","line":31,"in_reply_to":"AAAAWH%2F%2FI8k%3D","updated":"2014-03-20 06:08:43.000000000","message":"Yes. This is intensional by Salvatore\u0027s comment.\nIt looks like UT get broken by rebasing with master. I\u0027ll fix it.","commit_id":"4eea1d0e310db99273398be1d77c57fcd8197f78"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"9626474078267a309ef332935f6af7692dfb5194","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    cfg.StrOpt("},{"line_number":30,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":31,"context_line":"        default\u003dNone,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Driver for Security Groups Firewall\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"},{"line_number":35,"context_line":"        default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAWH%2F%2FC50%3D","line":32,"updated":"2014-03-20 17:39:57.000000000","message":"How about \u0027Driver for security groups firewall in the L2 agent.\u0027?","commit_id":"e2a9de789f6daf62ced057650a966dca224046db"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"451df4002b658d862bac604962cd5e71f98af74e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    cfg.StrOpt("},{"line_number":30,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":31,"context_line":"        default\u003dNone,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Driver for Security Groups Firewall\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_security_group\u0027,"},{"line_number":35,"context_line":"        default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAWH%2F%2FA30%3D","line":32,"in_reply_to":"AAAAWH%2F%2FC50%3D","updated":"2014-03-20 22:54:49.000000000","message":"Done","commit_id":"e2a9de789f6daf62ced057650a966dca224046db"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"9626474078267a309ef332935f6af7692dfb5194","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        default\u003dTrue,"},{"line_number":36,"context_line":"        help\u003d_("},{"line_number":37,"context_line":"            \u0027Controls if neutron security group is enabled or not. \u0027"},{"line_number":38,"context_line":"            \u0027It should be false when you use nova security group\u0027))"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAWH%2F%2FC3M%3D","line":38,"updated":"2014-03-20 17:39:57.000000000","message":"How about \u0027Controls whether the neutron security group API is enabled in the server. It should be false when using no security groups or using the nova security group API.\u0027?","commit_id":"e2a9de789f6daf62ced057650a966dca224046db"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"451df4002b658d862bac604962cd5e71f98af74e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        default\u003dTrue,"},{"line_number":36,"context_line":"        help\u003d_("},{"line_number":37,"context_line":"            \u0027Controls if neutron security group is enabled or not. \u0027"},{"line_number":38,"context_line":"            \u0027It should be false when you use nova security group\u0027))"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":"cfg.CONF.register_opts(security_group_opts, \u0027SECURITYGROUP\u0027)"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAWH%2F%2FA3s%3D","line":38,"in_reply_to":"AAAAWH%2F%2FC3M%3D","updated":"2014-03-20 22:54:49.000000000","message":"Done","commit_id":"e2a9de789f6daf62ced057650a966dca224046db"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"9626474078267a309ef332935f6af7692dfb5194","unresolved":false,"context_lines":[{"line_number":47,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027) or"},{"line_number":48,"context_line":"            (not cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":49,"context_line":"             cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d"},{"line_number":50,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def is_firewall_enabled():"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAWH%2F%2FDTM%3D","line":50,"updated":"2014-03-20 17:39:57.000000000","message":"This looks like it will result in a warning when enable_security_group \u003d\u003d False and firewall_driver \u003d\u003d None (the default). Isn\u0027t that a perfectly legal and common combination? I think if enable_security_group \u003d\u003d False, then any value should be allowed for firewall_driver.","commit_id":"e2a9de789f6daf62ced057650a966dca224046db"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"451df4002b658d862bac604962cd5e71f98af74e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027) or"},{"line_number":48,"context_line":"            (not cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":49,"context_line":"             cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d"},{"line_number":50,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027))"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def is_firewall_enabled():"}],"source_content_type":"text/x-python","patch_set":32,"id":"AAAAWH%2F%2FA20%3D","line":50,"in_reply_to":"AAAAWH%2F%2FDTM%3D","updated":"2014-03-20 22:54:49.000000000","message":"Good point.\nI think \nFalse \u0026 Noop or False and None should be valid value.\nI\u0027ll update test and this code","commit_id":"e2a9de789f6daf62ced057650a966dca224046db"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"5b1d349737cb529d6070d0fc64a7892d07a8e228","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            (not cfg.CONF.SECURITYGROUP.enable_security_group and"},{"line_number":50,"context_line":"             (cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d"},{"line_number":51,"context_line":"             \u0027neutron.agent.firewall.NoopFirewallDriver\u0027 or"},{"line_number":52,"context_line":"              cfg.CONF.SECURITYGROUP.firewall_driver \u003d\u003d None)"},{"line_number":53,"context_line":"             ))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":33,"id":"AAAAWH%2F%2FAS4%3D","line":52,"updated":"2014-03-21 00:51:55.000000000","message":"I think:\n\nreturn ((cfg.CONF.SECURITYGROUP.enable_security_group and\n\u0027neutron.agent.firewall.NoopFirewallDriver\u0027) or\nnot cfg.CONF.SECURITYGROUP.enable_security_group)\n\nwould be sufficient, but I think this is fine too.","commit_id":"f87e7d964c19cc2be33226df66f0c823af993d49"}],"neutron/tests/base.py":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"fa34a772a8463d8a86ce1e0eced3c637030ea780","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if \u0027SECURITYGROUP\u0027 in cfg.CONF:"},{"line_number":100,"context_line":"            cfg.CONF.set_default(\u0027firewall_driver\u0027,"},{"line_number":101,"context_line":"                                 \u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":102,"context_line":"                                 group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def config(self, **kw):"},{"line_number":105,"context_line":"        \"\"\"Override some configuration values."}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAWH%2F%2FwWg%3D","line":102,"updated":"2014-03-14 01:10:14.000000000","message":"Why is this needed? Maybe it deserves a comment.","commit_id":"fb297cdb5531317cddc52c95c7fa27e33f352464"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"2bef394762c679e05ff4061f012dd8fbbb355c96","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if \u0027SECURITYGROUP\u0027 in cfg.CONF:"},{"line_number":100,"context_line":"            cfg.CONF.set_default(\u0027firewall_driver\u0027,"},{"line_number":101,"context_line":"                                 \u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":102,"context_line":"                                 group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def config(self, **kw):"},{"line_number":105,"context_line":"        \"\"\"Override some configuration values."}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAWH%2F%2FwUY%3D","line":102,"in_reply_to":"AAAAWH%2F%2FwWg%3D","updated":"2014-03-14 01:14:31.000000000","message":"Because now, firewall_driver\u0027s default is None,\nand UT expcets this noop drivers.\nI\u0027ll add comment on here","commit_id":"fb297cdb5531317cddc52c95c7fa27e33f352464"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7d63253a0296745e095b4838e1683af9151e0d66","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            \u0027neutron.common.exceptions.NeutronException.use_fatal_exceptions\u0027,"},{"line_number":97,"context_line":"            fake_use_fatal_exceptions))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # The defualt value for firewall_driver is None, but UT expects"},{"line_number":100,"context_line":"        # Noop Driver"},{"line_number":101,"context_line":"        if \u0027SECURITYGROUP\u0027 in cfg.CONF:"},{"line_number":102,"context_line":"            cfg.CONF.set_default(\u0027firewall_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAWH%2F%2Fs5A%3D","line":99,"updated":"2014-03-14 11:50:59.000000000","message":"defualt -\u003e default","commit_id":"140c2374b0d4436ffa13adf0785d660ed1d916d1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"51aa794415c7aeae9cd17877388180907a57563d","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            \u0027neutron.common.exceptions.NeutronException.use_fatal_exceptions\u0027,"},{"line_number":97,"context_line":"            fake_use_fatal_exceptions))"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        # The defualt value for firewall_driver is None, but UT expects"},{"line_number":100,"context_line":"        # Noop Driver"},{"line_number":101,"context_line":"        if \u0027SECURITYGROUP\u0027 in cfg.CONF:"},{"line_number":102,"context_line":"            cfg.CONF.set_default(\u0027firewall_driver\u0027,"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAWH%2F%2Fp30%3D","line":99,"in_reply_to":"AAAAWH%2F%2Fs5A%3D","updated":"2014-03-14 17:53:16.000000000","message":"Done","commit_id":"140c2374b0d4436ffa13adf0785d660ed1d916d1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"36dffc2f07f95e9e19c006b7db35568495d46ccc","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if \u0027SECURITYGROUP\u0027 in cfg.CONF:"},{"line_number":102,"context_line":"            cfg.CONF.set_default(\u0027firewall_driver\u0027,"},{"line_number":103,"context_line":"                                 \u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":104,"context_line":"                                 group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def config(self, **kw):"},{"line_number":107,"context_line":"        \"\"\"Override some configuration values."}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAWH%2F%2FvIQ%3D","line":104,"updated":"2014-03-14 05:39:45.000000000","message":"In general, base.TestBase should not contain settings for specific feature. Can\u0027t we do this in base test class for portbinding?","commit_id":"140c2374b0d4436ffa13adf0785d660ed1d916d1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ebc78c3390ec4ed6563496657eaf5a751880bf94","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if \u0027SECURITYGROUP\u0027 in cfg.CONF:"},{"line_number":102,"context_line":"            cfg.CONF.set_default(\u0027firewall_driver\u0027,"},{"line_number":103,"context_line":"                                 \u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":104,"context_line":"                                 group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def config(self, **kw):"},{"line_number":107,"context_line":"        \"\"\"Override some configuration values."}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAWH%2F%2FpLA%3D","line":104,"in_reply_to":"AAAAWH%2F%2Fp4s%3D","updated":"2014-03-14 19:28:55.000000000","message":"I still think it is not a good solution since this class is originally intended to be used for both functional and unit tests. I haven\u0027t investigated which tests are affected. Could you add TODO comment here if you want to go as-is? You can assign me :-)","commit_id":"140c2374b0d4436ffa13adf0785d660ed1d916d1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"fbd5fe436f14467110190ec6aeae734a43dfdb89","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if \u0027SECURITYGROUP\u0027 in cfg.CONF:"},{"line_number":102,"context_line":"            cfg.CONF.set_default(\u0027firewall_driver\u0027,"},{"line_number":103,"context_line":"                                 \u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":104,"context_line":"                                 group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def config(self, **kw):"},{"line_number":107,"context_line":"        \"\"\"Override some configuration values."}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAWH%2F%2FSkc%3D","line":104,"in_reply_to":"AAAAWH%2F%2FpLA%3D","updated":"2014-03-18 20:45:16.000000000","message":"Sorry It was my mistake. There was not so much dependencies. I\u0027ll fix this in next patch","commit_id":"140c2374b0d4436ffa13adf0785d660ed1d916d1"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"51aa794415c7aeae9cd17877388180907a57563d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if \u0027SECURITYGROUP\u0027 in cfg.CONF:"},{"line_number":102,"context_line":"            cfg.CONF.set_default(\u0027firewall_driver\u0027,"},{"line_number":103,"context_line":"                                 \u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":104,"context_line":"                                 group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"    def config(self, **kw):"},{"line_number":107,"context_line":"        \"\"\"Override some configuration values."}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAAWH%2F%2Fp4s%3D","line":104,"in_reply_to":"AAAAWH%2F%2FvIQ%3D","updated":"2014-03-14 17:53:16.000000000","message":"Not only portbinding but really many class uses this option..\nSince it is a kind of common option and we are checking existence for the parameter, I think it is OK to have it here","commit_id":"140c2374b0d4436ffa13adf0785d660ed1d916d1"}],"neutron/tests/unit/linuxbridge/test_lb_neutron_agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"9453996a9fd29a7f32e4b7f6f303b6cfcfc968d2","unresolved":false,"context_lines":[{"line_number":662,"context_line":"            if expected \u003d\u003d lconst.VXLAN_NONE:"},{"line_number":663,"context_line":"                self.assertRaises(exceptions.VxlanNetworkUnsupported,"},{"line_number":664,"context_line":"                                  self.lbm.check_vxlan_support)"},{"line_number":665,"context_line":"                self.assertEqual(expected, self.lbm.vxlan_mode)"},{"line_number":666,"context_line":"            else:"},{"line_number":667,"context_line":"                self.lbm.check_vxlan_support()"},{"line_number":668,"context_line":"                self.assertEqual(expected, self.lbm.vxlan_mode)"}],"source_content_type":"text/x-python","patch_set":30,"id":"AAAAWH%2F%2FOGw%3D","line":665,"updated":"2014-03-19 11:03:47.000000000","message":"since this is in the if and else clause, could be made unconditional and placed at end.","commit_id":"4eea1d0e310db99273398be1d77c57fcd8197f78"}],"neutron/tests/unit/test_security_groups_rpc.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8363d868d209feca42e7b88bd5cdf50d71ac69a4","unresolved":false,"context_lines":[{"line_number":1218,"context_line":"FIREWALL_NOOP_DRIVER \u003d \u0027neutron.agent.firewall.NoopFirewallDriver\u0027"},{"line_number":1219,"context_line":""},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":"def set_firewall_driver(firewall_driver):"},{"line_number":1222,"context_line":"    cfg.CONF.set_override(\u0027firewall_driver\u0027, firewall_driver,"},{"line_number":1223,"context_line":"                          group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":1224,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FIdc%3D","side":"PARENT","line":1221,"updated":"2014-01-17 05:36:06.000000000","message":"We cannot remove it because it is used by other tests.","commit_id":"024c693effe13fe0dac0ae277c58a50a9a949415"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"f9f433c70d5e8d10707d5d7dab7342fdc2b30a84","unresolved":false,"context_lines":[{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":""},{"line_number":1484,"context_line":"class TestSecurityGroupExtensionControl(base.BaseTestCase):"},{"line_number":1485,"context_line":"    def test_disable_security_group_extension_noop_driver(self):"},{"line_number":1486,"context_line":"        cfg.CONF.set_override("},{"line_number":1487,"context_line":"            \u0027enable_security_group\u0027, False,"},{"line_number":1488,"context_line":"            group\u003d\u0027SECURITYGROUP\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUH%2F%2BKRQ%3D","line":1485,"updated":"2014-01-29 15:44:55.000000000","message":"tiny nit: shouldn\u0027t this be changed to:\n test_disable_security_group_extension_by_config","commit_id":"11424644e76bf9da0d0ca5ed333a2b5218627d44"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"00d69c486d500de1ed3389ec16f6e0edf950d63e","unresolved":false,"context_lines":[{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":""},{"line_number":1484,"context_line":"class TestSecurityGroupExtensionControl(base.BaseTestCase):"},{"line_number":1485,"context_line":"    def test_disable_security_group_extension_noop_driver(self):"},{"line_number":1486,"context_line":"        cfg.CONF.set_override("},{"line_number":1487,"context_line":"            \u0027enable_security_group\u0027, False,"},{"line_number":1488,"context_line":"            group\u003d\u0027SECURITYGROUP\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BpiY%3D","line":1485,"in_reply_to":"AAAAUH%2F%2BKRQ%3D","updated":"2014-02-22 16:47:17.000000000","message":"Done","commit_id":"11424644e76bf9da0d0ca5ed333a2b5218627d44"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"106773069ac3ca6411abdcf1795952803ae324f4","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"        cfg.CONF.set_override("},{"line_number":1716,"context_line":"            \u0027firewall_driver\u0027, \u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":1717,"context_line":"            group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":1718,"context_line":"        self.assertEqual(False, sg_rpc._is_valid_driver_combination())"},{"line_number":1719,"context_line":""},{"line_number":1720,"context_line":"    def test_is_invalid_drvier_combination_sg_disabled(self):"},{"line_number":1721,"context_line":"        cfg.CONF.set_override("}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAWH%2F%2F2%2FQ%3D","line":1718,"updated":"2014-03-13 10:32:00.000000000","message":"Change all these to assertTrue/assertFalse","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"b7fd5bc9f5d331281e2bcab225ec32f945a8a244","unresolved":false,"context_lines":[{"line_number":1715,"context_line":"        cfg.CONF.set_override("},{"line_number":1716,"context_line":"            \u0027firewall_driver\u0027, \u0027neutron.agent.firewall.NoopFirewallDriver\u0027,"},{"line_number":1717,"context_line":"            group\u003d\u0027SECURITYGROUP\u0027)"},{"line_number":1718,"context_line":"        self.assertEqual(False, sg_rpc._is_valid_driver_combination())"},{"line_number":1719,"context_line":""},{"line_number":1720,"context_line":"    def test_is_invalid_drvier_combination_sg_disabled(self):"},{"line_number":1721,"context_line":"        cfg.CONF.set_override("}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAWH%2F%2FzJo%3D","line":1718,"in_reply_to":"AAAAWH%2F%2F2%2FQ%3D","updated":"2014-03-13 18:28:25.000000000","message":"Done","commit_id":"b790ba014cea5ca963f911f37522740e998bf838"}],"run_tests.sh":[{"author":{"_account_id":5127,"name":"Justin Hammond","email":"runningempty@gmail.com","username":"justin-hammond"},"change_message_id":"7a00f9c252493b61e3e649feb7477f5227b2899b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"TESTRTESTS\u003d\"python -m neutron.openstack.common.lockutils python setup.py testr\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"if [ $never_venv -eq 0 ]"},{"line_number":168,"context_line":"then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAUH%2F%2FKjc%3D","line":165,"updated":"2014-01-16 20:06:32.000000000","message":"Is this intended? It wasn\u0027t mentioned in the commit.","commit_id":"6804610111b10c925dbcd08074c15e4cebef8598"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"039db6e42ee98fe3793782bc3637367ffba3564f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"}"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"TESTRTESTS\u003d\"python -m neutron.openstack.common.lockutils python setup.py testr\""},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"if [ $never_venv -eq 0 ]"},{"line_number":168,"context_line":"then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"AAAAUH%2F%2FJ4c%3D","line":165,"in_reply_to":"AAAAUH%2F%2FKjc%3D","updated":"2014-01-16 22:17:37.000000000","message":"Thank you for your taking this one.","commit_id":"6804610111b10c925dbcd08074c15e4cebef8598"}]}
