)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"ef7b57c0d8fb3056f1f13df61102f44631ed1b36","unresolved":false,"context_lines":[{"line_number":2569,"context_line":""},{"line_number":2570,"context_line":"    validate_tunnel_config(cfg.CONF.AGENT.tunnel_types, cfg.CONF.OVS.local_ip)"},{"line_number":2571,"context_line":""},{"line_number":2572,"context_line":"    init_max_tries \u003d 3"},{"line_number":2573,"context_line":"    init_try \u003d 1"},{"line_number":2574,"context_line":"    while True:"},{"line_number":2575,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_ea1e540a","line":2572,"range":{"start_line":2572,"start_character":4,"end_line":2572,"end_character":18},"updated":"2019-08-03 19:49:52.000000000","message":"nit: it is better to define a constant for this\n\nINIT_MAX_TRIES \u003d 3","commit_id":"bc4c4709e7e53935b7d90865fc13790f8a70f2b3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"88d17408ed9f7e992fd480487695c0a6805732b3","unresolved":false,"context_lines":[{"line_number":2569,"context_line":""},{"line_number":2570,"context_line":"    validate_tunnel_config(cfg.CONF.AGENT.tunnel_types, cfg.CONF.OVS.local_ip)"},{"line_number":2571,"context_line":""},{"line_number":2572,"context_line":"    init_max_tries \u003d 3"},{"line_number":2573,"context_line":"    init_try \u003d 1"},{"line_number":2574,"context_line":"    while True:"},{"line_number":2575,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a154fafe","line":2572,"range":{"start_line":2572,"start_character":4,"end_line":2572,"end_character":18},"in_reply_to":"7faddb67_ea1e540a","updated":"2019-08-05 09:18:39.000000000","message":"Done","commit_id":"bc4c4709e7e53935b7d90865fc13790f8a70f2b3"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"ef7b57c0d8fb3056f1f13df61102f44631ed1b36","unresolved":false,"context_lines":[{"line_number":2581,"context_line":"                LOG.warning(\"Ovsdb command timeout!\")"},{"line_number":2582,"context_line":"                init_try +\u003d 1"},{"line_number":2583,"context_line":"            else:"},{"line_number":2584,"context_line":"                LOG.error(\"%s agent terminated after %s initialization \""},{"line_number":2585,"context_line":"                          \"attempts!\", e, init_try)"},{"line_number":2586,"context_line":"                sys.exit(1)"},{"line_number":2587,"context_line":"        except (RuntimeError, ValueError) as e:"},{"line_number":2588,"context_line":"            LOG.error(\"%s agent terminated!\", e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_4ad5281b","line":2585,"range":{"start_line":2584,"start_character":25,"end_line":2585,"end_character":51},"updated":"2019-08-03 19:49:52.000000000","message":"nit: normally, we use keyword if there are more than 1 arguments.\n\n                LOG.error(\"%(exception)s agent terminated after %(init_try)s initialization \"\n                          \"attempts!\", {\u0027exceptioin\u0027: str(e), \u0027init_try\u0027: init_try})","commit_id":"bc4c4709e7e53935b7d90865fc13790f8a70f2b3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"88d17408ed9f7e992fd480487695c0a6805732b3","unresolved":false,"context_lines":[{"line_number":2581,"context_line":"                LOG.warning(\"Ovsdb command timeout!\")"},{"line_number":2582,"context_line":"                init_try +\u003d 1"},{"line_number":2583,"context_line":"            else:"},{"line_number":2584,"context_line":"                LOG.error(\"%s agent terminated after %s initialization \""},{"line_number":2585,"context_line":"                          \"attempts!\", e, init_try)"},{"line_number":2586,"context_line":"                sys.exit(1)"},{"line_number":2587,"context_line":"        except (RuntimeError, ValueError) as e:"},{"line_number":2588,"context_line":"            LOG.error(\"%s agent terminated!\", e)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_c157b600","line":2585,"range":{"start_line":2584,"start_character":25,"end_line":2585,"end_character":51},"in_reply_to":"7faddb67_4ad5281b","updated":"2019-08-05 09:18:39.000000000","message":"Done","commit_id":"bc4c4709e7e53935b7d90865fc13790f8a70f2b3"}]}