)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a683d380c1aa8a44294b3ff71ba4eaa4c9f5f67f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"blank value, but it looks like there is a trailing comma at the end"},{"line_number":11,"context_line":"of opt:router which causes dnsmasq adding its own ip address."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3a081f2a349d77bbd30f07ea23d047a6487ef5d2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_db3809a1","line":13,"updated":"2019-08-05 07:31:18.000000000","message":"Is there any bug reported for that? If so, please link to it here. If not, please create one - it will be easier to track backport of this fix to stable branches if that will be needed.","commit_id":"2bacacc962fff82f579ca3f8409fb920da64a663"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"46235d617a9101cb81b12440fbb63293ef1b7011","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     shenjiatong \u003cyshxxsjt715@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-26 19:10:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"remove trailing comma"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"when router is aimed to be disabled, extra-dhcp-options is given a"},{"line_number":10,"context_line":"blank value, but it looks like there is a trailing comma at the end"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7faddb67_5f2b4294","line":7,"updated":"2019-08-26 14:21:50.000000000","message":"Ok, reviewing the test I understand where the problem is.\n\nCan you provide, as requested previously, a bug report? BTW, please, add a better description in the bug report.","commit_id":"81f7eeeb0546d233a78cd0cda87fadd811ed8c44"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a683d380c1aa8a44294b3ff71ba4eaa4c9f5f67f","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"                            options.append("},{"line_number":1063,"context_line":"                                self._format_option("},{"line_number":1064,"context_line":"                                    opt_ip_version, port.id,"},{"line_number":1065,"context_line":"                                    opt.opt_name, opt.opt_value))"},{"line_number":1066,"context_line":"                    else:"},{"line_number":1067,"context_line":"                        LOG.info(\"Cannot apply dhcp option %(opt)s \""},{"line_number":1068,"context_line":"                                 \"because it\u0027s ip_version %(version)d \""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_3b4d9d3a","line":1065,"updated":"2019-08-05 07:31:18.000000000","message":"Maybe You could add some UT to cover such case?","commit_id":"2bacacc962fff82f579ca3f8409fb920da64a663"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"46235d617a9101cb81b12440fbb63293ef1b7011","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"                        continue"},{"line_number":1055,"context_line":"                    opt_ip_version \u003d opt.ip_version"},{"line_number":1056,"context_line":"                    if opt_ip_version in port_ip_versions:"},{"line_number":1057,"context_line":"                        if opt.opt_name \u003d\u003d \u0027router\u0027 and not opt.opt_value:"},{"line_number":1058,"context_line":"                            options.append("},{"line_number":1059,"context_line":"                                self._format_option(opt_ip_version, port.id,"},{"line_number":1060,"context_line":"                                                    opt.opt_name))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_c20c353b","line":1057,"updated":"2019-08-26 14:21:50.000000000","message":"This should not be solved here, but in Dnsmasq._format_option. If \"args\" argument(s) is an empty string (\"\"), this should be considered in [1]\n\n[1] https://github.com/openstack/neutron/blob/59545129e19107bad66ddc0e1d7da5b42c3a430d/neutron/agent/linux/dhcp.py#L1131","commit_id":"81f7eeeb0546d233a78cd0cda87fadd811ed8c44"}]}