)]}'
{"neutron/tests/unit/extensions/test_l3.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6168753ba7d20313311a310713eebffc8a8ae4c1","unresolved":false,"context_lines":[{"line_number":1976,"context_line":"                    ]"},{"line_number":1977,"context_line":"                    def my_publish(resource, event, trigger, payload):"},{"line_number":1978,"context_line":"                        if resource \u003d\u003d resources.ROUTER_GATEWAY and \\"},{"line_number":1979,"context_line":"                            event \u003d\u003d events.BEFORE_CREATE:"},{"line_number":1980,"context_line":"                            return exceptions.CallbackFailure("},{"line_number":1981,"context_line":"                                errors\u003derrors)"},{"line_number":1982,"context_line":"                    notify.side_effect \u003d my_publish"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_9bbc9f07","line":1979,"updated":"2019-08-07 12:44:08.000000000","message":"This will probably fail pep8 due to indentation, and if you\u0027re changing can remove the \\ and use ():\n\nif (resource \u003d\u003d ... and\n        event \u003d\u003d ...):\n    return ...","commit_id":"44ee18226bb07e414447c69e78c5d0e1ac4a7d91"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85a52c9b6c9b0443a7e2661e4f8c841e1fe5e94b","unresolved":false,"context_lines":[{"line_number":1998,"context_line":"                    self.assertEqual(r[\u0027router\u0027][\u0027id\u0027], payload.resource_id)"},{"line_number":1999,"context_line":"                    self.assertEqual(n[\u0027network\u0027][\u0027id\u0027],"},{"line_number":2000,"context_line":"                                     payload.metadata.get(\u0027network_id\u0027))"},{"line_number":2001,"context_line":"                    self.assertEqual([], payload.metadata.get(\u0027subnets\u0027))"},{"line_number":2002,"context_line":""},{"line_number":2003,"context_line":"    def test_router_add_gateway_notifications(self):"},{"line_number":2004,"context_line":"        call_count_total \u003d 4"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_10c0897c","line":2001,"updated":"2019-08-07 14:20:30.000000000","message":"I tried it locally with networking-ovn and this patch does indeed fix this test (test_router_add_gateway_no_subnet_forbidden)\n\nBut, the patch [0] also broke the test_router_add_gateway_notifications:\n\n{0} networking_ovn.tests.unit.l3.test_l3_ovn.OVNL3ExtrarouteTests.test_router_add_gateway_notifications [2.008316s] ... FAILED                                                                                     \n                                                                                                                                                                                                                   \nCaptured traceback:                                                                                                                                                                                                \n~~~~~~~~~~~~~~~~~~~                                                                                                                                                                                                \n    Traceback (most recent call last):                                                                                                                                                                             \n      File \"/tmp/networking-ovn/.tox/py27/lib/python2.7/site-packages/neutron/tests/base.py\", line 177, in func                                                                                                    \n        return f(self, *args, **kwargs)                                                                                                                                                                            \n      File \"/tmp/networking-ovn/.tox/py27/lib/python2.7/site-packages/neutron/tests/base.py\", line 177, in func                                                                                                    \n        return f(self, *args, **kwargs)                                                                                                                                                                            \n      File \"/tmp/networking-ovn/.tox/py27/lib/python2.7/site-packages/neutron/tests/unit/extensions/test_l3.py\", line 2016, in test_router_add_gateway_notifications                                               \n        notify.call_count)                                                                                                                                                                                         \n      File \"/tmp/networking-ovn/.tox/py27/lib/python2.7/site-packages/testtools/testcase.py\", line 411, in assertEqual                                                                                             \n        self.assertThat(observed, matcher, message)                                                                                                                                                                \n      File \"/tmp/networking-ovn/.tox/py27/lib/python2.7/site-packages/testtools/testcase.py\", line 498, in assertThat                                                                                              \n        raise mismatch_error                                                                                                                                                                                       \n    testtools.matchers._impl.MismatchError: 4 !\u003d 5\n\n[0] https://review.opendev.org/#/c/638274/","commit_id":"eb745322c5cff55eaf78321d5746aa0b8cc6a118"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c70943c7e159fb76ebc9327ff55fd63539bda4d4","unresolved":false,"context_lines":[{"line_number":1998,"context_line":"                    self.assertEqual(r[\u0027router\u0027][\u0027id\u0027], payload.resource_id)"},{"line_number":1999,"context_line":"                    self.assertEqual(n[\u0027network\u0027][\u0027id\u0027],"},{"line_number":2000,"context_line":"                                     payload.metadata.get(\u0027network_id\u0027))"},{"line_number":2001,"context_line":"                    self.assertEqual([], payload.metadata.get(\u0027subnets\u0027))"},{"line_number":2002,"context_line":""},{"line_number":2003,"context_line":"    def test_router_add_gateway_notifications(self):"},{"line_number":2004,"context_line":"        call_count_total \u003d 4"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_f0cccd8b","line":2001,"in_reply_to":"7faddb67_10c0897c","updated":"2019-08-07 14:41:25.000000000","message":"i haven\u0027t noticed test_router_add_gateway_notifications failure as midonet skips it for an unrelated reason.\n\nmaybe PS5 fixes it. (i haven\u0027t tested)","commit_id":"eb745322c5cff55eaf78321d5746aa0b8cc6a118"}]}