)]}'
{"neutron/api/rpc/handlers/l3_rpc.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"54a937e0ce609221b71d6626daae0553dd62d86b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        router_ids \u003d kwargs.get(\u0027router_ids\u0027)"},{"line_number":117,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":118,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":119,"context_line":"        LOG.debug(\u0027Synch routers for ids %(router_ids)s in %(host)s\u0027,"},{"line_number":120,"context_line":"                  {\u0027router_ids\u0027: router_ids,"},{"line_number":121,"context_line":"                   \u0027host\u0027: host})"},{"line_number":122,"context_line":"        routers \u003d self._routers_to_sync(context, router_ids, host)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_c84e7ac0","line":119,"range":{"start_line":119,"start_character":19,"end_line":119,"end_character":24},"updated":"2019-10-07 15:33:52.000000000","message":"Nittiest of the nits: the \"h\" is usually omitted so \"synchronize\" and it\u0027s variants typically contract to \"sync\".","commit_id":"a65fb17544f3c2e5f212c8fe52967765cfbc0f2c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d8d7b4eff0a224078552ec8ae6c13eb63c951dac","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        router_ids \u003d kwargs.get(\u0027router_ids\u0027)"},{"line_number":117,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":118,"context_line":"        context \u003d neutron_context.get_admin_context()"},{"line_number":119,"context_line":"        LOG.debug(\u0027Synch routers for ids %(router_ids)s in %(host)s\u0027,"},{"line_number":120,"context_line":"                  {\u0027router_ids\u0027: router_ids,"},{"line_number":121,"context_line":"                   \u0027host\u0027: host})"},{"line_number":122,"context_line":"        routers \u003d self._routers_to_sync(context, router_ids, host)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e8023d6f","line":119,"range":{"start_line":119,"start_character":19,"end_line":119,"end_character":24},"in_reply_to":"3fa7e38b_c84e7ac0","updated":"2019-10-08 17:12:23.000000000","message":"Done","commit_id":"a65fb17544f3c2e5f212c8fe52967765cfbc0f2c"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"54a937e0ce609221b71d6626daae0553dd62d86b","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        pf_plugin \u003d directory.get_plugin(plugin_constants.PORTFORWARDING)"},{"line_number":129,"context_line":"        if pf_plugin:"},{"line_number":130,"context_line":"            pf_plugin.sync_port_forwarding_fip(context, routers)"},{"line_number":131,"context_line":"        LOG.debug(\u0027For router ids %(router_ids)s in %(host)s returning \u0027"},{"line_number":132,"context_line":"                  \u0027%(routers)s\u0027, {\u0027router_ids\u0027: router_ids,"},{"line_number":133,"context_line":"                                  \u0027host\u0027: host,"},{"line_number":134,"context_line":"                                  \u0027routers\u0027: routers})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_08da52e8","line":131,"range":{"start_line":131,"start_character":19,"end_line":131,"end_character":33},"updated":"2019-10-07 15:33:52.000000000","message":"What is going on here?  I always try to make sure that just in case log messages prove useful they are in a state to keep around, and in this case I think it would be good to say more explicitly what this data is.","commit_id":"a65fb17544f3c2e5f212c8fe52967765cfbc0f2c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a6f1cced659ac98f68763e08b6de7030cd13f0ee","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        pf_plugin \u003d directory.get_plugin(plugin_constants.PORTFORWARDING)"},{"line_number":129,"context_line":"        if pf_plugin:"},{"line_number":130,"context_line":"            pf_plugin.sync_port_forwarding_fip(context, routers)"},{"line_number":131,"context_line":"        LOG.debug(\u0027For router ids %(router_ids)s in %(host)s returning \u0027"},{"line_number":132,"context_line":"                  \u0027%(routers)s\u0027, {\u0027router_ids\u0027: router_ids,"},{"line_number":133,"context_line":"                                  \u0027host\u0027: host,"},{"line_number":134,"context_line":"                                  \u0027routers\u0027: routers})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a81c5e77","line":131,"range":{"start_line":131,"start_character":19,"end_line":131,"end_character":33},"in_reply_to":"3fa7e38b_08da52e8","updated":"2019-10-07 15:43:50.000000000","message":"Yeah, maybe something like \"Routers to sync in host %s are: %s\" or something similar.","commit_id":"a65fb17544f3c2e5f212c8fe52967765cfbc0f2c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d8d7b4eff0a224078552ec8ae6c13eb63c951dac","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        pf_plugin \u003d directory.get_plugin(plugin_constants.PORTFORWARDING)"},{"line_number":129,"context_line":"        if pf_plugin:"},{"line_number":130,"context_line":"            pf_plugin.sync_port_forwarding_fip(context, routers)"},{"line_number":131,"context_line":"        LOG.debug(\u0027For router ids %(router_ids)s in %(host)s returning \u0027"},{"line_number":132,"context_line":"                  \u0027%(routers)s\u0027, {\u0027router_ids\u0027: router_ids,"},{"line_number":133,"context_line":"                                  \u0027host\u0027: host,"},{"line_number":134,"context_line":"                                  \u0027routers\u0027: routers})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_e8855dd0","line":131,"range":{"start_line":131,"start_character":19,"end_line":131,"end_character":33},"in_reply_to":"3fa7e38b_a81c5e77","updated":"2019-10-08 17:12:23.000000000","message":"Done","commit_id":"a65fb17544f3c2e5f212c8fe52967765cfbc0f2c"}],"neutron/db/l3_dvrscheduler_db.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a6f1cced659ac98f68763e08b6de7030cd13f0ee","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            context, agent_db, router_ids, with_dvr))"},{"line_number":412,"context_line":"        if not with_dvr:"},{"line_number":413,"context_line":"            return result_set"},{"line_number":414,"context_line":"        LOG.debug(\"Routers with IDs %(router_ids)s bound to L3 agent in host \""},{"line_number":415,"context_line":"                  \"%(host)s\","},{"line_number":416,"context_line":"                  {\u0027router_ids\u0027: result_set,"},{"line_number":417,"context_line":"                   \u0027host\u0027: agent_db[\u0027host\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_28086e2b","line":414,"range":{"start_line":414,"start_character":27,"end_line":414,"end_character":35},"updated":"2019-10-07 15:43:50.000000000","message":"nitty nit: IMO this is not necessary. Message like \"Routers [xx, yy, zz] bound to ...\" would be also good for me.","commit_id":"a65fb17544f3c2e5f212c8fe52967765cfbc0f2c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d8d7b4eff0a224078552ec8ae6c13eb63c951dac","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            context, agent_db, router_ids, with_dvr))"},{"line_number":412,"context_line":"        if not with_dvr:"},{"line_number":413,"context_line":"            return result_set"},{"line_number":414,"context_line":"        LOG.debug(\"Routers with IDs %(router_ids)s bound to L3 agent in host \""},{"line_number":415,"context_line":"                  \"%(host)s\","},{"line_number":416,"context_line":"                  {\u0027router_ids\u0027: result_set,"},{"line_number":417,"context_line":"                   \u0027host\u0027: agent_db[\u0027host\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_684acdac","line":414,"range":{"start_line":414,"start_character":27,"end_line":414,"end_character":35},"in_reply_to":"3fa7e38b_28086e2b","updated":"2019-10-08 17:12:23.000000000","message":"Done","commit_id":"a65fb17544f3c2e5f212c8fe52967765cfbc0f2c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a6f1cced659ac98f68763e08b6de7030cd13f0ee","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                                    list(subnet_ids))):"},{"line_number":442,"context_line":"                        result_set.add(router_id)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            LOG.debug(\"Routers with IDs %(router_ids)s are scheduled or have \""},{"line_number":445,"context_line":"                      \"serviceable ports in host %(host)s\","},{"line_number":446,"context_line":"                      {\u0027router_ids\u0027: result_set,"},{"line_number":447,"context_line":"                       \u0027host\u0027: agent_db[\u0027host\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_c8067a21","line":444,"range":{"start_line":444,"start_character":31,"end_line":444,"end_character":39},"updated":"2019-10-07 15:43:50.000000000","message":"same nitty nit here","commit_id":"a65fb17544f3c2e5f212c8fe52967765cfbc0f2c"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d8d7b4eff0a224078552ec8ae6c13eb63c951dac","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                                    list(subnet_ids))):"},{"line_number":442,"context_line":"                        result_set.add(router_id)"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"            LOG.debug(\"Routers with IDs %(router_ids)s are scheduled or have \""},{"line_number":445,"context_line":"                      \"serviceable ports in host %(host)s\","},{"line_number":446,"context_line":"                      {\u0027router_ids\u0027: result_set,"},{"line_number":447,"context_line":"                       \u0027host\u0027: agent_db[\u0027host\u0027]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_88daa9e6","line":444,"range":{"start_line":444,"start_character":31,"end_line":444,"end_character":39},"in_reply_to":"3fa7e38b_c8067a21","updated":"2019-10-08 17:12:23.000000000","message":"Done","commit_id":"a65fb17544f3c2e5f212c8fe52967765cfbc0f2c"}]}