)]}'
{"neutron/agent/dhcp/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d69391a27d7987a0b466134a1d7088ec089329b4","unresolved":false,"context_lines":[{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    def get_dhcp_port(self, port_id):"},{"line_number":780,"context_line":"        \"\"\"Make a remote process call to retrieve the dhcp port.\"\"\""},{"line_number":781,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.1\u0027)"},{"line_number":782,"context_line":"        port \u003d cctxt.call(self.context, \u0027get_dhcp_port\u0027, port_id\u003dport_id)"},{"line_number":783,"context_line":"        if port:"},{"line_number":784,"context_line":"            return dhcp.DictModel(port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a7979c45","line":781,"updated":"2019-08-28 16:07:28.000000000","message":"Don\u0027t we have to bump the rpc version to 1.8 for this?  It\u0027s not in 1.1","commit_id":"691f712e4e6483581aeac383b30d94043135ecbe"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"03c72ead5334494d49e636761064e5063b98e52f","unresolved":false,"context_lines":[{"line_number":778,"context_line":""},{"line_number":779,"context_line":"    def get_dhcp_port(self, port_id):"},{"line_number":780,"context_line":"        \"\"\"Make a remote process call to retrieve the dhcp port.\"\"\""},{"line_number":781,"context_line":"        cctxt \u003d self.client.prepare(version\u003d\u00271.1\u0027)"},{"line_number":782,"context_line":"        port \u003d cctxt.call(self.context, \u0027get_dhcp_port\u0027, port_id\u003dport_id)"},{"line_number":783,"context_line":"        if port:"},{"line_number":784,"context_line":"            return dhcp.DictModel(port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_69df2f66","line":781,"in_reply_to":"7faddb67_a7979c45","updated":"2019-08-29 08:55:09.000000000","message":"Upsss","commit_id":"691f712e4e6483581aeac383b30d94043135ecbe"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d69391a27d7987a0b466134a1d7088ec089329b4","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"        \"\"\"Check if DHCP port IPs are in the range of the DHCP subnets"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"        FIXME(kevinbenton): ensure we have the IPs we actually need."},{"line_number":1398,"context_line":"        can be removed once bug/1627480 is fixed"},{"line_number":1399,"context_line":"        \"\"\""},{"line_number":1400,"context_line":"        if self.driver.use_gateway_ips:"},{"line_number":1401,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_27b72cf8","line":1398,"updated":"2019-08-28 16:07:28.000000000","message":"So I guess the bug isn\u0027t fixed :(","commit_id":"691f712e4e6483581aeac383b30d94043135ecbe"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"03c72ead5334494d49e636761064e5063b98e52f","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"        \"\"\"Check if DHCP port IPs are in the range of the DHCP subnets"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"        FIXME(kevinbenton): ensure we have the IPs we actually need."},{"line_number":1398,"context_line":"        can be removed once bug/1627480 is fixed"},{"line_number":1399,"context_line":"        \"\"\""},{"line_number":1400,"context_line":"        if self.driver.use_gateway_ips:"},{"line_number":1401,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_a9d52749","line":1398,"in_reply_to":"7faddb67_27b72cf8","updated":"2019-08-29 08:55:09.000000000","message":"No and in 1841636 I reported a possible extension to this bug. This port information, given at the beginning of this DHCP setup, is not complete (but the port \"fixed_ips\" are correct!!).","commit_id":"691f712e4e6483581aeac383b30d94043135ecbe"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"178eeebe66150a4a0368b509b4fc9a93cba72c88","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"        \"\"\"Check if DHCP port IPs are in the range of the DHCP subnets"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"        FIXME(kevinbenton): ensure we have the IPs we actually need."},{"line_number":1398,"context_line":"        can be removed once bug/1627480 is fixed"},{"line_number":1399,"context_line":"        \"\"\""},{"line_number":1400,"context_line":"        if self.driver.use_gateway_ips:"},{"line_number":1401,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_e3db0ce7","line":1398,"updated":"2019-09-02 12:28:17.000000000","message":"bug https://bugs.launchpad.net/neutron/+bug/1627480 is marked as fixed already. So should we reopen it or maybe we can remove what Kevin mentioned here already?","commit_id":"eac1c898c6550cef704d96fe802662a299789343"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a03e00ef62274cba8e5136312b818aab51d96a40","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"        \"\"\"Check if DHCP port IPs are in the range of the DHCP subnets"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"        FIXME(kevinbenton): ensure we have the IPs we actually need."},{"line_number":1398,"context_line":"        can be removed once bug/1627480 is fixed"},{"line_number":1399,"context_line":"        \"\"\""},{"line_number":1400,"context_line":"        if self.driver.use_gateway_ips:"},{"line_number":1401,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_ee6e9362","line":1398,"in_reply_to":"7faddb67_ae797b93","updated":"2019-09-02 13:02:16.000000000","message":"So IMO we should reopen this bug with comment why we are doing this. Otherwise, those comments are a bit missleading.","commit_id":"eac1c898c6550cef704d96fe802662a299789343"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a30cf01b74e514445dfbfbec14b4cc528148fcc2","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"        \"\"\"Check if DHCP port IPs are in the range of the DHCP subnets"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"        FIXME(kevinbenton): ensure we have the IPs we actually need."},{"line_number":1398,"context_line":"        can be removed once bug/1627480 is fixed"},{"line_number":1399,"context_line":"        \"\"\""},{"line_number":1400,"context_line":"        if self.driver.use_gateway_ips:"},{"line_number":1401,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_ae797b93","line":1398,"in_reply_to":"7faddb67_e3db0ce7","updated":"2019-09-02 12:44:03.000000000","message":"A patch with tag \"closed-bug\" was submitted, but the bug is not solved. The patch submitted was a workaround to handle the situation when the port.fixed_ips don\u0027t match the DHCP subnets (what implies SubnetMismatchForPort).\n\nIMO, because the root cause is not fixed nor mitigated, we should keep it.\n\nAbout reopening the bug, I have no opinion on that.","commit_id":"eac1c898c6550cef704d96fe802662a299789343"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3d5e40903097ef01dc32192f9e5b430e2828ebe7","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"        \"\"\"Check if DHCP port IPs are in the range of the DHCP subnets"},{"line_number":1396,"context_line":""},{"line_number":1397,"context_line":"        FIXME(kevinbenton): ensure we have the IPs we actually need."},{"line_number":1398,"context_line":"        can be removed once bug/1627480 is fixed"},{"line_number":1399,"context_line":"        \"\"\""},{"line_number":1400,"context_line":"        if self.driver.use_gateway_ips:"},{"line_number":1401,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_ee8d2531","line":1398,"in_reply_to":"7faddb67_ee6e9362","updated":"2019-09-05 15:57:22.000000000","message":"Agree, we should reopen it again","commit_id":"eac1c898c6550cef704d96fe802662a299789343"}],"neutron/api/rpc/handlers/dhcp_rpc.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"99d7073ee00d1781b1119fe82c7c34c8334d037e","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        \"\"\"Retrieve the DHCP port\"\"\""},{"line_number":320,"context_line":"        port_id \u003d kwargs.get(\u0027port_id\u0027)"},{"line_number":321,"context_line":"        plugin \u003d directory.get_plugin()"},{"line_number":322,"context_line":"        return plugin.get_port(context, port_id)"},{"line_number":323,"context_line":""},{"line_number":324,"context_line":"    @db_api.retry_db_errors"},{"line_number":325,"context_line":"    def dhcp_ready_on_ports(self, context, port_ids):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_6cfb487a","line":322,"updated":"2019-09-05 16:28:56.000000000","message":"It\u0027s probably unlikely due to the fact the RPC call will come from a DHCP agent that is only handling DHCP ports and it knows the UUID, but what happens if this is called to pull a port that isn\u0027t a DHCP port? This is effectively a get_port() call. More of a nit than anything, but something that stood out to me.","commit_id":"eac1c898c6550cef704d96fe802662a299789343"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"178eeebe66150a4a0368b509b4fc9a93cba72c88","unresolved":false,"context_lines":[{"line_number":1907,"context_line":"                          \u0027device_id\u0027: mock.ANY}})])"},{"line_number":1908,"context_line":""},{"line_number":1909,"context_line":"    def test__check_dhcp_port_subnet(self):"},{"line_number":1910,"context_line":"        # this can go away once bug/1627480 is fixed"},{"line_number":1911,"context_line":"        plugin \u003d mock.Mock()"},{"line_number":1912,"context_line":"        fake_port_copy \u003d copy.deepcopy(fake_port1)"},{"line_number":1913,"context_line":"        fake_port_copy.fixed_ips \u003d [fake_fixed_ip1, fake_fixed_ip_subnet2]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_23ffe434","line":1910,"updated":"2019-09-02 12:28:17.000000000","message":"this bug is marked as fixed already :)","commit_id":"eac1c898c6550cef704d96fe802662a299789343"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a30cf01b74e514445dfbfbec14b4cc528148fcc2","unresolved":false,"context_lines":[{"line_number":1907,"context_line":"                          \u0027device_id\u0027: mock.ANY}})])"},{"line_number":1908,"context_line":""},{"line_number":1909,"context_line":"    def test__check_dhcp_port_subnet(self):"},{"line_number":1910,"context_line":"        # this can go away once bug/1627480 is fixed"},{"line_number":1911,"context_line":"        plugin \u003d mock.Mock()"},{"line_number":1912,"context_line":"        fake_port_copy \u003d copy.deepcopy(fake_port1)"},{"line_number":1913,"context_line":"        fake_port_copy.fixed_ips \u003d [fake_fixed_ip1, fake_fixed_ip_subnet2]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_6e6f03c4","line":1910,"in_reply_to":"7faddb67_23ffe434","updated":"2019-09-02 12:44:03.000000000","message":"As commented, the bug is not solved. The patch submitted was a workaround but the root cause is still there.","commit_id":"eac1c898c6550cef704d96fe802662a299789343"}]}