)]}'
{"neutron/privileged/agent/linux/ip_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"4a0388e161f83fbb5c718e3bab63e91389a90da4","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    \"\"\"List namespace process PIDs\"\"\""},{"line_number":195,"context_line":"    # NOTE(ralonsoh): until https://github.com/svinota/pyroute2/issues/633 is"},{"line_number":196,"context_line":"    # fixed, we should keep this retry loop."},{"line_number":197,"context_line":"    for idx in range(MAX_RETRIES):"},{"line_number":198,"context_line":"        try:"},{"line_number":199,"context_line":"            return netns.ns_pids().get(namespace, [])"},{"line_number":200,"context_line":"        except OSError as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_89a06b93","line":197,"updated":"2019-08-29 09:15:10.000000000","message":"in (very rare) corner case it may happend that during every retry another namespace will be deleted so if there will be more namespaces than MAX_RETRIES, it will fail again.\nSo MAX_RETRIES should be set to number of namespaces + 1 at every time.\nBut this is IMO some theoretical problem and IMO there is no need to do it like that :)","commit_id":"7ea4dc2c04e157d9ed3cd9582e20e53d4a74933e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f9cd202476cf45665f0f2c591277a98037930b16","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    \"\"\"List namespace process PIDs\"\"\""},{"line_number":195,"context_line":"    # NOTE(ralonsoh): until https://github.com/svinota/pyroute2/issues/633 is"},{"line_number":196,"context_line":"    # fixed, we should keep this retry loop."},{"line_number":197,"context_line":"    for idx in range(MAX_RETRIES):"},{"line_number":198,"context_line":"        try:"},{"line_number":199,"context_line":"            return netns.ns_pids().get(namespace, [])"},{"line_number":200,"context_line":"        except OSError as e:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_14bd72d6","line":197,"in_reply_to":"7faddb67_89a06b93","updated":"2019-08-29 10:01:05.000000000","message":"You are right, but this should be considered as a corner case as you commented. Once the issue in pyroute2 is fixed, we can remove this.\n\nBTW, I\u0027ve seen this problem several times the last two days.","commit_id":"7ea4dc2c04e157d9ed3cd9582e20e53d4a74933e"}]}