)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e8738444cea0f8b36db3c44562346875d3c12cc1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"with segmentation id outside of range available for specified"},{"line_number":14,"context_line":"physical network."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit fixes this issue by validating properly segmentation_id"},{"line_number":17,"context_line":"in vlan type driver. It is now always checked if segmentation_id is"},{"line_number":18,"context_line":"inside configed vlan ranges or in (MIN_VLAN_TAG, MAX_VLAN_TAG) range"},{"line_number":19,"context_line":"if no other ranges are specified for physical network."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_cc7e581a","line":17,"range":{"start_line":16,"start_character":32,"end_line":17,"end_character":19},"updated":"2019-08-30 13:48:36.000000000","message":"nit: I think this should be a better wording, but let\u0027s see native english speakers\u0027 opinion\n\" validating the segmentation_id by the vlan type driver.\"","commit_id":"5ba2393790da5a51cf2b2837c6acd5f29804ebb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"736b1dbed4f69cf91c2f4d47aea41ab38a33b904","unresolved":false,"context_lines":[{"line_number":13,"context_line":"with segmentation id outside of range available for specified"},{"line_number":14,"context_line":"physical network."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit fixes this issue by validating properly segmentation_id"},{"line_number":17,"context_line":"in vlan type driver. It is now always checked if segmentation_id is"},{"line_number":18,"context_line":"inside configed vlan ranges or in (MIN_VLAN_TAG, MAX_VLAN_TAG) range"},{"line_number":19,"context_line":"if no other ranges are specified for physical network."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_d30ef03b","line":17,"range":{"start_line":16,"start_character":32,"end_line":17,"end_character":19},"in_reply_to":"7faddb67_cc7e581a","updated":"2019-08-30 20:34:09.000000000","message":"Done","commit_id":"5ba2393790da5a51cf2b2837c6acd5f29804ebb5"}],"neutron/plugins/ml2/drivers/type_vlan.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ec359d36b43b8b6f22616291f90b235ac8a3047b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    @staticmethod"},{"line_number":61,"context_line":"    def _validate_segmentation_id(segmentation_id, ranges):"},{"line_number":62,"context_line":"        if not ranges:"},{"line_number":63,"context_line":"            ranges \u003d [(p_const.MIN_VLAN_TAG, p_const.MAX_VLAN_TAG)]"},{"line_number":64,"context_line":"        valid \u003d any(plugin_utils._is_valid_range(segmentation_id, lo, hi)"},{"line_number":65,"context_line":"                    for lo, hi in ranges)"},{"line_number":66,"context_line":"        if not valid:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_676f3d60","line":63,"updated":"2019-08-30 14:18:03.000000000","message":"Is there a test for this case where ranges aren\u0027t given?","commit_id":"5ba2393790da5a51cf2b2837c6acd5f29804ebb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"736b1dbed4f69cf91c2f4d47aea41ab38a33b904","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    @staticmethod"},{"line_number":61,"context_line":"    def _validate_segmentation_id(segmentation_id, ranges):"},{"line_number":62,"context_line":"        if not ranges:"},{"line_number":63,"context_line":"            ranges \u003d [(p_const.MIN_VLAN_TAG, p_const.MAX_VLAN_TAG)]"},{"line_number":64,"context_line":"        valid \u003d any(plugin_utils._is_valid_range(segmentation_id, lo, hi)"},{"line_number":65,"context_line":"                    for lo, hi in ranges)"},{"line_number":66,"context_line":"        if not valid:"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_d3403062","line":63,"in_reply_to":"7faddb67_676f3d60","updated":"2019-08-30 20:34:09.000000000","message":"yes, there are such UT already","commit_id":"5ba2393790da5a51cf2b2837c6acd5f29804ebb5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ec359d36b43b8b6f22616291f90b235ac8a3047b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        valid \u003d any(plugin_utils._is_valid_range(segmentation_id, lo, hi)"},{"line_number":65,"context_line":"                    for lo, hi in ranges)"},{"line_number":66,"context_line":"        if not valid:"},{"line_number":67,"context_line":"            msg \u003d _(\"segmentation_id out of ranges: %s\") % ranges"},{"line_number":68,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @db_api.retry_db_errors"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_07bbe9e4","line":67,"range":{"start_line":67,"start_character":44,"end_line":67,"end_character":50},"updated":"2019-08-30 14:18:03.000000000","message":"s/range","commit_id":"5ba2393790da5a51cf2b2837c6acd5f29804ebb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"736b1dbed4f69cf91c2f4d47aea41ab38a33b904","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        valid \u003d any(plugin_utils._is_valid_range(segmentation_id, lo, hi)"},{"line_number":65,"context_line":"                    for lo, hi in ranges)"},{"line_number":66,"context_line":"        if not valid:"},{"line_number":67,"context_line":"            msg \u003d _(\"segmentation_id out of ranges: %s\") % ranges"},{"line_number":68,"context_line":"            raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @db_api.retry_db_errors"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b35b3452","line":67,"range":{"start_line":67,"start_character":44,"end_line":67,"end_character":50},"in_reply_to":"7faddb67_07bbe9e4","updated":"2019-08-30 20:34:09.000000000","message":"Done","commit_id":"5ba2393790da5a51cf2b2837c6acd5f29804ebb5"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ec359d36b43b8b6f22616291f90b235ac8a3047b","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                msg \u003d (_(\"physical_network \u0027%s\u0027 unknown \""},{"line_number":252,"context_line":"                         \"for VLAN provider network\") % physical_network)"},{"line_number":253,"context_line":"                raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":254,"context_line":"            physical_network_ranges \u003d ranges[physical_network]"},{"line_number":255,"context_line":"            if segmentation_id:"},{"line_number":256,"context_line":"                self._validate_segmentation_id(segmentation_id,"},{"line_number":257,"context_line":"                                               physical_network_ranges)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_07a0c9a4","line":254,"updated":"2019-08-30 14:18:03.000000000","message":"nit: this could be inside the if(), and can probably just used ranges[] directly as the variable isn\u0027t used afterwards","commit_id":"5ba2393790da5a51cf2b2837c6acd5f29804ebb5"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"736b1dbed4f69cf91c2f4d47aea41ab38a33b904","unresolved":false,"context_lines":[{"line_number":251,"context_line":"                msg \u003d (_(\"physical_network \u0027%s\u0027 unknown \""},{"line_number":252,"context_line":"                         \"for VLAN provider network\") % physical_network)"},{"line_number":253,"context_line":"                raise exc.InvalidInput(error_message\u003dmsg)"},{"line_number":254,"context_line":"            physical_network_ranges \u003d ranges[physical_network]"},{"line_number":255,"context_line":"            if segmentation_id:"},{"line_number":256,"context_line":"                self._validate_segmentation_id(segmentation_id,"},{"line_number":257,"context_line":"                                               physical_network_ranges)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_f33a0ce4","line":254,"in_reply_to":"7faddb67_07a0c9a4","updated":"2019-08-30 20:34:09.000000000","message":"Done","commit_id":"5ba2393790da5a51cf2b2837c6acd5f29804ebb5"}]}