)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1fda43e037f926f98500e98caa0189c89e997ff1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix \u0027test_get_devices_info_veth_different_namespaces\u0027 failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is already a separate interface or bridge in namespace,"},{"line_number":10,"context_line":"adding an interface to namespace will result in a link device by default."},{"line_number":11,"context_line":"Closes-Bug: #1842482"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4c8ffb258a3e1ef6c30f27eb0a1ead2de6f208a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_075bb485","line":10,"updated":"2019-09-04 08:24:54.000000000","message":"This is not solving the problem. When a test is executed, the namespace self.namespace is recreated with a differenciated name.\n\nThis example is just creating the veth interfaces in other namespaces.\n\nIn the namespaces the only interface created is \"lo\".\n\nIn veth interfaces, the link device should be the other veth pair, but only in this interface is in the same namespace. If not, the interface index is irrelevant for the first one because is referring to other namespace with other index table.","commit_id":"b5d0cf92b72dc485e0e0b64025b88fd783ce02bc"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"5527f5cc431fc81295144383e9fc23876f799c19","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix \u0027test_get_devices_info_veth_different_namespaces\u0027 failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is already a separate interface or bridge in namespace,"},{"line_number":10,"context_line":"adding an interface to namespace will result in a link device by default."},{"line_number":11,"context_line":"Closes-Bug: #1842482"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4c8ffb258a3e1ef6c30f27eb0a1ead2de6f208a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_b2c54090","line":10,"in_reply_to":"7faddb67_075bb485","updated":"2019-09-04 08:43:05.000000000","message":"The self.namespace is created in setup, and the namespace is reused, the interface is not just \"lo\"，resulting in an unrelated index.","commit_id":"b5d0cf92b72dc485e0e0b64025b88fd783ce02bc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3463d0c11d13383410bf8409cf8e808fdc213dfe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix \u0027test_get_devices_info_veth_different_namespaces\u0027 failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is already a separate interface or bridge in namespace,"},{"line_number":10,"context_line":"adding an interface to namespace will result in a link device by default."},{"line_number":11,"context_line":"Closes-Bug: #1842482"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4c8ffb258a3e1ef6c30f27eb0a1ead2de6f208a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_727ca8b5","line":10,"in_reply_to":"7faddb67_3295d0e4","updated":"2019-09-04 09:27:34.000000000","message":"As I said, other test cases are irrelevant. Each test case is independent.\n\nThe IFLA_NAME is the own interface name, this is not related to IFLA_LINK, the veth pair link index.","commit_id":"b5d0cf92b72dc485e0e0b64025b88fd783ce02bc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c444faa66763f417e8fa35119495f37dd67f2330","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix \u0027test_get_devices_info_veth_different_namespaces\u0027 failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is already a separate interface or bridge in namespace,"},{"line_number":10,"context_line":"adding an interface to namespace will result in a link device by default."},{"line_number":11,"context_line":"Closes-Bug: #1842482"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4c8ffb258a3e1ef6c30f27eb0a1ead2de6f208a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_8d2ca593","line":10,"in_reply_to":"7faddb67_52340cfb","updated":"2019-09-04 09:36:25.000000000","message":"That\u0027s not correct. Please, prove this statement.","commit_id":"b5d0cf92b72dc485e0e0b64025b88fd783ce02bc"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"f0d80d0a4791280c8d80909fee5c859180fb82fe","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix \u0027test_get_devices_info_veth_different_namespaces\u0027 failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is already a separate interface or bridge in namespace,"},{"line_number":10,"context_line":"adding an interface to namespace will result in a link device by default."},{"line_number":11,"context_line":"Closes-Bug: #1842482"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4c8ffb258a3e1ef6c30f27eb0a1ead2de6f208a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_52340cfb","line":10,"in_reply_to":"7faddb67_727ca8b5","updated":"2019-09-04 09:33:09.000000000","message":"yes, I know, But if there are already other interfaces, it will lead to the wrong link device. In fact, in this case it should be None.","commit_id":"b5d0cf92b72dc485e0e0b64025b88fd783ce02bc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"96b83920b4060da79318f6ce7e3d4048000d253b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix \u0027test_get_devices_info_veth_different_namespaces\u0027 failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is already a separate interface or bridge in namespace,"},{"line_number":10,"context_line":"adding an interface to namespace will result in a link device by default."},{"line_number":11,"context_line":"Closes-Bug: #1842482"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4c8ffb258a3e1ef6c30f27eb0a1ead2de6f208a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_f2573859","line":10,"in_reply_to":"7faddb67_b2c54090","updated":"2019-09-04 09:14:46.000000000","message":"When is this namespace reused in this test case?\n\nRemember each test case is different and each test case will execute, independently, the setUp() method and will create a different self.namespace","commit_id":"b5d0cf92b72dc485e0e0b64025b88fd783ce02bc"},{"author":{"_account_id":29157,"name":"zhanghao","email":"hao.zhang.am.i@gmail.com","username":"zhanghao2"},"change_message_id":"d3fbe1103a8093dd529c6ccbd5d75454191b763a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix \u0027test_get_devices_info_veth_different_namespaces\u0027 failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is already a separate interface or bridge in namespace,"},{"line_number":10,"context_line":"adding an interface to namespace will result in a link device by default."},{"line_number":11,"context_line":"Closes-Bug: #1842482"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I4c8ffb258a3e1ef6c30f27eb0a1ead2de6f208a7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7faddb67_3295d0e4","line":10,"in_reply_to":"7faddb67_f2573859","updated":"2019-09-04 09:22:27.000000000","message":"I mean in one test case，you can print device IFLA_IFNAME, there are other interfaces.","commit_id":"b5d0cf92b72dc485e0e0b64025b88fd783ce02bc"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"31c338e8a9ac0e186342ea2a4dfbbb1b2e2b1f97","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     zhanghao2 \u003czhanghao2@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-08-11 19:35:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix \u0027test_get_devices_info_veth_different_namespaces\u0027 failure"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If there is already a separate interface or bridge in namespace,"},{"line_number":10,"context_line":"adding an interface to namespace will result in a link device by default."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_3ba128aa","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2019-09-04 13:45:30.000000000","message":"Actually we do not fix it now, just skip it.","commit_id":"37feef69276f58a0479b69e94de0136c1ad6ee21"}]}