)]}'
{"neutron/tests/functional/privileged/agent/linux/test_ip_lib.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3f29c6a22ae0c66d2c2765fd0f5da6e4322badaa","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        # interface link (namespace interface index) should be empty because"},{"line_number":215,"context_line":"        # this interface index do not refer to the same namespace."},{"line_number":216,"context_line":"        # https://bugs.launchpad.net/neutron/+bug/1842482"},{"line_number":217,"context_line":"        # self.assertIsNone(ip_lib.get_attr(veth1_1, \u0027IFLA_LINK\u0027))"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def test_get_devices_info_veth_same_namespaces(self):"},{"line_number":220,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(self.namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_b83e8126","line":217,"updated":"2019-09-04 11:09:20.000000000","message":"I don\u0027t understand that. The whole bug is because this attr is not None but it has value (5 usually):\n\ntesttools.matchers._impl.MismatchError: 5 is not None\n\nAnd in comment here You are saying that it \"should be empty\" and You are removing this assertion.\nIsn\u0027t it that before Your patch it was also expected that this will be emtpy and the problem now is that it isn\u0027t?\n\nAlso, if this is correct solution for this issue, You should IMO add this info from \"NOTE\" to the commit message and just remove this assertion. There is no need to keep it commented in the code.","commit_id":"48b4a7329ed6b06324a76be7bbd719fdce6ef877"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"4fbf55f4d2900b74c8385dad16628fcddb167391","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        # interface link (namespace interface index) should be empty because"},{"line_number":215,"context_line":"        # this interface index do not refer to the same namespace."},{"line_number":216,"context_line":"        # https://bugs.launchpad.net/neutron/+bug/1842482"},{"line_number":217,"context_line":"        # self.assertIsNone(ip_lib.get_attr(veth1_1, \u0027IFLA_LINK\u0027))"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def test_get_devices_info_veth_same_namespaces(self):"},{"line_number":220,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(self.namespace)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_139e9605","line":217,"in_reply_to":"7faddb67_b83e8126","updated":"2019-09-04 12:20:48.000000000","message":"That\u0027s the point, this is not correct\n\nIn a veth pair interface, IFLA_LINK is the index of the other interface, but only if the second interface is in the same namespace.\n\nThis test was implemented with this intention: to prove that if two veth pairs are in different namespaces, the IFLA_LINK parameter MUST NOT BE there.\n\nThis NOTE should remain here until we fix it (or we find the problem or we discover that this functionality has changed).","commit_id":"48b4a7329ed6b06324a76be7bbd719fdce6ef877"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"38e4d0c30a2d1235a4d4f2454f61ffc9549e535c","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        # present. We need to handle both cases."},{"line_number":224,"context_line":"        self.assertIn(ip_lib.get_attr(veth1_1, \u0027IFLA_LINK\u0027),"},{"line_number":225,"context_line":"                      [None, veth1_2[\u0027index\u0027]])"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def test_get_devices_info_veth_same_namespaces(self):"},{"line_number":229,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(self.namespace)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_8f8faf2c","line":226,"updated":"2019-09-04 18:30:41.000000000","message":"This is going to fail pep8 because of too many blank lines","commit_id":"1ea73bb189ded19c04380e27748fb4284ae93a40"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d06aced9c9bfc24d6e2a4cfbea08316dfea47eca","unresolved":false,"context_lines":[{"line_number":223,"context_line":"        # present. We need to handle both cases."},{"line_number":224,"context_line":"        self.assertIn(ip_lib.get_attr(veth1_1, \u0027IFLA_LINK\u0027),"},{"line_number":225,"context_line":"                      [None, veth1_2[\u0027index\u0027]])"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def test_get_devices_info_veth_same_namespaces(self):"},{"line_number":229,"context_line":"        ip_wrapper \u003d ip_lib.IPWrapper(self.namespace)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_afb38b99","line":226,"in_reply_to":"7faddb67_8f8faf2c","updated":"2019-09-04 18:48:48.000000000","message":"Thanks!","commit_id":"1ea73bb189ded19c04380e27748fb4284ae93a40"}]}