)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"83df4a544d5b9672c6e894722c652e5767cb6b41","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"        limit \u003d kwargs.pop(\u0027limit\u0027, None)"},{"line_number":1542,"context_line":"        filters \u003d filters or {}"},{"line_number":1543,"context_line":"        fixed_ips \u003d filters.pop(\u0027fixed_ips\u0027, {})"},{"line_number":1544,"context_line":"        mac_address \u003d filters.pop(\u0027mac_address\u0027, {})"},{"line_number":1545,"context_line":"        vif_type \u003d filters.pop(portbindings_def.VIF_TYPE, None)"},{"line_number":1546,"context_line":"        query \u003d model_query.get_collection_query(context, Port,"},{"line_number":1547,"context_line":"                                                 filters\u003dfilters,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_1ae12dff","line":1544,"range":{"start_line":1544,"start_character":49,"end_line":1544,"end_character":51},"updated":"2019-09-11 09:34:09.000000000","message":"nit: \u0027mac_address\u0027 key contains a list (of one single element). This should be []","commit_id":"141c318ec3cd8a5506f67ac71607b7e88af0e9ba"},{"author":{"_account_id":28100,"name":"Martin Midolesov","email":"mmidolesov@vmware.com","username":"martinmidolesov"},"change_message_id":"3f9df1b87565fe982d5741acafafe7ada09f6162","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"        limit \u003d kwargs.pop(\u0027limit\u0027, None)"},{"line_number":1542,"context_line":"        filters \u003d filters or {}"},{"line_number":1543,"context_line":"        fixed_ips \u003d filters.pop(\u0027fixed_ips\u0027, {})"},{"line_number":1544,"context_line":"        mac_address \u003d filters.pop(\u0027mac_address\u0027, {})"},{"line_number":1545,"context_line":"        vif_type \u003d filters.pop(portbindings_def.VIF_TYPE, None)"},{"line_number":1546,"context_line":"        query \u003d model_query.get_collection_query(context, Port,"},{"line_number":1547,"context_line":"                                                 filters\u003dfilters,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_bac1f482","line":1544,"range":{"start_line":1544,"start_character":49,"end_line":1544,"end_character":51},"in_reply_to":"5faad753_1ae12dff","updated":"2019-09-11 13:01:38.000000000","message":"I think so as fixed_ips just above - so it\u0027s not an issue as long we have proper check for \"if mac_address\".","commit_id":"141c318ec3cd8a5506f67ac71607b7e88af0e9ba"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"37d26e307978ac3b3d3f3b7b6a55ab182183008d","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"        limit \u003d kwargs.pop(\u0027limit\u0027, None)"},{"line_number":1542,"context_line":"        filters \u003d filters or {}"},{"line_number":1543,"context_line":"        fixed_ips \u003d filters.pop(\u0027fixed_ips\u0027, {})"},{"line_number":1544,"context_line":"        mac_address \u003d filters.pop(\u0027mac_address\u0027, {})"},{"line_number":1545,"context_line":"        vif_type \u003d filters.pop(portbindings_def.VIF_TYPE, None)"},{"line_number":1546,"context_line":"        query \u003d model_query.get_collection_query(context, Port,"},{"line_number":1547,"context_line":"                                                 filters\u003dfilters,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_dbdb6079","line":1544,"range":{"start_line":1544,"start_character":49,"end_line":1544,"end_character":51},"in_reply_to":"5faad753_7d55b61c","updated":"2019-09-13 11:13:35.000000000","message":"At least in in the CLI only a single MAC address is accepted in the CLI [1].\n\nBut this method is used in the plugin so no only the CLI will request it. Liu is right, this should handle several MACs.\n\n[1] https://docs.openstack.org/python-openstackclient/pike/cli/command-objects/port.html#port-list","commit_id":"141c318ec3cd8a5506f67ac71607b7e88af0e9ba"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5720b2f9d75158cda190dda762c7f28b0c8f50b2","unresolved":false,"context_lines":[{"line_number":1541,"context_line":"        limit \u003d kwargs.pop(\u0027limit\u0027, None)"},{"line_number":1542,"context_line":"        filters \u003d filters or {}"},{"line_number":1543,"context_line":"        fixed_ips \u003d filters.pop(\u0027fixed_ips\u0027, {})"},{"line_number":1544,"context_line":"        mac_address \u003d filters.pop(\u0027mac_address\u0027, {})"},{"line_number":1545,"context_line":"        vif_type \u003d filters.pop(portbindings_def.VIF_TYPE, None)"},{"line_number":1546,"context_line":"        query \u003d model_query.get_collection_query(context, Port,"},{"line_number":1547,"context_line":"                                                 filters\u003dfilters,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_7d55b61c","line":1544,"range":{"start_line":1544,"start_character":49,"end_line":1544,"end_character":51},"in_reply_to":"5faad753_bac1f482","updated":"2019-09-11 13:58:50.000000000","message":"So it should be mac_address(es), something like fixed_ip(s)?","commit_id":"141c318ec3cd8a5506f67ac71607b7e88af0e9ba"}],"releasenotes/notes/bug-1843428-mac-addres-case-insensitivity-750299c11b49a9a8.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61237899c1bd1b9f939ded9d434a9aedc3f4c3e6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When listing ports through"},{"line_number":5,"context_line":"    `openstack port list --mac-address A:B:C` command we hit case"},{"line_number":6,"context_line":"    sensitivity in terms of result when trying to list ports by"},{"line_number":7,"context_line":"    mac address. This fix makes the search based on mac address"},{"line_number":8,"context_line":"    case insensitive."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_b613545c","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":5},"updated":"2019-09-20 19:15:22.000000000","message":"These should be double `` so it shows up in bold in the note.","commit_id":"36f0a8725f668685d48aafc6b526151724aa5dd7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61237899c1bd1b9f939ded9d434a9aedc3f4c3e6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When listing ports through"},{"line_number":5,"context_line":"    `openstack port list --mac-address A:B:C` command we hit case"},{"line_number":6,"context_line":"    sensitivity in terms of result when trying to list ports by"},{"line_number":7,"context_line":"    mac address. This fix makes the search based on mac address"},{"line_number":8,"context_line":"    case insensitive."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_562c6098","line":5,"range":{"start_line":5,"start_character":39,"end_line":5,"end_character":44},"updated":"2019-09-20 19:15:22.000000000","message":"s/A:B:C:D:E:F","commit_id":"36f0a8725f668685d48aafc6b526151724aa5dd7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61237899c1bd1b9f939ded9d434a9aedc3f4c3e6","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When listing ports through"},{"line_number":5,"context_line":"    `openstack port list --mac-address A:B:C` command we hit case"},{"line_number":6,"context_line":"    sensitivity in terms of result when trying to list ports by"},{"line_number":7,"context_line":"    mac address. This fix makes the search based on mac address"},{"line_number":8,"context_line":"    case insensitive."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_764b9c58","line":6,"range":{"start_line":5,"start_character":57,"end_line":6,"end_character":34},"updated":"2019-09-20 19:15:22.000000000","message":"s/could not return any results","commit_id":"36f0a8725f668685d48aafc6b526151724aa5dd7"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"883c6aa0dd0ca6efe0ee2a28fd3262acd2f77314","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When listing ports through"},{"line_number":5,"context_line":"    `openstack port list --mac-address A:B:C` command we hit case"},{"line_number":6,"context_line":"    sensitivity in terms of result when trying to list ports by"},{"line_number":7,"context_line":"    mac address. This fix makes the search based on mac address"},{"line_number":8,"context_line":"    case insensitive."},{"line_number":9,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_0fc9c624","line":6,"range":{"start_line":5,"start_character":57,"end_line":6,"end_character":34},"in_reply_to":"3fa7e38b_764b9c58","updated":"2019-09-24 12:40:12.000000000","message":"This one is missing","commit_id":"36f0a8725f668685d48aafc6b526151724aa5dd7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61237899c1bd1b9f939ded9d434a9aedc3f4c3e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    When listing ports through"},{"line_number":5,"context_line":"    `openstack port list --mac-address A:B:C` command we hit case"},{"line_number":6,"context_line":"    sensitivity in terms of result when trying to list ports by"},{"line_number":7,"context_line":"    mac address. This fix makes the search based on mac address"},{"line_number":8,"context_line":"    case insensitive."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    .. _Bug 1843428: https://bugs.launchpad.net/neutron/+bug/1843428"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_364e846f","line":7,"range":{"start_line":7,"start_character":52,"end_line":7,"end_character":55},"updated":"2019-09-20 19:15:22.000000000","message":"s/MAC","commit_id":"36f0a8725f668685d48aafc6b526151724aa5dd7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61237899c1bd1b9f939ded9d434a9aedc3f4c3e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    When listing ports through"},{"line_number":5,"context_line":"    `openstack port list --mac-address A:B:C` command we hit case"},{"line_number":6,"context_line":"    sensitivity in terms of result when trying to list ports by"},{"line_number":7,"context_line":"    mac address. This fix makes the search based on mac address"},{"line_number":8,"context_line":"    case insensitive."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    .. _Bug 1843428: https://bugs.launchpad.net/neutron/+bug/1843428"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_b63cb4c8","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":7},"updated":"2019-09-20 19:15:22.000000000","message":"s/MAC","commit_id":"36f0a8725f668685d48aafc6b526151724aa5dd7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61237899c1bd1b9f939ded9d434a9aedc3f4c3e6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    When listing ports through"},{"line_number":5,"context_line":"    `openstack port list --mac-address A:B:C` command we hit case"},{"line_number":6,"context_line":"    sensitivity in terms of result when trying to list ports by"},{"line_number":7,"context_line":"    mac address. This fix makes the search based on mac address"},{"line_number":8,"context_line":"    case insensitive."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    .. _Bug 1843428: https://bugs.launchpad.net/neutron/+bug/1843428"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_9646584f","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"updated":"2019-09-20 19:15:22.000000000","message":"s/address if the cases differ","commit_id":"36f0a8725f668685d48aafc6b526151724aa5dd7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"61237899c1bd1b9f939ded9d434a9aedc3f4c3e6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"    mac address. This fix makes the search based on mac address"},{"line_number":8,"context_line":"    case insensitive."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    .. _Bug 1843428: https://bugs.launchpad.net/neutron/+bug/1843428"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_5603000e","line":10,"updated":"2019-09-20 19:15:22.000000000","message":"This isn\u0027t showing in the note.  Can you just add it to the paragraph above?\n\nFor more information see `bug 1843428 \u003curl\u003e`_.\n\nReplacing \u003curl\u003e of course.","commit_id":"36f0a8725f668685d48aafc6b526151724aa5dd7"}]}