)]}'
{"neutron/tests/functional/cmd/test_netns_cleanup.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"26eee09dba887690605a3f79ea23953fb6b6a67a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        to test the cleanup functionality which will issue a SIGKILL"},{"line_number":102,"context_line":"        to all remaining processes after the SIGTERM attempt"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        commands \u003d [[sys.executable, process_spawn.__file__,"},{"line_number":105,"context_line":"                     \u0027-n\u0027, NUM_SUBPROCESSES,"},{"line_number":106,"context_line":"                     \u0027-f\u0027, n_const.IPv4,"},{"line_number":107,"context_line":"                     \u0027-p\u0027, n_const.PROTO_NAME_TCP,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_1de02727","line":104,"updated":"2019-12-05 13:37:12.000000000","message":"Here you are running a command using an environment defined in L136-137. You should use only the executable name. In this case:\n\nos.path.basename(sys.executable)\n\nWith this change you should pass https://73af4e8bccf4cf28005c-8b3fd1cbec84f6612448a196d686f738.ssl.cf2.rackcdn.com/681400/7/check/neutron-functional/72aa91d/testr_results.html.gz","commit_id":"728f829773e9f6e8ed7ea495f5f2a45ef9a9a82b"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"21e92e16f0ebc32ea912997f78de16ddb109b022","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        to test the cleanup functionality which will issue a SIGKILL"},{"line_number":102,"context_line":"        to all remaining processes after the SIGTERM attempt"},{"line_number":103,"context_line":"        \"\"\""},{"line_number":104,"context_line":"        commands \u003d [[sys.executable, process_spawn.__file__,"},{"line_number":105,"context_line":"                     \u0027-n\u0027, NUM_SUBPROCESSES,"},{"line_number":106,"context_line":"                     \u0027-f\u0027, n_const.IPv4,"},{"line_number":107,"context_line":"                     \u0027-p\u0027, n_const.PROTO_NAME_TCP,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fa7e38b_866d9c30","line":104,"in_reply_to":"3fa7e38b_1de02727","updated":"2019-12-06 04:41:52.000000000","message":"Thanks a lot for the hint! Updated","commit_id":"728f829773e9f6e8ed7ea495f5f2a45ef9a9a82b"}],"neutron/tests/unit/agent/linux/test_daemon.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3170009dd32fe83b41d868fa903e043f849c8cb2","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def test_is_running_uuid_true(self):"},{"line_number":208,"context_line":"        mock_open \u003d self.useFixture("},{"line_number":209,"context_line":"            lib_fixtures.OpenFixture("},{"line_number":210,"context_line":"                \u0027/proc/34/cmdline\u0027, \u0027{} 1234\u0027.format("},{"line_number":211,"context_line":"                    sys.executable))).mock_open"},{"line_number":212,"context_line":"        p \u003d daemon.Pidfile(\u0027thefile\u0027, sys.executable, uuid\u003d\u00271234\u0027)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        with mock.patch.object(p, \u0027read\u0027) as read:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_5204534a","line":211,"range":{"start_line":210,"start_character":36,"end_line":211,"end_character":35},"updated":"2019-09-12 08:59:02.000000000","message":"\u0027%s 1234\u0027 % sys.executable","commit_id":"69c8d4e2fec458b6b97fb8e9558a0410b0f48d2c"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"db08b1728feddd6c2123dc71434cf8eefb78e0e7","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def test_is_running_uuid_true(self):"},{"line_number":208,"context_line":"        mock_open \u003d self.useFixture("},{"line_number":209,"context_line":"            lib_fixtures.OpenFixture("},{"line_number":210,"context_line":"                \u0027/proc/34/cmdline\u0027, \u0027{} 1234\u0027.format("},{"line_number":211,"context_line":"                    sys.executable))).mock_open"},{"line_number":212,"context_line":"        p \u003d daemon.Pidfile(\u0027thefile\u0027, sys.executable, uuid\u003d\u00271234\u0027)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        with mock.patch.object(p, \u0027read\u0027) as read:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_5260d301","line":211,"range":{"start_line":210,"start_character":36,"end_line":211,"end_character":35},"in_reply_to":"5faad753_5204534a","updated":"2019-09-12 09:04:54.000000000","message":"why?","commit_id":"69c8d4e2fec458b6b97fb8e9558a0410b0f48d2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"17ba5ecc86c2766ab9ada7c55ff051d37d686897","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def test_is_running_uuid_true(self):"},{"line_number":208,"context_line":"        mock_open \u003d self.useFixture("},{"line_number":209,"context_line":"            lib_fixtures.OpenFixture("},{"line_number":210,"context_line":"                \u0027/proc/34/cmdline\u0027, \u0027{} 1234\u0027.format("},{"line_number":211,"context_line":"                    sys.executable))).mock_open"},{"line_number":212,"context_line":"        p \u003d daemon.Pidfile(\u0027thefile\u0027, sys.executable, uuid\u003d\u00271234\u0027)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        with mock.patch.object(p, \u0027read\u0027) as read:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_6d0e4e33","line":211,"range":{"start_line":210,"start_character":36,"end_line":211,"end_character":35},"in_reply_to":"5faad753_5260d301","updated":"2019-09-12 09:06:59.000000000","message":"Check the unit test results: https://409f32abbe367e8fc10b-07499960a71aa815729b6aa191eb1322.ssl.cf2.rackcdn.com/681400/5/check/openstack-tox-py37/fbc3755/testr_results.html.gz\n\nft1.5: neutron.tests.unit.agent.linux.test_daemon.TestPidfile.test_is_running_uuid_false_StringException: Traceback (most recent call last):\n  File \"/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/base.py\", line 177, in func\n    return f(self, *args, **kwargs)\n  File \"/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/unit/agent/linux/test_daemon.py\", line 223, in test_is_running_uuid_false\n    \u0027/proc/34/cmdline\u0027, \u0027{} 1234\u0027).format(\nAttributeError: \u0027OpenFixture\u0027 object has no attribute \u0027format\u0027","commit_id":"69c8d4e2fec458b6b97fb8e9558a0410b0f48d2c"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"669f58ed58cdd490ece695b9c5da99971458e695","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def test_is_running_uuid_true(self):"},{"line_number":208,"context_line":"        mock_open \u003d self.useFixture("},{"line_number":209,"context_line":"            lib_fixtures.OpenFixture("},{"line_number":210,"context_line":"                \u0027/proc/34/cmdline\u0027, \u0027{} 1234\u0027.format("},{"line_number":211,"context_line":"                    sys.executable))).mock_open"},{"line_number":212,"context_line":"        p \u003d daemon.Pidfile(\u0027thefile\u0027, sys.executable, uuid\u003d\u00271234\u0027)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        with mock.patch.object(p, \u0027read\u0027) as read:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_cd842261","line":211,"range":{"start_line":210,"start_character":36,"end_line":211,"end_character":35},"in_reply_to":"5faad753_6d0e4e33","updated":"2019-09-12 09:10:57.000000000","message":"That was not because of the .format() but because I set one \")\" wrong. Fixed now (but still using .format())","commit_id":"69c8d4e2fec458b6b97fb8e9558a0410b0f48d2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"60da055fe9ca5d5c36d511a4371cacf853ddbb79","unresolved":false,"context_lines":[{"line_number":207,"context_line":"    def test_is_running_uuid_true(self):"},{"line_number":208,"context_line":"        mock_open \u003d self.useFixture("},{"line_number":209,"context_line":"            lib_fixtures.OpenFixture("},{"line_number":210,"context_line":"                \u0027/proc/34/cmdline\u0027, \u0027{} 1234\u0027.format("},{"line_number":211,"context_line":"                    sys.executable))).mock_open"},{"line_number":212,"context_line":"        p \u003d daemon.Pidfile(\u0027thefile\u0027, sys.executable, uuid\u003d\u00271234\u0027)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        with mock.patch.object(p, \u0027read\u0027) as read:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_4f39eea1","line":211,"range":{"start_line":210,"start_character":36,"end_line":211,"end_character":35},"in_reply_to":"5faad753_cd842261","updated":"2019-09-13 07:28:08.000000000","message":"Ahh, ok, I missed that","commit_id":"69c8d4e2fec458b6b97fb8e9558a0410b0f48d2c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3170009dd32fe83b41d868fa903e043f849c8cb2","unresolved":false,"context_lines":[{"line_number":220,"context_line":"    def test_is_running_uuid_false(self):"},{"line_number":221,"context_line":"        mock_open \u003d self.useFixture("},{"line_number":222,"context_line":"            lib_fixtures.OpenFixture("},{"line_number":223,"context_line":"                \u0027/proc/34/cmdline\u0027, \u0027{} 1234\u0027).format("},{"line_number":224,"context_line":"                    sys.executable)).mock_open"},{"line_number":225,"context_line":"        p \u003d daemon.Pidfile(\u0027thefile\u0027, sys.executable, uuid\u003d\u00276789\u0027)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        with mock.patch.object(p, \u0027read\u0027) as read:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5faad753_d295a3e5","line":224,"range":{"start_line":223,"start_character":36,"end_line":224,"end_character":34},"updated":"2019-09-12 08:59:02.000000000","message":"ditto\n\u0027%s 1234\u0027 % sys.executable","commit_id":"69c8d4e2fec458b6b97fb8e9558a0410b0f48d2c"}]}