)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"070fe382594aaf55b49602ad266638a2acac59aa","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                                            protocol,"},{"line_number":267,"context_line":"                                            key\u003dversion_from_protocol)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def set_igmp_snooping_state(self, state):"},{"line_number":270,"context_line":"        other_config \u003d {"},{"line_number":271,"context_line":"            \u0027mcast-snooping-disable-flood-unregistered\u0027: str(state)}"},{"line_number":272,"context_line":"        with self.ovsdb.transaction() as txn:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_475c294a","line":269,"range":{"start_line":269,"start_character":38,"end_line":269,"end_character":43},"updated":"2019-10-16 08:04:20.000000000","message":"nitty nit: can you force the state value to bool? Just to be sure \"state\" is only True/False.","commit_id":"432925349aa1518543302fb625ef30231861b9aa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"94d07eff131fe1e6f266c008611a4aaeb8ebdb16","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                                            protocol,"},{"line_number":267,"context_line":"                                            key\u003dversion_from_protocol)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"    def set_igmp_snooping_state(self, state):"},{"line_number":270,"context_line":"        other_config \u003d {"},{"line_number":271,"context_line":"            \u0027mcast-snooping-disable-flood-unregistered\u0027: str(state)}"},{"line_number":272,"context_line":"        with self.ovsdb.transaction() as txn:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_fbfa8c40","line":269,"range":{"start_line":269,"start_character":38,"end_line":269,"end_character":43},"in_reply_to":"3fa7e38b_475c294a","updated":"2019-10-16 12:35:06.000000000","message":"Done","commit_id":"432925349aa1518543302fb625ef30231861b9aa"}],"neutron/conf/agent/ovs_conf.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"070fe382594aaf55b49602ad266638a2acac59aa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                      \u0027overridden by Open vSwitch according to the \u0027"},{"line_number":35,"context_line":"                      \u0027documentation.\u0027)),"},{"line_number":36,"context_line":"    cfg.BoolOpt(\u0027igmp_snooping_enable\u0027, default\u003dFalse,"},{"line_number":37,"context_line":"                help\u003d_(\u0027Enable IGMP snooping for integration bridge. It this \u0027"},{"line_number":38,"context_line":"                       \u0027option is set to True, support for Internet Group \u0027"},{"line_number":39,"context_line":"                       \u0027Management Protocol (IGMP) is enabled in integration \u0027"},{"line_number":40,"context_line":"                       \u0027bridge. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_87ea2171","line":37,"range":{"start_line":37,"start_character":69,"end_line":37,"end_character":71},"updated":"2019-10-16 08:04:20.000000000","message":"s/It/If","commit_id":"432925349aa1518543302fb625ef30231861b9aa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"94d07eff131fe1e6f266c008611a4aaeb8ebdb16","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                      \u0027overridden by Open vSwitch according to the \u0027"},{"line_number":35,"context_line":"                      \u0027documentation.\u0027)),"},{"line_number":36,"context_line":"    cfg.BoolOpt(\u0027igmp_snooping_enable\u0027, default\u003dFalse,"},{"line_number":37,"context_line":"                help\u003d_(\u0027Enable IGMP snooping for integration bridge. It this \u0027"},{"line_number":38,"context_line":"                       \u0027option is set to True, support for Internet Group \u0027"},{"line_number":39,"context_line":"                       \u0027Management Protocol (IGMP) is enabled in integration \u0027"},{"line_number":40,"context_line":"                       \u0027bridge. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1bf6885e","line":37,"range":{"start_line":37,"start_character":69,"end_line":37,"end_character":71},"in_reply_to":"3fa7e38b_87ea2171","updated":"2019-10-16 12:35:06.000000000","message":"Done","commit_id":"432925349aa1518543302fb625ef30231861b9aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"070fe382594aaf55b49602ad266638a2acac59aa","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                       \u0027option is set to True, support for Internet Group \u0027"},{"line_number":39,"context_line":"                       \u0027Management Protocol (IGMP) is enabled in integration \u0027"},{"line_number":40,"context_line":"                       \u0027bridge. \u0027"},{"line_number":41,"context_line":"                       \u0027Setting this to True will also disable flooding of \u0027"},{"line_number":42,"context_line":"                       \u0027unregistered multicast packets to all ports in the \u0027"},{"line_number":43,"context_line":"                       \u0027bridge. It is option \u0027"},{"line_number":44,"context_line":"                       \u0027mcast-snooping-disable-flood-unregistered in \u0027"},{"line_number":45,"context_line":"                       \u0027Open vSwitch. See ovs-vsctl man page for details.\u0027)),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_e77d15b2","line":45,"range":{"start_line":41,"start_character":24,"end_line":45,"end_character":36},"updated":"2019-10-16 08:04:20.000000000","message":"I would rephrase this (but I\u0027m not English native speaker). Something like:\n\nSetting this option to True will also enable Open vSwitch \u0027mcast-snooping-disable-flood-unregistered\u0027 flag. This option will disable flooding of unregistered multicast packets to all ports. The switch will send unregistered multicast packets only to ports connected to multicast routers.","commit_id":"432925349aa1518543302fb625ef30231861b9aa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"94d07eff131fe1e6f266c008611a4aaeb8ebdb16","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                       \u0027option is set to True, support for Internet Group \u0027"},{"line_number":39,"context_line":"                       \u0027Management Protocol (IGMP) is enabled in integration \u0027"},{"line_number":40,"context_line":"                       \u0027bridge. \u0027"},{"line_number":41,"context_line":"                       \u0027Setting this to True will also disable flooding of \u0027"},{"line_number":42,"context_line":"                       \u0027unregistered multicast packets to all ports in the \u0027"},{"line_number":43,"context_line":"                       \u0027bridge. It is option \u0027"},{"line_number":44,"context_line":"                       \u0027mcast-snooping-disable-flood-unregistered in \u0027"},{"line_number":45,"context_line":"                       \u0027Open vSwitch. See ovs-vsctl man page for details.\u0027)),"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_dbc230e9","line":45,"range":{"start_line":41,"start_character":24,"end_line":45,"end_character":36},"in_reply_to":"3fa7e38b_e77d15b2","updated":"2019-10-16 12:35:06.000000000","message":"Done","commit_id":"432925349aa1518543302fb625ef30231861b9aa"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"070fe382594aaf55b49602ad266638a2acac59aa","unresolved":false,"context_lines":[{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def register_ovs_agent_opts(cfg\u003dcfg.CONF):"},{"line_number":50,"context_line":"    cfg.register_opts(OPTS, \u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a732bd0e","line":49,"updated":"2019-10-16 08:04:20.000000000","message":"You need to call this method in OVSAgentTestFramework._get_config_opts() to have this new option in FT.","commit_id":"432925349aa1518543302fb625ef30231861b9aa"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"94d07eff131fe1e6f266c008611a4aaeb8ebdb16","unresolved":false,"context_lines":[{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def register_ovs_agent_opts(cfg\u003dcfg.CONF):"},{"line_number":50,"context_line":"    cfg.register_opts(OPTS, \u0027OVS\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_1b79a8c3","line":49,"in_reply_to":"3fa7e38b_a732bd0e","updated":"2019-10-16 12:35:06.000000000","message":"Done","commit_id":"432925349aa1518543302fb625ef30231861b9aa"}]}