)]}'
{"neutron/tests/functional/agent/linux/test_keepalived.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"219469542ddea9240b6019e697fbf6dc43e1808a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # neutron.tests.unit.agent.linux.test_keepalived module"},{"line_number":53,"context_line":"        dev_names \u003d [\u0027eth0\u0027, \u0027eth1\u0027, \u0027eth2\u0027, \u0027eth4\u0027, \u0027eth6\u0027, \u0027eth10\u0027]"},{"line_number":54,"context_line":"        for name in dev_names:"},{"line_number":55,"context_line":"            self.ip_wrapper.add_dummy(name)"},{"line_number":56,"context_line":"        ip_device \u003d ip_lib.IPDevice(\u0027eth0\u0027, namespace\u003dself.namespace)"},{"line_number":57,"context_line":"        ip_device.link.set_up()"},{"line_number":58,"context_line":"        ip_device.addr.add(\u0027169.254.192.1/18\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_ea9bf862","line":55,"updated":"2019-09-24 13:28:32.000000000","message":"This will return an IPDevice class object, so you could just save the first one to use later.","commit_id":"7adf5605eb870a908532028fa95b0dbfc3df7b00"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d49d926422c43711eb1e2c87fbcce7120a27214","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        # neutron.tests.unit.agent.linux.test_keepalived module"},{"line_number":53,"context_line":"        dev_names \u003d [\u0027eth0\u0027, \u0027eth1\u0027, \u0027eth2\u0027, \u0027eth4\u0027, \u0027eth6\u0027, \u0027eth10\u0027]"},{"line_number":54,"context_line":"        for name in dev_names:"},{"line_number":55,"context_line":"            self.ip_wrapper.add_dummy(name)"},{"line_number":56,"context_line":"        ip_device \u003d ip_lib.IPDevice(\u0027eth0\u0027, namespace\u003dself.namespace)"},{"line_number":57,"context_line":"        ip_device.link.set_up()"},{"line_number":58,"context_line":"        ip_device.addr.add(\u0027169.254.192.1/18\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_85cd9567","line":55,"in_reply_to":"3fa7e38b_ea9bf862","updated":"2019-09-24 13:50:17.000000000","message":"You are right! Let\u0027s save time.","commit_id":"7adf5605eb870a908532028fa95b0dbfc3df7b00"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"c7a9f8b522499f6c4196bfe041c8328be111cc7a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            self.ip_wrapper.add_dummy(name)"},{"line_number":56,"context_line":"        ip_device \u003d ip_lib.IPDevice(\u0027eth0\u0027, namespace\u003dself.namespace)"},{"line_number":57,"context_line":"        ip_device.link.set_up()"},{"line_number":58,"context_line":"        ip_device.addr.add(\u0027169.254.192.1/18\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _spawn_keepalived(self, keepalived_manager):"},{"line_number":61,"context_line":"        keepalived_manager.spawn()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_1ea81a8b","line":58,"range":{"start_line":58,"start_character":42,"end_line":58,"end_character":44},"updated":"2019-09-24 09:49:24.000000000","message":"why not /16 , as described in rfc3927 ?","commit_id":"7adf5605eb870a908532028fa95b0dbfc3df7b00"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"219469542ddea9240b6019e697fbf6dc43e1808a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            self.ip_wrapper.add_dummy(name)"},{"line_number":56,"context_line":"        ip_device \u003d ip_lib.IPDevice(\u0027eth0\u0027, namespace\u003dself.namespace)"},{"line_number":57,"context_line":"        ip_device.link.set_up()"},{"line_number":58,"context_line":"        ip_device.addr.add(\u0027169.254.192.1/18\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _spawn_keepalived(self, keepalived_manager):"},{"line_number":61,"context_line":"        keepalived_manager.spawn()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2af7d061","line":58,"range":{"start_line":58,"start_character":42,"end_line":58,"end_character":44},"in_reply_to":"3fa7e38b_1ea81a8b","updated":"2019-09-24 13:28:32.000000000","message":"And do we know if this prefix is possibly used elsewhere and will conflict?  Should we use the exclusive_resources module?  Like get_test_net_address_fixture() ?","commit_id":"7adf5605eb870a908532028fa95b0dbfc3df7b00"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d49d926422c43711eb1e2c87fbcce7120a27214","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            self.ip_wrapper.add_dummy(name)"},{"line_number":56,"context_line":"        ip_device \u003d ip_lib.IPDevice(\u0027eth0\u0027, namespace\u003dself.namespace)"},{"line_number":57,"context_line":"        ip_device.link.set_up()"},{"line_number":58,"context_line":"        ip_device.addr.add(\u0027169.254.192.1/18\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _spawn_keepalived(self, keepalived_manager):"},{"line_number":61,"context_line":"        keepalived_manager.spawn()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_25bf01b1","line":58,"range":{"start_line":58,"start_character":42,"end_line":58,"end_character":44},"in_reply_to":"3fa7e38b_1ea81a8b","updated":"2019-09-24 13:50:17.000000000","message":"Sorry, my bad.","commit_id":"7adf5605eb870a908532028fa95b0dbfc3df7b00"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2d49d926422c43711eb1e2c87fbcce7120a27214","unresolved":false,"context_lines":[{"line_number":55,"context_line":"            self.ip_wrapper.add_dummy(name)"},{"line_number":56,"context_line":"        ip_device \u003d ip_lib.IPDevice(\u0027eth0\u0027, namespace\u003dself.namespace)"},{"line_number":57,"context_line":"        ip_device.link.set_up()"},{"line_number":58,"context_line":"        ip_device.addr.add(\u0027169.254.192.1/18\u0027)"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def _spawn_keepalived(self, keepalived_manager):"},{"line_number":61,"context_line":"        keepalived_manager.spawn()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c5af0d7b","line":58,"range":{"start_line":58,"start_character":42,"end_line":58,"end_character":44},"in_reply_to":"3fa7e38b_2af7d061","updated":"2019-09-24 13:50:17.000000000","message":"This device is inside a namespace only used by this test case. There should be no conflict.","commit_id":"7adf5605eb870a908532028fa95b0dbfc3df7b00"}]}