)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"989a49392b4e83bd58170cf4fc7d1ed43d216b3b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixing lost QoS on interfaces after operation like: reboot hard, live migration.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sometimes a vm gets its interface unset and reset too fast to be caught in"},{"line_number":10,"context_line":"an agent loop, and its QoS on it interfaces was lost and qos extension doesn\u0027t restore the qos."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I83a4d2c0ed480da3d3aa6a46350b95fac8f4f415"},{"line_number":13,"context_line":"Closes-Bug: #1845161"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_ff9b8d6f","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":13},"updated":"2019-09-26 07:28:01.000000000","message":"isn\u0027t this real problem? Shouldn\u0027t such thing be catched by ovsdb monitor? can You maybe check if patch https://review.opendev.org/#/c/681984/ can solve this issue?","commit_id":"5c38e58f5325c998ce32513cbe90eba9b7b0ab5a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"989a49392b4e83bd58170cf4fc7d1ed43d216b3b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fixing lost QoS on interfaces after operation like: reboot hard, live migration.."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Sometimes a vm gets its interface unset and reset too fast to be caught in"},{"line_number":10,"context_line":"an agent loop, and its QoS on it interfaces was lost and qos extension doesn\u0027t restore the qos."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I83a4d2c0ed480da3d3aa6a46350b95fac8f4f415"},{"line_number":13,"context_line":"Closes-Bug: #1845161"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_ffc62d68","line":10,"updated":"2019-09-26 07:28:01.000000000","message":"nit: please wrap up lines at 80 chars. It\u0027s easier to read later :)","commit_id":"5c38e58f5325c998ce32513cbe90eba9b7b0ab5a"}],"neutron/agent/l2/extensions/qos.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"702b3a760a212873c30e95efee412a676766fa93","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            qos_policy_id) or self.resource_rpc.pull("},{"line_number":259,"context_line":"            context, resources.QOS_POLICY, qos_policy_id)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        if not self.policy_map.has_policy_changed(port, qos_policy_id):"},{"line_number":262,"context_line":"            self.qos_driver.create(port, qos_policy)"},{"line_number":263,"context_line":"            return"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        if qos_policy is None:"},{"line_number":266,"context_line":"            LOG.info(\"QoS policy %(qos_policy_id)s applied to port \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_a7f68062","line":263,"range":{"start_line":261,"start_character":0,"end_line":263,"end_character":18},"updated":"2019-09-25 12:50:28.000000000","message":"I think this will fix some problems and may create others.\n\nWhen we missed calling create() this would help.\n\nBut when create() was called properly here we will call create() a 2nd time. For that to work all create handlers would have to be idempotent. We have no guarantee for that.","commit_id":"5c38e58f5325c998ce32513cbe90eba9b7b0ab5a"},{"author":{"_account_id":30922,"name":"Nguyen Duy Binh","email":"binhnd1008@gmail.com","username":"binhnd108"},"change_message_id":"bacc4f42c94ba37bfe5bcefda3f62729d13b9e71","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            qos_policy_id) or self.resource_rpc.pull("},{"line_number":259,"context_line":"            context, resources.QOS_POLICY, qos_policy_id)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        if not self.policy_map.has_policy_changed(port, qos_policy_id):"},{"line_number":262,"context_line":"            self.qos_driver.create(port, qos_policy)"},{"line_number":263,"context_line":"            return"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        if qos_policy is None:"},{"line_number":266,"context_line":"            LOG.info(\"QoS policy %(qos_policy_id)s applied to port \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_df6a60b1","line":263,"range":{"start_line":261,"start_character":0,"end_line":263,"end_character":18},"in_reply_to":"3fa7e38b_a7f68062","updated":"2019-09-25 14:13:29.000000000","message":"when i trace in code, i see that when the QoS policy lost on the interface, the QoS policy on port wasn\u0027t be clean before, so that, the function policy_map.has_policy_changed return False, and the QoS policy wasnt be restore although it has lost.\nAnd i want to recreate qos for interface in this part of code.\nDo you have any other suggestion for fix this bug?","commit_id":"5c38e58f5325c998ce32513cbe90eba9b7b0ab5a"}]}
