)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6e0deb8366302b64ef97fb21a609e0eaf84a5ff9","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"[0]: https://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/callbacks/registry.py#L67"},{"line_number":55,"context_line":"[1]: https://review.opendev.org/541766"},{"line_number":56,"context_line":"[3]: https://review.opendev.org/#/c/679483/2"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Change-Id: I6482223ed2a479de4f5ef4cef056c311c0281408"},{"line_number":59,"context_line":"Closes-Bug: #1841967"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_4b07271a","line":56,"updated":"2019-10-02 14:41:02.000000000","message":"At a minimum we\u0027d need a Conflicts section here since there is a new file and the code is completely different.","commit_id":"f90b643650df18bd9e5b31a57a84fd4620069393"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6e0deb8366302b64ef97fb21a609e0eaf84a5ff9","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            for subnet in subnets:"},{"line_number":467,"context_line":"                kwargs \u003d {\u0027context\u0027: context, \u0027subnet_id\u0027: subnet.id}"},{"line_number":468,"context_line":"                registry.notify("},{"line_number":469,"context_line":"                    resources.SUBNET, events.BEFORE_DELETE, None, **kwargs)"},{"line_number":470,"context_line":"                self._delete_subnet(context, subnet)"},{"line_number":471,"context_line":"            with db_api.context_manager.writer.using(context):"},{"line_number":472,"context_line":"                network_db \u003d self._get_network(context, id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_50a35201","line":469,"updated":"2019-10-02 14:41:02.000000000","message":"There is a method called _check_subnet_not_used() which does a similar thing, but it\u0027s only called from delete_subnet().\n\nBut the main reason for my comment is that this code isn\u0027t in master, so I don\u0027t think we should be putting it in a stable release.","commit_id":"f90b643650df18bd9e5b31a57a84fd4620069393"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"b1f11f176df69d362cde1eacd3f10c612fe8ac04","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            for subnet in subnets:"},{"line_number":467,"context_line":"                kwargs \u003d {\u0027context\u0027: context, \u0027subnet_id\u0027: subnet.id}"},{"line_number":468,"context_line":"                registry.notify("},{"line_number":469,"context_line":"                    resources.SUBNET, events.BEFORE_DELETE, None, **kwargs)"},{"line_number":470,"context_line":"                self._delete_subnet(context, subnet)"},{"line_number":471,"context_line":"            with db_api.context_manager.writer.using(context):"},{"line_number":472,"context_line":"                network_db \u003d self._get_network(context, id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8f075a19","line":469,"in_reply_to":"3fa7e38b_50a35201","updated":"2019-10-03 11:19:27.000000000","message":"The reason why I risked pushing this to stable/queens is that the patch that was merged to master has once a patchset which I used as base of this one. \nSo I considered this as a grey area.\nIf from stable maintenance perspective this is not allowed I am OK with it.","commit_id":"f90b643650df18bd9e5b31a57a84fd4620069393"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5203a6177f522cd790bacb2023fd315a44324c51","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            for subnet in subnets:"},{"line_number":467,"context_line":"                kwargs \u003d {\u0027context\u0027: context, \u0027subnet_id\u0027: subnet.id}"},{"line_number":468,"context_line":"                registry.notify("},{"line_number":469,"context_line":"                    resources.SUBNET, events.BEFORE_DELETE, None, **kwargs)"},{"line_number":470,"context_line":"                self._delete_subnet(context, subnet)"},{"line_number":471,"context_line":"            with db_api.context_manager.writer.using(context):"},{"line_number":472,"context_line":"                network_db \u003d self._get_network(context, id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_ef4fee8f","line":469,"in_reply_to":"3fa7e38b_8f075a19","updated":"2019-10-03 12:28:49.000000000","message":"I understand there\u0027s always going to be some modifications to patches to get them to apply to master-3 branches, it\u0027s just not obvious to me why this code is here.  Is there a BEFORE_DELETE happening in master in some other code path that I\u0027m missing?","commit_id":"f90b643650df18bd9e5b31a57a84fd4620069393"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"edb5077ea5a9c79ae96cc26f6463b96b12843f9c","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            for subnet in subnets:"},{"line_number":467,"context_line":"                kwargs \u003d {\u0027context\u0027: context, \u0027subnet_id\u0027: subnet.id}"},{"line_number":468,"context_line":"                registry.notify("},{"line_number":469,"context_line":"                    resources.SUBNET, events.BEFORE_DELETE, None, **kwargs)"},{"line_number":470,"context_line":"                self._delete_subnet(context, subnet)"},{"line_number":471,"context_line":"            with db_api.context_manager.writer.using(context):"},{"line_number":472,"context_line":"                network_db \u003d self._get_network(context, id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_b06bf8b4","line":469,"in_reply_to":"3fa7e38b_ef4fee8f","updated":"2019-10-14 11:59:40.000000000","message":"Mark Goddard answered a similar question in the original review: https://review.opendev.org/#/c/679483/2/neutron/db/db_base_plugin_v2.py@497","commit_id":"f90b643650df18bd9e5b31a57a84fd4620069393"}]}