)]}'
{"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c0f36e22310a873a2d45e32f8dbdcf51fedbc921","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"                # enforce it\u0027s not nullable on database level"},{"line_number":1099,"context_line":"                    db_network.mtu is None):"},{"line_number":1100,"context_line":"                db_network.mtu \u003d self._get_network_mtu(db_network,"},{"line_number":1101,"context_line":"                                                       validate\u003dFalse)"},{"line_number":1102,"context_line":"                # agents should now update all ports to reflect new MTU"},{"line_number":1103,"context_line":"                need_network_update_notify \u003d True"},{"line_number":1104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_35d7e54d","side":"PARENT","line":1101,"updated":"2019-10-15 10:52:39.000000000","message":"Hi Tom. This is going to be removed, as zhanghao mentioned, in [1].\n\nSorry but this patch will be no longer needed very soon ([1] is almost ready to be approved).\n\n[1] https://review.opendev.org/#/c/679399","commit_id":"6b52e361f0eae01e67b1d9be47faee36b0627efe"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8563a04e911f5ce390c1d4a1f1dd2e8198425201","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"                # enforce it\u0027s not nullable on database level"},{"line_number":1099,"context_line":"                    db_network.mtu is None):"},{"line_number":1100,"context_line":"                db_network.mtu \u003d self._get_network_mtu(db_network,"},{"line_number":1101,"context_line":"                                                       validate\u003dFalse)"},{"line_number":1102,"context_line":"                # agents should now update all ports to reflect new MTU"},{"line_number":1103,"context_line":"                need_network_update_notify \u003d True"},{"line_number":1104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6e8a6e64","side":"PARENT","line":1101,"in_reply_to":"3fa7e38b_35d7e54d","updated":"2019-10-15 14:02:58.000000000","message":"Actually you are right. I see no reason to make validate\u003dFalse.\n\nI\u0027m trying to find the author of this (Ihar) to ask him about this.\n\nIf you are going to push this path, you should implement a test in fullstack.test_mtu.TestMTUScenarios to check the exception in case MTU value is not valid.","commit_id":"6b52e361f0eae01e67b1d9be47faee36b0627efe"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ddad0b45753744ddf31c19c6f0d190e1d5953b5","unresolved":false,"context_lines":[{"line_number":1098,"context_line":"                # enforce it\u0027s not nullable on database level"},{"line_number":1099,"context_line":"                    db_network.mtu is None):"},{"line_number":1100,"context_line":"                db_network.mtu \u003d self._get_network_mtu(db_network,"},{"line_number":1101,"context_line":"                                                       validate\u003dFalse)"},{"line_number":1102,"context_line":"                # agents should now update all ports to reflect new MTU"},{"line_number":1103,"context_line":"                need_network_update_notify \u003d True"},{"line_number":1104,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_aec2a683","side":"PARENT","line":1101,"in_reply_to":"3fa7e38b_6e8a6e64","updated":"2019-12-11 10:26:23.000000000","message":"Talking about the fullstack test: https://storage.bhs1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_8d6/688656/1/check/neutron-fullstack/8d6efda/testr_results.html.gz\n\nHere is your example. Now you need to implement a test working (not raising an exception).","commit_id":"6b52e361f0eae01e67b1d9be47faee36b0627efe"}],"neutron/tests/fullstack/test_mtu.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ec08c4731473a5902754320006b2aaa3b112f162","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# from neutronclient.common import exceptions"},{"line_number":16,"context_line":"from oslo_utils import uuidutils"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.tests.fullstack import base"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_5a540154","side":"PARENT","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":2},"updated":"2019-12-12 14:00:01.000000000","message":"We didn\u0027t see that before!","commit_id":"3ad5ad02c94ac0359956db9aa9c3314ebd9651d3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"ec08c4731473a5902754320006b2aaa3b112f162","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class TestMTUScenarios(MTUNetworkTestSetup):"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_mtu_update_network(self):"},{"line_number":48,"context_line":"        network \u003d self.safe_client.create_network(self.tenant_id,"},{"line_number":49,"context_line":"                                                  name\u003d\u0027mtu-test-network\u0027,"},{"line_number":50,"context_line":"                                                  mtu\u003d1450)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_9acb591b","line":47,"updated":"2019-12-12 14:00:01.000000000","message":"You should keep the previous test but with a lower MTU (update and delete).\n\nThen you can add this new test (update with exception) to the class.","commit_id":"a11fe783129a59d6426042ef81cf8dba6cdffab1"},{"author":{"_account_id":26106,"name":"Tom Stappaerts","email":"tom.stappaerts@nokia.com","username":"TomStappaerts"},"change_message_id":"0a485ad8d479bf0c8a1d57405851f46783992027","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class TestMTUScenarios(MTUNetworkTestSetup):"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_mtu_update_network(self):"},{"line_number":48,"context_line":"        network \u003d self.safe_client.create_network(self.tenant_id,"},{"line_number":49,"context_line":"                                                  name\u003d\u0027mtu-test-network\u0027,"},{"line_number":50,"context_line":"                                                  mtu\u003d1450)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_faf12d6b","line":47,"in_reply_to":"3fa7e38b_9acb591b","updated":"2019-12-12 14:01:47.000000000","message":"I could but is not the whole point of the test that it can illegaly update the mtu to be higher than is allowed and delete is still allowed?","commit_id":"a11fe783129a59d6426042ef81cf8dba6cdffab1"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"fd3ea9604b68fd91f9c3afc7a52d90a5a400f210","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class TestMTUScenarios(MTUNetworkTestSetup):"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def test_mtu_update_network(self):"},{"line_number":48,"context_line":"        network \u003d self.safe_client.create_network(self.tenant_id,"},{"line_number":49,"context_line":"                                                  name\u003d\u0027mtu-test-network\u0027,"},{"line_number":50,"context_line":"                                                  mtu\u003d1450)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_55113252","line":47,"in_reply_to":"3fa7e38b_faf12d6b","updated":"2019-12-12 14:19:43.000000000","message":"I mean having two test:\n1) the previous one, but updating to a lower MTU (e.g. 900)\n2) your current test, raising an exception.","commit_id":"a11fe783129a59d6426042ef81cf8dba6cdffab1"}]}