)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5e654d4acea657351bba2bdf0ee726b32948659a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It seems that this function often requires longer than the default"},{"line_number":10,"context_line":"60 seconds. This mitigates the linked bug, but why is this taking so"},{"line_number":11,"context_line":"long, and what could cause it to increase further?"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I08e4d81e1d311efd08af66a6d304ea6adcc09480"},{"line_number":14,"context_line":"Partial-Bug: 1848187"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_d2b76320","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":50},"updated":"2019-10-17 04:28:27.000000000","message":"So do you have the information now?","commit_id":"5435f6c9b1899a5da29d3a8d7bbb15f79764bebe"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9d9026e60dfa9e6efdb1fca0fee826e67cb829e3","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    def enable(self):"},{"line_number":215,"context_line":"        \"\"\"Enables DHCP for this network by spawning a local process.\"\"\""},{"line_number":216,"context_line":"        try:"},{"line_number":217,"context_line":"            common_utils.wait_until_true(self._enable, timeout\u003d120)"},{"line_number":218,"context_line":"        except common_utils.WaitTimeout:"},{"line_number":219,"context_line":"            LOG.error(\"Failed to start DHCP process for network %s\","},{"line_number":220,"context_line":"                      self.network.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_95a303b2","line":217,"updated":"2019-10-18 07:28:38.000000000","message":"I don\u0027t think that increasing this timeout will solve any problem. In bug report I pointed to some other bugs which may be related to Your issue. Can You check if changing ulimit for containers will fix this problem for You? If not, maybe You can e.g. add some additional debug messages in self._enable() method and check on which step in this method this is actually slowing so much. Maybe than we will be able to fix root cause of the problem.","commit_id":"5435f6c9b1899a5da29d3a8d7bbb15f79764bebe"},{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"df3c4338727b07ba5e010f6a2a537a70d4e99b2d","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    def enable(self):"},{"line_number":215,"context_line":"        \"\"\"Enables DHCP for this network by spawning a local process.\"\"\""},{"line_number":216,"context_line":"        try:"},{"line_number":217,"context_line":"            common_utils.wait_until_true(self._enable, timeout\u003d120)"},{"line_number":218,"context_line":"        except common_utils.WaitTimeout:"},{"line_number":219,"context_line":"            LOG.error(\"Failed to start DHCP process for network %s\","},{"line_number":220,"context_line":"                      self.network.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3959028d","line":217,"range":{"start_line":217,"start_character":63,"end_line":217,"end_character":66},"updated":"2019-10-16 22:46:36.000000000","message":"I would suggest to make this timeout configurable so that others can change it for their purposes.","commit_id":"5435f6c9b1899a5da29d3a8d7bbb15f79764bebe"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"5e654d4acea657351bba2bdf0ee726b32948659a","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    def enable(self):"},{"line_number":215,"context_line":"        \"\"\"Enables DHCP for this network by spawning a local process.\"\"\""},{"line_number":216,"context_line":"        try:"},{"line_number":217,"context_line":"            common_utils.wait_until_true(self._enable, timeout\u003d120)"},{"line_number":218,"context_line":"        except common_utils.WaitTimeout:"},{"line_number":219,"context_line":"            LOG.error(\"Failed to start DHCP process for network %s\","},{"line_number":220,"context_line":"                      self.network.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f2c61f9a","line":217,"range":{"start_line":217,"start_character":63,"end_line":217,"end_character":66},"in_reply_to":"3fa7e38b_3959028d","updated":"2019-10-17 04:28:27.000000000","message":"Some one may not like config option, so how about make this dynamic according to the dhcp instance or namespace number? Or maybe the IP number?\nThe root cause of the timeout should be clarified, dynamic timeout changes can be based on this.","commit_id":"5435f6c9b1899a5da29d3a8d7bbb15f79764bebe"},{"author":{"_account_id":28048,"name":"Will Szumski","email":"will@stackhpc.com","username":"jovial"},"change_message_id":"bd98fe132a2fccc704094a5a22f7e9954e369e0a","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    def enable(self):"},{"line_number":215,"context_line":"        \"\"\"Enables DHCP for this network by spawning a local process.\"\"\""},{"line_number":216,"context_line":"        try:"},{"line_number":217,"context_line":"            common_utils.wait_until_true(self._enable, timeout\u003d120)"},{"line_number":218,"context_line":"        except common_utils.WaitTimeout:"},{"line_number":219,"context_line":"            LOG.error(\"Failed to start DHCP process for network %s\","},{"line_number":220,"context_line":"                      self.network.id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_16daba78","line":217,"in_reply_to":"3fa7e38b_95a303b2","updated":"2019-10-18 09:25:20.000000000","message":"Thanks, I will look into your suggestions. I have tried increasing this timeout and it did seem to improve my tempest tests results.","commit_id":"5435f6c9b1899a5da29d3a8d7bbb15f79764bebe"}]}