)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fdd81d3680fc5aa5023b2de492150445475cbee7","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - OVSBridge._find_queue(port_id)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The methods currently used are incorrect and are not testing correctly"},{"line_number":15,"context_line":"the real status if the OVS DB."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ibf2b06439a3cf6a40fec0435b4305a93a5629fd8"},{"line_number":18,"context_line":"Closes-Bug: #1848220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_05d2055d","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":18},"updated":"2019-10-27 10:27:00.000000000","message":"nitty nit: \"of\" probably","commit_id":"c898c24168836492dd43b109609e6babbce67091"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3256d5bf575748f9bd830505f9e12856eb4b2179","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - OVSBridge._find_queue(port_id)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The methods currently used are incorrect and are not testing correctly"},{"line_number":15,"context_line":"the real status if the OVS DB."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ibf2b06439a3cf6a40fec0435b4305a93a5629fd8"},{"line_number":18,"context_line":"Closes-Bug: #1848220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_7fa56cb4","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":18},"in_reply_to":"3fa7e38b_05d2055d","updated":"2019-10-29 13:12:22.000000000","message":"Done","commit_id":"c898c24168836492dd43b109609e6babbce67091"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"84cb0b0acbdd64fb16bc7f21f54be49928ca7a18","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  - OVSBridge._find_queue(port_id)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"The methods currently used are incorrect and are not testing correctly"},{"line_number":15,"context_line":"the real status if the OVS DB."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ibf2b06439a3cf6a40fec0435b4305a93a5629fd8"},{"line_number":18,"context_line":"Closes-Bug: #1848220"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3fa7e38b_8d56de29","line":15,"range":{"start_line":15,"start_character":16,"end_line":15,"end_character":18},"in_reply_to":"3fa7e38b_7fa56cb4","updated":"2019-10-31 14:51:38.000000000","message":"thx, but it wasn\u0027t necessary to respin just becase of that :)","commit_id":"c898c24168836492dd43b109609e6babbce67091"}],"neutron/tests/fullstack/test_qos.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c30cdf24d8b2487a56ca4ca3a7cc6d1aafd3414e","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        for qos in qoses:"},{"line_number":687,"context_line":"            qos_queue \u003d qos[\u0027queues\u0027].get(queue_num)"},{"line_number":688,"context_line":"            if qos_queue:"},{"line_number":689,"context_line":"                if qos_queue.uuid \u003d\u003d queue[\u0027_uuid\u0027]:"},{"line_number":690,"context_line":"                    break"},{"line_number":691,"context_line":"        else:"},{"line_number":692,"context_line":"            self.fail(\u0027QoS register not found with queue-num %s\u0027 % queue_num)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_83053c12","line":689,"updated":"2019-11-01 18:38:37.000000000","message":"nit: can combine this line with above since there are no other checks here","commit_id":"80e160d72b1c47aba1634dbbae40e19089f3592c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"07ecadb19d04192afc0dc9eca867654b3eaab442","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        for qos in qoses:"},{"line_number":687,"context_line":"            qos_queue \u003d qos[\u0027queues\u0027].get(queue_num)"},{"line_number":688,"context_line":"            if qos_queue:"},{"line_number":689,"context_line":"                if qos_queue.uuid \u003d\u003d queue[\u0027_uuid\u0027]:"},{"line_number":690,"context_line":"                    break"},{"line_number":691,"context_line":"        else:"},{"line_number":692,"context_line":"            self.fail(\u0027QoS register not found with queue-num %s\u0027 % queue_num)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_35c10c81","line":689,"in_reply_to":"3fa7e38b_83053c12","updated":"2019-11-04 14:20:19.000000000","message":"Done","commit_id":"80e160d72b1c47aba1634dbbae40e19089f3592c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c30cdf24d8b2487a56ca4ca3a7cc6d1aafd3414e","unresolved":false,"context_lines":[{"line_number":687,"context_line":"            qos_queue \u003d qos[\u0027queues\u0027].get(queue_num)"},{"line_number":688,"context_line":"            if qos_queue:"},{"line_number":689,"context_line":"                if qos_queue.uuid \u003d\u003d queue[\u0027_uuid\u0027]:"},{"line_number":690,"context_line":"                    break"},{"line_number":691,"context_line":"        else:"},{"line_number":692,"context_line":"            self.fail(\u0027QoS register not found with queue-num %s\u0027 % queue_num)"},{"line_number":693,"context_line":"        return qos, qos[\u0027queues\u0027][queue_num]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_400e5a3b","line":690,"updated":"2019-11-01 18:38:37.000000000","message":"could just return qos, qos_queue here too, then drop the else: below","commit_id":"80e160d72b1c47aba1634dbbae40e19089f3592c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"07ecadb19d04192afc0dc9eca867654b3eaab442","unresolved":false,"context_lines":[{"line_number":687,"context_line":"            qos_queue \u003d qos[\u0027queues\u0027].get(queue_num)"},{"line_number":688,"context_line":"            if qos_queue:"},{"line_number":689,"context_line":"                if qos_queue.uuid \u003d\u003d queue[\u0027_uuid\u0027]:"},{"line_number":690,"context_line":"                    break"},{"line_number":691,"context_line":"        else:"},{"line_number":692,"context_line":"            self.fail(\u0027QoS register not found with queue-num %s\u0027 % queue_num)"},{"line_number":693,"context_line":"        return qos, qos[\u0027queues\u0027][queue_num]"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_b53adc94","line":690,"in_reply_to":"3fa7e38b_400e5a3b","updated":"2019-11-04 14:20:19.000000000","message":"Done","commit_id":"80e160d72b1c47aba1634dbbae40e19089f3592c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c30cdf24d8b2487a56ca4ca3a7cc6d1aafd3414e","unresolved":false,"context_lines":[{"line_number":690,"context_line":"                    break"},{"line_number":691,"context_line":"        else:"},{"line_number":692,"context_line":"            self.fail(\u0027QoS register not found with queue-num %s\u0027 % queue_num)"},{"line_number":693,"context_line":"        return qos, qos[\u0027queues\u0027][queue_num]"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    def test_min_bw_qos_port_removed(self):"},{"line_number":696,"context_line":"        \"\"\"Test if min BW limit config is properly removed when port removed\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_2026becc","line":693,"range":{"start_line":693,"start_character":20,"end_line":693,"end_character":44},"updated":"2019-11-01 18:38:37.000000000","message":"guess this is qos_queue from above, but we can\u0027t use it here (assuming a pep8 complaint)","commit_id":"80e160d72b1c47aba1634dbbae40e19089f3592c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"07ecadb19d04192afc0dc9eca867654b3eaab442","unresolved":false,"context_lines":[{"line_number":690,"context_line":"                    break"},{"line_number":691,"context_line":"        else:"},{"line_number":692,"context_line":"            self.fail(\u0027QoS register not found with queue-num %s\u0027 % queue_num)"},{"line_number":693,"context_line":"        return qos, qos[\u0027queues\u0027][queue_num]"},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"    def test_min_bw_qos_port_removed(self):"},{"line_number":696,"context_line":"        \"\"\"Test if min BW limit config is properly removed when port removed\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_154bb02a","line":693,"range":{"start_line":693,"start_character":20,"end_line":693,"end_character":44},"in_reply_to":"3fa7e38b_2026becc","updated":"2019-11-04 14:20:19.000000000","message":"You are right!","commit_id":"80e160d72b1c47aba1634dbbae40e19089f3592c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c30cdf24d8b2487a56ca4ca3a7cc6d1aafd3414e","unresolved":false,"context_lines":[{"line_number":706,"context_line":"                         queue.other_config)"},{"line_number":707,"context_line":"        queues \u003d vm.bridge._list_queues(port\u003dvm.neutron_port[\u0027id\u0027])"},{"line_number":708,"context_line":"        self.assertEqual(1, len(queues))"},{"line_number":709,"context_line":"        self.assertEqual(queue.uuid, queues[0][\u0027_uuid\u0027])"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        # Delete port with qos policy attached"},{"line_number":712,"context_line":"        vm.destroy()"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_6009162f","line":709,"updated":"2019-11-01 18:38:37.000000000","message":"This looks like the same check done on L689, so should always be True","commit_id":"80e160d72b1c47aba1634dbbae40e19089f3592c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"07ecadb19d04192afc0dc9eca867654b3eaab442","unresolved":false,"context_lines":[{"line_number":706,"context_line":"                         queue.other_config)"},{"line_number":707,"context_line":"        queues \u003d vm.bridge._list_queues(port\u003dvm.neutron_port[\u0027id\u0027])"},{"line_number":708,"context_line":"        self.assertEqual(1, len(queues))"},{"line_number":709,"context_line":"        self.assertEqual(queue.uuid, queues[0][\u0027_uuid\u0027])"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"        # Delete port with qos policy attached"},{"line_number":712,"context_line":"        vm.destroy()"}],"source_content_type":"text/x-python","patch_set":12,"id":"3fa7e38b_351d8c0e","line":709,"in_reply_to":"3fa7e38b_6009162f","updated":"2019-11-04 14:20:19.000000000","message":"Almost. \"queue\" is from \"_find_agent_qos_and_queue\".\n\nBut \"queues\" was retrieved using \"_list_queues\" in the main method and \"_find_queue\" in \"_find_agent_qos_and_queue\".\n\nOf course, as tested both should be the same but we use different methods to retrieve the parameter to compare with \"queue\" (from the QoS register).","commit_id":"80e160d72b1c47aba1634dbbae40e19089f3592c"}]}