)]}'
{"neutron/db/securitygroups_db.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e31629e16f2ccb863a7f368fa4d4ad5ab1a227ba","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                     \u0027specifying the entire port range (%(min)s - \u0027"},{"line_number":525,"context_line":"                     \u0027%(max)s). It was automatically converted to not \u0027"},{"line_number":526,"context_line":"                     \u0027have a range to better optimize it for the backend \u0027"},{"line_number":527,"context_line":"                     \u0027security group implementation(s). \u0027,"},{"line_number":528,"context_line":"                     {\u0027project\u0027: rule[\u0027tenant_id\u0027],"},{"line_number":529,"context_line":"                      \u0027min\u0027: rule[\u0027port_range_min\u0027],"},{"line_number":530,"context_line":"                      \u0027max\u0027: rule[\u0027port_range_max\u0027]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_70a60bc4","line":527,"range":{"start_line":527,"start_character":55,"end_line":527,"end_character":56},"updated":"2019-10-28 16:02:53.000000000","message":"No one even noticed the extra trailing space, I win the nitpicking award for my own review :)","commit_id":"1fc81ccdaad6d3ba0117c58a41e136e8d04e2a83"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"537ebc9d870506e52327a28138e0ce4bd02f53d1","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                     \u0027specifying the entire port range (%(min)s - \u0027"},{"line_number":525,"context_line":"                     \u0027%(max)s). It was automatically converted to not \u0027"},{"line_number":526,"context_line":"                     \u0027have a range to better optimize it for the backend \u0027"},{"line_number":527,"context_line":"                     \u0027security group implementation(s). \u0027,"},{"line_number":528,"context_line":"                     {\u0027project\u0027: rule[\u0027tenant_id\u0027],"},{"line_number":529,"context_line":"                      \u0027min\u0027: rule[\u0027port_range_min\u0027],"},{"line_number":530,"context_line":"                      \u0027max\u0027: rule[\u0027port_range_max\u0027]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_cd77f6d3","line":527,"range":{"start_line":527,"start_character":55,"end_line":527,"end_character":56},"in_reply_to":"3fa7e38b_70a60bc4","updated":"2019-10-31 14:50:21.000000000","message":"LOL. You made my day with this comment :D","commit_id":"1fc81ccdaad6d3ba0117c58a41e136e8d04e2a83"}],"neutron/tests/fullstack/test_securitygroup.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"537ebc9d870506e52327a28138e0ce4bd02f53d1","unresolved":false,"context_lines":[{"line_number":113,"context_line":"             2. connection from allowed security group is permitted"},{"line_number":114,"context_line":"             3. traffic not explicitly allowed (eg. ICMP) is blocked,"},{"line_number":115,"context_line":"             4. a security group update takes effect,"},{"line_number":116,"context_line":"             5. a remote security group member addition works, and"},{"line_number":117,"context_line":"             6. an established connection stops by deleting a SG rule."},{"line_number":118,"context_line":"             7. multiple overlapping remote rules work,"},{"line_number":119,"context_line":"             8. test other protocol functionality by using SCTP protocol"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_4dbf8660","line":116,"updated":"2019-10-31 14:50:21.000000000","message":"I also updated descrition here to match steps below","commit_id":"6bd35fdcd2b4731e0fcd708c19e854853f2cb5ae"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c2804f668c58c0c4db09220f5e66ac86b16ef51f","unresolved":false,"context_lines":[{"line_number":113,"context_line":"             2. connection from allowed security group is permitted"},{"line_number":114,"context_line":"             3. traffic not explicitly allowed (eg. ICMP) is blocked,"},{"line_number":115,"context_line":"             4. a security group update takes effect,"},{"line_number":116,"context_line":"             5. a remote security group member addition works, and"},{"line_number":117,"context_line":"             6. an established connection stops by deleting a SG rule."},{"line_number":118,"context_line":"             7. multiple overlapping remote rules work,"},{"line_number":119,"context_line":"             8. test other protocol functionality by using SCTP protocol"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_086dfcca","line":116,"in_reply_to":"3fa7e38b_4dbf8660","updated":"2019-10-31 15:05:21.000000000","message":"Thanks, I hadn\u0027t even noticed this list.","commit_id":"6bd35fdcd2b4731e0fcd708c19e854853f2cb5ae"}],"neutron/tests/unit/extensions/test_securitygroup.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e31629e16f2ccb863a7f368fa4d4ad5ab1a227ba","unresolved":false,"context_lines":[{"line_number":971,"context_line":"        name \u003d \u0027webservers\u0027"},{"line_number":972,"context_line":"        description \u003d \u0027my webservers\u0027"},{"line_number":973,"context_line":"        with self.security_group(name, description) as sg:"},{"line_number":974,"context_line":"            with self.security_group(name, description) as sg2:"},{"line_number":975,"context_line":"                security_group_id \u003d sg[\u0027security_group\u0027][\u0027id\u0027]"},{"line_number":976,"context_line":"                direction \u003d \"ingress\""},{"line_number":977,"context_line":"                remote_group_id \u003d sg2[\u0027security_group\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_300f3389","line":974,"updated":"2019-10-28 16:02:53.000000000","message":"We don\u0027t actually need sg2 here, leftover from my copy/paste.  I\u0027ll get rid of it.","commit_id":"1fc81ccdaad6d3ba0117c58a41e136e8d04e2a83"}]}