)]}'
{"neutron/plugins/ml2/config.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"00625cb3e0835b864715d3748d965ccb31353176","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                       \"neutron.ml2.mechanism_drivers namespace.\")),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027bulk_support\u0027,"},{"line_number":34,"context_line":"                default\u003dTrue,"},{"line_number":35,"context_line":"                help\u003d_(\"Use bulk operations with ML2 drivers\")),"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BgxQ%3D","line":35,"updated":"2014-01-24 22:00:21.000000000","message":"Should we indicate the default in the help, or should the option be disable_bulk_support, since enabling is the default?","commit_id":"c29559caaee0df5be01877a9d751cb40f44981a5"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"07c8bb063b162a9a4147afd27bb297740c95f9b2","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                       \"neutron.ml2.mechanism_drivers namespace.\")),"},{"line_number":33,"context_line":"    cfg.BoolOpt(\u0027bulk_support\u0027,"},{"line_number":34,"context_line":"                default\u003dTrue,"},{"line_number":35,"context_line":"                help\u003d_(\"Use bulk operations with ML2 drivers\")),"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BguU%3D","line":35,"in_reply_to":"AAAAUH%2F%2BgxQ%3D","updated":"2014-01-24 22:13:18.000000000","message":"I indicated the default in help. I prefer avoiding the boolean negative options that lead to double-negatives to enable something.","commit_id":"c29559caaee0df5be01877a9d751cb40f44981a5"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"e9c459e41ef38b5175b75dd4fe1b1c8dda20cc5e","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        for driver in self.ordered_mech_drivers:"},{"line_number":139,"context_line":"            LOG.info(_(\"Initializing mechanism driver \u0027%s\u0027\"), driver.name)"},{"line_number":140,"context_line":"            driver.obj.initialize()"},{"line_number":141,"context_line":"            if not getattr(driver.obj, \u0027native_bulk_support\u0027, True):"},{"line_number":142,"context_line":"                self.native_bulk_support \u003d False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def _call_on_drivers(self, method_name, context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F9rU4%3D","line":141,"updated":"2014-02-05 03:16:52.000000000","message":"Shouldn\u0027t the default for getattr here be False?\n\n    if not getattr(driver.obj, \u0027native_bulk_support\u0027, False):","commit_id":"c1c25829d0764f0823ca7ce5d5b51ef6530df1d9"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"75e8d3595aae18da4b818d8c86166081f131ecef","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        for driver in self.ordered_mech_drivers:"},{"line_number":139,"context_line":"            LOG.info(_(\"Initializing mechanism driver \u0027%s\u0027\"), driver.name)"},{"line_number":140,"context_line":"            driver.obj.initialize()"},{"line_number":141,"context_line":"            if not getattr(driver.obj, \u0027native_bulk_support\u0027, True):"},{"line_number":142,"context_line":"                self.native_bulk_support \u003d False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def _call_on_drivers(self, method_name, context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F9qz4%3D","line":141,"updated":"2014-02-05 06:32:10.000000000","message":"replace 141-2 with:\n\nself.native_bulk_support \u0026\u003d getattr(driver.obj, \u0027native_bulk_support\u0027, True)","commit_id":"c1c25829d0764f0823ca7ce5d5b51ef6530df1d9"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"576a23cb3aeca92a0d0008f03b40fb2beff155dc","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        for driver in self.ordered_mech_drivers:"},{"line_number":139,"context_line":"            LOG.info(_(\"Initializing mechanism driver \u0027%s\u0027\"), driver.name)"},{"line_number":140,"context_line":"            driver.obj.initialize()"},{"line_number":141,"context_line":"            if not getattr(driver.obj, \u0027native_bulk_support\u0027, True):"},{"line_number":142,"context_line":"                self.native_bulk_support \u003d False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def _call_on_drivers(self, method_name, context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F9qyU%3D","line":141,"in_reply_to":"AAAAUH%2F9qz4%3D","updated":"2014-02-05 06:35:14.000000000","message":"Done","commit_id":"c1c25829d0764f0823ca7ce5d5b51ef6530df1d9"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"07a311322abfe52fd822f301a3211f9d4fb400fb","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        for driver in self.ordered_mech_drivers:"},{"line_number":139,"context_line":"            LOG.info(_(\"Initializing mechanism driver \u0027%s\u0027\"), driver.name)"},{"line_number":140,"context_line":"            driver.obj.initialize()"},{"line_number":141,"context_line":"            if not getattr(driver.obj, \u0027native_bulk_support\u0027, True):"},{"line_number":142,"context_line":"                self.native_bulk_support \u003d False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def _call_on_drivers(self, method_name, context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F9q%2FE%3D","line":141,"in_reply_to":"AAAAUH%2F9rKw%3D","updated":"2014-02-05 06:02:36.000000000","message":"I think Kevin you meant to say that this enables it by default. I agree that should be the default and is backward compatible.","commit_id":"c1c25829d0764f0823ca7ce5d5b51ef6530df1d9"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0be2a699edc2a43afa0f0c3cd457477adfc66369","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        for driver in self.ordered_mech_drivers:"},{"line_number":139,"context_line":"            LOG.info(_(\"Initializing mechanism driver \u0027%s\u0027\"), driver.name)"},{"line_number":140,"context_line":"            driver.obj.initialize()"},{"line_number":141,"context_line":"            if not getattr(driver.obj, \u0027native_bulk_support\u0027, True):"},{"line_number":142,"context_line":"                self.native_bulk_support \u003d False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def _call_on_drivers(self, method_name, context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F9rKw%3D","line":141,"in_reply_to":"AAAAUH%2F9rQY%3D","updated":"2014-02-05 04:30:11.000000000","message":"OK I was thinking the opposite but this makes sense.","commit_id":"c1c25829d0764f0823ca7ce5d5b51ef6530df1d9"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e2a9491679d18112e83118947a35d8a57ec410ab","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        for driver in self.ordered_mech_drivers:"},{"line_number":139,"context_line":"            LOG.info(_(\"Initializing mechanism driver \u0027%s\u0027\"), driver.name)"},{"line_number":140,"context_line":"            driver.obj.initialize()"},{"line_number":141,"context_line":"            if not getattr(driver.obj, \u0027native_bulk_support\u0027, True):"},{"line_number":142,"context_line":"                self.native_bulk_support \u003d False"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def _call_on_drivers(self, method_name, context,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAUH%2F9rQY%3D","line":141,"in_reply_to":"AAAAUH%2F9rU4%3D","updated":"2014-02-05 03:46:40.000000000","message":"I think it\u0027s better to have bulk support be the default and then drivers can disable it explicitly if necessary.\n\nThis disables it if they don\u0027t define it.","commit_id":"c1c25829d0764f0823ca7ce5d5b51ef6530df1d9"}]}
