)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ae1f890df04e4883235dc690933cea72869b6239","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[OVS] Handle added/removed ports in the same polling iteration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OVS agent processes the port events in a polling loop. It could happen"},{"line_number":10,"context_line":"(and more frecuently in a loaded OVS agent) that the \"removed\" and \"added\""},{"line_number":11,"context_line":"events can happen in the same polling iteration. Because of this, the same"},{"line_number":12,"context_line":"port is detected as \"removed\" and \"added\"."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3fa7e38b_0f6acd7f","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":20},"updated":"2019-11-02 09:07:12.000000000","message":"frequently ?","commit_id":"cf0ca23f3920fe3e474283c72c37f47b0736be4a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b806e9306a111d17637fc4fb93e5b0812cfaef7f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[OVS] Handle added/removed ports in the same polling iteration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OVS agent processes the port events in a polling loop. It could happen"},{"line_number":10,"context_line":"(and more frecuently in a loaded OVS agent) that the \"removed\" and \"added\""},{"line_number":11,"context_line":"events can happen in the same polling iteration. Because of this, the same"},{"line_number":12,"context_line":"port is detected as \"removed\" and \"added\"."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_7346fc23","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":20},"updated":"2019-11-20 11:55:12.000000000","message":"nit: frequently","commit_id":"4b95e517463b638ca68fe6c3198a5742e22c000c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ea0b52a828b4886ef11b5e33fbbf47c8b2b0158","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[OVS] Handle added/removed ports in the same polling iteration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OVS agent processes the port events in a polling loop. It could happen"},{"line_number":10,"context_line":"(and more frecuently in a loaded OVS agent) that the \"removed\" and \"added\""},{"line_number":11,"context_line":"events can happen in the same polling iteration. Because of this, the same"},{"line_number":12,"context_line":"port is detected as \"removed\" and \"added\"."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_7dd59bb6","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":20},"in_reply_to":"3fa7e38b_7346fc23","updated":"2019-12-06 10:51:46.000000000","message":"Done","commit_id":"4b95e517463b638ca68fe6c3198a5742e22c000c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b806e9306a111d17637fc4fb93e5b0812cfaef7f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"driver methods (based on the OVS agent QoS cache, storing port and QoS rules)."},{"line_number":23,"context_line":"This will lead to an unconfigured port."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch solves this issue by detecting this doble event and registering it"},{"line_number":26,"context_line":"as \"removed_and_added\". When the \"added\" port is handled, the QoS deletion"},{"line_number":27,"context_line":"method is called first (if needed) to remove the unneded artifacts (OVS"},{"line_number":28,"context_line":"registers, OF rules) and remove the QoS cache (port/QoS policy). Then the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_f363ccaf","line":25,"range":{"start_line":25,"start_character":47,"end_line":25,"end_character":52},"updated":"2019-11-20 11:55:12.000000000","message":"nit: double","commit_id":"4b95e517463b638ca68fe6c3198a5742e22c000c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ea0b52a828b4886ef11b5e33fbbf47c8b2b0158","unresolved":false,"context_lines":[{"line_number":22,"context_line":"driver methods (based on the OVS agent QoS cache, storing port and QoS rules)."},{"line_number":23,"context_line":"This will lead to an unconfigured port."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"This patch solves this issue by detecting this doble event and registering it"},{"line_number":26,"context_line":"as \"removed_and_added\". When the \"added\" port is handled, the QoS deletion"},{"line_number":27,"context_line":"method is called first (if needed) to remove the unneded artifacts (OVS"},{"line_number":28,"context_line":"registers, OF rules) and remove the QoS cache (port/QoS policy). Then the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_1ddee7da","line":25,"range":{"start_line":25,"start_character":47,"end_line":25,"end_character":52},"in_reply_to":"3fa7e38b_f363ccaf","updated":"2019-12-06 10:51:46.000000000","message":"Done","commit_id":"4b95e517463b638ca68fe6c3198a5742e22c000c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b806e9306a111d17637fc4fb93e5b0812cfaef7f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"registers, OF rules) and remove the QoS cache (port/QoS policy). Then the"},{"line_number":29,"context_line":"QoS policy is applied again on the port."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"NOTE: this is going to be quite difficult to be tested in a fullstack test."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I51eef168fa8c18a3e4cee57c9ff86046ea9203fd"},{"line_number":34,"context_line":"Closes-Bug: #1845161"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_5372e07d","line":31,"updated":"2019-11-20 11:55:12.000000000","message":"another nit: I think that many of lines in this commit msg are a bit too long","commit_id":"4b95e517463b638ca68fe6c3198a5742e22c000c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ea0b52a828b4886ef11b5e33fbbf47c8b2b0158","unresolved":false,"context_lines":[{"line_number":28,"context_line":"registers, OF rules) and remove the QoS cache (port/QoS policy). Then the"},{"line_number":29,"context_line":"QoS policy is applied again on the port."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"NOTE: this is going to be quite difficult to be tested in a fullstack test."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Change-Id: I51eef168fa8c18a3e4cee57c9ff86046ea9203fd"},{"line_number":34,"context_line":"Closes-Bug: #1845161"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3fa7e38b_3ddba3ea","line":31,"in_reply_to":"3fa7e38b_5372e07d","updated":"2019-12-06 10:51:46.000000000","message":"Done","commit_id":"4b95e517463b638ca68fe6c3198a5742e22c000c"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b806e9306a111d17637fc4fb93e5b0812cfaef7f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                 \u0027added\u0027: added or set(),"},{"line_number":103,"context_line":"                 \u0027removed\u0027: removed or set(),"},{"line_number":104,"context_line":"                 \u0027updated\u0027: updated or set(),"},{"line_number":105,"context_line":"                 \u0027added_and_removed\u0027: added_and_removed or set(),"},{"line_number":106,"context_line":"                 \u0027removed_and_added\u0027: removed_and_added or set()}"},{"line_number":107,"context_line":"        super(PortInfo, self).__init__(_dict)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_1316a8f3","line":105,"updated":"2019-11-20 11:55:12.000000000","message":"What is the use case of this set? If it was added and them removed in same iteration, why it can\u0027t be just treated as \"removed\"?","commit_id":"4b95e517463b638ca68fe6c3198a5742e22c000c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ea0b52a828b4886ef11b5e33fbbf47c8b2b0158","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                 \u0027added\u0027: added or set(),"},{"line_number":103,"context_line":"                 \u0027removed\u0027: removed or set(),"},{"line_number":104,"context_line":"                 \u0027updated\u0027: updated or set(),"},{"line_number":105,"context_line":"                 \u0027added_and_removed\u0027: added_and_removed or set(),"},{"line_number":106,"context_line":"                 \u0027removed_and_added\u0027: removed_and_added or set()}"},{"line_number":107,"context_line":"        super(PortInfo, self).__init__(_dict)"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_5d01bf38","line":105,"in_reply_to":"3fa7e38b_1316a8f3","updated":"2019-12-06 10:51:46.000000000","message":"For now, there is no use case. I can remove it.","commit_id":"4b95e517463b638ca68fe6c3198a5742e22c000c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b806e9306a111d17637fc4fb93e5b0812cfaef7f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                 \u0027removed\u0027: removed or set(),"},{"line_number":104,"context_line":"                 \u0027updated\u0027: updated or set(),"},{"line_number":105,"context_line":"                 \u0027added_and_removed\u0027: added_and_removed or set(),"},{"line_number":106,"context_line":"                 \u0027removed_and_added\u0027: removed_and_added or set()}"},{"line_number":107,"context_line":"        super(PortInfo, self).__init__(_dict)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_f3d66c27","line":106,"range":{"start_line":106,"start_character":18,"end_line":106,"end_character":35},"updated":"2019-11-20 11:55:12.000000000","message":"nit: maybe \"re_added\" would be shorter version of this?","commit_id":"4b95e517463b638ca68fe6c3198a5742e22c000c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9ea0b52a828b4886ef11b5e33fbbf47c8b2b0158","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                 \u0027removed\u0027: removed or set(),"},{"line_number":104,"context_line":"                 \u0027updated\u0027: updated or set(),"},{"line_number":105,"context_line":"                 \u0027added_and_removed\u0027: added_and_removed or set(),"},{"line_number":106,"context_line":"                 \u0027removed_and_added\u0027: removed_and_added or set()}"},{"line_number":107,"context_line":"        super(PortInfo, self).__init__(_dict)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3fa7e38b_bde8f37a","line":106,"range":{"start_line":106,"start_character":18,"end_line":106,"end_character":35},"in_reply_to":"3fa7e38b_f3d66c27","updated":"2019-12-06 10:51:46.000000000","message":"Done","commit_id":"4b95e517463b638ca68fe6c3198a5742e22c000c"}]}