)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa1206546b117a228433d7a0abe27523222bedc1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This reverts commit 69b3762dda47272513e02340e7942d5a39f825c5."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I18ff3b434cf62267ef26f90f00096ab812d0b4b4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_bc6c5c36","line":11,"updated":"2019-10-28 20:04:10.000000000","message":"As zuul wasn\u0027t happy because of that, maybe You can link to bug which is related to this revert?","commit_id":"eb2726c8a8a5aae40c61135abcf0dca106f42352"}],"neutron/db/migration/alembic_migrations/versions/train/expand/c3e9d13c4367_add_binding_index_to_.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ab97309b93ef5949dd8d5931bd1f9eb301a376b6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2019 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_3e4a8b26","side":"PARENT","line":1,"updated":"2019-10-30 00:08:31.000000000","message":"We can directly do such DB migration removal?","commit_id":"69b3762dda47272513e02340e7942d5a39f825c5"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b081ee527ef21e3d5a715f222f7d05a1248d37c4","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\"Add binding index to NetworkDhcpAgentBindings"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Revision ID: c3e9d13c4367"},{"line_number":25,"context_line":"Revises: 63fd95af7dcd"},{"line_number":26,"context_line":"Create Date: 2019-08-20 18:42:39.647676"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_743c9f91","side":"PARENT","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":25},"updated":"2019-10-30 10:44:42.000000000","message":"Again, with this revert patch, the neutron DB could upgrade to 86274d77933e?\nhttps://opendev.org/openstack/neutron/src/branch/master/neutron/db/migration/alembic_migrations/versions/ussuri/expand/86274d77933e_change_mtu_to_not_null.py#L24\n\n\nHere is my test:\n\n/usr/local/bin/neutron-db-manage --config-file /etc/neutron/neutron.conf history\n  Running history for neutron ...\n/usr/local/lib/python3.6/site-packages/alembic/script/revision.py:154: UserWarning: Revision c3e9d13c4367 referenced from c3e9d13c4367 -\u003e 86274d77933e (head),  is not present\n  % (downrev, rev)\nTraceback (most recent call last):\n  File \"/usr/local/bin/neutron-db-manage\", line 10, in \u003cmodule\u003e\n    sys.exit(main())\n  File \"/opt/stack/neutron/neutron/db/migration/cli.py\", line 658, in main\n    return_val |\u003d bool(CONF.command.func(config, CONF.command.name))\n  File \"/opt/stack/neutron/neutron/db/migration/cli.py\", line 97, in do_generic_show\n    do_alembic_command(config, cmd, **kwargs)\n  File \"/opt/stack/neutron/neutron/db/migration/cli.py\", line 83, in do_alembic_command\n    getattr(alembic_command, cmd)(config, *args, **kwargs)\n  File \"/usr/local/lib/python3.6/site-packages/alembic/command.py\", line 430, in history\n    _display_history(config, script, base, head)\n  File \"/usr/local/lib/python3.6/site-packages/alembic/command.py\", line 399, in _display_history\n    base\u003dbase or \"base\", head\u003dhead or \"heads\"\n  File \"/usr/local/lib/python3.6/site-packages/alembic/script/base.py\", line 215, in walk_revisions\n    head, base, inclusive\u003dTrue, assert_relative_length\u003dFalse\n  File \"/usr/local/lib/python3.6/site-packages/alembic/script/revision.py\", line 765, in _iterate_revisions\n    requested_lowers \u003d self.get_revisions(lower)\n  File \"/usr/local/lib/python3.6/site-packages/alembic/script/revision.py\", line 321, in get_revisions\n    resolved_id, branch_label \u003d self._resolve_revision_number(id_)\n  File \"/usr/local/lib/python3.6/site-packages/alembic/script/revision.py\", line 501, in _resolve_revision_number\n    self._revision_map\n  File \"/usr/local/lib/python3.6/site-packages/alembic/util/langhelpers.py\", line 230, in __get__\n    obj.__dict__[self.__name__] \u003d result \u003d self.fget(obj)\n  File \"/usr/local/lib/python3.6/site-packages/alembic/script/revision.py\", line 156, in _revision_map\n    down_revision \u003d map_[downrev]\nKeyError: \u0027c3e9d13c4367\u0027","commit_id":"843b5ffd9a8ee3f4d9d8830f43aa3d517cc11e07"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"299dbc63c8447f76cffca94bd1b26de100e05c5c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\"Add binding index to NetworkDhcpAgentBindings"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Revision ID: c3e9d13c4367"},{"line_number":25,"context_line":"Revises: 63fd95af7dcd"},{"line_number":26,"context_line":"Create Date: 2019-08-20 18:42:39.647676"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_2a97a292","side":"PARENT","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":25},"in_reply_to":"3fa7e38b_47abf7d4","updated":"2019-10-30 12:26:12.000000000","message":"Ok, so You were right, it\u0027s not working now even on clean install. All CI is broken because of that","commit_id":"843b5ffd9a8ee3f4d9d8830f43aa3d517cc11e07"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"824bfc87dfcf4fce8521aa44918dca6e4c5365a3","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\"Add binding index to NetworkDhcpAgentBindings"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Revision ID: c3e9d13c4367"},{"line_number":25,"context_line":"Revises: 63fd95af7dcd"},{"line_number":26,"context_line":"Create Date: 2019-08-20 18:42:39.647676"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_47abf7d4","side":"PARENT","line":24,"range":{"start_line":24,"start_character":13,"end_line":24,"end_character":25},"in_reply_to":"3fa7e38b_743c9f91","updated":"2019-10-30 11:15:14.000000000","message":"Are You trying to to this on new installation or on existing one when You already did db migration including this reverting patch?\nI think it will work fine on all new installation and as this patch which we want to revert wasn\u0027t included in any release yet we should be good to simply revert it.\nLets unblock the gate by merging it ASAP :)\nEspecially that it also broke neutron-dynamic-routing jobs, see https://bugs.launchpad.net/neutron/+bug/1850626 for details","commit_id":"843b5ffd9a8ee3f4d9d8830f43aa3d517cc11e07"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c4b4d32009de3075fe8a133cf7dd5fafa1917d29","unresolved":false,"context_lines":[{"line_number":35,"context_line":"NETWORK_DHCP_AGENT_BINDING \u003d \u0027networkdhcpagentbindings\u0027"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def upgrade():"},{"line_number":39,"context_line":"    op.add_column(NETWORK_DHCP_AGENT_BINDING,"},{"line_number":40,"context_line":"                  sa.Column(\u0027binding_index\u0027, sa.Integer(), nullable\u003dFalse,"},{"line_number":41,"context_line":"                            server_default\u003d\u00271\u0027, autoincrement\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_b1af7ae1","side":"PARENT","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":14},"updated":"2019-10-31 07:17:10.000000000","message":"May I know the reason why a new upgrade does not work? Or why not merge the follow-up patch to this?","commit_id":"843b5ffd9a8ee3f4d9d8830f43aa3d517cc11e07"}],"neutron/db/migration/alembic_migrations/versions/ussuri/expand/86274d77933e_change_mtu_to_not_null.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"c303537e69af148d8f5b01d8c52b85927053ed14","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\"change_mtu_to_not_null"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Revision ID: 86274d77933e"},{"line_number":24,"context_line":"Revises: c613d0b82681"},{"line_number":25,"context_line":"Create Date: 2019-08-30 15:52:30.015146"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_a36f315e","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":21},"updated":"2019-10-31 07:19:38.000000000","message":"Such change never happened before! Looks like this breaks some rules of DB migration.","commit_id":"4da4434d52a05e63fb8bbc043171149068ffe603"}]}