)]}'
{"neutron/core_extensions/qos.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"09564eefdc665225da257c4abcbdcf82afd58f29","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":110,"context_line":"        retval \u003d {qos_consts.QOS_POLICY_ID: qos_policy_id}"},{"line_number":111,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":112,"context_line":"            network_binding \u003d resource.get(\u0027qos_network_policy_binding\u0027)"},{"line_number":113,"context_line":"            qos_net_policy_id \u003d (network_binding[\u0027policy_id\u0027] if"},{"line_number":114,"context_line":"                                 network_binding else None)"},{"line_number":115,"context_line":"            retval[qos_consts.QOS_NETWORK_POLICY_ID] \u003d qos_net_policy_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_52de6f10","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":72},"updated":"2020-01-22 16:07:53.000000000","message":"I think we should make the next 3 lines conditional on a non Null result from this by doing \"if network_binding:\" like is done in the Port object [1].  It seems that is an inexpensive sanity check.  What do you think?\n\n[1] https://opendev.org/openstack/neutron/src/commit/4b48de8e8895cce4c5496f41be3679c1f87297fd/neutron/objects/ports.py#L477","commit_id":"f2b52b5e8f2579cac2e9cd3844ed3e75d18cd06d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"794163d430220a03518b11d3049d693421b6c6cb","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":110,"context_line":"        retval \u003d {qos_consts.QOS_POLICY_ID: qos_policy_id}"},{"line_number":111,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":112,"context_line":"            network_binding \u003d resource.get(\u0027qos_network_policy_binding\u0027)"},{"line_number":113,"context_line":"            qos_net_policy_id \u003d (network_binding[\u0027policy_id\u0027] if"},{"line_number":114,"context_line":"                                 network_binding else None)"},{"line_number":115,"context_line":"            retval[qos_consts.QOS_NETWORK_POLICY_ID] \u003d qos_net_policy_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_fb22d701","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":72},"in_reply_to":"3fa7e38b_52de6f10","updated":"2020-01-22 18:10:56.000000000","message":"This check is done in the next line. \"qos_net_policy_id\" is assigned to network_binding[\u0027policy_id\u0027] only if \"network_binding\" is not None (bool(network_binding) \u003d\u003d True).","commit_id":"f2b52b5e8f2579cac2e9cd3844ed3e75d18cd06d"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"c8a1d2434f2b582aa7d17738b402f1c659840bdb","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        qos_policy_id \u003d binding[\u0027policy_id\u0027] if binding else None"},{"line_number":110,"context_line":"        retval \u003d {qos_consts.QOS_POLICY_ID: qos_policy_id}"},{"line_number":111,"context_line":"        if resource_type \u003d\u003d base.PORT:"},{"line_number":112,"context_line":"            network_binding \u003d resource.get(\u0027qos_network_policy_binding\u0027)"},{"line_number":113,"context_line":"            qos_net_policy_id \u003d (network_binding[\u0027policy_id\u0027] if"},{"line_number":114,"context_line":"                                 network_binding else None)"},{"line_number":115,"context_line":"            retval[qos_consts.QOS_NETWORK_POLICY_ID] \u003d qos_net_policy_id"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fa7e38b_50f08466","line":112,"range":{"start_line":112,"start_character":0,"end_line":112,"end_character":72},"in_reply_to":"3fa7e38b_fb22d701","updated":"2020-01-24 23:27:59.000000000","message":"Indeed it is.  +1","commit_id":"f2b52b5e8f2579cac2e9cd3844ed3e75d18cd06d"}]}