)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cd5ad44606b8799b67c4d4cbe0ad56e175b27f3b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"function, which considers balancing the networks with the agents, whether"},{"line_number":12,"context_line":"enable_dhcp is set on its subnets or not. It does not take into account"},{"line_number":13,"context_line":"the network_auto_schedule config option. This is particularly disturbing"},{"line_number":14,"context_line":"when considering backends which have their provide their own DHCP."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"With this patch, if network_auto_schedule is set to False, networks wont"},{"line_number":17,"context_line":"be automatically scheduled to DHCP Agents. If DHCP is to be mapped to a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_8443e6b0","line":14,"range":{"start_line":14,"start_character":37,"end_line":14,"end_character":42},"updated":"2019-11-26 09:07:36.000000000","message":"nitty nit: not needed here","commit_id":"139b496ef957364caee6861fd16676cdfb76a38b"}],"neutron/db/agentschedulers_db.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0c78ca48c4cd4534f249d935807a63f5dd122524","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                                  \"%(agent)s\","},{"line_number":345,"context_line":"                                  saved_binding)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"                if cfg.CONF.network_auto_schedule:"},{"line_number":348,"context_line":"                    self._schedule_network("},{"line_number":349,"context_line":"                        context, saved_binding[\u0027net\u0027], dhcp_notifier)"},{"line_number":350,"context_line":"        except Exception:"},{"line_number":351,"context_line":"            # we want to be thorough and catch whatever is raised"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_0fe91bb6","line":348,"range":{"start_line":347,"start_character":16,"end_line":348,"end_character":43},"updated":"2019-11-11 03:17:45.000000000","message":"In this class this is the only one calls that schedule_network finally, it checked that \u0027network_auto_schedule\u0027 already. Or I missed something?","commit_id":"893cc1b26c1adf310cb33ac628191780713244cd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"50ca41f13c99e4e467edaec9c158c6ca0c5a77d6","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                                  \"%(agent)s\","},{"line_number":345,"context_line":"                                  saved_binding)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"                if cfg.CONF.network_auto_schedule:"},{"line_number":348,"context_line":"                    self._schedule_network("},{"line_number":349,"context_line":"                        context, saved_binding[\u0027net\u0027], dhcp_notifier)"},{"line_number":350,"context_line":"        except Exception:"},{"line_number":351,"context_line":"            # we want to be thorough and catch whatever is raised"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8f7aebb7","line":348,"range":{"start_line":347,"start_character":16,"end_line":348,"end_character":43},"in_reply_to":"3fa7e38b_0fe91bb6","updated":"2019-11-11 06:11:05.000000000","message":"There are 2 scenarios: \nThis scenario handles the situation when the network is assigned to DHCP and the DHCP agent goes down.\nBut if you have a network which is assigned a DHCP agent ( in an env which has several  agents) and you unmap the network from the agent, it is rescheduled to another DHCP agent  by the DHCP Scheduler.schedule() . That is not required if you have a network which provides DHCP from its backend.","commit_id":"893cc1b26c1adf310cb33ac628191780713244cd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a26a2dbd462e4de029ac81f5b555dc1b53fb16ee","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                                  \"%(agent)s\","},{"line_number":345,"context_line":"                                  saved_binding)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"                if cfg.CONF.network_auto_schedule:"},{"line_number":348,"context_line":"                    self._schedule_network("},{"line_number":349,"context_line":"                        context, saved_binding[\u0027net\u0027], dhcp_notifier)"},{"line_number":350,"context_line":"        except Exception:"},{"line_number":351,"context_line":"            # we want to be thorough and catch whatever is raised"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_efd275fd","line":348,"range":{"start_line":347,"start_character":16,"end_line":348,"end_character":43},"in_reply_to":"3fa7e38b_243439ac","updated":"2019-11-19 03:40:58.000000000","message":"I observed this problem, that if we have a network without DHCP enabled on the subnet, it was still having a map with the DHCP agent. Using Vanilla Openstack. I have also linked the bug which has been created with the similar issue","commit_id":"893cc1b26c1adf310cb33ac628191780713244cd"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b9680f4f1593d6a35271697bde0a873f9f4c3648","unresolved":false,"context_lines":[{"line_number":344,"context_line":"                                  \"%(agent)s\","},{"line_number":345,"context_line":"                                  saved_binding)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"                if cfg.CONF.network_auto_schedule:"},{"line_number":348,"context_line":"                    self._schedule_network("},{"line_number":349,"context_line":"                        context, saved_binding[\u0027net\u0027], dhcp_notifier)"},{"line_number":350,"context_line":"        except Exception:"},{"line_number":351,"context_line":"            # we want to be thorough and catch whatever is raised"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_243439ac","line":348,"range":{"start_line":347,"start_character":16,"end_line":348,"end_character":43},"in_reply_to":"3fa7e38b_8f7aebb7","updated":"2019-11-11 11:20:29.000000000","message":"For one network, if its subnet has no dhcp enabled, such scheduled instance is only in database, agent side has no real resource. I have no idea about the whole story of such scheduling action. But IMO, for different backend providers, it can also silently ignore such thing.","commit_id":"893cc1b26c1adf310cb33ac628191780713244cd"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0c78ca48c4cd4534f249d935807a63f5dd122524","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            return {\u0027agents\u0027: []}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    def schedule_network(self, context, created_network):"},{"line_number":478,"context_line":"        if self.network_scheduler and cfg.CONF.network_auto_schedule:"},{"line_number":479,"context_line":"            return self.network_scheduler.schedule("},{"line_number":480,"context_line":"                self, context, created_network)"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_6fc20f37","line":478,"range":{"start_line":478,"start_character":55,"end_line":478,"end_character":59},"updated":"2019-11-11 03:17:45.000000000","message":"Looks like this \u0027auto\u0027 does not match the function here. More proper place is the Line 483 ?","commit_id":"893cc1b26c1adf310cb33ac628191780713244cd"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b9680f4f1593d6a35271697bde0a873f9f4c3648","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            return {\u0027agents\u0027: []}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    def schedule_network(self, context, created_network):"},{"line_number":478,"context_line":"        if self.network_scheduler and cfg.CONF.network_auto_schedule:"},{"line_number":479,"context_line":"            return self.network_scheduler.schedule("},{"line_number":480,"context_line":"                self, context, created_network)"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c444451c","line":478,"range":{"start_line":478,"start_character":55,"end_line":478,"end_character":59},"in_reply_to":"3fa7e38b_4f4e3397","updated":"2019-11-11 11:20:29.000000000","message":"So for one code path, it will check this config option twice.","commit_id":"893cc1b26c1adf310cb33ac628191780713244cd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"50ca41f13c99e4e467edaec9c158c6ca0c5a77d6","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            return {\u0027agents\u0027: []}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    def schedule_network(self, context, created_network):"},{"line_number":478,"context_line":"        if self.network_scheduler and cfg.CONF.network_auto_schedule:"},{"line_number":479,"context_line":"            return self.network_scheduler.schedule("},{"line_number":480,"context_line":"                self, context, created_network)"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4f4e3397","line":478,"range":{"start_line":478,"start_character":55,"end_line":478,"end_character":59},"in_reply_to":"3fa7e38b_6fc20f37","updated":"2019-11-11 06:11:05.000000000","message":"No, , this is the intended place","commit_id":"893cc1b26c1adf310cb33ac628191780713244cd"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"a26a2dbd462e4de029ac81f5b555dc1b53fb16ee","unresolved":false,"context_lines":[{"line_number":475,"context_line":"            return {\u0027agents\u0027: []}"},{"line_number":476,"context_line":""},{"line_number":477,"context_line":"    def schedule_network(self, context, created_network):"},{"line_number":478,"context_line":"        if self.network_scheduler and cfg.CONF.network_auto_schedule:"},{"line_number":479,"context_line":"            return self.network_scheduler.schedule("},{"line_number":480,"context_line":"                self, context, created_network)"},{"line_number":481,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_8f03c176","line":478,"range":{"start_line":478,"start_character":55,"end_line":478,"end_character":59},"in_reply_to":"3fa7e38b_c444451c","updated":"2019-11-19 03:40:58.000000000","message":"Not exactly.\nSchedule Network() is called whenever a network has to be scheduled ( that includes creation of network as well ). But the earlier check of the config option was done only when the DHCP agents went down.","commit_id":"893cc1b26c1adf310cb33ac628191780713244cd"}],"releasenotes/notes/modify-dhcp-behavior-based-on-network-auto-schedule-1ea5e74fd5bb560c.yaml":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"29a19519c59a2acea92a9efd0fdc4617d0186297","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Neutron currently does not fully respect the network-auto-schedule"},{"line_number":5,"context_line":"    option. If the network-auto-schedule option is set to False, the network"},{"line_number":6,"context_line":"    a) Is still scheduled on the DHCP agent when it is created"},{"line_number":7,"context_line":"    b) Is scheduled on a new DHCP agent if the old DHCP mapping is removed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_38d583b7","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":70},"updated":"2019-11-25 15:06:43.000000000","message":"Let\u0027s be exact to make the reader\u0027s life easier by writing something like this: ``DEFAULT.network_auto_schedule``","commit_id":"cad1ff23fe843c0d96d41f8eb1c1cc7885e5b882"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"89f6d6e9ef1b3aad265179e277670f7d450a1f7b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Neutron currently does not fully respect the network-auto-schedule"},{"line_number":5,"context_line":"    option. If the network-auto-schedule option is set to False, the network"},{"line_number":6,"context_line":"    a) Is still scheduled on the DHCP agent when it is created"},{"line_number":7,"context_line":"    b) Is scheduled on a new DHCP agent if the old DHCP mapping is removed"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_e893925a","line":4,"range":{"start_line":4,"start_character":49,"end_line":4,"end_character":70},"in_reply_to":"3fa7e38b_38d583b7","updated":"2019-11-26 01:55:09.000000000","message":"I think I can reword it to the network-auto-schedule config option","commit_id":"cad1ff23fe843c0d96d41f8eb1c1cc7885e5b882"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"29a19519c59a2acea92a9efd0fdc4617d0186297","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    a) Is still scheduled on the DHCP agent when it is created"},{"line_number":7,"context_line":"    b) Is scheduled on a new DHCP agent if the old DHCP mapping is removed"},{"line_number":8,"context_line":"    by the user/admin."},{"line_number":9,"context_line":"    While (a) is not a deal breaker and seems good to have, (b) needs fix."},{"line_number":10,"context_line":"    It is especially necessary where the Network Backends provide DHCP"},{"line_number":11,"context_line":"    directly. This has been fixed now and if the network-auto-schedule"},{"line_number":12,"context_line":"    is set to False in the config file, networks would not be automatically"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_bb308d9f","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":74},"updated":"2019-11-25 15:06:43.000000000","message":"I don\u0027t see why (a) is good to have. As I read it (a) is still contradicting the config option\u0027s meaning and by that it sets up a later surprise. Am I missing something?","commit_id":"cad1ff23fe843c0d96d41f8eb1c1cc7885e5b882"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"89f6d6e9ef1b3aad265179e277670f7d450a1f7b","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    a) Is still scheduled on the DHCP agent when it is created"},{"line_number":7,"context_line":"    b) Is scheduled on a new DHCP agent if the old DHCP mapping is removed"},{"line_number":8,"context_line":"    by the user/admin."},{"line_number":9,"context_line":"    While (a) is not a deal breaker and seems good to have, (b) needs fix."},{"line_number":10,"context_line":"    It is especially necessary where the Network Backends provide DHCP"},{"line_number":11,"context_line":"    directly. This has been fixed now and if the network-auto-schedule"},{"line_number":12,"context_line":"    is set to False in the config file, networks would not be automatically"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3fa7e38b_4882e600","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":74},"in_reply_to":"3fa7e38b_bb308d9f","updated":"2019-11-26 01:55:09.000000000","message":"If you have a network backend which requires DHCP, then yes, its an unintentional effect, which may not cause any grievances. Just from that angle, its still OK to have.\nYeah, maybe Good is too optimistic a word.\nLet me remove this sentence in its entirety.","commit_id":"cad1ff23fe843c0d96d41f8eb1c1cc7885e5b882"}]}