)]}'
{"neutron/tests/common/agents/l2_extensions.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9235a806b23a358129aab3f703311d8812ef29e3","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                               namespace\u003dreceiver_vm.namespace)"},{"line_number":111,"context_line":"    tcpdump_async.start(block\u003dTrue)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    sender_vm.block_until_ping(receiver_vm.ip)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    try:"},{"line_number":116,"context_line":"        tcpdump_async.stop(kill_signal\u003dsignal.SIGINT)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_98066c1c","line":113,"updated":"2019-11-15 10:51:13.000000000","message":"Yeah, it makes sense.\n\nnit: Reviewing the code (and testing), I realize that block_until_ping -\u003e ping_predicate has a try/except context waiting for RuntimeError. When [1] was implemented, the expected exception for \"assert_ping\" was this one, but now we have created our own one: ProcessExecutionError. We should use it.\n\n[1] I233cb40e701ef462e9d570d9677da1cbcc2c91c8","commit_id":"458fd224db8cb263b8872ae8d0b7c893e9fd8de2"}]}