)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f63b9c7bf72bed9ff204c225e318cabd9183b4a8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add upgrade check for NIC Switch agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds an upgrade check for NIC switch agent"},{"line_number":10,"context_line":"alerting operators to ensure relevant hosts have kernel \u003e 3.13."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This check is introduced due to recent cleanup in NIC switch"},{"line_number":13,"context_line":"agent code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_4f933750","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":62},"updated":"2019-11-18 14:04:32.000000000","message":"Just to be sure: according to [1], hosts with kernel \u003e\u003d 3.13 are OK, that means, including version 3.13.\n\nPlease Adrian, can you check it?\n\nThank you in advance.\n\n[1] https://review.opendev.org/#/c/255916/","commit_id":"8168f8209171e5169be0716a05ddfe13aeda015e"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"a946f912e5b01a2b4c55e522b46ab9767edf2e67","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add upgrade check for NIC Switch agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit adds an upgrade check for NIC switch agent"},{"line_number":10,"context_line":"alerting operators to ensure relevant hosts have kernel \u003e 3.13."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This check is introduced due to recent cleanup in NIC switch"},{"line_number":13,"context_line":"agent code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_db7da5e6","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":62},"in_reply_to":"3fa7e38b_4f933750","updated":"2019-11-18 18:13:37.000000000","message":"Yes its \u003e\u003d3.13, will modify.","commit_id":"8168f8209171e5169be0716a05ddfe13aeda015e"}],"doc/source/cli/neutron-status.rst":[{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"c0f01f9e1de419666418a29f9c60fbb9b4761948","unresolved":false,"context_lines":[{"line_number":60,"context_line":"     * - 255"},{"line_number":61,"context_line":"       - An unexpected error occurred."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  **History of Checks**"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  **21.0.0 (Ussuri)**"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"3fa7e38b_acf759d4","line":63,"range":{"start_line":63,"start_character":2,"end_line":63,"end_character":23},"updated":"2019-11-18 12:43:51.000000000","message":"according to [1] we should have a history of checks \n\n  \"Each check should be documented in the history section of \n  the CLI guide and have a release note. This is important \n  since the checks can be run in an isolated environment \n  apart from the actual deployed version of the code and \n  since the checks should be idempotent, the history / \n  change log is good for knowing what is being validated.\"\n\n\nA release note was already added in [2]\n\n[1]https://docs.openstack.org/nova/latest/reference/upgrade-checks.html\n[2]https://review.opendev.org/#/c/677095","commit_id":"8168f8209171e5169be0716a05ddfe13aeda015e"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a10c49ba617e19d8d14bfdb5c864f7bfcd59f89e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"         upgrade."},{"line_number":60,"context_line":"     * - 255"},{"line_number":61,"context_line":"       - An unexpected error occurred."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  **History of Checks**"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  **21.0.0 (Ussuri)**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_e5369402","line":62,"updated":"2019-11-21 10:27:29.000000000","message":"No needed for this patch but we should add history of older checks which we forgot to add earlier :/","commit_id":"46fbaa0e54ec8515922f219e022a4957963c6f3c"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5e806a54278bd4f619adce78b00f63b850642bff","unresolved":false,"context_lines":[{"line_number":59,"context_line":"         upgrade."},{"line_number":60,"context_line":"     * - 255"},{"line_number":61,"context_line":"       - An unexpected error occurred."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  **History of Checks**"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  **21.0.0 (Ussuri)**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_9c65841f","line":62,"in_reply_to":"3fa7e38b_2845586f","updated":"2019-11-25 20:44:04.000000000","message":"no, this one is fine. I just wanted to say that we should add history with other checkes to this list also. Sorry for confusing comment.","commit_id":"46fbaa0e54ec8515922f219e022a4957963c6f3c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a10a5c00973fee6288aa982d1a5746fe1acc8cdd","unresolved":false,"context_lines":[{"line_number":59,"context_line":"         upgrade."},{"line_number":60,"context_line":"     * - 255"},{"line_number":61,"context_line":"       - An unexpected error occurred."},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  **History of Checks**"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  **21.0.0 (Ussuri)**"}],"source_content_type":"text/x-rst","patch_set":2,"id":"3fa7e38b_2845586f","line":62,"in_reply_to":"3fa7e38b_e5369402","updated":"2019-11-21 18:17:15.000000000","message":"That means Adrian needs to remove this or not? Sorry, this is not clear for me.","commit_id":"46fbaa0e54ec8515922f219e022a4957963c6f3c"}],"neutron/cmd/upgrade_checks/checks.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a10c49ba617e19d8d14bfdb5c864f7bfcd59f89e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        # U release is the first release that moves from CentOS-7 to CentOS-8,"},{"line_number":181,"context_line":"        # this was added as a \"heads-up\" for operators to make sure min kernel"},{"line_number":182,"context_line":"        # requirement is fullfiled."},{"line_number":183,"context_line":"        agents \u003d get_nic_switch_agents()"},{"line_number":184,"context_line":"        if len(agents):"},{"line_number":185,"context_line":"            hosts \u003d \u0027,\u0027.join([agent.get(\"host\") for agent in agents])"},{"line_number":186,"context_line":"            return upgradecheck.Result("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b0121857","line":183,"updated":"2019-11-21 10:27:29.000000000","message":"You need to add something like in L 152 here also to warn users if there is no db connection string set.\nThis will also help with failing functional test.","commit_id":"46fbaa0e54ec8515922f219e022a4957963c6f3c"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"ce4b81cca3e024104eec7e2f76210c598dd73bc3","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        # U release is the first release that moves from CentOS-7 to CentOS-8,"},{"line_number":181,"context_line":"        # this was added as a \"heads-up\" for operators to make sure min kernel"},{"line_number":182,"context_line":"        # requirement is fullfiled."},{"line_number":183,"context_line":"        agents \u003d get_nic_switch_agents()"},{"line_number":184,"context_line":"        if len(agents):"},{"line_number":185,"context_line":"            hosts \u003d \u0027,\u0027.join([agent.get(\"host\") for agent in agents])"},{"line_number":186,"context_line":"            return upgradecheck.Result("}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9c137259","line":183,"in_reply_to":"3fa7e38b_b0121857","updated":"2019-11-21 16:30:41.000000000","message":"Thanks Slawek!\ni didn\u0027t get a chance to run functional test inhouse and sort the issue.","commit_id":"46fbaa0e54ec8515922f219e022a4957963c6f3c"}]}