)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"89e31f0fb8df616a940e2bf195982c2c49678e96","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        pid \u003d self.pid"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if self.active:"},{"line_number":183,"context_line":"            cmd \u003d [\u0027kill\u0027, \u0027-15\u0027, pid]"},{"line_number":184,"context_line":"            utils.execute(cmd, self.root_helper)"},{"line_number":185,"context_line":"            if not retain_port:"},{"line_number":186,"context_line":"                self.device_manager.destroy(self.network, self.interface_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSTI%3D","line":183,"updated":"2014-01-28 11:54:33.000000000","message":"I think this is a great opportunity to port this to signal.SIGTERM and os.kill.","commit_id":"3479177d218899e9daf025c93bfe42aff10ced21"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"b2a09d85c01be0a2c705c7fbd06bf3e9edc4f9b3","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        pid \u003d self.pid"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if self.active:"},{"line_number":183,"context_line":"            cmd \u003d [\u0027kill\u0027, \u0027-15\u0027, pid]"},{"line_number":184,"context_line":"            utils.execute(cmd, self.root_helper)"},{"line_number":185,"context_line":"            if not retain_port:"},{"line_number":186,"context_line":"                self.device_manager.destroy(self.network, self.interface_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSFU%3D","line":183,"in_reply_to":"AAAAUH%2F%2BSHk%3D","updated":"2014-01-28 12:38:50.000000000","message":"Folks, this is an investigation.\nI don\u0027t think SIGTERM is acceptable in production at this stage because it might leave running unwanted and potentially dangerous running processes behind.\n\nUsage of os.kill I think will preclude usage of rootwrap, and that would be another problem to face.","commit_id":"3479177d218899e9daf025c93bfe42aff10ced21"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f25d83990adf253afd9587fae39f67bd6b82549e","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        pid \u003d self.pid"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if self.active:"},{"line_number":183,"context_line":"            cmd \u003d [\u0027kill\u0027, \u0027-15\u0027, pid]"},{"line_number":184,"context_line":"            utils.execute(cmd, self.root_helper)"},{"line_number":185,"context_line":"            if not retain_port:"},{"line_number":186,"context_line":"                self.device_manager.destroy(self.network, self.interface_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSHk%3D","line":183,"in_reply_to":"AAAAUH%2F%2BSI0%3D","updated":"2014-01-28 12:33:48.000000000","message":"Sorry, it\u0027s me who doesn\u0027t read... ;)","commit_id":"3479177d218899e9daf025c93bfe42aff10ced21"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f03b2d09b7e288132fb219e5b5af4a6d9a8f3a6f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        pid \u003d self.pid"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        if self.active:"},{"line_number":183,"context_line":"            cmd \u003d [\u0027kill\u0027, \u0027-15\u0027, pid]"},{"line_number":184,"context_line":"            utils.execute(cmd, self.root_helper)"},{"line_number":185,"context_line":"            if not retain_port:"},{"line_number":186,"context_line":"                self.device_manager.destroy(self.network, self.interface_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BSI0%3D","line":183,"in_reply_to":"AAAAUH%2F%2BSTI%3D","updated":"2014-01-28 12:31:13.000000000","message":"read https://bugs.launchpad.net/neutron/+bug/1273386/comments/5 :-)\n\nIt\u0027s just a test","commit_id":"3479177d218899e9daf025c93bfe42aff10ced21"}]}