)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3c65f978963db0b30659b84d8de71d8b70b336a0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"./networking_ovn/common/utils.py -\u003e ./neutron/common/ovn/utils.py"},{"line_number":15,"context_line":"./networking_ovn/common/hash_ring_manager.py -\u003e neutron/common/ovn/hash_ring_manager.py"},{"line_number":16,"context_line":"./networking_ovn/common/config.py -\u003e ./neutron/conf/ovn.py"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ib46bfdd14a150a324dbf28c6a50c839c5c824e35"},{"line_number":19,"context_line":"Related-Blueprint: neutron-ovn-merge"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"3fa7e38b_a1e25b01","line":17,"updated":"2019-11-29 15:33:50.000000000","message":"Please add authors of original files as co-authors of this patch","commit_id":"0d5b38d1577ec26da1d282bb2a3b464151f4302a"}],"etc/oslo-config-generator/macvtap_agent.ini":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d70d06dad7a9b5c4aa61d3f4f6a54f2b9332ef8a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"output_file \u003d etc/neutron/plugins/ml2/macvtap_agent.ini.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.ovn"},{"line_number":6,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":18,"id":"3fa7e38b_d0a7edbb","line":5,"updated":"2019-12-04 08:45:18.000000000","message":"is this change in correct file?","commit_id":"4dc36a20f2db7f08f2d065e1221734f65c96d369"}],"etc/oslo-config-generator/ovn.ini":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d70d06dad7a9b5c4aa61d3f4f6a54f2b9332ef8a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"output_file \u003d etc/neutron/ovn.ini.sample"},{"line_number":3,"context_line":"wrap_width \u003d 79"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"namespace \u003d neutron.ml2.macvtap.agent"},{"line_number":6,"context_line":"namespace \u003d oslo.log"}],"source_content_type":"text/x-properties","patch_set":18,"id":"3fa7e38b_90917556","line":5,"updated":"2019-12-04 08:45:18.000000000","message":"is that correct?","commit_id":"4dc36a20f2db7f08f2d065e1221734f65c96d369"}],"neutron/common/ovn/exceptions.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb9f9138ed622090b99c5ab350d0a4a69967b979","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2017 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_2bc98b50","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2019-11-27 13:09:41.000000000","message":"nitty nit: 2019, but please change it only if You will respin this patch for different reason :)","commit_id":"d78ff76ff81b550caa93bd5ab4fb83489caab20a"}],"neutron/conf/ovn.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb9f9138ed622090b99c5ab350d0a4a69967b979","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    return cfg.CONF.ovn.ovn_dhcp6_global_options"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"def setup_logging():"},{"line_number":296,"context_line":"    \"\"\"Sets up the logging options for a log with supplied name.\"\"\""},{"line_number":297,"context_line":"    product_name \u003d \"networking-ovn\""},{"line_number":298,"context_line":"    # We use the oslo.log default log levels and add only the extra levels"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_2b374b4e","line":295,"range":{"start_line":295,"start_character":4,"end_line":295,"end_character":17},"updated":"2019-11-27 13:09:41.000000000","message":"do we need this function here? There is similar one in neutron/common/config.py already","commit_id":"d78ff76ff81b550caa93bd5ab4fb83489caab20a"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"6b413c9141734d4a2323e93730541eb91d6c6265","unresolved":false,"context_lines":[{"line_number":292,"context_line":"    return cfg.CONF.ovn.ovn_dhcp6_global_options"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"def setup_logging():"},{"line_number":296,"context_line":"    \"\"\"Sets up the logging options for a log with supplied name.\"\"\""},{"line_number":297,"context_line":"    product_name \u003d \"networking-ovn\""},{"line_number":298,"context_line":"    # We use the oslo.log default log levels and add only the extra levels"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_0b236f08","line":295,"range":{"start_line":295,"start_character":4,"end_line":295,"end_character":17},"in_reply_to":"3fa7e38b_2b374b4e","updated":"2019-11-27 13:11:23.000000000","message":"I believe no. thx","commit_id":"d78ff76ff81b550caa93bd5ab4fb83489caab20a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb9f9138ed622090b99c5ab350d0a4a69967b979","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"def setup_logging():"},{"line_number":296,"context_line":"    \"\"\"Sets up the logging options for a log with supplied name.\"\"\""},{"line_number":297,"context_line":"    product_name \u003d \"networking-ovn\""},{"line_number":298,"context_line":"    # We use the oslo.log default log levels and add only the extra levels"},{"line_number":299,"context_line":"    # that we need."},{"line_number":300,"context_line":"    logging.set_defaults(default_log_levels\u003dlogging.get_default_log_levels() +"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ebeb73a1","line":297,"range":{"start_line":297,"start_character":20,"end_line":297,"end_character":34},"updated":"2019-11-27 13:09:41.000000000","message":"still?","commit_id":"d78ff76ff81b550caa93bd5ab4fb83489caab20a"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"6b413c9141734d4a2323e93730541eb91d6c6265","unresolved":false,"context_lines":[{"line_number":294,"context_line":""},{"line_number":295,"context_line":"def setup_logging():"},{"line_number":296,"context_line":"    \"\"\"Sets up the logging options for a log with supplied name.\"\"\""},{"line_number":297,"context_line":"    product_name \u003d \"networking-ovn\""},{"line_number":298,"context_line":"    # We use the oslo.log default log levels and add only the extra levels"},{"line_number":299,"context_line":"    # that we need."},{"line_number":300,"context_line":"    logging.set_defaults(default_log_levels\u003dlogging.get_default_log_levels() +"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_6b0ea38d","line":297,"range":{"start_line":297,"start_character":20,"end_line":297,"end_character":34},"in_reply_to":"3fa7e38b_ebeb73a1","updated":"2019-11-27 13:11:23.000000000","message":";) no :)","commit_id":"d78ff76ff81b550caa93bd5ab4fb83489caab20a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cd8faba57819c7c0ab6e0cf6803eac258e2f3064","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_e41dc162","line":1,"updated":"2019-11-29 16:16:57.000000000","message":"IMO, this should go to neutron.conf.plugins.ml2.drivers.ovn","commit_id":"0d5b38d1577ec26da1d282bb2a3b464151f4302a"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"319f1f30ec3b3eec3530e72dba668a318ab498d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_0dfca770","line":1,"in_reply_to":"3fa7e38b_d5f9464e","updated":"2019-12-03 07:59:08.000000000","message":"ACK, moving","commit_id":"0d5b38d1577ec26da1d282bb2a3b464151f4302a"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"c6a8fbfb0d94616cc92228344157507f14dd36af","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_d5f9464e","line":1,"in_reply_to":"3fa7e38b_e41dc162","updated":"2019-12-02 09:27:28.000000000","message":"+1","commit_id":"0d5b38d1577ec26da1d282bb2a3b464151f4302a"}],"neutron/plugins/ml2/drivers/ovn/common/utils.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fb9f9138ed622090b99c5ab350d0a4a69967b979","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import re"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"from neutron._i18n import _"},{"line_number":20,"context_line":"from neutron.common.ovn import constants"},{"line_number":21,"context_line":"from neutron.common.ovn import exceptions as ovn_exc"},{"line_number":22,"context_line":"from neutron_lib.api.definitions import external_net"},{"line_number":23,"context_line":"from neutron_lib.api.definitions import extra_dhcp_opt as edo_ext"},{"line_number":24,"context_line":"from neutron_lib.api.definitions import l3"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_eb4053a5","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":52},"updated":"2019-11-27 13:09:41.000000000","message":"those imports should be in 3rd group of imports","commit_id":"d78ff76ff81b550caa93bd5ab4fb83489caab20a"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"6b413c9141734d4a2323e93730541eb91d6c6265","unresolved":false,"context_lines":[{"line_number":16,"context_line":"import re"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"from neutron._i18n import _"},{"line_number":20,"context_line":"from neutron.common.ovn import constants"},{"line_number":21,"context_line":"from neutron.common.ovn import exceptions as ovn_exc"},{"line_number":22,"context_line":"from neutron_lib.api.definitions import external_net"},{"line_number":23,"context_line":"from neutron_lib.api.definitions import extra_dhcp_opt as edo_ext"},{"line_number":24,"context_line":"from neutron_lib.api.definitions import l3"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_cb1c77c4","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":52},"in_reply_to":"3fa7e38b_eb4053a5","updated":"2019-11-27 13:11:23.000000000","message":"ack","commit_id":"d78ff76ff81b550caa93bd5ab4fb83489caab20a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7fbca3781b65d8e6574068cd022dd3bb31390e58","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":13,"id":"3fa7e38b_feb8fac7","line":1,"updated":"2019-11-28 16:43:43.000000000","message":"Why this file is here instead of common.ovn?\n\nThis is also used in common.ovn.acl and implements methods that will be used in db.ovn_revision_numbers_db, agent.ovsdb.ovn.commands, etc; IMO this should be in common.ovn.utils.","commit_id":"d4739fc027e4f403a9294f3d902da533ac38c3b1"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"f277bb295a26a52312fe41a48fd5ff079b1a0201","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":13,"id":"3fa7e38b_60646422","line":1,"in_reply_to":"3fa7e38b_feb8fac7","updated":"2019-11-29 08:01:07.000000000","message":"Ok, so lets move it.","commit_id":"d4739fc027e4f403a9294f3d902da533ac38c3b1"}],"neutron/tests/unit/common/ovn/test_utils.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"299447700e44d593ba330c0a02047cd00b60d87e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 Red Hat, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":17,"id":"3fa7e38b_38b75f88","line":1,"range":{"start_line":1,"start_character":15,"end_line":1,"end_character":16},"updated":"2019-12-03 09:41:20.000000000","message":"9","commit_id":"34641048f95d1e613dff829cff960a81f7e4df63"}],"setup.cfg":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b155aa7f5b24ba9c6b1de79bfee20bed4180a65b","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    neutron.ml2.sriov.agent \u003d neutron.opts:list_sriov_agent_opts"},{"line_number":148,"context_line":"    neutron.ml2.xenapi \u003d neutron.opts:list_xenapi_opts"},{"line_number":149,"context_line":"    nova.auth \u003d neutron.opts:list_auth_opts"},{"line_number":150,"context_line":"    ovn \u003d neutron.conf.plugins.ml2.drivers.ovn.ovn_conf:list_opts"},{"line_number":151,"context_line":"oslo.config.opts.defaults \u003d"},{"line_number":152,"context_line":"    neutron \u003d neutron.common.config:set_cors_middleware_defaults"},{"line_number":153,"context_line":"oslo.policy.enforcer \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":17,"id":"3fa7e38b_fec76c45","line":150,"range":{"start_line":150,"start_character":4,"end_line":150,"end_character":7},"updated":"2019-12-03 14:00:34.000000000","message":"shouldn\u0027t be \"neutron.ovn\" here?","commit_id":"34641048f95d1e613dff829cff960a81f7e4df63"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"557b8e4c6b5ac325fa893eaa5a8953367dade928","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    neutron.ml2.sriov.agent \u003d neutron.opts:list_sriov_agent_opts"},{"line_number":148,"context_line":"    neutron.ml2.xenapi \u003d neutron.opts:list_xenapi_opts"},{"line_number":149,"context_line":"    nova.auth \u003d neutron.opts:list_auth_opts"},{"line_number":150,"context_line":"    ovn \u003d neutron.conf.plugins.ml2.drivers.ovn.ovn_conf:list_opts"},{"line_number":151,"context_line":"oslo.config.opts.defaults \u003d"},{"line_number":152,"context_line":"    neutron \u003d neutron.common.config:set_cors_middleware_defaults"},{"line_number":153,"context_line":"oslo.policy.enforcer \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":17,"id":"3fa7e38b_b0e35c06","line":150,"range":{"start_line":150,"start_character":4,"end_line":150,"end_character":7},"in_reply_to":"3fa7e38b_fec76c45","updated":"2019-12-03 17:15:08.000000000","message":"+1","commit_id":"34641048f95d1e613dff829cff960a81f7e4df63"}]}
