)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7c40e8fe8ac4acdfdecff4444e5de5f232f2f22a","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"We try to not block later developments in which one neutron"},{"line_number":49,"context_line":"agent may manage devices on multiple hosts. That\u0027s why we allow"},{"line_number":50,"context_line":"the each physdev to be associated with a different hypervisor."},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"But here we do not try to solve the problem that the natural physdev"},{"line_number":53,"context_line":"identifiers may not be unique accross multiple hosts. We leave solving"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_633a8acd","line":50,"range":{"start_line":50,"start_character":0,"end_line":50,"end_character":3},"updated":"2019-12-11 16:29:08.000000000","message":"nit: that","commit_id":"258eebea71b1cac37badf429a90d5cf57e4c455c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7c40e8fe8ac4acdfdecff4444e5de5f232f2f22a","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Since we only changed the free-format configurations field of the"},{"line_number":74,"context_line":"report_state message rpc version is not bumped and we expect this"},{"line_number":75,"context_line":"change to be backported to stein and train."},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"Change-Id: I9b08a3a9c20b702b745b41d4885fb5120fd665ce"},{"line_number":78,"context_line":"Closes-Bug: #1853840"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_034f166a","line":75,"updated":"2019-12-11 16:29:08.000000000","message":"+1","commit_id":"258eebea71b1cac37badf429a90d5cf57e4c455c"}],"neutron/agent/common/utils.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"dcb14f560c4569f128edd6815b21b3dd1f5498d8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    :param device_mappings: Device mappings standardized to the list-valued"},{"line_number":84,"context_line":"        format."},{"line_number":85,"context_line":"    \"\"\""},{"line_number":86,"context_line":"    default_hypervisor \u003d socket.gethostname()"},{"line_number":87,"context_line":"    rv \u003d {}"},{"line_number":88,"context_line":"    for _physnet, devices in device_mappings.items():"},{"line_number":89,"context_line":"        for device in devices:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_1c278db8","line":86,"range":{"start_line":86,"start_character":25,"end_line":86,"end_character":45},"updated":"2019-12-10 13:14:49.000000000","message":"nit: you can use the neutron-lib method for this:\nhttps://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/utils/net.py#L23","commit_id":"258eebea71b1cac37badf429a90d5cf57e4c455c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7c40e8fe8ac4acdfdecff4444e5de5f232f2f22a","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    :param device_mappings: Device mappings standardized to the list-valued"},{"line_number":84,"context_line":"        format."},{"line_number":85,"context_line":"    \"\"\""},{"line_number":86,"context_line":"    default_hypervisor \u003d socket.gethostname()"},{"line_number":87,"context_line":"    rv \u003d {}"},{"line_number":88,"context_line":"    for _physnet, devices in device_mappings.items():"},{"line_number":89,"context_line":"        for device in devices:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_43598e26","line":86,"range":{"start_line":86,"start_character":25,"end_line":86,"end_character":45},"in_reply_to":"3fa7e38b_1c278db8","updated":"2019-12-11 16:29:08.000000000","message":"That can be done when this is moved to neutron_lib anyhow.","commit_id":"258eebea71b1cac37badf429a90d5cf57e4c455c"}],"neutron/services/placement_report/plugin.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"671da8611d401244292c27d840ffd5ca9ab5b082","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            # hypervisor name, which is true in many deployments, but not"},{"line_number":88,"context_line":"            # always. (In nova terminology: The compute host\u0027s DEFAULT.host is"},{"line_number":89,"context_line":"            # not neccessarily the same as the compute node name. We may even"},{"line_number":90,"context_line":"            # have multiple compute nodes behind a compute host.)"},{"line_number":91,"context_line":"            hypervisors \u003d {"},{"line_number":92,"context_line":"                device: agent[\u0027host\u0027]"},{"line_number":93,"context_line":"                for device"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_353f1387","line":90,"updated":"2019-12-09 09:35:11.000000000","message":"maybe You can add note about release when we added that and/or when we can remove this \"else\" block","commit_id":"b507cd3a2159991151eee671d8ec026b41c67a18"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"ba4565de6a0aac8287e6e209a67324d6c56321fc","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            # hypervisor name, which is true in many deployments, but not"},{"line_number":88,"context_line":"            # always. (In nova terminology: The compute host\u0027s DEFAULT.host is"},{"line_number":89,"context_line":"            # not neccessarily the same as the compute node name. We may even"},{"line_number":90,"context_line":"            # have multiple compute nodes behind a compute host.)"},{"line_number":91,"context_line":"            hypervisors \u003d {"},{"line_number":92,"context_line":"                device: agent[\u0027host\u0027]"},{"line_number":93,"context_line":"                for device"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a502e3b8","line":90,"in_reply_to":"3fa7e38b_353f1387","updated":"2019-12-10 09:26:07.000000000","message":"Done","commit_id":"b507cd3a2159991151eee671d8ec026b41c67a18"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"671da8611d401244292c27d840ffd5ca9ab5b082","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                for device"},{"line_number":94,"context_line":"                in configurations[\u0027resource_provider_bandwidths\u0027].keys()"},{"line_number":95,"context_line":"            }"},{"line_number":96,"context_line":"        LOG.error(\u0027device-hypervisor map: %s\u0027, repr(hypervisors))"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        log_msg \u003d ("},{"line_number":99,"context_line":"            \u0027Synchronization of resources \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_f56dfb98","line":96,"updated":"2019-12-09 09:35:11.000000000","message":"I think this is some development leftover, isn\u0027t it?","commit_id":"b507cd3a2159991151eee671d8ec026b41c67a18"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"ba4565de6a0aac8287e6e209a67324d6c56321fc","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                for device"},{"line_number":94,"context_line":"                in configurations[\u0027resource_provider_bandwidths\u0027].keys()"},{"line_number":95,"context_line":"            }"},{"line_number":96,"context_line":"        LOG.error(\u0027device-hypervisor map: %s\u0027, repr(hypervisors))"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        log_msg \u003d ("},{"line_number":99,"context_line":"            \u0027Synchronization of resources \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_a53423ad","line":96,"in_reply_to":"3fa7e38b_f56dfb98","updated":"2019-12-10 09:26:07.000000000","message":"oops, yes","commit_id":"b507cd3a2159991151eee671d8ec026b41c67a18"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7c40e8fe8ac4acdfdecff4444e5de5f232f2f22a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            # always. (In nova terminology: The compute host\u0027s DEFAULT.host is"},{"line_number":89,"context_line":"            # not neccessarily the same as the compute node name. We may even"},{"line_number":90,"context_line":"            # have multiple compute nodes behind a compute host.)"},{"line_number":91,"context_line":"            # TODO(bence romsics): This else branch can be removed when we no"},{"line_number":92,"context_line":"            # longer want to support pre-Ussuri agents."},{"line_number":93,"context_line":"            hypervisors \u003d {"},{"line_number":94,"context_line":"                device: agent[\u0027host\u0027]"},{"line_number":95,"context_line":"                for device"},{"line_number":96,"context_line":"                in configurations[\u0027resource_provider_bandwidths\u0027].keys()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_63db6a7c","line":93,"range":{"start_line":91,"start_character":0,"end_line":93,"end_character":1},"updated":"2019-12-11 16:29:08.000000000","message":"+1","commit_id":"258eebea71b1cac37badf429a90d5cf57e4c455c"}],"releasenotes/notes/locate-rp-tree-parent-by-hypervisor-name-3244ed87dc57f950.yaml":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"671da8611d401244292c27d840ffd5ca9ab5b082","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``sriov-agent``. Hypervisor names default to ``socket.gethostname()``"},{"line_number":11,"context_line":"    which works out of the box with ``libvirt`` even when the ``DEFAULT.host``"},{"line_number":12,"context_line":"    config option is set to a non-default value. We believe this change fixes"},{"line_number":13,"context_line":"    `bug 696600 \u003chttps://launchpad.net/bugs/1853840\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_7507cbca","line":13,"updated":"2019-12-09 09:35:11.000000000","message":"Maybe You should also add \"upgrade\" section with description of new config option?","commit_id":"b507cd3a2159991151eee671d8ec026b41c67a18"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"ba4565de6a0aac8287e6e209a67324d6c56321fc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``sriov-agent``. Hypervisor names default to ``socket.gethostname()``"},{"line_number":11,"context_line":"    which works out of the box with ``libvirt`` even when the ``DEFAULT.host``"},{"line_number":12,"context_line":"    config option is set to a non-default value. We believe this change fixes"},{"line_number":13,"context_line":"    `bug 696600 \u003chttps://launchpad.net/bugs/1853840\u003e`_."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3fa7e38b_a5d0a32c","line":13,"in_reply_to":"3fa7e38b_7507cbca","updated":"2019-12-10 09:26:07.000000000","message":"Done","commit_id":"b507cd3a2159991151eee671d8ec026b41c67a18"}]}