)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"faebed28c3987f28fc960172fd74836c668ba6b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Improve ovs cleanup utility help"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Fixed a couple of things for ovs_all_ports\u003dFalse."},{"line_number":10,"context_line":"First state that it also cleans up ports created Nova."},{"line_number":11,"context_line":"Second since [1] it only cleans up the integration bridge."},{"line_number":12,"context_line":"[1] https://opendev.org/openstack/neutron/commit/b09b4460"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_a1d562e8","line":10,"range":{"start_line":10,"start_character":49,"end_line":10,"end_character":53},"updated":"2019-12-19 15:36:54.000000000","message":"nit: by Nova","commit_id":"b63862aba886c28c93cb385511dd3d9b788a579a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"faebed28c3987f28fc960172fd74836c668ba6b8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Fixed a couple of things for ovs_all_ports\u003dFalse."},{"line_number":10,"context_line":"First state that it also cleans up ports created Nova."},{"line_number":11,"context_line":"Second since [1] it only cleans up the integration bridge."},{"line_number":12,"context_line":"[1] https://opendev.org/openstack/neutron/commit/b09b4460"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I41dda554e8cb4b4ca36515d64f17ad5bf52f3b49"},{"line_number":15,"context_line":"Closes-Bug: #1853582"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3fa7e38b_21fbb27b","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":57},"updated":"2019-12-19 15:36:54.000000000","message":"nit: insert a blank line before this one","commit_id":"b63862aba886c28c93cb385511dd3d9b788a579a"}],"neutron/conf/agent/cmd.py":[{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"951e63efa4a844f8b0d28fc79fe5ce286904e592","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d_(\u0027True to delete all ports on all the OpenvSwitch \u0027"},{"line_number":44,"context_line":"                       \u0027bridges. False to delete ports created by \u0027"},{"line_number":45,"context_line":"                       \u0027Neutron and Nova on the integration bridge.\u0027))"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_4958faf7","line":45,"range":{"start_line":45,"start_character":41,"end_line":45,"end_character":66},"updated":"2019-12-09 14:55:56.000000000","message":"After I read the relevant code I think this still does not describe the actual behavior. To my understanding this is how the code behaves (without implying whether this is the wanted behavior or not):\n\n1) We always act on all ovs bridges - the value of ovs_all_ports does not matter in that. Please see my comment in the bug report.\n\nhttps://bugs.launchpad.net/neutron/+bug/1853582/comments/4\n\n2) ovs_all_ports\u003dTrue deletes absolutely all ports on all bridges.\n\n3) ovs_all_ports\u003dFalse deletes all VIFs on all bridges.\n\nWhere vifs are ports (whose interfaces) marked with both external_ids iface-id and attached-mac. (That\u0027s what we call vif, right?)\n\nI\u0027m not sure if skip_cleanup needs to be explained in this help string.\n\nSince nova and neutron both create vifs (nova for VMs, neutron for routers, dhcp, etc.), I think the the correct help would be: False to only delete VIFs on all bridges. ;-)\n\nIf I had to guess the original intent it would be like:\n\n\u0027No\u0027 to clean up all ports except patch ports (and the special bridge representor port with the same name as the bridge). \u0027Yes\u0027 to clean up absolutely everything.\n\nFor the record here\u0027s one diff of what it actually cleaned up from a random devstack environment:\n\n$ diff -u ~/ports-{before,after}-cleanup\n--- /home/rubasov/ports-before-cleanup  2019-12-09 14:38:23.345733351 +0000\n+++ /home/rubasov/ports-after-cleanup   2019-12-09 14:36:01.876459607 +0000\n@@ -2,18 +2,9 @@\n br-int\n br-physnet0\n br-tun\n-fg-1731b198-e0\n int-br-ex\n int-br-physnet0\n patch-int\n patch-tun\n phy-br-ex\n phy-br-physnet0\n-qg-abf516cf-90\n-qr-1ea78e69-2a\n-qr-1f0311dc-64\n-sg-2c2ad50e-aa\n-sg-ba92a268-ae\n-tap2c3402b2-4b\n-tap3d587e18-b0\n-tapc10c9b62-9f","commit_id":"b63862aba886c28c93cb385511dd3d9b788a579a"},{"author":{"_account_id":2733,"name":"Darragh O\u0027Reilly","email":"doreilly@suse.com","username":"darragh-oreilly"},"change_message_id":"122100444ac673e4314f3754303978c0f6ac7812","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d_(\u0027True to delete all ports on all the OpenvSwitch \u0027"},{"line_number":44,"context_line":"                       \u0027bridges. False to delete ports created by \u0027"},{"line_number":45,"context_line":"                       \u0027Neutron and Nova on the integration bridge.\u0027))"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_b0978a39","line":45,"range":{"start_line":45,"start_character":41,"end_line":45,"end_character":66},"in_reply_to":"3fa7e38b_4958faf7","updated":"2019-12-09 17:08:09.000000000","message":"For (1) see my comments in the bug.\nFor (2) agree.\nFor (3) I can change it to \"False to only delete VIFs on the integration bridge\"","commit_id":"b63862aba886c28c93cb385511dd3d9b788a579a"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"ac2e3ec811b8c9e64571dd5f629fe960a205fbc1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                default\u003dFalse,"},{"line_number":43,"context_line":"                help\u003d_(\u0027True to delete all ports on all the OpenvSwitch \u0027"},{"line_number":44,"context_line":"                       \u0027bridges. False to delete ports created by \u0027"},{"line_number":45,"context_line":"                       \u0027Neutron and Nova on the integration bridge.\u0027))"},{"line_number":46,"context_line":"]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_363627e9","line":45,"range":{"start_line":45,"start_character":41,"end_line":45,"end_character":66},"in_reply_to":"3fa7e38b_b0978a39","updated":"2019-12-10 12:06:45.000000000","message":"(1) You\u0027re right.\n(3) As you feel like. My main point wanted to be about the bridges - but I was wrong about that. Writing about VIFs is technically more correct but the concept of a VIF may not be well known to even administrators.","commit_id":"b63862aba886c28c93cb385511dd3d9b788a579a"}]}