)]}'
{"neutron/agent/common/ovs_lib.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"af572ba4b009caad67c910d7f4182611f63016be","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def is_hw_offload_enabled(self):"},{"line_number":205,"context_line":"        _cfg \u003d self.config"},{"line_number":206,"context_line":"        if _cfg.get(\u0027other_config\u0027):"},{"line_number":207,"context_line":"            return _cfg[\u0027other_config\u0027].get(\u0027hw-offload\u0027) \u003d\u003d \u0027true\u0027"},{"line_number":208,"context_line":"        return False"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_c99fd562","line":207,"updated":"2019-12-12 10:25:20.000000000","message":"Nothing guarantees the value is \u0027true\u0027 instead of \u0027True\u0027. Please, as in [1], convert to lower the result, taking care that get(\u0027hw-offload\u0027) can be None. E.g.:\n\n@property\ndef is_hw_offload_enabled(self):\n    return self.config.get(\u0027other_config\u0027,\n                           {}).get(\u0027hw-offload\u0027, \u0027\u0027).lower() \u003d\u003d \u0027true\u0027\n\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/agent/linux/openvswitch_firewall/iptables.py#L39","commit_id":"c9f48f173691b050d69d314b457e8f83cd0d4862"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"a6df3541028ace6cfa2e77f69170bd5ca877aad7","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def is_hw_offload_enabled(self):"},{"line_number":205,"context_line":"        _cfg \u003d self.config"},{"line_number":206,"context_line":"        if _cfg.get(\u0027other_config\u0027):"},{"line_number":207,"context_line":"            return _cfg[\u0027other_config\u0027].get(\u0027hw-offload\u0027) \u003d\u003d \u0027true\u0027"},{"line_number":208,"context_line":"        return False"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3487dc5d","line":207,"in_reply_to":"3fa7e38b_c99fd562","updated":"2019-12-12 11:05:45.000000000","message":"Done","commit_id":"c9f48f173691b050d69d314b457e8f83cd0d4862"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"764690cea01a4db43bc6d4bf76ccb411a33913cc","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def is_hw_offload_enabled(self):"},{"line_number":205,"context_line":"        _cfg \u003d self.config"},{"line_number":206,"context_line":"        if _cfg.get(\u0027other_config\u0027):"},{"line_number":207,"context_line":"            return self.config.get(\u0027other_config\u0027,"},{"line_number":208,"context_line":"                                   {}).get(\u0027hw-offload\u0027, \u0027\u0027).lower() \u003d\u003d \u0027true\u0027"},{"line_number":209,"context_line":"        return False"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_34e91caa","line":207,"updated":"2019-12-12 11:43:29.000000000","message":"The example given replaced all method, not only L207. You don\u0027t need the check in L206 or assignment in L205 with this line.","commit_id":"3baa9527ddaf6a0c447d13604e5df60837e47545"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"ff3c9d0b247ad15e0adc5ee5aaec1e48205bbd87","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def is_hw_offload_enabled(self):"},{"line_number":205,"context_line":"        _cfg \u003d self.config"},{"line_number":206,"context_line":"        if _cfg.get(\u0027other_config\u0027):"},{"line_number":207,"context_line":"            return self.config.get(\u0027other_config\u0027,"},{"line_number":208,"context_line":"                                   {}).get(\u0027hw-offload\u0027, \u0027\u0027).lower() \u003d\u003d \u0027true\u0027"},{"line_number":209,"context_line":"        return False"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_34883cc1","line":207,"in_reply_to":"3fa7e38b_34e91caa","updated":"2019-12-12 11:58:14.000000000","message":"Done","commit_id":"3baa9527ddaf6a0c447d13604e5df60837e47545"},{"author":{"_account_id":28714,"name":"Adrian Chiris","email":"adrianc@nvidia.com","username":"adrianc"},"change_message_id":"d37555a3e010700131bff1f5164e078db0a3f222","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        options[\u0027local_ip\u0027] \u003d local_ip"},{"line_number":515,"context_line":"        options[\u0027in_key\u0027] \u003d \u0027flow\u0027"},{"line_number":516,"context_line":"        options[\u0027out_key\u0027] \u003d \u0027flow\u0027"},{"line_number":517,"context_line":"        # NOTE(moshele): pkt_mark is not support when using ovs hw-offload,"},{"line_number":518,"context_line":"        # therefore avoid clear mark on  encapsulating packets when it\u0027s"},{"line_number":519,"context_line":"        # enabled"},{"line_number":520,"context_line":"        if not self.is_hw_offload_enabled:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_14998078","line":517,"range":{"start_line":517,"start_character":41,"end_line":517,"end_character":48},"updated":"2019-12-12 11:49:14.000000000","message":"nit:supported","commit_id":"3baa9527ddaf6a0c447d13604e5df60837e47545"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"ff3c9d0b247ad15e0adc5ee5aaec1e48205bbd87","unresolved":false,"context_lines":[{"line_number":514,"context_line":"        options[\u0027local_ip\u0027] \u003d local_ip"},{"line_number":515,"context_line":"        options[\u0027in_key\u0027] \u003d \u0027flow\u0027"},{"line_number":516,"context_line":"        options[\u0027out_key\u0027] \u003d \u0027flow\u0027"},{"line_number":517,"context_line":"        # NOTE(moshele): pkt_mark is not support when using ovs hw-offload,"},{"line_number":518,"context_line":"        # therefore avoid clear mark on  encapsulating packets when it\u0027s"},{"line_number":519,"context_line":"        # enabled"},{"line_number":520,"context_line":"        if not self.is_hw_offload_enabled:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_744f94bd","line":517,"range":{"start_line":517,"start_character":41,"end_line":517,"end_character":48},"in_reply_to":"3fa7e38b_14998078","updated":"2019-12-12 11:58:14.000000000","message":"Done","commit_id":"3baa9527ddaf6a0c447d13604e5df60837e47545"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"003bdaeea06f2fb5c43cf8d456fc8083b42a8e61","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    @property"},{"line_number":204,"context_line":"    def is_hw_offload_enabled(self):"},{"line_number":205,"context_line":"        return self.config.get(\u0027other_config\u0027,"},{"line_number":206,"context_line":"                               {}).get(\u0027hw-offload\u0027, \u0027\u0027).lower() \u003d\u003d \u0027true\u0027"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# Map from version string to on-the-wire protocol version encoding:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_8f2f9df3","line":206,"updated":"2019-12-12 12:59:07.000000000","message":"sorry for that but I have one more thing here. According to Rodolfo and to https://docs.mellanox.com/display/MLNXOFEDv471001/OVS+Offload+Using+ASAP2+Direct this flag shouldn\u0027t change during neutron-ovs agent runtime. So maybe You could do something like:\n- in __init__() method add\n\n    self._hw_offload \u003d None\n\nand than here:\n\n    if self._hw_offload is None:\n        self._hw_offload \u003d self.config.get(\u0027other_config\u0027,\n                               {}).get(\u0027hw-offload\u0027, \u0027\u0027).lower() \u003d\u003d \u0027true\u0027\n\n    return self._hw_offload\n\nThat way You will not query ovsdb every time You want to add tunnel port.","commit_id":"133bb2f2d4d1e2021f18bcefc1ceb97a1bdcdaee"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e733d9e7fbdb280c7ff0880ed2a20eefb2661122","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    @property"},{"line_number":204,"context_line":"    def is_hw_offload_enabled(self):"},{"line_number":205,"context_line":"        return self.config.get(\u0027other_config\u0027,"},{"line_number":206,"context_line":"                               {}).get(\u0027hw-offload\u0027, \u0027\u0027).lower() \u003d\u003d \u0027true\u0027"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"# Map from version string to on-the-wire protocol version encoding:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fa7e38b_03f28fe3","line":206,"in_reply_to":"3fa7e38b_8f2f9df3","updated":"2019-12-18 04:41:47.000000000","message":"Done","commit_id":"133bb2f2d4d1e2021f18bcefc1ceb97a1bdcdaee"}]}