)]}'
{"neutron/agent/linux/interface.py":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"2696b2e4f24debe0309e0a8f6929460717fd7121","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                 bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone):"},{"line_number":341,"context_line":"        \"\"\"Plug in the interface.\"\"\""},{"line_number":342,"context_line":"        if not bridge:"},{"line_number":343,"context_line":"            bridge \u003d self.conf.OVS.integration_bridge"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        self.check_bridge_exists(bridge)"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_6561a038","line":343,"range":{"start_line":343,"start_character":31,"end_line":343,"end_character":53},"updated":"2019-12-20 23:18:49.000000000","message":"If people are using the old config, will they break after picking up this code? If yes, could we make it backward-compatible during the deprecation period?","commit_id":"fa36984d95c9fc1dc40ab253826e442369791667"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5cdf3e8d4d3d065cdd1ec22196f58c5de51e8480","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                 bridge\u003dNone, namespace\u003dNone, prefix\u003dNone, mtu\u003dNone):"},{"line_number":341,"context_line":"        \"\"\"Plug in the interface.\"\"\""},{"line_number":342,"context_line":"        if not bridge:"},{"line_number":343,"context_line":"            bridge \u003d self.conf.OVS.integration_bridge"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        self.check_bridge_exists(bridge)"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_9c4c79ca","line":343,"range":{"start_line":343,"start_character":31,"end_line":343,"end_character":53},"in_reply_to":"3fa7e38b_6561a038","updated":"2020-02-14 09:33:38.000000000","message":"That\u0027s the point: OVS.integration_bridge and ovs_integration_bridge must have the same value. Any deployment with different values in those parameters [1] will fail.\n\nThat means we have a redundant config parameter.\n\n[1] https://bugs.launchpad.net/neutron/+bug/1856152","commit_id":"fa36984d95c9fc1dc40ab253826e442369791667"}],"neutron/conf/agent/common.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d88c79e5fb0fe3b0f5c96cff3739b667e25fe780","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Name of Open vSwitch bridge to use. Do not use this \u0027"},{"line_number":56,"context_line":"                      \u0027variable to set the OVS integration bridge name, but \u0027"},{"line_number":57,"context_line":"                      \u0027\"OVS.integration_bridge\".\u0027)),"},{"line_number":58,"context_line":"    cfg.BoolOpt(\u0027ovs_use_veth\u0027,"},{"line_number":59,"context_line":"                default\u003dFalse,"},{"line_number":60,"context_line":"                help\u003d_(\"Uses veth for an OVS interface or not. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b5715f48","line":57,"updated":"2019-12-16 09:25:42.000000000","message":"Can You also maybe add info in which Release this option will be removed? I think it can be removed in \"W\" cycle.","commit_id":"e2f328f0b7de7c6280cbb8caebb34dca03966799"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5cdf3e8d4d3d065cdd1ec22196f58c5de51e8480","unresolved":false,"context_lines":[{"line_number":54,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Name of Open vSwitch bridge to use. Do not use this \u0027"},{"line_number":56,"context_line":"                      \u0027variable to set the OVS integration bridge name, but \u0027"},{"line_number":57,"context_line":"                      \u0027\"OVS.integration_bridge\".\u0027)),"},{"line_number":58,"context_line":"    cfg.BoolOpt(\u0027ovs_use_veth\u0027,"},{"line_number":59,"context_line":"                default\u003dFalse,"},{"line_number":60,"context_line":"                help\u003d_(\"Uses veth for an OVS interface or not. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_9fb6bdfc","line":57,"in_reply_to":"3fa7e38b_b5715f48","updated":"2020-02-14 09:33:38.000000000","message":"Done","commit_id":"e2f328f0b7de7c6280cbb8caebb34dca03966799"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a8b9047d8a366512920178c06460ea907a0fe416","unresolved":false,"context_lines":[{"line_number":53,"context_line":"               default\u003d\u0027br-int\u0027,"},{"line_number":54,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":55,"context_line":"               deprecated_reason\u003d\u0027This variable is a duplicate of \u0027"},{"line_number":56,"context_line":"                                 \u0027OVS.integration_bridge. To be removed in W.\u0027,"},{"line_number":57,"context_line":"               help\u003d_(\u0027Name of Open vSwitch bridge to use\u0027)),"},{"line_number":58,"context_line":"    cfg.BoolOpt(\u0027ovs_use_veth\u0027,"},{"line_number":59,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_60eb7910","line":56,"updated":"2020-01-07 11:06:46.000000000","message":"according to oslo config docs: https://docs.openstack.org/oslo.config/latest/reference/deprecating.html I think that You can add deprecated_name parameter in OVS.integration_bridge option to point that this option is the old one.","commit_id":"fa36984d95c9fc1dc40ab253826e442369791667"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6ae22abfe5b34969d8fe5413787cbf553c20a5fc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"               default\u003d\u0027br-int\u0027,"},{"line_number":54,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":55,"context_line":"               deprecated_reason\u003d\u0027This variable is a duplicate of \u0027"},{"line_number":56,"context_line":"                                 \u0027OVS.integration_bridge. To be removed in W.\u0027,"},{"line_number":57,"context_line":"               help\u003d_(\u0027Name of Open vSwitch bridge to use\u0027)),"},{"line_number":58,"context_line":"    cfg.BoolOpt(\u0027ovs_use_veth\u0027,"},{"line_number":59,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_43f18e63","line":56,"in_reply_to":"3fa7e38b_60eb7910","updated":"2020-01-27 19:56:59.000000000","message":"+1","commit_id":"fa36984d95c9fc1dc40ab253826e442369791667"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5cdf3e8d4d3d065cdd1ec22196f58c5de51e8480","unresolved":false,"context_lines":[{"line_number":53,"context_line":"               default\u003d\u0027br-int\u0027,"},{"line_number":54,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":55,"context_line":"               deprecated_reason\u003d\u0027This variable is a duplicate of \u0027"},{"line_number":56,"context_line":"                                 \u0027OVS.integration_bridge. To be removed in W.\u0027,"},{"line_number":57,"context_line":"               help\u003d_(\u0027Name of Open vSwitch bridge to use\u0027)),"},{"line_number":58,"context_line":"    cfg.BoolOpt(\u0027ovs_use_veth\u0027,"},{"line_number":59,"context_line":"                default\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_ca9340fe","line":56,"in_reply_to":"3fa7e38b_60eb7910","updated":"2020-02-14 09:33:38.000000000","message":"I didn\u0027t know that. Thanks!","commit_id":"fa36984d95c9fc1dc40ab253826e442369791667"}],"neutron/tests/functional/agent/l2/base.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d88c79e5fb0fe3b0f5c96cff3739b667e25fe780","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            \u0027interface_driver\u0027,"},{"line_number":149,"context_line":"            \u0027neutron.agent.linux.interface.OVSInterfaceDriver\u0027)"},{"line_number":150,"context_line":"        config.set_override(\u0027integration_bridge\u0027, self.br_int, \"OVS\")"},{"line_number":151,"context_line":"        config.set_override(\u0027integration_bridge\u0027, self.br_int, \"OVS\")"},{"line_number":152,"context_line":"        config.set_override(\u0027tunnel_bridge\u0027, self.br_tun, \"OVS\")"},{"line_number":153,"context_line":"        config.set_override(\u0027int_peer_patch_port\u0027, self.patch_tun, \"OVS\")"},{"line_number":154,"context_line":"        config.set_override(\u0027tun_peer_patch_port\u0027, self.patch_int, \"OVS\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_b5eabfd6","line":151,"updated":"2019-12-16 09:25:42.000000000","message":"we don\u0027t need it as it\u0027s the same as line above","commit_id":"e2f328f0b7de7c6280cbb8caebb34dca03966799"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5cdf3e8d4d3d065cdd1ec22196f58c5de51e8480","unresolved":false,"context_lines":[{"line_number":148,"context_line":"            \u0027interface_driver\u0027,"},{"line_number":149,"context_line":"            \u0027neutron.agent.linux.interface.OVSInterfaceDriver\u0027)"},{"line_number":150,"context_line":"        config.set_override(\u0027integration_bridge\u0027, self.br_int, \"OVS\")"},{"line_number":151,"context_line":"        config.set_override(\u0027integration_bridge\u0027, self.br_int, \"OVS\")"},{"line_number":152,"context_line":"        config.set_override(\u0027tunnel_bridge\u0027, self.br_tun, \"OVS\")"},{"line_number":153,"context_line":"        config.set_override(\u0027int_peer_patch_port\u0027, self.patch_tun, \"OVS\")"},{"line_number":154,"context_line":"        config.set_override(\u0027tun_peer_patch_port\u0027, self.patch_int, \"OVS\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_dfbf55a9","line":151,"in_reply_to":"3fa7e38b_b5eabfd6","updated":"2020-02-14 09:33:38.000000000","message":"Sorry!","commit_id":"e2f328f0b7de7c6280cbb8caebb34dca03966799"}],"releasenotes/notes/deprecate-ovs_integration_bridge-d4d1521c35f999bd.yaml":[{"author":{"_account_id":27654,"name":"Hongbin Lu","email":"kira034@163.com","username":"hongbin.lu"},"change_message_id":"f307f0ad0a7ca256555bd245e1da1e3ed2438040","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Deprecate ``ovs_integration_bridge``. This configuration option is a"},{"line_number":4,"context_line":"    duplicate of ``OVS:integration_bridge``. Currently both options must be the"},{"line_number":5,"context_line":"    same to avoid configuration clashes. Previously used in the DHCP agent."},{"line_number":6,"context_line":"    It will be removed in next releases."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_e54cb0ca","line":5,"range":{"start_line":4,"start_character":45,"end_line":5,"end_character":39},"updated":"2019-12-20 23:24:46.000000000","message":"How do we enforce this? or we leave it to operators to make sure both options are the same? Do we need a upgrade check for this?","commit_id":"fa36984d95c9fc1dc40ab253826e442369791667"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5cdf3e8d4d3d065cdd1ec22196f58c5de51e8480","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - Deprecate ``ovs_integration_bridge``. This configuration option is a"},{"line_number":4,"context_line":"    duplicate of ``OVS:integration_bridge``. Currently both options must be the"},{"line_number":5,"context_line":"    same to avoid configuration clashes. Previously used in the DHCP agent."},{"line_number":6,"context_line":"    It will be removed in next releases."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_aa9044f4","line":5,"range":{"start_line":4,"start_character":45,"end_line":5,"end_character":39},"in_reply_to":"3fa7e38b_e54cb0ca","updated":"2020-02-14 09:33:38.000000000","message":"That\u0027s the point [1]: there is no check. Those configuration options are redundant. I decided to keep the OVS agent one because this is related to an OVS parameter.\n\n[1] https://bugs.launchpad.net/neutron/+bug/1856152","commit_id":"fa36984d95c9fc1dc40ab253826e442369791667"}]}